194789 2019-02-18 14:01:06 -0800 Web Inspector: Styles: typing ";" shouldn't focus on the next property when there's open parenthesis or comment 2019-02-18 14:46:02 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1507414 0 nvasilyev 2019-02-18 14:01:06 -0800 We've had this for a while: Bug 178498: Web Inspector: Styles Redesign: Typing semicolon at the end of value should move to the next property Now that I added better detection of unbalanced characters, we should use it for this case as well. 1507416 1 webkit-bug-importer 2019-02-18 14:01:41 -0800 <rdar://problem/48177447> 1507417 2 362329 nvasilyev 2019-02-18 14:02:56 -0800 Created attachment 362329 Patch 1507425 3 362329 mattbaker 2019-02-18 14:12:44 -0800 Comment on attachment 362329 Patch r=me, nice! 1507446 4 362329 commit-queue 2019-02-18 14:46:00 -0800 Comment on attachment 362329 Patch Clearing flags on attachment: 362329 Committed r241740: <https://trac.webkit.org/changeset/241740> 1507447 5 commit-queue 2019-02-18 14:46:02 -0800 All reviewed patches have been landed. Closing bug. 362329 2019-02-18 14:02:56 -0800 2019-02-18 14:46:00 -0800 Patch patch.txt text/plain 2180 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGMwOGY1MWM5YTA5Li43MWQzYjdhMmQxMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDItMTggIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogU3R5bGVzOiB0eXBpbmcgIjsiIHNob3VsZG4ndCBmb2N1cyBvbiB0aGUgbmV4dCBwcm9wZXJ0 eSB3aGVuIHRoZXJlJ3Mgb3BlbiBwYXJlbnRoZXNpcyBvciBjb21tZW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ3ODkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv U3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5LmpzOgorICAgICAgICAoV0kuU3ByZWFkc2hlZXRTdHls ZVByb3BlcnR5LnByb3RvdHlwZS5faGFuZGxlVmFsdWVCZWZvcmVJbnB1dCk6CisKIDIwMTktMDIt MTcgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogTW92ZSBDU1MgY29tcGxldGlvbiBsb2dpYyBmcm9tIFNwcmVhZHNoZWV0VGV4 dEZpZWxkIHRvIFNwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5 LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFkc2hl ZXRTdHlsZVByb3BlcnR5LmpzCmluZGV4IDI0OTQ4NTEyYjM0Li41ZTA4NTNhNDc5MyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFkc2hl ZXRTdHlsZVByb3BlcnR5LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1NwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5qcwpAQCAtNzI3LDIwICs3MjcsOCBA QCBXSS5TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkgPSBjbGFzcyBTcHJlYWRzaGVldFN0eWxlUHJv cGVydHkgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgaWYgKCFzZWxlY3Rpb24ucmFuZ2VDb3Vu dCB8fCBzZWxlY3Rpb24uZ2V0UmFuZ2VBdCgwKS5lbmRPZmZzZXQgIT09IHRleHQubGVuZ3RoKQog ICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIC8vIEZpbmQgdGhlIGZpcnN0IGFuZCBsYXN0 IGluZGV4IChpZiBhbnkpIG9mIGEgcXVvdGUgY2hhcmFjdGVyIHRvIGVuc3VyZSB0aGF0IHRoZSBz dHJpbmcKLSAgICAgICAgLy8gZG9lc24ndCBjb250YWluIHVuYmFsYW5jZWQgcXVvdGVzLiBJZiBz bywgdGhlbiB0aGVyZSdzIG5vIHdheSB0aGF0IHRoZSBzZW1pY29sb24gY291bGQgYmUKLSAgICAg ICAgLy8gcGFydCBvZiBhIHN0cmluZyB3aXRoaW4gdGhlIHZhbHVlLCBzbyB3ZSBjYW4gYXNzdW1l IHRoYXQgaXQncyB0aGUgcHJvcGVydHkgInRlcm1pbmF0b3IiLgotICAgICAgICBjb25zdCBxdW90 ZVJlZ2V4ID0gL1siJ10vZzsKLSAgICAgICAgbGV0IHN0YXJ0ID0gLTE7Ci0gICAgICAgIGxldCBl bmQgPSB0ZXh0Lmxlbmd0aDsKLSAgICAgICAgbGV0IG1hdGNoID0gbnVsbDsKLSAgICAgICAgd2hp bGUgKG1hdGNoID0gcXVvdGVSZWdleC5leGVjKHRleHQpKSB7Ci0gICAgICAgICAgICBpZiAoc3Rh cnQgPCAwKQotICAgICAgICAgICAgICAgIHN0YXJ0ID0gbWF0Y2guaW5kZXg7Ci0gICAgICAgICAg ICBlbmQgPSBtYXRjaC5pbmRleCArIDE7Ci0gICAgICAgIH0KLQotICAgICAgICBpZiAoc3RhcnQg IT09IC0xICYmICF0ZXh0LnN1YnN0cmluZyhzdGFydCwgZW5kKS5oYXNNYXRjaGluZ0VzY2FwZWRR dW90ZXMoKSkKKyAgICAgICAgbGV0IHVuYmFsYW5jZWRDaGFyYWN0ZXJzID0gV0kuQ1NTQ29tcGxl dGlvbnMuY29tcGxldGVVbmJhbGFuY2VkVmFsdWUodGV4dCk7CisgICAgICAgIGlmICh1bmJhbGFu Y2VkQ2hhcmFjdGVycykKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBldmVudC5wcmV2 ZW50RGVmYXVsdCgpOwo=