194777 2019-02-18 08:53:53 -0800 Check the existence of the frame in Document::hasFrameSpecificStorageAccess() and Document::setHasFrameSpecificStorageAccess() 2019-02-18 15:14:05 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander achristensen cdumez commit-queue dbates esprehn+autocc ews-watchlist ggaren kangil.han webkit-bug-importer oldest_to_newest 1507285 0 wilander 2019-02-18 08:53:53 -0800 We should check that the document has a frame in Document::hasFrameSpecificStorageAccess() and Document::setHasFrameSpecificStorageAccess(). 1507286 1 wilander 2019-02-18 08:54:04 -0800 rdar://problem/47731945 1507290 2 362301 wilander 2019-02-18 09:16:11 -0800 Created attachment 362301 Patch 1507318 3 362301 cdumez 2019-02-18 10:59:02 -0800 Comment on attachment 362301 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362301&action=review > Source/WebCore/ChangeLog:9 > + No new tests. I think we should try and write a test as explained offline. 1507393 4 362321 wilander 2019-02-18 13:20:20 -0800 Created attachment 362321 Patch 1507429 5 362321 ggaren 2019-02-18 14:18:52 -0800 Comment on attachment 362321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362321&action=review r=me > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:590 > + RELEASE_ASSERT(sessionID.isValid()); I'm not sure it's good practice to include a RELEASE_ASSERT in a fix for a null pointer dereference. That increases the chances that the crash rate will go up rather than down after the fix. For example, if we ever wanted to merge this fix onto a release branch, instead of saying "it's just a null check" we would say "it's a null check and possibly a new way to crash". That's a much more muddled risk/reward discussion. How about an ASSERT with early return? 1507431 6 wilander 2019-02-18 14:21:29 -0800 (In reply to Geoffrey Garen from comment #5) > Comment on attachment 362321 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362321&action=review > > r=me Thanks! > > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:590 > > + RELEASE_ASSERT(sessionID.isValid()); > > I'm not sure it's good practice to include a RELEASE_ASSERT in a fix for a > null pointer dereference. That increases the chances that the crash rate > will go up rather than down after the fix. For example, if we ever wanted to > merge this fix onto a release branch, instead of saying "it's just a null > check" we would say "it's a null check and possibly a new way to crash". > That's a much more muddled risk/reward discussion. > > How about an ASSERT with early return? I'm actually of the same opinion but Chris wants us to find other bad call sites (if there are any). Chris, care to weigh in? 1507432 7 cdumez 2019-02-18 14:23:58 -0800 (In reply to John Wilander from comment #6) > (In reply to Geoffrey Garen from comment #5) > > Comment on attachment 362321 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=362321&action=review > > > > r=me > > Thanks! > > > > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:590 > > > + RELEASE_ASSERT(sessionID.isValid()); > > > > I'm not sure it's good practice to include a RELEASE_ASSERT in a fix for a > > null pointer dereference. That increases the chances that the crash rate > > will go up rather than down after the fix. For example, if we ever wanted to > > merge this fix onto a release branch, instead of saying "it's just a null > > check" we would say "it's a null check and possibly a new way to crash". > > That's a much more muddled risk/reward discussion. > > > > How about an ASSERT with early return? > > I'm actually of the same opinion but Chris wants us to find other bad call > sites (if there are any). Chris, care to weigh in? I am OK with ASSERT() with early return. I actually thought this is what we eventually agreed on offline but I probably wasn't clear I changed my mind. 1507433 8 wilander 2019-02-18 14:24:51 -0800 (In reply to Chris Dumez from comment #7) > (In reply to John Wilander from comment #6) > > (In reply to Geoffrey Garen from comment #5) > > > Comment on attachment 362321 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=362321&action=review > > > > > > r=me > > > > Thanks! > > > > > > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:590 > > > > + RELEASE_ASSERT(sessionID.isValid()); > > > > > > I'm not sure it's good practice to include a RELEASE_ASSERT in a fix for a > > > null pointer dereference. That increases the chances that the crash rate > > > will go up rather than down after the fix. For example, if we ever wanted to > > > merge this fix onto a release branch, instead of saying "it's just a null > > > check" we would say "it's a null check and possibly a new way to crash". > > > That's a much more muddled risk/reward discussion. > > > > > > How about an ASSERT with early return? > > > > I'm actually of the same opinion but Chris wants us to find other bad call > > sites (if there are any). Chris, care to weigh in? > > I am OK with ASSERT() with early return. I actually thought this is what we > eventually agreed on offline but I probably wasn't clear I changed my mind. OK, I will fix this and land. Thanks, both of you. 1507439 9 362335 wilander 2019-02-18 14:29:44 -0800 Created attachment 362335 Patch for landing 1507478 10 362335 commit-queue 2019-02-18 15:14:03 -0800 Comment on attachment 362335 Patch for landing Clearing flags on attachment: 362335 Committed r241743: <https://trac.webkit.org/changeset/241743> 1507479 11 commit-queue 2019-02-18 15:14:05 -0800 All reviewed patches have been landed. Closing bug. 362301 2019-02-18 09:16:11 -0800 2019-02-18 13:20:19 -0800 Patch bug-194777-20190218091611.patch text/plain 1904 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjE0MWE4ZmMzZGZiMzE0 Mjc5NzU1MDE2NjdiZDM3NTFhMDRiMmNlNi4uZjVlNTFjZjU5ZDJiZjI4OTkwMmZmOWY3NGU4MTA2 ZmZiOTY3MGFiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAyLTE4ICBKb2hu IFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIENoZWNrIHRoZSBleGlz dGVuY2Ugb2YgdGhlIGZyYW1lIGluIERvY3VtZW50OjpoYXNGcmFtZVNwZWNpZmljU3RvcmFnZUFj Y2VzcygpIGFuZCBEb2N1bWVudDo6c2V0SGFzRnJhbWVTcGVjaWZpY1N0b3JhZ2VBY2Nlc3MoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0Nzc3Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzczMTk0NT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBkb20v RG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6Omhhc0ZyYW1lU3BlY2lm aWNTdG9yYWdlQWNjZXNzIGNvbnN0KToKKyAgICAgICAgICAgIE5vdyBjaGVja3MgZm9yIHRoZSBl eGlzdGVuY2Ugb2YgdGhlIGZyYW1lLgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldEhh c0ZyYW1lU3BlY2lmaWNTdG9yYWdlQWNjZXNzKToKKyAgICAgICAgICAgIE5vdyBjaGVja3MgZm9y IHRoZSBleGlzdGVuY2Ugb2YgdGhlIGZyYW1lLgorCiAyMDE5LTAyLTE3ICBEYXZpZCBLaWx6ZXIg IDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjI0MTYyMC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDA1MDU1NWJhOTQ5MWY0N2NhMGJi NGRmZGFhYTE5M2Q5YWM1NGVkZjkuLjQxNmZmZTBmZjE5YmRkNWZmNGU5ZDMzZGVkODVjMTExNzAw ZDJkZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtODQ1OCwxMiArODQ1OCwxMyBAQCB2 b2lkIERvY3VtZW50Ojp1cGRhdGVNYWluQXJ0aWNsZUVsZW1lbnRBZnRlckxheW91dCgpCiAjaWYg RU5BQkxFKFJFU09VUkNFX0xPQURfU1RBVElTVElDUykKIGJvb2wgRG9jdW1lbnQ6Omhhc0ZyYW1l U3BlY2lmaWNTdG9yYWdlQWNjZXNzKCkgY29uc3QKIHsKLSAgICByZXR1cm4gbV9mcmFtZS0+bG9h ZGVyKCkuY2xpZW50KCkuaGFzRnJhbWVTcGVjaWZpY1N0b3JhZ2VBY2Nlc3MoKTsKKyAgICByZXR1 cm4gbV9mcmFtZSAmJiBtX2ZyYW1lLT5sb2FkZXIoKS5jbGllbnQoKS5oYXNGcmFtZVNwZWNpZmlj U3RvcmFnZUFjY2VzcygpOwogfQogICAgIAogdm9pZCBEb2N1bWVudDo6c2V0SGFzRnJhbWVTcGVj aWZpY1N0b3JhZ2VBY2Nlc3MoYm9vbCB2YWx1ZSkKIHsKLSAgICBtX2ZyYW1lLT5sb2FkZXIoKS5j bGllbnQoKS5zZXRIYXNGcmFtZVNwZWNpZmljU3RvcmFnZUFjY2Vzcyh2YWx1ZSk7CisgICAgaWYg KG1fZnJhbWUpCisgICAgICAgIG1fZnJhbWUtPmxvYWRlcigpLmNsaWVudCgpLnNldEhhc0ZyYW1l U3BlY2lmaWNTdG9yYWdlQWNjZXNzKHZhbHVlKTsKIH0KIAogYm9vbCBEb2N1bWVudDo6aGFzUmVx dWVzdGVkUGFnZVNwZWNpZmljU3RvcmFnZUFjY2Vzc1dpdGhVc2VySW50ZXJhY3Rpb24oY29uc3Qg U3RyaW5nJiBwcmltYXJ5RG9tYWluKQo= 362321 2019-02-18 13:20:20 -0800 2019-02-18 14:29:43 -0800 Patch bug-194777-20190218132020.patch text/plain 9767 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjE0MWE4ZmMzZGZiMzE0 Mjc5NzU1MDE2NjdiZDM3NTFhMDRiMmNlNi4uODVlM2YxNTRlY2QyNjQ4YzFiOTk0MjIyZDZjYzRi MjZkMjZkN2MxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTAyLTE4ICBKb2hu IFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIENoZWNrIHRoZSBleGlz dGVuY2Ugb2YgdGhlIGZyYW1lIGluIERvY3VtZW50OjpoYXNGcmFtZVNwZWNpZmljU3RvcmFnZUFj Y2VzcygpIGFuZCBEb2N1bWVudDo6c2V0SGFzRnJhbWVTcGVjaWZpY1N0b3JhZ2VBY2Nlc3MoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0Nzc3Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzczMTk0NT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3Mv cmVtb3ZlLXJlcXVlc3RpbmctaWZyYW1lLmh0bWwKKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6aGFzRnJhbWVTcGVjaWZpY1N0b3JhZ2VB Y2Nlc3MgY29uc3QpOgorICAgICAgICAgICAgTm93IGNoZWNrcyBmb3IgdGhlIGV4aXN0ZW5jZSBv ZiB0aGUgZnJhbWUuCisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6c2V0SGFzRnJhbWVTcGVj aWZpY1N0b3JhZ2VBY2Nlc3MpOgorICAgICAgICAgICAgTm93IGNoZWNrcyBmb3IgdGhlIGV4aXN0 ZW5jZSBvZiB0aGUgZnJhbWUuCisgICAgICAgICogbG9hZGVyL1Jlc291cmNlTG9hZE9ic2VydmVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlTG9hZE9ic2VydmVyOjpsb2dVc2VySW50 ZXJhY3Rpb25XaXRoUmVkdWNlZFRpbWVSZXNvbHV0aW9uKToKKyAgICAgICAgICAgIE5vdyBjaGVj a3MgdGhhdCB0aGUgc2Vzc2lvbiBJRCBpcyB2YWxpZC4KKwogMjAxOS0wMi0xNyAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHIyNDE2MjAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQwYjkxYjBhNTE5ZjU1MTJkZmIyNjNlMDE3NjllNDBm YmVjYjcyZmIuLjJhNzkzYzQ3NDExYjJiMzIwMWU5OWFjNjRkNTgxOTRiYWM3MDE0MTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDItMTggIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRl ckBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlY2sgdGhlIGV4aXN0ZW5jZSBvZiB0aGUgZnJhbWUg aW4gRG9jdW1lbnQ6Omhhc0ZyYW1lU3BlY2lmaWNTdG9yYWdlQWNjZXNzKCkgYW5kIERvY3VtZW50 OjpzZXRIYXNGcmFtZVNwZWNpZmljU3RvcmFnZUFjY2VzcygpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ3NzcKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzQ3NzMxOTQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3Bw OgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6bG9nVXNl ckludGVyYWN0aW9uKToKKyAgICAgICAgICAgQWRkZWQgYSBSRUxFQVNFX0FTU0VSVCB0byBoZWxw IHVzIGZpbmQgb3RoZXIgY2FsbCBzaXRlcyBwYXNzaW5nIGludmFsaWQgc2Vzc2lvbiBJRHMuCisK IDIwMTktMDItMTggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHVEtdIENyYXNoIHdoaWxlIGZpbGxpbmcgc2VsZWN0aW9uIGRhdGEgZHVyaW5n IGRyYWcgYW5kIGRyb3AKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDA1MDU1NWJhOTQ5MWY0 N2NhMGJiNGRmZGFhYTE5M2Q5YWM1NGVkZjkuLjQxNmZmZTBmZjE5YmRkNWZmNGU5ZDMzZGVkODVj MTExNzAwZDJkZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtODQ1OCwxMiArODQ1OCwx MyBAQCB2b2lkIERvY3VtZW50Ojp1cGRhdGVNYWluQXJ0aWNsZUVsZW1lbnRBZnRlckxheW91dCgp CiAjaWYgRU5BQkxFKFJFU09VUkNFX0xPQURfU1RBVElTVElDUykKIGJvb2wgRG9jdW1lbnQ6Omhh c0ZyYW1lU3BlY2lmaWNTdG9yYWdlQWNjZXNzKCkgY29uc3QKIHsKLSAgICByZXR1cm4gbV9mcmFt ZS0+bG9hZGVyKCkuY2xpZW50KCkuaGFzRnJhbWVTcGVjaWZpY1N0b3JhZ2VBY2Nlc3MoKTsKKyAg ICByZXR1cm4gbV9mcmFtZSAmJiBtX2ZyYW1lLT5sb2FkZXIoKS5jbGllbnQoKS5oYXNGcmFtZVNw ZWNpZmljU3RvcmFnZUFjY2VzcygpOwogfQogICAgIAogdm9pZCBEb2N1bWVudDo6c2V0SGFzRnJh bWVTcGVjaWZpY1N0b3JhZ2VBY2Nlc3MoYm9vbCB2YWx1ZSkKIHsKLSAgICBtX2ZyYW1lLT5sb2Fk ZXIoKS5jbGllbnQoKS5zZXRIYXNGcmFtZVNwZWNpZmljU3RvcmFnZUFjY2Vzcyh2YWx1ZSk7Cisg ICAgaWYgKG1fZnJhbWUpCisgICAgICAgIG1fZnJhbWUtPmxvYWRlcigpLmNsaWVudCgpLnNldEhh c0ZyYW1lU3BlY2lmaWNTdG9yYWdlQWNjZXNzKHZhbHVlKTsKIH0KIAogYm9vbCBEb2N1bWVudDo6 aGFzUmVxdWVzdGVkUGFnZVNwZWNpZmljU3RvcmFnZUFjY2Vzc1dpdGhVc2VySW50ZXJhY3Rpb24o Y29uc3QgU3RyaW5nJiBwcmltYXJ5RG9tYWluKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bG9hZGVyL1Jlc291cmNlTG9hZE9ic2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9S ZXNvdXJjZUxvYWRPYnNlcnZlci5jcHAKaW5kZXggYTM2MzE1NTAxNzAyMGM5NzdmNWRlNTQ3YzVl OWI4MjE2YWRlMjllMC4uMzBkZmFhMGE0M2VhMTYyMTZlYTZmZTEzNDY3OTAyMTU2MTYzOTczNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZE9ic2VydmVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkT2JzZXJ2ZXIuY3BwCkBA IC0xOTMsNyArMTkzLDcgQEAgdm9pZCBSZXNvdXJjZUxvYWRPYnNlcnZlcjo6bG9nV2ViU29ja2V0 TG9hZGluZyhjb25zdCBVUkwmIHRhcmdldFVSTCwgY29uc3QgVVJMJgogCiB2b2lkIFJlc291cmNl TG9hZE9ic2VydmVyOjpsb2dVc2VySW50ZXJhY3Rpb25XaXRoUmVkdWNlZFRpbWVSZXNvbHV0aW9u KGNvbnN0IERvY3VtZW50JiBkb2N1bWVudCkKIHsKLSAgICBpZiAoIXNob3VsZExvZyhkb2N1bWVu dC5zZXNzaW9uSUQoKS5pc0VwaGVtZXJhbCgpKSkKKyAgICBpZiAoIWRvY3VtZW50LnNlc3Npb25J RCgpLmlzVmFsaWQoKSB8fCAhc2hvdWxkTG9nKGRvY3VtZW50LnNlc3Npb25JRCgpLmlzRXBoZW1l cmFsKCkpKQogICAgICAgICByZXR1cm47CiAKICAgICBhdXRvJiB1cmwgPSBkb2N1bWVudC51cmwo KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5l Y3Rpb25Ub1dlYlByb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKaW5kZXggM2RmNDNjNDZkZGJiMzU1NjgzYjU0 NTlmZjM4YjU2NTg5NzcwZmZjYS4uZTkyNTVkYzE5OGE1MzFlNTg4YTA4YWRkNzA2MTE0NTM3NDI3 YjliNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29u bmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKQEAgLTU4Nyw2ICs1ODcsNyBAQCB2 b2lkIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpyZW1vdmVTdG9yYWdlQWNjZXNzRm9y QWxsRnJhbWVzT25QYWdlKFBBTDo6UwogCiB2b2lkIE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9j ZXNzOjpsb2dVc2VySW50ZXJhY3Rpb24oUEFMOjpTZXNzaW9uSUQgc2Vzc2lvbklELCBjb25zdCBT dHJpbmcmIHRvcExldmVsT3JpZ2luKQogeworICAgIFJFTEVBU0VfQVNTRVJUKHNlc3Npb25JRC5p c1ZhbGlkKCkpOwogICAgIGlmIChhdXRvIG5ldHdvcmtTZXNzaW9uID0gbmV0d29ya1Byb2Nlc3Mo KS5uZXR3b3JrU2Vzc2lvbihzZXNzaW9uSUQpKSB7CiAgICAgICAgIGlmIChhdXRvKiByZXNvdXJj ZUxvYWRTdGF0aXN0aWNzID0gbmV0d29ya1Nlc3Npb24tPnJlc291cmNlTG9hZFN0YXRpc3RpY3Mo KSkKICAgICAgICAgICAgIHJlc291cmNlTG9hZFN0YXRpc3RpY3MtPmxvZ1VzZXJJbnRlcmFjdGlv bih0b3BMZXZlbE9yaWdpbiwgW10geyB9KTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhZmY2MjI4ZWI2MDgxOWNjNjkyNjYw NjdmYTAyZWFkYTE4ZDliYzI4Li44N2FjMWM4MTA4ZjJmMjNiZGIyMDdjZTI0ODZlNmNjNTUxYWU1 YjFmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDItMTggIEpvaG4gV2lsYW5kZXIgIDx3 aWxhbmRlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlY2sgdGhlIGV4aXN0ZW5jZSBvZiB0aGUg ZnJhbWUgaW4gRG9jdW1lbnQ6Omhhc0ZyYW1lU3BlY2lmaWNTdG9yYWdlQWNjZXNzKCkgYW5kIERv Y3VtZW50OjpzZXRIYXNGcmFtZVNwZWNpZmljU3RvcmFnZUFjY2VzcygpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ3NzcKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzQ3NzMxOTQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL3JlbW92ZS1yZXF1ZXN0aW5n LWlmcmFtZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvc3RvcmFn ZUFjY2Vzcy9yZW1vdmUtcmVxdWVzdGluZy1pZnJhbWUuaHRtbDogQWRkZWQuCisgICAgICAgICog aHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL3Jlc291cmNlcy9yZXF1ZXN0LXN0b3JhZ2UtYWNjZXNz LWFuZC1pbW1lZGlhdGVseS1wb3N0bWVzc2FnZS1pZnJhbWUuaHRtbDogQWRkZWQuCisKIDIwMTkt MDItMTcgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAg ICAgVXNlIGR1bXBKU0NvbnNvbGVMb2dJblN0ZEVycj10cnVlIHdlYmtpdC10ZXN0LXJ1bm5lciBv cHRpb24gZm9yIG5vbi1pbXBvcnRlZCB0ZXN0cyBpbnN0ZWFkIG9mIHVzaW5nIER1bXBKU0NvbnNv bGVMb2dJblN0ZEVyciBleHBlY3RhdGlvbiBpbiBUZXN0RXhwZWN0YXRpb25zCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvcmVtb3ZlLXJlcXVlc3Rpbmct aWZyYW1lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc3RvcmFnZUFjY2Vz cy9yZW1vdmUtcmVxdWVzdGluZy1pZnJhbWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjcwNTQ2 ZDI5MzI3OTQzMDk0MzYyM2U5OWMzN2I3MTc2MzZiMjMwZDIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvcmVtb3ZlLXJlcXVlc3RpbmctaWZy YW1lLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEwIEBACitUZXN0cyB0aGF0IFN0b3JhZ2UgQWNj ZXNzIEFQSSBjYWxscyB3b3JrIHdlbGwgZm9yIHJlbW92ZWQgZnJhbWVzLgorCitPbiBzdWNjZXNz LCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAi VEVTVCBDT01QTEVURSIuCisKKworUEFTUyBpZnJhbWUgcmVtb3ZlZC4KK1BBU1Mgc3VjY2Vzc2Z1 bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvcmVtb3ZlLXJlcXVlc3RpbmctaWZyYW1lLmh0 bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvcmVtb3ZlLXJlcXVlc3Rp bmctaWZyYW1lLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDUzYTIyZjhmNmJlOGJmMjRlMzQ2NDg3MDk0OWQx NDJlMzRjZmZjZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc3Rv cmFnZUFjY2Vzcy9yZW1vdmUtcmVxdWVzdGluZy1pZnJhbWUuaHRtbApAQCAtMCwwICsxLDYyIEBA Cis8IURPQ1RZUEUgaHRtbD4gPCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyB1c2VGbGV4aWJsZVZp ZXdwb3J0PXRydWUgXSAtLT4KKzxodG1sPgorPGhlYWQ+CisgICAgPG1ldGEgbmFtZT0idmlld3Bv cnQiIGNvbnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xLCB1c2VyLXNj YWxhYmxlPW5vIj4KKyAgICA8c2NyaXB0IHNyYz0iL2pzLXRlc3QtcmVzb3VyY2VzL2pzLXRlc3Qu anMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIvanMtdGVzdC1yZXNvdXJjZXMvdWktaGVs cGVyLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iL3Jlc291cmNlTG9hZFN0YXRpc3Rp Y3MvcmVzb3VyY2VzL3V0aWwuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJy dW5UZXN0KCkiPgorPHNjcmlwdD4KKyAgICBkZXNjcmlwdGlvbigiVGVzdHMgdGhhdCBTdG9yYWdl IEFjY2VzcyBBUEkgY2FsbHMgd29yayB3ZWxsIGZvciByZW1vdmVkIGZyYW1lcy4iKTsKKyAgICBq c1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKworICAgIGZ1bmN0aW9uIGZpbmlzaFRlc3QoKSB7CisgICAg ICAgIHNldEVuYWJsZUZlYXR1cmUoZmFsc2UsIGZpbmlzaEpTVGVzdCk7CisgICAgfQorCisgICAg ZnVuY3Rpb24gcmVjZWl2ZU1lc3NhZ2UoKSB7CisgICAgICAgIHJlcXVlc3RpbmdpZnJhbWUucmVt b3ZlKCk7CisgICAgICAgIHRlc3RQYXNzZWQoImlmcmFtZSByZW1vdmVkLiIpOworICAgICAgICBz ZXRUaW1lb3V0KGZpbmlzaFRlc3QsIDAuNSk7CisgICAgfQorCisgICAgd2luZG93LmFkZEV2ZW50 TGlzdGVuZXIoIm1lc3NhZ2UiLCByZWNlaXZlTWVzc2FnZSwgZmFsc2UpOworCisgICAgZnVuY3Rp b24gYWN0aXZhdGVFbGVtZW50KGVsZW1lbnRJZCkgeworICAgICAgICB2YXIgZWxlbWVudCA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKGVsZW1lbnRJZCk7CisgICAgICAgIHZhciBjZW50ZXJYID0g ZWxlbWVudC5vZmZzZXRMZWZ0ICsgZWxlbWVudC5vZmZzZXRXaWR0aCAvIDI7CisgICAgICAgIHZh ciBjZW50ZXJZID0gZWxlbWVudC5vZmZzZXRUb3AgKyBlbGVtZW50Lm9mZnNldEhlaWdodCAvIDI7 CisgICAgICAgIFVJSGVscGVyLmFjdGl2YXRlQXQoY2VudGVyWCwgY2VudGVyWSkudGhlbigKKyAg ICAgICAgICAgIGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmV2ZW50 U2VuZGVyKQorICAgICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCJlc2NhcGUi KTsKKyAgICAgICAgICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgICAgICAgICAgdGVzdEZhaWxl ZCgiTm8gZXZlbnRTZW5kZXIuIik7CisgICAgICAgICAgICAgICAgICAgIGZpbmlzaFRlc3QoKTsK KyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9LAorICAgICAgICAgICAgZnVuY3Rpb24g KCkgeworICAgICAgICAgICAgICAgIHRlc3RGYWlsZWQoIlByb21pc2UgcmVqZWN0ZWQuIik7Cisg ICAgICAgICAgICAgICAgZmluaXNoVGVzdCgpOworICAgICAgICAgICAgfQorICAgICAgICApOwor ICAgIH0KKworICAgIGNvbnN0IGlmcmFtZUlEID0gInJlcXVlc3RpbmdpZnJhbWUiOworICAgIGNv bnN0IGlmcmFtZVNvdXJjZSA9ICJodHRwOi8vbG9jYWxob3N0OjgwMDAvc3RvcmFnZUFjY2Vzcy9y ZXNvdXJjZXMvcmVxdWVzdC1zdG9yYWdlLWFjY2Vzcy1hbmQtaW1tZWRpYXRlbHktcG9zdG1lc3Nh Z2UtaWZyYW1lLmh0bWwiOworCisgICAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICAgICAgbGV0 IGlmcmFtZUVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpZnJhbWUiKTsKKyAgICAg ICAgaWZyYW1lRWxlbWVudC5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHRlc3RS dW5uZXIuc3RhdGlzdGljc1VwZGF0ZUNvb2tpZUJsb2NraW5nKGZ1bmN0aW9uKCkgeworICAgICAg ICAgICAgICAgIGFjdGl2YXRlRWxlbWVudChpZnJhbWVJRCk7CisgICAgICAgICAgICB9KTsKKyAg ICAgICAgfTsKKyAgICAgICAgaWZyYW1lRWxlbWVudC5pZCA9IGlmcmFtZUlEOworICAgICAgICBp ZnJhbWVFbGVtZW50LnNyYyA9IGlmcmFtZVNvdXJjZTsKKyAgICAgICAgZG9jdW1lbnQuYm9keS5h cHBlbmRDaGlsZChpZnJhbWVFbGVtZW50KTsKKyAgICB9Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwv aHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvcmVzb3VyY2VzL3JlcXVlc3Qtc3RvcmFnZS1hY2Nl c3MtYW5kLWltbWVkaWF0ZWx5LXBvc3RtZXNzYWdlLWlmcmFtZS5odG1sIGIvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL3Jlc291cmNlcy9yZXF1ZXN0LXN0b3JhZ2UtYWNjZXNz LWFuZC1pbW1lZGlhdGVseS1wb3N0bWVzc2FnZS1pZnJhbWUuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yODQw ZmMxMzUwOTRmNjBkMTVhYzlhMTI2YmEyN2Q3YWNjNjNiY2U1Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL3Jlc291cmNlcy9yZXF1ZXN0LXN0 b3JhZ2UtYWNjZXNzLWFuZC1pbW1lZGlhdGVseS1wb3N0bWVzc2FnZS1pZnJhbWUuaHRtbApAQCAt MCwwICsxLDE1IEBACis8aHRtbD4KKzxoZWFkPgorICAgIDxzY3JpcHQ+CisgICAgICAgIGlmIChp bnRlcm5hbHMpCisgICAgICAgICAgICBpbnRlcm5hbHMuc2V0VXNlckdyYW50c1N0b3JhZ2VBY2Nl c3ModHJ1ZSk7CisKKyAgICAgICAgZnVuY3Rpb24gbWFrZVJlcXVlc3RXaXRoVXNlckdlc3R1cmUo KSB7CisgICAgICAgICAgICBkb2N1bWVudC5yZXF1ZXN0U3RvcmFnZUFjY2VzcygpOworICAgICAg ICAgICAgdG9wLnBvc3RNZXNzYWdlKCJBUEkgY2FsbGVkLiIsICJodHRwOi8vMTI3LjAuMC4xOjgw MDAiKTsKKyAgICAgICAgfQorICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25jbGljaz0i bWFrZVJlcXVlc3RXaXRoVXNlckdlc3R1cmUoKSI+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3 bGluZSBhdCBlbmQgb2YgZmlsZQo= 362335 2019-02-18 14:29:44 -0800 2019-02-18 15:14:03 -0800 Patch for landing bug-194777-20190218142944.patch text/plain 9920 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjE0MWE4ZmMzZGZiMzE0 Mjc5NzU1MDE2NjdiZDM3NTFhMDRiMmNlNi4uMWIwZTkxMmM5ODc2ZDhhMWY5YTIyYjk3MzAxMDRh Y2FkNGJjMWIxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTAyLTE4ICBKb2hu IFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIENoZWNrIHRoZSBleGlz dGVuY2Ugb2YgdGhlIGZyYW1lIGluIERvY3VtZW50OjpoYXNGcmFtZVNwZWNpZmljU3RvcmFnZUFj Y2VzcygpIGFuZCBEb2N1bWVudDo6c2V0SGFzRnJhbWVTcGVjaWZpY1N0b3JhZ2VBY2Nlc3MoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0Nzc3Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzczMTk0NT4KKworICAgICAgICBSZXZpZXdlZCBieSBH ZW9mZnJleSBHYXJlbiBhbmQgQ2hyaXMgRHVtZXouCisKKyAgICAgICAgVGVzdDogaHR0cC90ZXN0 cy9zdG9yYWdlQWNjZXNzL3JlbW92ZS1yZXF1ZXN0aW5nLWlmcmFtZS5odG1sCisKKyAgICAgICAg KiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6Omhhc0ZyYW1l U3BlY2lmaWNTdG9yYWdlQWNjZXNzIGNvbnN0KToKKyAgICAgICAgICAgIE5vdyBjaGVja3MgZm9y IHRoZSBleGlzdGVuY2Ugb2YgdGhlIGZyYW1lLgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6 OnNldEhhc0ZyYW1lU3BlY2lmaWNTdG9yYWdlQWNjZXNzKToKKyAgICAgICAgICAgIE5vdyBjaGVj a3MgZm9yIHRoZSBleGlzdGVuY2Ugb2YgdGhlIGZyYW1lLgorICAgICAgICAqIGxvYWRlci9SZXNv dXJjZUxvYWRPYnNlcnZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUxvYWRPYnNl cnZlcjo6bG9nVXNlckludGVyYWN0aW9uV2l0aFJlZHVjZWRUaW1lUmVzb2x1dGlvbik6CisgICAg ICAgICAgICBOb3cgY2hlY2tzIHRoYXQgdGhlIHNlc3Npb24gSUQgaXMgdmFsaWQuCisKIDIwMTkt MDItMTcgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByMjQxNjIwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCBkMGI5MWIwYTUxOWY1NTEy ZGZiMjYzZTAxNzY5ZTQwZmJlY2I3MmZiLi40Zjc3N2JlMmMwMzc5NDQwNTI0NGMyMjQ5NmIxNjU0 MGIwYzc0ZTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAyLTE4ICBKb2huIFdp bGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIENoZWNrIHRoZSBleGlzdGVu Y2Ugb2YgdGhlIGZyYW1lIGluIERvY3VtZW50OjpoYXNGcmFtZVNwZWNpZmljU3RvcmFnZUFjY2Vz cygpIGFuZCBEb2N1bWVudDo6c2V0SGFzRnJhbWVTcGVjaWZpY1N0b3JhZ2VBY2Nlc3MoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0Nzc3CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS80NzczMTk0NT4KKworICAgICAgICBSZXZpZXdlZCBieSBHZW9m ZnJleSBHYXJlbiBhbmQgQ2hyaXMgRHVtZXouCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdv cmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpsb2dVc2VySW50ZXJhY3Rpb24pOgorICAgICAgICAg ICBOb3cgcmV0dXJucyBlYXJseSBpZiB0aGUgaW5jb21pbmcgc2Vzc2lvbiBJRCBpcyBpbnZhbGlk LgorICAgICAgICAgICBBZGRlZCBhbiBBU1NFUlQgdG8gaGVscCB1cyBmaW5kIG90aGVyIGNhbGwg c2l0ZXMgcGFzc2luZyBpbnZhbGlkIHNlc3Npb24gSURzLgorCiAyMDE5LTAyLTE4ICBDYXJsb3Mg R2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBDcmFz aCB3aGlsZSBmaWxsaW5nIHNlbGVjdGlvbiBkYXRhIGR1cmluZyBkcmFnIGFuZCBkcm9wCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcAppbmRleCAwNTA1NTViYTk0OTFmNDdjYTBiYjRkZmRhYWExOTNkOWFj NTRlZGY5Li40MTZmZmUwZmYxOWJkZDVmZjRlOWQzM2RlZDg1YzExMTcwMGQyZGQ2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5jcHAKQEAgLTg0NTgsMTIgKzg0NTgsMTMgQEAgdm9pZCBEb2N1bWVudDo6 dXBkYXRlTWFpbkFydGljbGVFbGVtZW50QWZ0ZXJMYXlvdXQoKQogI2lmIEVOQUJMRShSRVNPVVJD RV9MT0FEX1NUQVRJU1RJQ1MpCiBib29sIERvY3VtZW50OjpoYXNGcmFtZVNwZWNpZmljU3RvcmFn ZUFjY2VzcygpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIG1fZnJhbWUtPmxvYWRlcigpLmNsaWVudCgp Lmhhc0ZyYW1lU3BlY2lmaWNTdG9yYWdlQWNjZXNzKCk7CisgICAgcmV0dXJuIG1fZnJhbWUgJiYg bV9mcmFtZS0+bG9hZGVyKCkuY2xpZW50KCkuaGFzRnJhbWVTcGVjaWZpY1N0b3JhZ2VBY2Nlc3Mo KTsKIH0KICAgICAKIHZvaWQgRG9jdW1lbnQ6OnNldEhhc0ZyYW1lU3BlY2lmaWNTdG9yYWdlQWNj ZXNzKGJvb2wgdmFsdWUpCiB7Ci0gICAgbV9mcmFtZS0+bG9hZGVyKCkuY2xpZW50KCkuc2V0SGFz RnJhbWVTcGVjaWZpY1N0b3JhZ2VBY2Nlc3ModmFsdWUpOworICAgIGlmIChtX2ZyYW1lKQorICAg ICAgICBtX2ZyYW1lLT5sb2FkZXIoKS5jbGllbnQoKS5zZXRIYXNGcmFtZVNwZWNpZmljU3RvcmFn ZUFjY2Vzcyh2YWx1ZSk7CiB9CiAKIGJvb2wgRG9jdW1lbnQ6Omhhc1JlcXVlc3RlZFBhZ2VTcGVj aWZpY1N0b3JhZ2VBY2Nlc3NXaXRoVXNlckludGVyYWN0aW9uKGNvbnN0IFN0cmluZyYgcHJpbWFy eURvbWFpbikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRP YnNlcnZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkT2JzZXJ2ZXIu Y3BwCmluZGV4IGEzNjMxNTUwMTcwMjBjOTc3ZjVkZTU0N2M1ZTliODIxNmFkZTI5ZTAuLjMwZGZh YTBhNDNlYTE2MjE2ZWE2ZmUxMzQ2NzkwMjE1NjE2Mzk3MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRPYnNlcnZlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL1Jlc291cmNlTG9hZE9ic2VydmVyLmNwcApAQCAtMTkzLDcgKzE5Myw3IEBAIHZv aWQgUmVzb3VyY2VMb2FkT2JzZXJ2ZXI6OmxvZ1dlYlNvY2tldExvYWRpbmcoY29uc3QgVVJMJiB0 YXJnZXRVUkwsIGNvbnN0IFVSTCYKIAogdm9pZCBSZXNvdXJjZUxvYWRPYnNlcnZlcjo6bG9nVXNl ckludGVyYWN0aW9uV2l0aFJlZHVjZWRUaW1lUmVzb2x1dGlvbihjb25zdCBEb2N1bWVudCYgZG9j dW1lbnQpCiB7Ci0gICAgaWYgKCFzaG91bGRMb2coZG9jdW1lbnQuc2Vzc2lvbklEKCkuaXNFcGhl bWVyYWwoKSkpCisgICAgaWYgKCFkb2N1bWVudC5zZXNzaW9uSUQoKS5pc1ZhbGlkKCkgfHwgIXNo b3VsZExvZyhkb2N1bWVudC5zZXNzaW9uSUQoKS5pc0VwaGVtZXJhbCgpKSkKICAgICAgICAgcmV0 dXJuOwogCiAgICAgYXV0byYgdXJsID0gZG9jdW1lbnQudXJsKCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNw cCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlBy b2Nlc3MuY3BwCmluZGV4IDNkZjQzYzQ2ZGRiYjM1NTY4M2I1NDU5ZmYzOGI1NjU4OTc3MGZmY2Eu LmIxYzcyMTMyNzUxMDEzMThiNzI3NjAyMzU1YTA3NjE0YjBiMjgwZmEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3Mu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25U b1dlYlByb2Nlc3MuY3BwCkBAIC01ODcsNiArNTg3LDEwIEBAIHZvaWQgTmV0d29ya0Nvbm5lY3Rp b25Ub1dlYlByb2Nlc3M6OnJlbW92ZVN0b3JhZ2VBY2Nlc3NGb3JBbGxGcmFtZXNPblBhZ2UoUEFM OjpTCiAKIHZvaWQgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmxvZ1VzZXJJbnRlcmFj dGlvbihQQUw6OlNlc3Npb25JRCBzZXNzaW9uSUQsIGNvbnN0IFN0cmluZyYgdG9wTGV2ZWxPcmln aW4pCiB7CisgICAgQVNTRVJUKHNlc3Npb25JRC5pc1ZhbGlkKCkpOworICAgIGlmICghc2Vzc2lv bklELmlzVmFsaWQoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYgKGF1dG8gbmV0d29ya1Nl c3Npb24gPSBuZXR3b3JrUHJvY2VzcygpLm5ldHdvcmtTZXNzaW9uKHNlc3Npb25JRCkpIHsKICAg ICAgICAgaWYgKGF1dG8qIHJlc291cmNlTG9hZFN0YXRpc3RpY3MgPSBuZXR3b3JrU2Vzc2lvbi0+ cmVzb3VyY2VMb2FkU3RhdGlzdGljcygpKQogICAgICAgICAgICAgcmVzb3VyY2VMb2FkU3RhdGlz dGljcy0+bG9nVXNlckludGVyYWN0aW9uKHRvcExldmVsT3JpZ2luLCBbXSB7IH0pOwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IGFmZjYyMjhlYjYwODE5Y2M2OTI2NjA2N2ZhMDJlYWRhMThkOWJjMjguLmU4MDhkOWNmOTYwMDdl ZDkyMWU1YWZiY2JiNjFmNWY1NzBiYTI3NDAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0w Mi0xOCAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KKworICAgICAgICBDaGVj ayB0aGUgZXhpc3RlbmNlIG9mIHRoZSBmcmFtZSBpbiBEb2N1bWVudDo6aGFzRnJhbWVTcGVjaWZp Y1N0b3JhZ2VBY2Nlc3MoKSBhbmQgRG9jdW1lbnQ6OnNldEhhc0ZyYW1lU3BlY2lmaWNTdG9yYWdl QWNjZXNzKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5NDc3NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc3MzE5NDU+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgR2VvZmZyZXkgR2FyZW4gYW5kIENocmlzIER1bWV6LgorCisgICAgICAgICogaHR0 cC90ZXN0cy9zdG9yYWdlQWNjZXNzL3JlbW92ZS1yZXF1ZXN0aW5nLWlmcmFtZS1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9yZW1vdmUtcmVx dWVzdGluZy1pZnJhbWUuaHRtbDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9zdG9yYWdl QWNjZXNzL3Jlc291cmNlcy9yZXF1ZXN0LXN0b3JhZ2UtYWNjZXNzLWFuZC1pbW1lZGlhdGVseS1w b3N0bWVzc2FnZS1pZnJhbWUuaHRtbDogQWRkZWQuCisKIDIwMTktMDItMTcgIEZ1amlpIEhpcm9u b3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgVXNlIGR1bXBKU0NvbnNv bGVMb2dJblN0ZEVycj10cnVlIHdlYmtpdC10ZXN0LXJ1bm5lciBvcHRpb24gZm9yIG5vbi1pbXBv cnRlZCB0ZXN0cyBpbnN0ZWFkIG9mIHVzaW5nIER1bXBKU0NvbnNvbGVMb2dJblN0ZEVyciBleHBl Y3RhdGlvbiBpbiBUZXN0RXhwZWN0YXRpb25zCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvcmVtb3ZlLXJlcXVlc3RpbmctaWZyYW1lLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9yZW1vdmUtcmVxdWVzdGlu Zy1pZnJhbWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjcwNTQ2ZDI5MzI3OTQzMDk0MzYyM2U5 OWMzN2I3MTc2MzZiMjMwZDIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3N0b3JhZ2VBY2Nlc3MvcmVtb3ZlLXJlcXVlc3RpbmctaWZyYW1lLWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDEwIEBACitUZXN0cyB0aGF0IFN0b3JhZ2UgQWNjZXNzIEFQSSBjYWxscyB3b3Jr IHdlbGwgZm9yIHJlbW92ZWQgZnJhbWVzLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBz ZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisK KworUEFTUyBpZnJhbWUgcmVtb3ZlZC4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK KworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3N0 b3JhZ2VBY2Nlc3MvcmVtb3ZlLXJlcXVlc3RpbmctaWZyYW1lLmh0bWwgYi9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvcmVtb3ZlLXJlcXVlc3RpbmctaWZyYW1lLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uZDUzYTIyZjhmNmJlOGJmMjRlMzQ2NDg3MDk0OWQxNDJlMzRjZmZjZQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9yZW1vdmUt cmVxdWVzdGluZy1pZnJhbWUuaHRtbApAQCAtMCwwICsxLDYyIEBACis8IURPQ1RZUEUgaHRtbD4g PCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyB1c2VGbGV4aWJsZVZpZXdwb3J0PXRydWUgXSAtLT4K KzxodG1sPgorPGhlYWQ+CisgICAgPG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9IndpZHRo PWRldmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xLCB1c2VyLXNjYWxhYmxlPW5vIj4KKyAgICA8 c2NyaXB0IHNyYz0iL2pzLXRlc3QtcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgorICAg IDxzY3JpcHQgc3JjPSIvanMtdGVzdC1yZXNvdXJjZXMvdWktaGVscGVyLmpzIj48L3NjcmlwdD4K KyAgICA8c2NyaXB0IHNyYz0iL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvcmVzb3VyY2VzL3V0aWwu anMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPHNjcmlw dD4KKyAgICBkZXNjcmlwdGlvbigiVGVzdHMgdGhhdCBTdG9yYWdlIEFjY2VzcyBBUEkgY2FsbHMg d29yayB3ZWxsIGZvciByZW1vdmVkIGZyYW1lcy4iKTsKKyAgICBqc1Rlc3RJc0FzeW5jID0gdHJ1 ZTsKKworICAgIGZ1bmN0aW9uIGZpbmlzaFRlc3QoKSB7CisgICAgICAgIHNldEVuYWJsZUZlYXR1 cmUoZmFsc2UsIGZpbmlzaEpTVGVzdCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gcmVjZWl2ZU1l c3NhZ2UoKSB7CisgICAgICAgIHJlcXVlc3RpbmdpZnJhbWUucmVtb3ZlKCk7CisgICAgICAgIHRl c3RQYXNzZWQoImlmcmFtZSByZW1vdmVkLiIpOworICAgICAgICBzZXRUaW1lb3V0KGZpbmlzaFRl c3QsIDAuNSk7CisgICAgfQorCisgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoIm1lc3NhZ2Ui LCByZWNlaXZlTWVzc2FnZSwgZmFsc2UpOworCisgICAgZnVuY3Rpb24gYWN0aXZhdGVFbGVtZW50 KGVsZW1lbnRJZCkgeworICAgICAgICB2YXIgZWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKGVsZW1lbnRJZCk7CisgICAgICAgIHZhciBjZW50ZXJYID0gZWxlbWVudC5vZmZzZXRMZWZ0 ICsgZWxlbWVudC5vZmZzZXRXaWR0aCAvIDI7CisgICAgICAgIHZhciBjZW50ZXJZID0gZWxlbWVu dC5vZmZzZXRUb3AgKyBlbGVtZW50Lm9mZnNldEhlaWdodCAvIDI7CisgICAgICAgIFVJSGVscGVy LmFjdGl2YXRlQXQoY2VudGVyWCwgY2VudGVyWSkudGhlbigKKyAgICAgICAgICAgIGZ1bmN0aW9u ICgpIHsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKQorICAgICAgICAg ICAgICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCJlc2NhcGUiKTsKKyAgICAgICAgICAgICAg ICBlbHNlIHsKKyAgICAgICAgICAgICAgICAgICAgdGVzdEZhaWxlZCgiTm8gZXZlbnRTZW5kZXIu Iik7CisgICAgICAgICAgICAgICAgICAgIGZpbmlzaFRlc3QoKTsKKyAgICAgICAgICAgICAgICB9 CisgICAgICAgICAgICB9LAorICAgICAgICAgICAgZnVuY3Rpb24gKCkgeworICAgICAgICAgICAg ICAgIHRlc3RGYWlsZWQoIlByb21pc2UgcmVqZWN0ZWQuIik7CisgICAgICAgICAgICAgICAgZmlu aXNoVGVzdCgpOworICAgICAgICAgICAgfQorICAgICAgICApOworICAgIH0KKworICAgIGNvbnN0 IGlmcmFtZUlEID0gInJlcXVlc3RpbmdpZnJhbWUiOworICAgIGNvbnN0IGlmcmFtZVNvdXJjZSA9 ICJodHRwOi8vbG9jYWxob3N0OjgwMDAvc3RvcmFnZUFjY2Vzcy9yZXNvdXJjZXMvcmVxdWVzdC1z dG9yYWdlLWFjY2Vzcy1hbmQtaW1tZWRpYXRlbHktcG9zdG1lc3NhZ2UtaWZyYW1lLmh0bWwiOwor CisgICAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICAgICAgbGV0IGlmcmFtZUVsZW1lbnQgPSBk b2N1bWVudC5jcmVhdGVFbGVtZW50KCJpZnJhbWUiKTsKKyAgICAgICAgaWZyYW1lRWxlbWVudC5v bmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHRlc3RSdW5uZXIuc3RhdGlzdGljc1Vw ZGF0ZUNvb2tpZUJsb2NraW5nKGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgIGFjdGl2YXRl RWxlbWVudChpZnJhbWVJRCk7CisgICAgICAgICAgICB9KTsKKyAgICAgICAgfTsKKyAgICAgICAg aWZyYW1lRWxlbWVudC5pZCA9IGlmcmFtZUlEOworICAgICAgICBpZnJhbWVFbGVtZW50LnNyYyA9 IGlmcmFtZVNvdXJjZTsKKyAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChpZnJhbWVF bGVtZW50KTsKKyAgICB9Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5l IGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3N0b3Jh Z2VBY2Nlc3MvcmVzb3VyY2VzL3JlcXVlc3Qtc3RvcmFnZS1hY2Nlc3MtYW5kLWltbWVkaWF0ZWx5 LXBvc3RtZXNzYWdlLWlmcmFtZS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdl QWNjZXNzL3Jlc291cmNlcy9yZXF1ZXN0LXN0b3JhZ2UtYWNjZXNzLWFuZC1pbW1lZGlhdGVseS1w b3N0bWVzc2FnZS1pZnJhbWUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yODQwZmMxMzUwOTRmNjBkMTVhYzlh MTI2YmEyN2Q3YWNjNjNiY2U1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9zdG9yYWdlQWNjZXNzL3Jlc291cmNlcy9yZXF1ZXN0LXN0b3JhZ2UtYWNjZXNzLWFuZC1p bW1lZGlhdGVseS1wb3N0bWVzc2FnZS1pZnJhbWUuaHRtbApAQCAtMCwwICsxLDE1IEBACis8aHRt bD4KKzxoZWFkPgorICAgIDxzY3JpcHQ+CisgICAgICAgIGlmIChpbnRlcm5hbHMpCisgICAgICAg ICAgICBpbnRlcm5hbHMuc2V0VXNlckdyYW50c1N0b3JhZ2VBY2Nlc3ModHJ1ZSk7CisKKyAgICAg ICAgZnVuY3Rpb24gbWFrZVJlcXVlc3RXaXRoVXNlckdlc3R1cmUoKSB7CisgICAgICAgICAgICBk b2N1bWVudC5yZXF1ZXN0U3RvcmFnZUFjY2VzcygpOworICAgICAgICAgICAgdG9wLnBvc3RNZXNz YWdlKCJBUEkgY2FsbGVkLiIsICJodHRwOi8vMTI3LjAuMC4xOjgwMDAiKTsKKyAgICAgICAgfQor ICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25jbGljaz0ibWFrZVJlcXVlc3RXaXRoVXNl ckdlc3R1cmUoKSI+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmls ZQo=