194774 2019-02-18 04:41:11 -0800 WebPageProxy::didFinishDocumentLoadForFrame() crashing in WPE and GTK+ ports 2019-02-18 13:39:37 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 csaavedra csaavedra achristensen dbates webkit-bug-importer wilander oldest_to_newest 1507251 0 csaavedra 2019-02-18 04:41:11 -0800 WebPageProxy::didFinishDocumentLoadForFrame() crashing in WPE and GTK+ ports 1507252 1 362290 csaavedra 2019-02-18 04:41:31 -0800 Created attachment 362290 Patch 1507257 2 csaavedra 2019-02-18 06:44:43 -0800 This was introduced in https://trac.webkit.org/changeset/241451/ 1507371 3 362290 achristensen 2019-02-18 12:46:59 -0800 Comment on attachment 362290 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362290&action=review Null checking navigation before using it is fine, but the way you did it here makes it hard to read and see where the assignment is done. Could we keep the assignment on its own line? > Source/WebKit/ChangeLog:3 > + WebPageProxy::didFinishDocumentLoadForFrame() crashing in WPE and GTK+ ports Why is this only WPE and GTK? Under what conditions does it crash? 1507399 4 362290 achristensen 2019-02-18 13:30:48 -0800 Comment on attachment 362290 Patch https://trac.webkit.org/changeset/241735/webkit 1507405 5 webkit-bug-importer 2019-02-18 13:39:37 -0800 <rdar://problem/48176470> 362290 2019-02-18 04:41:31 -0800 2019-02-18 13:30:48 -0800 Patch bug-194774-20190218144130.patch text/plain 2038 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc1Yzc2YWRhZGM5NmVkMWUz NjFiMGU2YjJlNDgxMWE0NGU4MjA4ZjQuLmNlZGNmYTJlZWRkMmFhMzNkZmQ3ZTQzMzU4M2U1M2Jk MWVhZDBjZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDItMTggIENsYXVkaW8g U2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJQYWdlUHJveHk6 OmRpZEZpbmlzaERvY3VtZW50TG9hZEZvckZyYW1lKCkgY3Jhc2hpbmcgaW4gV1BFIGFuZCBHVEsr IHBvcnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTQ3NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJv eHk6OmRpZEZpbmlzaERvY3VtZW50TG9hZEZvckZyYW1lKToKKyAgICAgICAgbmF2aWdhdGlvblN0 YXRlKCkubmF2aWdhdGlvbihuYXZpZ2F0aW9uSUQpIGNhbiByZXR1cm4gbnVsbHB0ciBhbmQKKyAg ICAgICAgbmVlZHMgdG8gYmUgc2FmZS1ndWFyZGVkLCBhcyBpdCdzIHRoZSBjYXNlIGluIG90aGVy IG1ldGhvZHMgZmV0Y2hpbmcKKyAgICAgICAgdGhlIG5hdmlnYXRpb24gdGhpcyB3YXkuCisKIDIw MTktMDItMTcgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIGh0 dHBzOi8vZGV2aWNlLmxvZ2luLm1pY3Jvc29mdG9ubGluZS5jb20gaXMgaGFuZ2luZyBvbiBTVFA3 NQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggZjBhM2Q0Yzhm YWZhYTExMTMzN2Y4N2UyZGQwNThjODEyNjBiYWFkZS4uOGEwZTdmMTI1YWMwNzhjMDNlYWM1NGNj Y2EyNGU4YTIxMzViNjIxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku Y3BwCkBAIC00MTM0LDggKzQxMzQsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkRmluaXNoRG9j dW1lbnRMb2FkRm9yRnJhbWUodWludDY0X3QgZnJhbWVJRCwgdWludDY0X3QgbmF2aQogCiAgICAg Ly8gRklYTUU6IFdlIHNob3VsZCBtZXNzYWdlIGNoZWNrIHRoYXQgbmF2aWdhdGlvbklEIGlzIG5v dCB6ZXJvIGhlcmUsIGJ1dCBpdCdzIGN1cnJlbnRseSB6ZXJvIGZvciBzb21lIG5hdmlnYXRpb25z IHRocm91Z2ggdGhlIHBhZ2UgY2FjaGUuCiAgICAgUmVmUHRyPEFQSTo6TmF2aWdhdGlvbj4gbmF2 aWdhdGlvbjsKLSAgICBpZiAoZnJhbWUtPmlzTWFpbkZyYW1lKCkgJiYgbmF2aWdhdGlvbklEKSB7 Ci0gICAgICAgIG5hdmlnYXRpb24gPSBuYXZpZ2F0aW9uU3RhdGUoKS5uYXZpZ2F0aW9uKG5hdmln YXRpb25JRCk7CisgICAgaWYgKGZyYW1lLT5pc01haW5GcmFtZSgpICYmIG5hdmlnYXRpb25JRCAm JiAobmF2aWdhdGlvbiA9IG5hdmlnYXRpb25TdGF0ZSgpLm5hdmlnYXRpb24obmF2aWdhdGlvbklE KSkpIHsKICAgICAgICAgaWYgKGF1dG8mIGFkQ2xpY2tBdHRyaWJ1dGlvbiA9IG5hdmlnYXRpb24t PmFkQ2xpY2tBdHRyaWJ1dGlvbigpKSB7CiAgICAgICAgICAgICBpZiAoYWRDbGlja0F0dHJpYnV0 aW9uLT5kZXN0aW5hdGlvbigpLm1hdGNoZXMoZnJhbWUtPnVybCgpKSkKICAgICAgICAgICAgICAg ICBtX3Byb2Nlc3MtPnByb2Nlc3NQb29sKCkuc2VuZFRvTmV0d29ya2luZ1Byb2Nlc3MoTWVzc2Fn ZXM6Ok5ldHdvcmtQcm9jZXNzOjpTdG9yZUFkQ2xpY2tBdHRyaWJ1dGlvbihtX3dlYnNpdGVEYXRh U3RvcmUtPnNlc3Npb25JRCgpLCAqYWRDbGlja0F0dHJpYnV0aW9uKSk7Cg==