194772 2019-02-18 01:58:15 -0800 [ARM] Fix crash with sampling profiler 2019-02-19 09:03:22 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dominik.infuehr webkit-unassigned commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff saam ysuzuki oldest_to_newest 1507217 0 dominik.infuehr 2019-02-18 01:58:15 -0800 [ARM] Fix crash with sampling profiler 1507222 1 362275 dominik.infuehr 2019-02-18 02:21:33 -0800 Created attachment 362275 Patch 1507223 2 362276 dominik.infuehr 2019-02-18 02:22:32 -0800 Created attachment 362276 Patch 1507302 3 362276 mark.lam 2019-02-18 09:50:51 -0800 Comment on attachment 362276 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362276&action=review r=me with fix. > Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:181 > + if (dest == ARMRegisters::sp) { This is incorrect. You only need this alternative codegen if (dest == ARMRegisters::sp && src != dest). If (dest == ARMRegisters::sp && src == dest), the implementation below would generate more optimal code. For details, see add(RegisterID rd, RegisterID rn, ARMThumbImmediate imm) in ARMv7Assembler.h. 1507410 4 362327 dominik.infuehr 2019-02-18 13:49:57 -0800 Created attachment 362327 Patch 1507603 5 dominik.infuehr 2019-02-18 22:56:43 -0800 Thank you very much for the review! I've extended the condition to also check for `src != dest`. 1507607 6 362327 commit-queue 2019-02-18 23:16:03 -0800 Comment on attachment 362327 Patch Clearing flags on attachment: 362327 Committed r241756: <https://trac.webkit.org/changeset/241756> 1507608 7 commit-queue 2019-02-18 23:16:05 -0800 All reviewed patches have been landed. Closing bug. 1507686 8 webkit-bug-importer 2019-02-19 09:03:22 -0800 <rdar://problem/48201956> 362275 2019-02-18 02:21:33 -0800 2019-02-18 02:22:14 -0800 Patch bug-194772-20190218112132.patch text/plain 3919 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx M2YxZDE3ZDI5MGY3ODFhMGYyNTJlYjQ5NmI2NDQ4ZjE3N2Y0NzRlLi4zZDEyYTEzNzk1NzJlZGZj YTM2OTE5ZTM4YTI0NzMxZjczODI4ODg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOS0wMi0xOCAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBbQVJNXSBGaXggY3Jhc2ggd2l0aCBzYW1wbGluZyBwcm9maWxlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NzcyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc2FtcGxpbmct cHJvZmlsZXItcmljaGFyZHMuanMgd2FzIGNyYXNoaW5nIHdpdGggYW4gZW5hYmxlZCBzYW1wbGlu ZyBwcm9maWxlci4gYWRkMzIKKyAgICAgICAgZGlkIG5vdCB1cGRhdGUgdGhlIHN0YWNrIHBvaW50 ZXIgaW4gYSBzaW5nbGUgaW5zdHJ1Y3Rpb24uIFRoZSBzcmMgcmVnaXN0ZXIgd2FzIGZpcnN0Cisg ICAgICAgIG1vdmVkIGludG8gdGhlIHN0YWNrIHBvaW50ZXIsIHRoZSBpbW1lZGlhdGUgaW1tIHdh cyBhZGRlZCBpbiBhIHN1YnNlcXVlbnQgaW5zdHJ1Y3Rpb24uCisKKyAgICAgICAgVGhpcyB3YXMg cHJvYmxlbWF0aWMgd2hlbiBhIHNpZ25hbCBoYW5kbGVyIHdhcyBpbnZva2VkIGJlZm9yZSBhcHBs eWluZyB0aGUgaW1tZWRpYXRlLAorICAgICAgICB3aGVuIHRoZSBzdGFjayBwb2ludGVyIGlzIHN0 aWxsIHNldCB0byB0aGUgdGVtcG9yYXJ5IHZhbHVlLiBBdm9pZCB0aGlzIGJ5IGNhbGN1bGF0aW5n IHNyYytpbW0gaW4KKyAgICAgICAgYSB0ZW1wb3JhcnkgcmVnaXN0ZXIgYW5kIHRoZW4gbW92ZSBp dCBpbiBvbmUgZ28gaW50byB0aGUgc3RhY2sgcG9pbnRlci4KKworICAgICAgICAqIGFzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlckFSTXY3Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJN djc6OmFkZDMyKToKKwogMjAxOS0wMi0xNyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNv bT4KIAogICAgICAgICBXYXNtQjNJUkdlbmVyYXRvciBtb2RlbHMgc29tZSBlZmZlY3RzIGluY29y cmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyQVJNdjcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJBUk12Ny5oCmluZGV4IGMxZmJiNDcwNmM1NzE0ODE2MWI1NzJjZGVhNWU0MWM2Y2Mx YWQzY2MuLmVhMTEyZjQyYzc5MjM0ZTVhZjYyYzA0NGFjYTA0MGVmYjBjZmYzYjUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12 Ny5oCkBAIC0xNzcsMTUgKzE3NywxNSBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGFkZDMyKFRydXN0 ZWRJbW0zMiBpbW0sIFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRlc3QpCiAgICAgewotICAg ICAgICBBUk1UaHVtYkltbWVkaWF0ZSBhcm1JbW0gPSBBUk1UaHVtYkltbWVkaWF0ZTo6bWFrZVVJ bnQxMk9yRW5jb2RlZEltbShpbW0ubV92YWx1ZSk7Ci0KLSAgICAgICAgLy8gRm9yIGFkZHMgd2l0 aCBzdGFjayBwb2ludGVyIGRlc3RpbmF0aW9uLCBtb3ZpbmcgdGhlIHNyYyBmaXJzdCB0byBzcCBp cwotICAgICAgICAvLyBuZWVkZWQgdG8gYXZvaWQgdW5wcmVkaWN0YWJsZSBpbnN0cnVjdGlvbgot ICAgICAgICBpZiAoZGVzdCA9PSBBUk1SZWdpc3RlcnM6OnNwICYmIHNyYyAhPSBkZXN0KSB7Ci0g ICAgICAgICAgICBtb3ZlKHNyYywgQVJNUmVnaXN0ZXJzOjpzcCk7Ci0gICAgICAgICAgICBzcmMg PSBBUk1SZWdpc3RlcnM6OnNwOworICAgICAgICAvLyBGb3IgYWRkcyB3aXRoIHN0YWNrIHBvaW50 ZXIgZGVzdGluYXRpb24gYXZvaWQgdW5wcmVkaWN0YWJsZSBpbnN0cnVjdGlvbgorICAgICAgICBp ZiAoZGVzdCA9PSBBUk1SZWdpc3RlcnM6OnNwKSB7CisgICAgICAgICAgICBhZGQzMihpbW0sIHNy YywgZGF0YVRlbXBSZWdpc3Rlcik7CisgICAgICAgICAgICBtb3ZlKGRhdGFUZW1wUmVnaXN0ZXIs IGRlc3QpOworICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKKyAgICAgICAgQVJNVGh1 bWJJbW1lZGlhdGUgYXJtSW1tID0gQVJNVGh1bWJJbW1lZGlhdGU6Om1ha2VVSW50MTJPckVuY29k ZWRJbW0oaW1tLm1fdmFsdWUpOworCiAgICAgICAgIGlmIChhcm1JbW0uaXNWYWxpZCgpKQogICAg ICAgICAgICAgbV9hc3NlbWJsZXIuYWRkKGRlc3QsIHNyYywgYXJtSW1tKTsKICAgICAgICAgZWxz ZSB7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IDAyZGE0NTk3MDdjYjViMDI5YzFhMDQ2MzE5MWZlODk3ZWRiNTUwNTQuLjM4NjE5NjdhZmNk NWY0NmUzMWE0MjY3YjM1YjYwZmIzZDc2MWZjNjEgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdl TG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDItMTgg IERvbWluaWsgSW5mdWVociAgPGRpbmZ1ZWhyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0FSTV0g Rml4IGNyYXNoIHdpdGggc2FtcGxpbmcgcHJvZmlsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDc3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBza2lwIHRlc3Qgc2luY2UgY3Jhc2ggd2l0 aCBzYW1wbGluZyBwcm9maWxlciBpcyBub3cgZml4ZWQuCisKKyAgICAgICAgKiBzdHJlc3Mvc2Ft cGxpbmctcHJvZmlsZXItcmljaGFyZHMuanM6CisKIDIwMTktMDItMTcgIFNhYW0gQmFyYXRpICA8 c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRGVhZGxvY2sgd2hlbiBhZGRpbmcgYSBTdHJ1 Y3R1cmUgcHJvcGVydHkgdHJhbnNpdGlvbiBhbmQgdGhlbiBkb2luZyBpbmNyZW1lbnRhbCBtYXJr aW5nCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9zYW1wbGluZy1wcm9maWxlci1yaWNoYXJk cy5qcyBiL0pTVGVzdHMvc3RyZXNzL3NhbXBsaW5nLXByb2ZpbGVyLXJpY2hhcmRzLmpzCmluZGV4 IDVlYTQxYmQ3MTQ5NmEzMzY0NDdkZTliNjZjNjZmNWYzZDIzMDI4NjUuLjdjZjgyYjMwMmE3ZGIz ZjNkZWNkMmY0MWRjNDg1NTc2MDk1OWVkMGIgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL3Nh bXBsaW5nLXByb2ZpbGVyLXJpY2hhcmRzLmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL3NhbXBsaW5n LXByb2ZpbGVyLXJpY2hhcmRzLmpzCkBAIC0xLDYgKzEsNCBAQAotLy8gW0pTQ10gW0FybXY3XSBz dHJlc3Mvc2FtcGxpbmctcHJvZmlsZXItcmljaGFyZHMuanMgY3Jhc2hlcwotLy8gaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDQyNgotLy9AIHNraXAgaWYgWyJhcm0i LCAibWlwcyJdLmluY2x1ZGU/KCRhcmNoaXRlY3R1cmUpIGFuZCAkaG9zdE9TID09ICJsaW51eCIK Ky8vQCBza2lwIGlmICRhcmNoaXRlY3R1cmUgPT0gIm1pcHMiIGFuZCAkaG9zdE9TID09ICJsaW51 eCIKIC8vQCBza2lwIGlmICRhcmNoaXRlY3R1cmUgPT0gIng4NiIKIC8vQCBydW5EZWZhdWx0KCIt LWNvbGxlY3RDb250aW51b3VzbHk9MSIsICItLXVzZVNhbXBsaW5nUHJvZmlsZXI9MSIsICItLWNv bGxlY3RTYW1wbGluZ1Byb2ZpbGVyRGF0YUZvckpTQ1NoZWxsPTEiKQogCg== 362276 2019-02-18 02:22:32 -0800 2019-02-18 13:49:52 -0800 Patch bug-194772-20190218112231.patch text/plain 3919 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx M2YxZDE3ZDI5MGY3ODFhMGYyNTJlYjQ5NmI2NDQ4ZjE3N2Y0NzRlLi4zZDEyYTEzNzk1NzJlZGZj YTM2OTE5ZTM4YTI0NzMxZjczODI4ODg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOS0wMi0xOCAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBbQVJNXSBGaXggY3Jhc2ggd2l0aCBzYW1wbGluZyBwcm9maWxlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NzcyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc2FtcGxpbmct cHJvZmlsZXItcmljaGFyZHMuanMgd2FzIGNyYXNoaW5nIHdpdGggYW4gZW5hYmxlZCBzYW1wbGlu ZyBwcm9maWxlci4gYWRkMzIKKyAgICAgICAgZGlkIG5vdCB1cGRhdGUgdGhlIHN0YWNrIHBvaW50 ZXIgaW4gYSBzaW5nbGUgaW5zdHJ1Y3Rpb24uIFRoZSBzcmMgcmVnaXN0ZXIgd2FzIGZpcnN0Cisg ICAgICAgIG1vdmVkIGludG8gdGhlIHN0YWNrIHBvaW50ZXIsIHRoZSBpbW1lZGlhdGUgaW1tIHdh cyBhZGRlZCBpbiBhIHN1YnNlcXVlbnQgaW5zdHJ1Y3Rpb24uCisKKyAgICAgICAgVGhpcyB3YXMg cHJvYmxlbWF0aWMgd2hlbiBhIHNpZ25hbCBoYW5kbGVyIHdhcyBpbnZva2VkIGJlZm9yZSBhcHBs eWluZyB0aGUgaW1tZWRpYXRlLAorICAgICAgICB3aGVuIHRoZSBzdGFjayBwb2ludGVyIGlzIHN0 aWxsIHNldCB0byB0aGUgdGVtcG9yYXJ5IHZhbHVlLiBBdm9pZCB0aGlzIGJ5IGNhbGN1bGF0aW5n IHNyYytpbW0gaW4KKyAgICAgICAgYSB0ZW1wb3JhcnkgcmVnaXN0ZXIgYW5kIHRoZW4gbW92ZSBp dCBpbiBvbmUgZ28gaW50byB0aGUgc3RhY2sgcG9pbnRlci4KKworICAgICAgICAqIGFzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlckFSTXY3Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJN djc6OmFkZDMyKToKKwogMjAxOS0wMi0xNyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNv bT4KIAogICAgICAgICBXYXNtQjNJUkdlbmVyYXRvciBtb2RlbHMgc29tZSBlZmZlY3RzIGluY29y cmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyQVJNdjcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJBUk12Ny5oCmluZGV4IGMxZmJiNDcwNmM1NzE0ODE2MWI1NzJjZGVhNWU0MWM2Y2Mx YWQzY2MuLmVhMTEyZjQyYzc5MjM0ZTVhZjYyYzA0NGFjYTA0MGVmYjBjZmYzYjUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12 Ny5oCkBAIC0xNzcsMTUgKzE3NywxNSBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGFkZDMyKFRydXN0 ZWRJbW0zMiBpbW0sIFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRlc3QpCiAgICAgewotICAg ICAgICBBUk1UaHVtYkltbWVkaWF0ZSBhcm1JbW0gPSBBUk1UaHVtYkltbWVkaWF0ZTo6bWFrZVVJ bnQxMk9yRW5jb2RlZEltbShpbW0ubV92YWx1ZSk7Ci0KLSAgICAgICAgLy8gRm9yIGFkZHMgd2l0 aCBzdGFjayBwb2ludGVyIGRlc3RpbmF0aW9uLCBtb3ZpbmcgdGhlIHNyYyBmaXJzdCB0byBzcCBp cwotICAgICAgICAvLyBuZWVkZWQgdG8gYXZvaWQgdW5wcmVkaWN0YWJsZSBpbnN0cnVjdGlvbgot ICAgICAgICBpZiAoZGVzdCA9PSBBUk1SZWdpc3RlcnM6OnNwICYmIHNyYyAhPSBkZXN0KSB7Ci0g ICAgICAgICAgICBtb3ZlKHNyYywgQVJNUmVnaXN0ZXJzOjpzcCk7Ci0gICAgICAgICAgICBzcmMg PSBBUk1SZWdpc3RlcnM6OnNwOworICAgICAgICAvLyBGb3IgYWRkcyB3aXRoIHN0YWNrIHBvaW50 ZXIgZGVzdGluYXRpb24gYXZvaWQgdW5wcmVkaWN0YWJsZSBpbnN0cnVjdGlvbgorICAgICAgICBp ZiAoZGVzdCA9PSBBUk1SZWdpc3RlcnM6OnNwKSB7CisgICAgICAgICAgICBhZGQzMihpbW0sIHNy YywgZGF0YVRlbXBSZWdpc3Rlcik7CisgICAgICAgICAgICBtb3ZlKGRhdGFUZW1wUmVnaXN0ZXIs IGRlc3QpOworICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKKyAgICAgICAgQVJNVGh1 bWJJbW1lZGlhdGUgYXJtSW1tID0gQVJNVGh1bWJJbW1lZGlhdGU6Om1ha2VVSW50MTJPckVuY29k ZWRJbW0oaW1tLm1fdmFsdWUpOworCiAgICAgICAgIGlmIChhcm1JbW0uaXNWYWxpZCgpKQogICAg ICAgICAgICAgbV9hc3NlbWJsZXIuYWRkKGRlc3QsIHNyYywgYXJtSW1tKTsKICAgICAgICAgZWxz ZSB7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IDAyZGE0NTk3MDdjYjViMDI5YzFhMDQ2MzE5MWZlODk3ZWRiNTUwNTQuLjM4NjE5NjdhZmNk NWY0NmUzMWE0MjY3YjM1YjYwZmIzZDc2MWZjNjEgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdl TG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDItMTgg IERvbWluaWsgSW5mdWVociAgPGRpbmZ1ZWhyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0FSTV0g Rml4IGNyYXNoIHdpdGggc2FtcGxpbmcgcHJvZmlsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDc3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBza2lwIHRlc3Qgc2luY2UgY3Jhc2ggd2l0 aCBzYW1wbGluZyBwcm9maWxlciBpcyBub3cgZml4ZWQuCisKKyAgICAgICAgKiBzdHJlc3Mvc2Ft cGxpbmctcHJvZmlsZXItcmljaGFyZHMuanM6CisKIDIwMTktMDItMTcgIFNhYW0gQmFyYXRpICA8 c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRGVhZGxvY2sgd2hlbiBhZGRpbmcgYSBTdHJ1 Y3R1cmUgcHJvcGVydHkgdHJhbnNpdGlvbiBhbmQgdGhlbiBkb2luZyBpbmNyZW1lbnRhbCBtYXJr aW5nCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9zYW1wbGluZy1wcm9maWxlci1yaWNoYXJk cy5qcyBiL0pTVGVzdHMvc3RyZXNzL3NhbXBsaW5nLXByb2ZpbGVyLXJpY2hhcmRzLmpzCmluZGV4 IDVlYTQxYmQ3MTQ5NmEzMzY0NDdkZTliNjZjNjZmNWYzZDIzMDI4NjUuLjdjZjgyYjMwMmE3ZGIz ZjNkZWNkMmY0MWRjNDg1NTc2MDk1OWVkMGIgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL3Nh bXBsaW5nLXByb2ZpbGVyLXJpY2hhcmRzLmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL3NhbXBsaW5n LXByb2ZpbGVyLXJpY2hhcmRzLmpzCkBAIC0xLDYgKzEsNCBAQAotLy8gW0pTQ10gW0FybXY3XSBz dHJlc3Mvc2FtcGxpbmctcHJvZmlsZXItcmljaGFyZHMuanMgY3Jhc2hlcwotLy8gaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDQyNgotLy9AIHNraXAgaWYgWyJhcm0i LCAibWlwcyJdLmluY2x1ZGU/KCRhcmNoaXRlY3R1cmUpIGFuZCAkaG9zdE9TID09ICJsaW51eCIK Ky8vQCBza2lwIGlmICRhcmNoaXRlY3R1cmUgPT0gIm1pcHMiIGFuZCAkaG9zdE9TID09ICJsaW51 eCIKIC8vQCBza2lwIGlmICRhcmNoaXRlY3R1cmUgPT0gIng4NiIKIC8vQCBydW5EZWZhdWx0KCIt LWNvbGxlY3RDb250aW51b3VzbHk9MSIsICItLXVzZVNhbXBsaW5nUHJvZmlsZXI9MSIsICItLWNv bGxlY3RTYW1wbGluZ1Byb2ZpbGVyRGF0YUZvckpTQ1NoZWxsPTEiKQogCg== 362327 2019-02-18 13:49:57 -0800 2019-02-18 23:16:03 -0800 Patch bug-194772-20190218224956.patch text/plain 3853 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 M2I3MDAzMjczM2UzMjI3YzZhOGQ4Y2I0ODdlMDcxNmM2Zjc1NmM1Li43MjQwOGQwYzAyNWFjM2Y5 MWRhMjhmNmMwNDY3Nzg0YjczNDUyNmMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOS0wMi0xOCAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBbQVJNXSBGaXggY3Jhc2ggd2l0aCBzYW1wbGluZyBwcm9maWxlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NzcyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBMYW0uCisKKyAgICAgICAgc2FtcGxpbmctcHJvZmls ZXItcmljaGFyZHMuanMgd2FzIGNyYXNoaW5nIHdpdGggYW4gZW5hYmxlZCBzYW1wbGluZyBwcm9m aWxlci4gYWRkMzIKKyAgICAgICAgZGlkIG5vdCB1cGRhdGUgdGhlIHN0YWNrIHBvaW50ZXIgaW4g YSBzaW5nbGUgaW5zdHJ1Y3Rpb24uIFRoZSBzcmMgcmVnaXN0ZXIgd2FzIGZpcnN0CisgICAgICAg IG1vdmVkIGludG8gdGhlIHN0YWNrIHBvaW50ZXIsIHRoZSBpbW1lZGlhdGUgaW1tIHdhcyBhZGRl ZCBpbiBhIHN1YnNlcXVlbnQgaW5zdHJ1Y3Rpb24uCisKKyAgICAgICAgVGhpcyB3YXMgcHJvYmxl bWF0aWMgd2hlbiBhIHNpZ25hbCBoYW5kbGVyIHdhcyBpbnZva2VkIGJlZm9yZSBhcHBseWluZyB0 aGUgaW1tZWRpYXRlLAorICAgICAgICB3aGVuIHRoZSBzdGFjayBwb2ludGVyIGlzIHN0aWxsIHNl dCB0byB0aGUgdGVtcG9yYXJ5IHZhbHVlLiBBdm9pZCB0aGlzIGJ5IGNhbGN1bGF0aW5nIHNyYytp bW0gaW4KKyAgICAgICAgYSB0ZW1wb3JhcnkgcmVnaXN0ZXIgYW5kIHRoZW4gbW92ZSBpdCBpbiBv bmUgZ28gaW50byB0aGUgc3RhY2sgcG9pbnRlci4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNy b0Fzc2VtYmxlckFSTXY3Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNdjc6OmFk ZDMyKToKKwogMjAxOS0wMi0xOCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4K IAogICAgICAgICBCeXRlY29kZSBjYWNoZSBzaG91bGQgYSBoYXZlIGEgYm9vdC1zcGVjaWZpYyB2 YWxpZGF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01h Y3JvQXNzZW1ibGVyQVJNdjcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXJBUk12Ny5oCmluZGV4IGMxZmJiNDcwNmM1NzE0ODE2MWI1NzJjZGVhNWU0MWM2 Y2MxYWQzY2MuLjU1OWZjMjYzZTlmN2VjYzcyY2RlNzdlZWQ5ZWI3YWE0MTAxMzViZmYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12 Ny5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJB Uk12Ny5oCkBAIC0xNzcsMTUgKzE3NywxNSBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGFkZDMyKFRy dXN0ZWRJbW0zMiBpbW0sIFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRlc3QpCiAgICAgewot ICAgICAgICBBUk1UaHVtYkltbWVkaWF0ZSBhcm1JbW0gPSBBUk1UaHVtYkltbWVkaWF0ZTo6bWFr ZVVJbnQxMk9yRW5jb2RlZEltbShpbW0ubV92YWx1ZSk7Ci0KLSAgICAgICAgLy8gRm9yIGFkZHMg d2l0aCBzdGFjayBwb2ludGVyIGRlc3RpbmF0aW9uLCBtb3ZpbmcgdGhlIHNyYyBmaXJzdCB0byBz cCBpcwotICAgICAgICAvLyBuZWVkZWQgdG8gYXZvaWQgdW5wcmVkaWN0YWJsZSBpbnN0cnVjdGlv bgorICAgICAgICAvLyBGb3IgYWRkcyB3aXRoIHN0YWNrIHBvaW50ZXIgZGVzdGluYXRpb24gYXZv aWQgdW5wcmVkaWN0YWJsZSBpbnN0cnVjdGlvbgogICAgICAgICBpZiAoZGVzdCA9PSBBUk1SZWdp c3RlcnM6OnNwICYmIHNyYyAhPSBkZXN0KSB7Ci0gICAgICAgICAgICBtb3ZlKHNyYywgQVJNUmVn aXN0ZXJzOjpzcCk7Ci0gICAgICAgICAgICBzcmMgPSBBUk1SZWdpc3RlcnM6OnNwOworICAgICAg ICAgICAgYWRkMzIoaW1tLCBzcmMsIGRhdGFUZW1wUmVnaXN0ZXIpOworICAgICAgICAgICAgbW92 ZShkYXRhVGVtcFJlZ2lzdGVyLCBkZXN0KTsKKyAgICAgICAgICAgIHJldHVybjsKICAgICAgICAg fQogCisgICAgICAgIEFSTVRodW1iSW1tZWRpYXRlIGFybUltbSA9IEFSTVRodW1iSW1tZWRpYXRl OjptYWtlVUludDEyT3JFbmNvZGVkSW1tKGltbS5tX3ZhbHVlKTsKKwogICAgICAgICBpZiAoYXJt SW1tLmlzVmFsaWQoKSkKICAgICAgICAgICAgIG1fYXNzZW1ibGVyLmFkZChkZXN0LCBzcmMsIGFy bUltbSk7CiAgICAgICAgIGVsc2UgewpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9K U1Rlc3RzL0NoYW5nZUxvZwppbmRleCBiMDczOTc5NzJkZGM0MDc2NjE0OTJkMGY4ODRhYzM2M2Nj NmVjZWFkLi5lNzkzMmFlMDM3NjExZGVkOWM1NmM2NzU3YmE0YjhkNjViYjgzNTUwIDEwMDY0NAot LS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDE5LTAyLTE4ICBEb21pbmlrIEluZnVlaHIgIDxkaW5mdWVockBpZ2FsaWEuY29t PgorCisgICAgICAgIFtBUk1dIEZpeCBjcmFzaCB3aXRoIHNhbXBsaW5nIHByb2ZpbGVyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ3NzIKKworICAg ICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAgICBEbyBub3Qgc2tpcCB0ZXN0IHNp bmNlIGNyYXNoIHdpdGggc2FtcGxpbmcgcHJvZmlsZXIgaXMgbm93IGZpeGVkLgorCisgICAgICAg ICogc3RyZXNzL3NhbXBsaW5nLXByb2ZpbGVyLXJpY2hhcmRzLmpzOgorCiAyMDE5LTAyLTE4ICBE b21pbmlrIEluZnVlaHIgIDxkaW5mdWVockBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtBUk1dIFRl c3QgZ2FyZGVuaW5nOiBUZXN0IHJ1bm5pbmcgb3V0IG9mIGV4ZWN1dGFibGUgbWVtb3J5CmRpZmYg LS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9zYW1wbGluZy1wcm9maWxlci1yaWNoYXJkcy5qcyBiL0pT VGVzdHMvc3RyZXNzL3NhbXBsaW5nLXByb2ZpbGVyLXJpY2hhcmRzLmpzCmluZGV4IDVlYTQxYmQ3 MTQ5NmEzMzY0NDdkZTliNjZjNjZmNWYzZDIzMDI4NjUuLjdjZjgyYjMwMmE3ZGIzZjNkZWNkMmY0 MWRjNDg1NTc2MDk1OWVkMGIgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL3NhbXBsaW5nLXBy b2ZpbGVyLXJpY2hhcmRzLmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL3NhbXBsaW5nLXByb2ZpbGVy LXJpY2hhcmRzLmpzCkBAIC0xLDYgKzEsNCBAQAotLy8gW0pTQ10gW0FybXY3XSBzdHJlc3Mvc2Ft cGxpbmctcHJvZmlsZXItcmljaGFyZHMuanMgY3Jhc2hlcwotLy8gaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDQyNgotLy9AIHNraXAgaWYgWyJhcm0iLCAibWlwcyJd LmluY2x1ZGU/KCRhcmNoaXRlY3R1cmUpIGFuZCAkaG9zdE9TID09ICJsaW51eCIKKy8vQCBza2lw IGlmICRhcmNoaXRlY3R1cmUgPT0gIm1pcHMiIGFuZCAkaG9zdE9TID09ICJsaW51eCIKIC8vQCBz a2lwIGlmICRhcmNoaXRlY3R1cmUgPT0gIng4NiIKIC8vQCBydW5EZWZhdWx0KCItLWNvbGxlY3RD b250aW51b3VzbHk9MSIsICItLXVzZVNhbXBsaW5nUHJvZmlsZXI9MSIsICItLWNvbGxlY3RTYW1w bGluZ1Byb2ZpbGVyRGF0YUZvckpTQ1NoZWxsPTEiKQogCg==