194767 2019-02-17 14:47:14 -0800 Deadlock when adding a Structure property transition and then doing incremental marking 2019-02-17 17:28:33 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1507156 0 saam 2019-02-17 14:47:14 -0800 So you have a Structure S. S is on the mark stack. Then: 1. S grabs its lock 2. S adds a new property transition 3. We find out we need to do some incremental marking 4. We mark S 5. visitChildren on S will try to grab its lock 6. We are now in a deadlock 1507160 1 362257 saam 2019-02-17 15:08:47 -0800 Created attachment 362257 patch 1507161 2 362257 mark.lam 2019-02-17 15:11:34 -0800 Comment on attachment 362257 patch r=me 1507177 3 362257 commit-queue 2019-02-17 17:27:28 -0800 Comment on attachment 362257 patch Clearing flags on attachment: 362257 Committed r241655: <https://trac.webkit.org/changeset/241655> 1507178 4 commit-queue 2019-02-17 17:27:29 -0800 All reviewed patches have been landed. Closing bug. 1507180 5 webkit-bug-importer 2019-02-17 17:28:33 -0800 <rdar://problem/48150864> 362257 2019-02-17 15:08:47 -0800 2019-02-17 17:27:28 -0800 patch b-backup.diff text/plain 3616 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDE2NTIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDE5LTAyLTE3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIERlYWRsb2NrIHdoZW4gYWRkaW5nIGEgU3RydWN0dXJlIHByb3BlcnR5 IHRyYW5zaXRpb24gYW5kIHRoZW4gZG9pbmcgaW5jcmVtZW50YWwgbWFya2luZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NzY3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvaW5jcmVtZW50 YWwtbWFya2luZy1zaG91bGQtbm90LWRlYWQtbG9jay1pbi1uZXctcHJvcGVydHktdHJhbnNpdGlv bi5qczogQWRkZWQuCisKIDIwMTktMDItMTUgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBs ZS5jb20+CiAKICAgICAgICAgUkVMRUFTRV9BU1NFUlQgYXQgY29tLmFwcGxlLkphdmFTY3JpcHRD b3JlOiBKU0M6OmpzU3Vic3RyaW5nT2ZSZXNvbHZlZApJbmRleDogSlNUZXN0cy9zdHJlc3MvaW5j cmVtZW50YWwtbWFya2luZy1zaG91bGQtbm90LWRlYWQtbG9jay1pbi1uZXctcHJvcGVydHktdHJh bnNpdGlvbi5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9pbmNyZW1lbnRhbC1tYXJr aW5nLXNob3VsZC1ub3QtZGVhZC1sb2NrLWluLW5ldy1wcm9wZXJ0eS10cmFuc2l0aW9uLmpzCShu b25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2luY3JlbWVudGFsLW1hcmtpbmctc2hvdWxk LW5vdC1kZWFkLWxvY2staW4tbmV3LXByb3BlcnR5LXRyYW5zaXRpb24uanMJKHdvcmtpbmcgY29w eSkKQEAgLTAsMCArMSwxMiBAQAorLy9AIHJ1bkRlZmF1bHQoIi0tZ2NJbmNyZW1lbnRTY2FsZT0x MDAiLCAiLS1nY0luY3JlbWVudEJ5dGVzPTEwIiwgIi0tbnVtYmVyT2ZHQ01hcmtlcnM9MSIpCisK K2xldCBhID0gW107CisKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDAwMDsgKytpKSB7CisgICAg bGV0IG8gPSB7fTsKKyAgICBsZXQgcDEgPSBgZiR7IChNYXRoLnJhbmRvbSgpICogMTAwMDAwMDAw MDApIHwgMCB9YAorICAgIGxldCBwMiA9IGBmJHsgKE1hdGgucmFuZG9tKCkgKiAxMDAwMDAwMDAw MCkgfCAwIH1gCisgICAgb1twMV0gPSAyMDsKKyAgICBvW3AyXSA9IDQyOworICAgIGEucHVzaChv KTsKK30KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQxNjUxKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDI1IEBACisyMDE5LTAyLTE3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisg ICAgICAgIERlYWRsb2NrIHdoZW4gYWRkaW5nIGEgU3RydWN0dXJlIHByb3BlcnR5IHRyYW5zaXRp b24gYW5kIHRoZW4gZG9pbmcgaW5jcmVtZW50YWwgbWFya2luZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NzY3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjYW4gaGFwcGVuIGluIHRoZSBmb2xs b3dpbmcgc2NlbmFyaW86CisgICAgICAgIAorICAgICAgICBZb3UgaGF2ZSBhIFN0cnVjdHVyZSBT LiBTIGlzIG9uIHRoZSBtYXJrIHN0YWNrLiBUaGVuOgorICAgICAgICAxLiBTIGdyYWJzIGl0cyBs b2NrCisgICAgICAgIDIuIFMgYWRkcyBhIG5ldyBwcm9wZXJ0eSB0cmFuc2l0aW9uCisgICAgICAg IDMuIFdlIGZpbmQgb3V0IHdlIG5lZWQgdG8gZG8gc29tZSBpbmNyZW1lbnRhbCBtYXJraW5nCisg ICAgICAgIDQuIFdlIG1hcmsgUworICAgICAgICA1LiB2aXNpdENoaWxkcmVuIG9uIFMgd2lsbCB0 cnkgdG8gZ3JhYiBpdHMgbG9jaworICAgICAgICA2LiBXZSBhcmUgbm93IGluIGEgZGVhZGxvY2sK KworICAgICAgICAqIGhlYXAvSGVhcC5jcHA6CisgICAgICAgIChKU0M6OkhlYXA6OnBlcmZvcm1J bmNyZW1lbnQpOgorICAgICAgICAqIHJ1bnRpbWUvU3RydWN0dXJlLmNwcDoKKyAgICAgICAgKEpT Qzo6U3RydWN0dXJlOjphZGROZXdQcm9wZXJ0eVRyYW5zaXRpb24pOgorCiAyMDE5LTAyLTE3ICBD b21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMjQxNjEyLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVh cC5jcHAJKHJldmlzaW9uIDI0MTY1MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hl YXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODg3LDYgKzI4ODcsOSBAQCB2b2lkIEhlYXA6OnBl cmZvcm1JbmNyZW1lbnQoc2l6ZV90IGJ5dGVzCiAgICAgaWYgKCFtX29iamVjdFNwYWNlLmlzTWFy a2luZygpKQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoaXNEZWZlcnJlZCgpKQorICAgICAg ICByZXR1cm47CisKICAgICBtX2luY3JlbWVudEJhbGFuY2UgKz0gYnl0ZXMgKiBPcHRpb25zOjpn Y0luY3JlbWVudFNjYWxlKCk7CiAKICAgICAvLyBTYXZlIG91cnNlbHZlcyBmcm9tIGNyYXp5LiBT aW5jZSB0aGlzIGlzIGFuIG9wdGltaXphdGlvbiwgaXQncyBPSyB0byBnbyBiYWNrIHRvIGFueSBj b25zaXN0ZW50CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVy ZS5jcHAJKHJldmlzaW9uIDI0MTY1MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1N0cnVjdHVyZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUxMCw2ICs1MTAsNyBAQCBTdHJ1Y3R1 cmUqIFN0cnVjdHVyZTo6YWRkTmV3UHJvcGVydHlUcmFuCiAgICAgY2hlY2tPZmZzZXQodHJhbnNp dGlvbi0+bV9vZmZzZXQsIHRyYW5zaXRpb24tPmlubGluZUNhcGFjaXR5KCkpOwogICAgIHsKICAg ICAgICAgQ29uY3VycmVudEpTTG9ja2VyIGxvY2tlcihzdHJ1Y3R1cmUtPm1fbG9jayk7CisgICAg ICAgIERlZmVyR0MgZGVmZXJHQyh2bS5oZWFwKTsKICAgICAgICAgc3RydWN0dXJlLT5tX3RyYW5z aXRpb25UYWJsZS5hZGQodm0sIHRyYW5zaXRpb24pOwogICAgIH0KICAgICB0cmFuc2l0aW9uLT5j aGVja09mZnNldENvbnNpc3RlbmN5KCk7Cg==