194766 2019-02-17 13:36:07 -0800 iOS Safari will not load USDZ in QLPreview when opening as BLOB 2019-02-18 11:10:02 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino webkit-bug-importer wenson_hsieh oldest_to_newest 1507143 0 dino 2019-02-17 13:36:07 -0800 iOS Safari will not load USDZ in QLPreview when opening as BLOB 1507144 1 dino 2019-02-17 13:36:35 -0800 <rdar://problem/42769186> 1507145 2 362248 dino 2019-02-17 13:40:38 -0800 Created attachment 362248 Patch 1507146 3 362248 wenson_hsieh 2019-02-17 13:58:09 -0800 Comment on attachment 362248 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362248&action=review > Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:100 > + completionHandler((NSURL*)strongSelf->_finishedURL, nil); Nit - NSURL * 1507326 4 dino 2019-02-18 11:10:02 -0800 Committed r241730: <https://trac.webkit.org/changeset/241730> 362248 2019-02-17 13:40:38 -0800 2019-02-17 13:58:09 -0800 Patch bug-194766-20190218084036.patch text/plain 3287 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZkNWZiNjQ4Mzc0YTYxYjg2 OGM1MmViODBmNDM4MjZkOTFmN2U4ZWQuLjVkYmEwOGZlZmZhYjgxZjU3OWI4YjUyMDY0ZmZmZTZm NGMxMmU1MTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTktMDItMTcgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIGlPUyBTYWZhcmkgd2lsbCBub3QgbG9h ZCBVU0RaIGluIFFMUHJldmlldyB3aGVuIG9wZW5pbmcgYXMgQkxPQgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NzY2CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS80Mjc2OTE4Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBIGRvd25sb2FkIGZyb20gYSBCbG9iIFVSTCBjYW4gaGFwcGVuIGVmZmVjdGl2 ZWx5IGluc3RhbnRseSwgd2hpY2ggbWVhbnMKKyAgICAgICAgdGhhdCB0aGUgbG9hZEhhbmRsZXIg b24gdGhlIHJlZ2lzdGVySXRlbUZvclR5cGVJZGVudGlmaWVyIG1ldGhvZCBtaWdodCBub3QgaGF2 ZQorICAgICAgICBiZWVuIGNhbGxlZCB5ZXQsIGFuZCB3ZSBoYXZlbid0IGJlZW4gdG9sZCB3aGF0 IHRoZSBjb21wbGV0aW9uSGFuZGxlciBpcy4KKyAgICAgICAgSW4gdGhpcyBjYXNlLCBrZWVwIGEg cmVjb3JkIG9mIHRoZSBVUkwgd2UgZmluaXNoZWQgd2l0aCwgYW5kIGNhbGwgdGhlIGNvbXBsZXRp b25IYW5kbGVyCisgICAgICAgIHJpZ2h0IGF3YXkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29j b2EvU3lzdGVtUHJldmlld0NvbnRyb2xsZXJDb2NvYS5tbTogQWRkIHR3byBuZXcgcHJpdmF0ZSBt ZW1iZXIgdmFyaWFibGVzLAorICAgICAgICBfaGFzRmluaXNoZWQgYW5kIF9maW5pc2hlZFVSTC4K KyAgICAgICAgKC1bX1dLUHJldmlld0NvbnRyb2xsZXJEYXRhU291cmNlIHByZXZpZXdDb250cm9s bGVyOnByZXZpZXdJdGVtQXRJbmRleDpdKTogQ2FsbCB0aGUgY29tcGxldGlvbkhhbmRsZXIKKyAg ICAgICAgcmlnaHQgYXdheSBpZiB3ZSd2ZSBmaW5pc2hlZC4KKyAgICAgICAgKC1bX1dLUHJldmll d0NvbnRyb2xsZXJEYXRhU291cmNlIGZpbmlzaDpdKTogUmVtZW1iZXIgdGhhdCB3ZSd2ZSBmaW5p c2hlZC4KKwogMjAxOS0wMi0xNSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAg ICAgICAgIFtQU09OXSBEaXNhYmxlIFdlYkNvbnRlbnQgcHJvY2VzcyBjYWNoZSBvbiBkZXZpY2Vz IHdpdGggbGVzcyB0aGFuIDNHQiBvZiBSQU0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0NvY29hL1N5c3RlbVByZXZpZXdDb250cm9sbGVyQ29jb2EubW0gYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Db2NvYS9TeXN0ZW1QcmV2aWV3Q29udHJvbGxlckNvY29hLm1tCmluZGV4 IDMxZjI4NzFkZTQzMDcxM2FjYzA2NzdlOWZmMzA2ZWRiMjZmMmRhNjUuLjBhM2RjYjAyNGU4MjA1 YWU4ZjZkM2I2NmJiMjkxYWU5NjU2ZjMyMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0NvY29hL1N5c3RlbVByZXZpZXdDb250cm9sbGVyQ29jb2EubW0KKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvU3lzdGVtUHJldmlld0NvbnRyb2xsZXJDb2NvYS5tbQpA QCAtNDEsNiArNDEsOCBAQAogQGludGVyZmFjZSBfV0tQcmV2aWV3Q29udHJvbGxlckRhdGFTb3Vy Y2UgOiBOU09iamVjdCA8UUxQcmV2aWV3Q29udHJvbGxlckRhdGFTb3VyY2U+IHsKICAgICBSZXRh aW5QdHI8TlNJdGVtUHJvdmlkZXI+IF9pdGVtUHJvdmlkZXI7CiAgICAgUmV0YWluUHRyPFFMSXRl bT4gX2l0ZW07CisgICAgQk9PTCBfaGFzRmluaXNoZWQ7CisgICAgVVJMIF9maW5pc2hlZFVSTDsK IH07CiAKIEBwcm9wZXJ0eSAoc3Ryb25nKSBOU0l0ZW1Qcm92aWRlckNvbXBsZXRpb25IYW5kbGVy IGNvbXBsZXRpb25IYW5kbGVyOwpAQCAtODcsMTAgKzg5LDE2IEBACiAgICAgX2l0ZW0gPSBhZG9w dE5TKFtQQUw6OmFsbG9jUUxJdGVtSW5zdGFuY2UoKSBpbml0V2l0aFByZXZpZXdJdGVtUHJvdmlk ZXI6X2l0ZW1Qcm92aWRlci5nZXQoKSBjb250ZW50VHlwZTpjb250ZW50VHlwZSBwcmV2aWV3VGl0 bGU6QCJQcmV2aWV3IiBmaWxlU2l6ZTpAKDApXSk7CiAgICAgW19pdGVtIHNldFVzZUxvYWRpbmdU aW1lb3V0Ok5PXTsKIAorICAgIF9oYXNGaW5pc2hlZCA9IE5POwogICAgIFdlYWtPYmpDUHRyPF9X S1ByZXZpZXdDb250cm9sbGVyRGF0YVNvdXJjZT4gd2Vha1NlbGYgeyBzZWxmIH07CiAgICAgW19p dGVtUHJvdmlkZXIgcmVnaXN0ZXJJdGVtRm9yVHlwZUlkZW50aWZpZXI6Y29udGVudFR5cGUgbG9h ZEhhbmRsZXI6W3dlYWtTZWxmID0gV1RGTW92ZSh3ZWFrU2VsZildIChOU0l0ZW1Qcm92aWRlckNv bXBsZXRpb25IYW5kbGVyIGNvbXBsZXRpb25IYW5kbGVyLCBDbGFzcyBleHBlY3RlZFZhbHVlQ2xh c3MsIE5TRGljdGlvbmFyeSAqIG9wdGlvbnMpIHsKLSAgICAgICAgaWYgKGF1dG8gc3Ryb25nU2Vs ZiA9IHdlYWtTZWxmLmdldCgpKQorICAgICAgICBpZiAoYXV0byBzdHJvbmdTZWxmID0gd2Vha1Nl bGYuZ2V0KCkpIHsKICAgICAgICAgICAgIFtzdHJvbmdTZWxmIHNldENvbXBsZXRpb25IYW5kbGVy OmNvbXBsZXRpb25IYW5kbGVyXTsKKyAgICAgICAgICAgIC8vIElmIHRoZSBkb3dubG9hZCBoYXBw ZW5lZCBpbnN0YW50bHksIHRoZSBjYWxsIHRvIGZpbmlzaCBtaWdodCBoYXZlIGNvbWUgYmVmb3Jl IHRoaXMKKyAgICAgICAgICAgIC8vIGxvYWRIYW5kbGVyLiBJbiB0aGF0IGNhc2UsIGNhbGwgdGhl IGNvbXBsZXRpb25IYW5kbGVyIGhlcmUuCisgICAgICAgICAgICBpZiAoc3Ryb25nU2VsZi0+X2hh c0ZpbmlzaGVkKQorICAgICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKChOU1VSTCopc3Ry b25nU2VsZi0+X2ZpbmlzaGVkVVJMLCBuaWwpOworICAgICAgICB9CiAgICAgfV07CiAgICAgcmV0 dXJuIF9pdGVtLmdldCgpOwogfQpAQCAtMTAzLDYgKzExMSw5IEBACiAKIC0gKHZvaWQpZmluaXNo OihVUkwpdXJsCiB7CisgICAgX2hhc0ZpbmlzaGVkID0gWUVTOworICAgIF9maW5pc2hlZFVSTCA9 IHVybDsKKwogICAgIGlmIChzZWxmLmNvbXBsZXRpb25IYW5kbGVyKQogICAgICAgICBzZWxmLmNv bXBsZXRpb25IYW5kbGVyKChOU1VSTCopdXJsLCBuaWwpOwogfQo=