194763 2019-02-17 11:20:53 -0800 Update WebKit review policy to allow r- by non-reviewers 2019-02-18 13:16:03 -0800 1 1 1 Unclassified WebKit WebKit Website Other Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dbates fujii jond mcatanzaro mjs rniwa sam oldest_to_newest 1507112 0 aakash_jain 2019-02-17 11:20:53 -0800 We should allow non-reviewers to set r- on patches. For e.g.: In case a reviewer who has no expertise in a particular tricky area of code (and so probably shouldn’t r+), notices an obvious error (e.g. a specific link that accesses memory out-of-bounds) it would be appropriate (but not required), for him/her to set r- on the patch. This would help other reviewers with the review. 1507175 1 362262 aakash_jain 2019-02-17 17:07:56 -0800 Created attachment 362262 Proposed patch 1507176 2 362262 sam 2019-02-17 17:27:16 -0800 Comment on attachment 362262 Proposed patch I disagree with this policy change. I think it makes it makes things more confusing for no real gain. Ideally, we should codify this rule by not allowing non-reviewers to change the review flag to r+ or r-. 1507388 3 rniwa 2019-02-18 13:16:03 -0800 Seems like this is WontFix given the latest webkit-dev discussions. 362262 2019-02-17 17:07:56 -0800 2019-02-17 17:27:16 -0800 Proposed patch review-policy-r-2.patch text/plain 1830 aakash_jain SW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp dGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDE2NTEpCisrKyBXZWJzaXRlcy93 ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE5 LTAyLTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBV cGRhdGUgV2ViS2l0IHJldmlldyBwb2xpY3kgdG8gYWxsb3cgci0gYnkgbm9uLXJldmlld2Vycwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NzYzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjb21taXQt cmV2aWV3Lm1kOgorCiAyMDE5LTAyLTA3ICBKb24gRGF2aXMgIDxqb25kQGFwcGxlLmNvbT4KIAog ICAgICAgICBGaXhlZCBhbmltYXRpb24gcG9zaXRpb25pbmcgd2hlbiBob21lcGFnZSBhbmltYXRp b24gY29tcGxldGVzCkluZGV4OiBXZWJzaXRlcy93ZWJraXQub3JnL2NvbW1pdC1yZXZpZXcubWQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb21taXQtcmV2aWV3Lm1kCShyZXZp c2lvbiAyNDE2NTEpCisrKyBXZWJzaXRlcy93ZWJraXQub3JnL2NvbW1pdC1yZXZpZXcubWQJKHdv cmtpbmcgY29weSkKQEAgLTMwLDcgKzMwLDcgQEAgQSBXZWJLaXQgUmV2aWV3ZXIgc2hvdWxkIGJl IGEgcGVyc29uIHdobwogCiBBIHBvdGVudGlhbCBSZXZpZXdlciBtYXkgYmUgbm9taW5hdGVkIG9u Y2UgdGhleSBoYXZlIHN1Ym1pdHRlZCBhIG1pbmltdW0gb2YgODAgZ29vZCBwYXRjaGVzLiBUaGV5 IHNob3VsZCBhbHNvIGJlIGluIHRvdWNoIHdpdGggb3RoZXIgcmV2aWV3ZXJzIGFuZCBhd2FyZSBv ZiB3aG8gYXJlIHRoZSBleHBlcnRzIGluIHZhcmlvdXMgYXJlYXMuCiAKLUEgcGVyc29uIHdobyBz dWJtaXRzIG1hbnkgcGF0Y2hlcyBidXQgZG9lcyBub3Qgc2hvdyBnb29kIGNvbGxhYm9yYXRpb24g c2tpbGxzLCBjb2RlIHVuZGVyc3RhbmRpbmcgb3IgdW5kZXJzdGFuZGluZyBvZiBwcm9qZWN0IHBv bGljaWVzIG1heSBuZXZlciBiZSBub21pbmF0ZWQuIE1ha2luZyB1bm9mZmljaWFsIHJldmlld3Mg YmVmb3JlIHlvdSBiZWNvbWUgYSByZXZpZXdlciBpcyBlbmNvdXJhZ2VkLiBUaGlzIGlzIGFuIGV4 Y2VsbGVudCB3YXkgdG8gc2hvdyB5b3VyIHNraWxscy4gTm90ZSB0aGF0IHlvdSBzaG91bGQgbm90 IHB1dCByKyBub3Igci0gb24gcGF0Y2hlcyBpbiBzdWNoIHVub2ZmaWNpYWwgcmV2aWV3cy4KK0Eg cGVyc29uIHdobyBzdWJtaXRzIG1hbnkgcGF0Y2hlcyBidXQgZG9lcyBub3Qgc2hvdyBnb29kIGNv bGxhYm9yYXRpb24gc2tpbGxzLCBjb2RlIHVuZGVyc3RhbmRpbmcgb3IgdW5kZXJzdGFuZGluZyBv ZiBwcm9qZWN0IHBvbGljaWVzIG1heSBuZXZlciBiZSBub21pbmF0ZWQuIE1ha2luZyB1bm9mZmlj aWFsIHJldmlld3MgYmVmb3JlIHlvdSBiZWNvbWUgYSByZXZpZXdlciBpcyBlbmNvdXJhZ2VkLiBU aGlzIGlzIGFuIGV4Y2VsbGVudCB3YXkgdG8gc2hvdyB5b3VyIHNraWxscy4gTm90ZSB0aGF0IHlv dSBzaG91bGQgbm90IHB1dCByKyBvbiBwYXRjaGVzIGluIHN1Y2ggdW5vZmZpY2lhbCByZXZpZXdz LgogCiBGb3IgUmV2aWV3ZXIgc3RhdHVzLCB0aGVyZSBpcyBubyBzdXBlcnZpc2lvbiBleGNlcHRp b24uCiAK