194740 2019-02-15 21:55:24 -0800 Web Inspector: Logging a native function to the console, such as `alert`, produces unhandled rejection 2019-02-15 22:55:00 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1506960 0 joepeck 2019-02-15 21:55:24 -0800 Logging a native function to the console, such as `alert`, produces unhandled rejection Steps to Reproduce: 1. Inspect this page 2. js> alert => Exception 1506961 1 362208 joepeck 2019-02-15 21:57:52 -0800 Created attachment 362208 [PATCH] Proposed Fix 1506968 2 362208 mattbaker 2019-02-15 22:16:09 -0800 Comment on attachment 362208 [PATCH] Proposed Fix r=me 1506970 3 362208 commit-queue 2019-02-15 22:42:00 -0800 Comment on attachment 362208 [PATCH] Proposed Fix Clearing flags on attachment: 362208 Committed r241643: <https://trac.webkit.org/changeset/241643> 1506971 4 commit-queue 2019-02-15 22:42:02 -0800 All reviewed patches have been landed. Closing bug. 1506973 5 webkit-bug-importer 2019-02-15 22:55:00 -0800 <rdar://problem/48135272> 362208 2019-02-15 21:57:52 -0800 2019-02-15 22:42:00 -0800 [PATCH] Proposed Fix no-source-found-1.patch text/plain 2929 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFjYjcxMjU3NWExLi5jNDY3ODZkYzE0YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDItMTUgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBMb2dnaW5nIGEgbmF0aXZlIGZ1bmN0aW9uIHRvIHRoZSBjb25zb2xlLCBzdWNoIGFzIGBhbGVy dGAsIHByb2R1Y2VzIHVuaGFuZGxlZCByZWplY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDc0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Qcm90b2NvbC9SZW1vdGVP YmplY3QuanM6CisgICAgICAgIChXSS5SZW1vdGVPYmplY3QucHJvdG90eXBlLmZpbmRGdW5jdGlv blNvdXJjZUNvZGVMb2NhdGlvbik6CisgICAgICAgIEluIGNhc2Ugb2YgYSBwcm90b2NvbCBlcnJv ciAoY29tbW9uIHdoZW4gYXR0ZW1wdGluZyB0byBnZXQgYSBsb2NhdGlvbgorICAgICAgICBmb3Ig YSBuYXRpdmUgZnVuY3Rpb24pIHByb2R1Y2UgdGhlIE5vU291cmNlRm91bmQgcmVzdWx0LgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanM6CisgICAg ICAgIChXSS5Db25zb2xlTWVzc2FnZVZpZXcucHJvdG90eXBlLl9hcHBlbmRMb2NhdGlvbkxpbmsp OgorICAgICAgICBTaW1wbGlmeSB3aXRoIGFuIGFycm93IGZ1bmN0aW9uLgorCiAyMDE5LTAyLTE1 ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogU29tZSB0aW1lbGluZXMgdmlld3Mgd29yaywgc2hvdyBMZWdhY3kgQ1BVIHRpbWVs aW5lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90 b2NvbC9SZW1vdGVPYmplY3QuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Qcm90b2NvbC9SZW1vdGVPYmplY3QuanMKaW5kZXggMTYwY2M3ZWIyMzYuLmJmMjMxN2M1NzBk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2Nv bC9SZW1vdGVPYmplY3QuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvUHJvdG9jb2wvUmVtb3RlT2JqZWN0LmpzCkBAIC02MTAsNyArNjEwLDcgQEAgV0kuUmVtb3Rl T2JqZWN0ID0gY2xhc3MgUmVtb3RlT2JqZWN0CiAKICAgICAgICAgdGhpcy5fdGFyZ2V0LkRlYnVn Z2VyQWdlbnQuZ2V0RnVuY3Rpb25EZXRhaWxzKHRoaXMuX29iamVjdElkLCAoZXJyb3IsIHJlc3Bv bnNlKSA9PiB7CiAgICAgICAgICAgICBpZiAoZXJyb3IpIHsKLSAgICAgICAgICAgICAgICByZXN1 bHQucmVqZWN0KGVycm9yKTsKKyAgICAgICAgICAgICAgICByZXN1bHQucmVzb2x2ZShXSS5SZW1v dGVPYmplY3QuU291cmNlQ29kZUxvY2F0aW9uUHJvbWlzZS5Ob1NvdXJjZUZvdW5kKTsKICAgICAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdl Vmlldy5qcwppbmRleCBkZTZlYzI0ZTk5MS4uNGNmNThmZDNmZmQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xl TWVzc2FnZVZpZXcuanMKQEAgLTM1NCw3ICszNTQsNyBAQCBXSS5Db25zb2xlTWVzc2FnZVZpZXcg PSBjbGFzcyBDb25zb2xlTWVzc2FnZVZpZXcgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgaWYg KHRoaXMuX21lc3NhZ2UucGFyYW1ldGVycyAmJiB0aGlzLl9tZXNzYWdlLnBhcmFtZXRlcnMubGVu Z3RoID09PSAxKSB7CiAgICAgICAgICAgICB2YXIgcGFyYW1ldGVyID0gdGhpcy5fY3JlYXRlUmVt b3RlT2JqZWN0SWZOZWVkZWQodGhpcy5fbWVzc2FnZS5wYXJhbWV0ZXJzWzBdKTsKIAotICAgICAg ICAgICAgcGFyYW1ldGVyLmZpbmRGdW5jdGlvblNvdXJjZUNvZGVMb2NhdGlvbigpLnRoZW4oZnVu Y3Rpb24ocmVzdWx0KSB7CisgICAgICAgICAgICBwYXJhbWV0ZXIuZmluZEZ1bmN0aW9uU291cmNl Q29kZUxvY2F0aW9uKCkudGhlbigocmVzdWx0KSA9PiB7CiAgICAgICAgICAgICAgICAgaWYgKHJl c3VsdCA9PT0gV0kuUmVtb3RlT2JqZWN0LlNvdXJjZUNvZGVMb2NhdGlvblByb21pc2UuTm9Tb3Vy Y2VGb3VuZCB8fCByZXN1bHQgPT09IFdJLlJlbW90ZU9iamVjdC5Tb3VyY2VDb2RlTG9jYXRpb25Q cm9taXNlLk1pc3NpbmdPYmplY3RJZCkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwogCkBA IC0zNjUsNyArMzY1LDcgQEAgV0kuQ29uc29sZU1lc3NhZ2VWaWV3ID0gY2xhc3MgQ29uc29sZU1l c3NhZ2VWaWV3IGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICAgICAgICAgIHRoaXMuX2Vs ZW1lbnQuaW5zZXJ0QmVmb3JlKGxpbmssIHRoaXMuX2VsZW1lbnQuZmlyc3RDaGlsZCk7CiAgICAg ICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICB0aGlzLl9lbGVtZW50LmFwcGVu ZENoaWxkKGxpbmspOwotICAgICAgICAgICAgfS5iaW5kKHRoaXMpKTsKKyAgICAgICAgICAgIH0p OwogICAgICAgICB9CiAgICAgfQogCg==