194735 2019-02-15 19:13:13 -0800 [JSC] Lazily create empty RegExp 2019-02-15 20:33:24 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1506921 0 ysuzuki 2019-02-15 19:13:13 -0800 [JSC] Lazily create empty RegExp 1506922 1 362199 ysuzuki 2019-02-15 19:14:41 -0800 Created attachment 362199 Patch 1506932 2 362199 keith_miller 2019-02-15 19:53:40 -0800 Comment on attachment 362199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362199&action=review > Source/JavaScriptCore/runtime/RegExpCache.h:51 > + if (m_emptyRegExp) Should we mark this likely? 1506937 3 362199 ysuzuki 2019-02-15 20:26:31 -0800 Comment on attachment 362199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362199&action=review Thank you! >> Source/JavaScriptCore/runtime/RegExpCache.h:51 >> + if (m_emptyRegExp) > > Should we mark this likely? Sounds nice! Yeah, we should put LIKELY, fixed. 1506944 4 ysuzuki 2019-02-15 20:32:47 -0800 Committed r241640: <https://trac.webkit.org/changeset/241640> 1506945 5 webkit-bug-importer 2019-02-15 20:33:24 -0800 <rdar://problem/48133654> 362199 2019-02-15 19:14:41 -0800 2019-02-15 19:53:40 -0800 Patch bug-194735-20190215191440.patch text/plain 7293 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 MDQ5ZjBjMzc2YmY0NmQ4MGM0OGFhY2E0NzYwNDk5YWMwYWFmZGU4Li5iM2UxMTlhZDJmYzUyZDgy ODY2NzYzY2M2MDdlYjljNTUzMTQ5YWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxOS0wMi0xNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIExhemlseSBjcmVhdGUgZW1wdHkgUmVnRXhwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ3MzUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIHNjcmlwdHMgZG8gbm90 IGhhdmUgYW55IFJlZ0V4cC4gSW4gdGhhdCBjYXNlLCBhbGxvY2F0aW5nIE1hcmtlZEJsb2NrIGZv ciBSZWdFeHAgaXMgY29zdGx5LgorICAgICAgICBQcmV2aW91c2x5LCB0aGVyZSB3YXMgYWx3YXlz IG9uZSBSZWdFeHAsICJlbXB0eSBSZWdFeHAiLiBUaGlzIHBhdGNoIGxhemlseSBjcmVhdGVzIGl0 IGFuZCBkcm9wCisgICAgICAgIG9uZSBNYXJrZWRCbG9jay4KKworICAgICAgICAqIHJ1bnRpbWUv SlNHbG9iYWxPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpKU0dsb2JhbE9iamVjdDo6aW5pdCk6 CisgICAgICAgICogcnVudGltZS9SZWdFeHBDYWNoZS5jcHA6CisgICAgICAgIChKU0M6OlJlZ0V4 cENhY2hlOjplbnN1cmVFbXB0eVJlZ0V4cFNsb3cpOgorICAgICAgICAoSlNDOjpSZWdFeHBDYWNo ZTo6aW5pdGlhbGl6ZSk6IERlbGV0ZWQuCisgICAgICAgICogcnVudGltZS9SZWdFeHBDYWNoZS5o OgorICAgICAgICAoSlNDOjpSZWdFeHBDYWNoZTo6ZW5zdXJlRW1wdHlSZWdFeHApOgorICAgICAg ICAoSlNDOjpSZWdFeHBDYWNoZTo6ZW1wdHlSZWdFeHAgY29uc3QpOiBEZWxldGVkLgorICAgICAg ICAqIHJ1bnRpbWUvUmVnRXhwQ2FjaGVkUmVzdWx0LmNwcDoKKyAgICAgICAgKEpTQzo6UmVnRXhw Q2FjaGVkUmVzdWx0OjpsYXN0UmVzdWx0KToKKyAgICAgICAgKiBydW50aW1lL1JlZ0V4cENhY2hl ZFJlc3VsdC5oOgorICAgICAgICAqIHJ1bnRpbWUvVk0uY3BwOgorICAgICAgICAoSlNDOjpWTTo6 Vk0pOgorCiAyMDE5LTAyLTE1ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAK ICAgICAgICAgW0pTQ10gTWFrZSBidWlsdGluIG9iamVjdHMgbW9yZSBsYXppbHkgaW5pdGlhbGl6 ZWQgdW5kZXIgbm9uLUpJVCBtb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0dsb2JhbE9iamVjdC5jcHAKaW5kZXggYzIzYzE5MjU3ZjRiMjk3Yzc4YmRiMmViZDBjNTU4 ZTU5OTFjOTQ1My4uZDBjN2NjZGJmZTNmYTlmZmI1ZmY5ZGQwMDgyYmE5NWJjMzAwMTk1OCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcApA QCAtNjg4LDcgKzY4OCw3IEBAIHZvaWQgSlNHbG9iYWxPYmplY3Q6OmluaXQoVk0mIHZtKQogICAg IG1fYXJyYXlDb25zdHJ1Y3Rvci5zZXQodm0sIHRoaXMsIGFycmF5Q29uc3RydWN0b3IpOwogICAg IAogICAgIFJlZ0V4cENvbnN0cnVjdG9yKiByZWdFeHBDb25zdHJ1Y3RvciA9IFJlZ0V4cENvbnN0 cnVjdG9yOjpjcmVhdGUodm0sIFJlZ0V4cENvbnN0cnVjdG9yOjpjcmVhdGVTdHJ1Y3R1cmUodm0s IHRoaXMsIG1fZnVuY3Rpb25Qcm90b3R5cGUuZ2V0KCkpLCBtX3JlZ0V4cFByb3RvdHlwZS5nZXQo KSwgbV9zcGVjaWVzR2V0dGVyU2V0dGVyLmdldCgpKTsKLSAgICBtX3JlZ0V4cEdsb2JhbERhdGEu Y2FjaGVkUmVzdWx0KCkucmVjb3JkKHZtLCB0aGlzLCB2bS5yZWdFeHBDYWNoZSgpLT5lbXB0eVJl Z0V4cCgpLCBqc0VtcHR5U3RyaW5nKCZ2bSksIE1hdGNoUmVzdWx0KDAsIDApKTsKKyAgICBtX3Jl Z0V4cEdsb2JhbERhdGEuY2FjaGVkUmVzdWx0KCkucmVjb3JkKHZtLCB0aGlzLCBudWxscHRyLCBq c0VtcHR5U3RyaW5nKCZ2bSksIE1hdGNoUmVzdWx0KDAsIDApKTsKICAgICAKICAgICBKU0FycmF5 QnVmZmVyQ29uc3RydWN0b3IqIGFycmF5QnVmZmVyQ29uc3RydWN0b3IgPSBKU0FycmF5QnVmZmVy Q29uc3RydWN0b3I6OmNyZWF0ZSh2bSwgSlNBcnJheUJ1ZmZlckNvbnN0cnVjdG9yOjpjcmVhdGVT dHJ1Y3R1cmUodm0sIHRoaXMsIG1fZnVuY3Rpb25Qcm90b3R5cGUuZ2V0KCkpLCBtX2FycmF5QnVm ZmVyUHJvdG90eXBlLmdldCgpLCBtX3NwZWNpZXNHZXR0ZXJTZXR0ZXIuZ2V0KCkpOwogICAgIG1f YXJyYXlCdWZmZXJQcm90b3R5cGUtPnB1dERpcmVjdFdpdGhvdXRUcmFuc2l0aW9uKHZtLCB2bS5w cm9wZXJ0eU5hbWVzLT5jb25zdHJ1Y3RvciwgYXJyYXlCdWZmZXJDb25zdHJ1Y3Rvciwgc3RhdGlj X2Nhc3Q8dW5zaWduZWQ+KFByb3BlcnR5QXR0cmlidXRlOjpEb250RW51bSkpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwQ2FjaGUuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwQ2FjaGUuY3BwCmluZGV4IDJjYjI5YzQwMjNl ZGI4OTQwY2EzNjY2Y2QwMmFhZTk2MzZlMmYzMjYuLmQ3NmJiMzk2Mjk3ZDQ2NzE2OTQ5YjM5MzEz YjBmMmFjY2U5ZTQ4ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1JlZ0V4cENhY2hlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdF eHBDYWNoZS5jcHAKQEAgLTU2LDkgKzU2LDExIEBAIFJlZ0V4cENhY2hlOjpSZWdFeHBDYWNoZShW TSogdm0pCiB7CiB9CiAKLXZvaWQgUmVnRXhwQ2FjaGU6OmluaXRpYWxpemUoVk0mIHZtKQorUmVn RXhwKiBSZWdFeHBDYWNoZTo6ZW5zdXJlRW1wdHlSZWdFeHBTbG93KFZNJiB2bSkKIHsKLSAgICBt X2VtcHR5UmVnRXhwLnNldCh2bSwgUmVnRXhwOjpjcmVhdGUodm0sICIiLCBOb0ZsYWdzKSk7Cisg ICAgUmVnRXhwKiByZWdFeHAgPSBSZWdFeHA6OmNyZWF0ZSh2bSwgIiIsIE5vRmxhZ3MpOworICAg IG1fZW1wdHlSZWdFeHAuc2V0KHZtLCByZWdFeHApOworICAgIHJldHVybiByZWdFeHA7CiB9CiAK IHZvaWQgUmVnRXhwQ2FjaGU6OmZpbmFsaXplKEhhbmRsZTxVbmtub3duPiBoYW5kbGUsIHZvaWQq KQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwQ2FjaGUu aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cENhY2hlLmgKaW5kZXggMmY1 YmRjM2M1NTE4NmZiM2YxN2U2Yzc4MjJlNGJjMzA1OTgzZWFlMi4uZDVjNTQwYmY4YjViNTBjNDFi YWNmMmE4MGI0MjRkM2U2Y2M3ZDQyMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvUmVnRXhwQ2FjaGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9SZWdFeHBDYWNoZS5oCkBAIC00Niw5ICs0NiwxMiBAQCBjbGFzcyBSZWdFeHBDYWNoZSA6IHBy aXZhdGUgV2Vha0hhbmRsZU93bmVyIHsKICAgICBSZWdFeHBDYWNoZShWTSogdm0pOwogICAgIHZv aWQgZGVsZXRlQWxsQ29kZSgpOwogCi0gICAgdm9pZCBpbml0aWFsaXplKFZNJik7Ci0KLSAgICBS ZWdFeHAqIGVtcHR5UmVnRXhwKCkgY29uc3QgeyByZXR1cm4gbV9lbXB0eVJlZ0V4cC5nZXQoKTsg fQorICAgIFJlZ0V4cCogZW5zdXJlRW1wdHlSZWdFeHAoVk0mIHZtKQorICAgIHsKKyAgICAgICAg aWYgKG1fZW1wdHlSZWdFeHApCisgICAgICAgICAgICByZXR1cm4gbV9lbXB0eVJlZ0V4cC5nZXQo KTsKKyAgICAgICAgcmV0dXJuIGVuc3VyZUVtcHR5UmVnRXhwU2xvdyh2bSk7CisgICAgfQogCiBw cml2YXRlOgogICAgIApAQCAtNTgsNiArNjEsOCBAQCBjbGFzcyBSZWdFeHBDYWNoZSA6IHByaXZh dGUgV2Vha0hhbmRsZU93bmVyIHsKIAogICAgIHZvaWQgZmluYWxpemUoSGFuZGxlPFVua25vd24+ LCB2b2lkKiBjb250ZXh0KSBvdmVycmlkZTsKIAorICAgIFJlZ0V4cCogZW5zdXJlRW1wdHlSZWdF eHBTbG93KFZNJik7CisKICAgICBSZWdFeHAqIGxvb2t1cE9yQ3JlYXRlKGNvbnN0IFdURjo6U3Ry aW5nJiBwYXR0ZXJuU3RyaW5nLCBSZWdFeHBGbGFncyk7CiAgICAgdm9pZCBhZGRUb1N0cm9uZ0Nh Y2hlKFJlZ0V4cCopOwogICAgIFJlZ0V4cENhY2hlTWFwIG1fd2Vha0NhY2hlOyAvLyBIb2xkcyBh bGwgcmVndWxhciBleHByZXNzaW9ucyBjdXJyZW50bHkgbGl2ZS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cENhY2hlZFJlc3VsdC5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBDYWNoZWRSZXN1bHQuY3BwCmluZGV4IGM2YTZi MDMyZGZhMjI4YmE1ODMwMDczODdkNjc2ZDc5ZTgwOTNiYjEuLjllMTAwZDI0MDNjNTRkYTYxMWIz MGE4OGMxYjg5NzM1NmNlOTk3YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1JlZ0V4cENhY2hlZFJlc3VsdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvUmVnRXhwQ2FjaGVkUmVzdWx0LmNwcApAQCAtNDUsOCArNDUsMTEgQEAgdm9pZCBS ZWdFeHBDYWNoZWRSZXN1bHQ6OnZpc2l0QWdncmVnYXRlKFNsb3RWaXNpdG9yJiB2aXNpdG9yKQog CiBKU0FycmF5KiBSZWdFeHBDYWNoZWRSZXN1bHQ6Omxhc3RSZXN1bHQoRXhlY1N0YXRlKiBleGVj LCBKU09iamVjdCogb3duZXIpCiB7CisgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKICAgICBpZiAo IW1fcmVpZmllZCkgewotICAgICAgICBtX3JlaWZpZWRJbnB1dC5zZXQoZXhlYy0+dm0oKSwgb3du ZXIsIG1fbGFzdElucHV0LmdldCgpKTsKKyAgICAgICAgbV9yZWlmaWVkSW5wdXQuc2V0KHZtLCBv d25lciwgbV9sYXN0SW5wdXQuZ2V0KCkpOworICAgICAgICBpZiAoIW1fbGFzdFJlZ0V4cCkKKyAg ICAgICAgICAgIG1fbGFzdFJlZ0V4cC5zZXQodm0sIG93bmVyLCB2bS5yZWdFeHBDYWNoZSgpLT5l bnN1cmVFbXB0eVJlZ0V4cCh2bSkpOwogICAgICAgICBpZiAobV9yZXN1bHQpCiAgICAgICAgICAg ICBtX3JlaWZpZWRSZXN1bHQuc2V0V2l0aG91dFdyaXRlQmFycmllcihjcmVhdGVSZWdFeHBNYXRj aGVzQXJyYXkoZXhlYywgZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVjdCgpLCBtX2xhc3RJbnB1dC5n ZXQoKSwgbV9sYXN0UmVnRXhwLmdldCgpLCBtX3Jlc3VsdC5zdGFydCkpOwogICAgICAgICBlbHNl CkBAIC01NCw3ICs1Nyw3IEBAIEpTQXJyYXkqIFJlZ0V4cENhY2hlZFJlc3VsdDo6bGFzdFJlc3Vs dChFeGVjU3RhdGUqIGV4ZWMsIEpTT2JqZWN0KiBvd25lcikKICAgICAgICAgbV9yZWlmaWVkTGVm dENvbnRleHQuY2xlYXIoKTsKICAgICAgICAgbV9yZWlmaWVkUmlnaHRDb250ZXh0LmNsZWFyKCk7 CiAgICAgICAgIG1fcmVpZmllZCA9IHRydWU7Ci0gICAgICAgIGV4ZWMtPnZtKCkuaGVhcC53cml0 ZUJhcnJpZXIob3duZXIpOworICAgICAgICB2bS5oZWFwLndyaXRlQmFycmllcihvd25lcik7CiAg ICAgfQogICAgIHJldHVybiBtX3JlaWZpZWRSZXN1bHQuZ2V0KCk7CiB9CmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBDYWNoZWRSZXN1bHQuaCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cENhY2hlZFJlc3VsdC5oCmluZGV4IDg4YTZj NjYzZTcxM2RhYzlkOTMzZDhkMDg4YTY2ZWZjMDExY2MyZDIuLmE1YjAzOTE4NWZmYTA1OTIxMmVh NDUxYjYyZGE5MzI1YTZiYzFhZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1JlZ0V4cENhY2hlZFJlc3VsdC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1JlZ0V4cENhY2hlZFJlc3VsdC5oCkBAIC02NSw2ICs2NSw4IEBAIGNsYXNzIFJlZ0V4 cENhY2hlZFJlc3VsdCB7CiAKICAgICB2b2lkIHZpc2l0QWdncmVnYXRlKFNsb3RWaXNpdG9yJik7 CiAKKyAgICAvLyBtX2xhc3RSZWdFeHAgd291bGQgYmUgbnVsbHB0ciB3aGVuIFJlZ0V4cENhY2hl ZFJlc3VsdCBpcyBub3QgcmVpZmllZC4KKyAgICAvLyBJZiB3ZSBmaW5kIG1fbGFzdFJlZ0V4cCBp cyBudWxscHRyLCBpdCBtZWFucyB0aGlzIHNob3VsZCBob2xkIHRoZSBlbXB0eSBSZWdFeHAuCiAg ICAgc3RhdGljIHB0cmRpZmZfdCBvZmZzZXRPZkxhc3RSZWdFeHAoKSB7IHJldHVybiBPQkpFQ1Rf T0ZGU0VUT0YoUmVnRXhwQ2FjaGVkUmVzdWx0LCBtX2xhc3RSZWdFeHApOyB9CiAgICAgc3RhdGlj IHB0cmRpZmZfdCBvZmZzZXRPZkxhc3RJbnB1dCgpIHsgcmV0dXJuIE9CSkVDVF9PRkZTRVRPRihS ZWdFeHBDYWNoZWRSZXN1bHQsIG1fbGFzdElucHV0KTsgfQogICAgIHN0YXRpYyBwdHJkaWZmX3Qg b2Zmc2V0T2ZSZXN1bHQoKSB7IHJldHVybiBPQkpFQ1RfT0ZGU0VUT0YoUmVnRXhwQ2FjaGVkUmVz dWx0LCBtX3Jlc3VsdCk7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1ZNLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAppbmRleCA3 OTAyMmQ2MjE4MTE2ODI3M2UwZTY4OGI5YjE5YTY0NWI0YmFlYzY5Li4wOTUyZmZlZmRmN2NmNmEx OWI0ZDU1MTZiMmUxZjQzMWY4YjI5MTVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9WTS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0u Y3BwCkBAIC00MDEsNyArNDAxLDYgQEAgVk06OlZNKFZNVHlwZSB2bVR5cGUsIEhlYXBUeXBlIGhl YXBUeXBlKQogICAgIHNlbnRpbmVsU2V0QnVja2V0LnNldCgqdGhpcywgSlNTZXQ6OkJ1Y2tldFR5 cGU6OmNyZWF0ZVNlbnRpbmVsKCp0aGlzKSk7CiAgICAgc2VudGluZWxNYXBCdWNrZXQuc2V0KCp0 aGlzLCBKU01hcDo6QnVja2V0VHlwZTo6Y3JlYXRlU2VudGluZWwoKnRoaXMpKTsKIAotICAgIG1f cmVnRXhwQ2FjaGUtPmluaXRpYWxpemUoKnRoaXMpOwogICAgIHNtYWxsU3RyaW5ncy5pbml0aWFs aXplQ29tbW9uU3RyaW5ncygqdGhpcyk7CiAKICAgICBUaHJlYWQ6OmN1cnJlbnQoKS5zZXRDdXJy ZW50QXRvbWljU3RyaW5nVGFibGUoZXhpc3RpbmdFbnRyeUF0b21pY1N0cmluZ1RhYmxlKTsK