194730 2019-02-15 16:14:36 -0800 NetworkLoad should cancel its task at destruction time 2019-02-15 16:49:13 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez ggaren webkit-bug-importer oldest_to_newest 1506833 0 youennf 2019-02-15 16:14:36 -0800 NetworkLoad should cancel its task at destruction time 1506835 1 362176 youennf 2019-02-15 16:17:22 -0800 Created attachment 362176 Patch 1506836 2 webkit-bug-importer 2019-02-15 16:17:42 -0800 <rdar://problem/48128564> 1506844 3 362176 ggaren 2019-02-15 16:24:30 -0800 Comment on attachment 362176 Patch r=me 1506847 4 362176 achristensen 2019-02-15 16:26:50 -0800 Comment on attachment 362176 Patch Nope. We don't want to do this. When the task is destroyed it will effectively cancel. What we want to do instead is null check m_client in NetworkDataTask::shouldCaptureExtraNetworkLoadMetrics 1506862 5 youennf 2019-02-15 16:38:55 -0800 WONTFIX for now, let's do null check and revisit this issue if needed. 1506864 6 youennf 2019-02-15 16:41:46 -0800 In the meantime, I filed https://bugs.webkit.org/show_bug.cgi?id=194732. 362176 2019-02-15 16:17:22 -0800 2019-02-15 16:49:13 -0800 Patch bug-194730-20190215161721.patch text/plain 1680 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI4OTlmY2Y2M2RkOTc4NzMw ZDQ2ODgzMWFlNDJmMzM3ODI5MTYzNDEuLmRhMDQyNzMyOGNlMzFhZGZiNTliOGQwN2I2YzQ1OTYy YjczNzJhYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDItMTUgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE5ldHdvcmtMb2FkIHNob3VsZCBj YW5jZWwgaXRzIHRhc2sgYXQgZGVzdHJ1Y3Rpb24gdGltZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NzMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmV0d29ya0RhdGFUYXNrIG1heSBiZSBrZXB0IGFs aXZlIGlmIHJlZmluZyBpdC4KKyAgICAgICAgVGhpcyBtaWdodCBoYXBwZW4gZm9yIGluc3RhbmNl IGluIERvd25sb2FkTWFuYWdlciBvciB3aGVuIGNoZWNraW5nIGZvciBUTFMgY2VydGlmaWNhdGVz LgorICAgICAgICBJbiB0aGF0IGNhc2UsIGlmIHRoZSBOZXR3b3JrTG9hZCBnZXQgZGVzdHJveWVk LCBpdCBjbGVhcnMgdGhlIGNsaWVudCBvZiB0aGUgTmV0d29ya0RhdGFUYXNrLgorICAgICAgICBU byBlbnN1cmUgdGhhdCBOZXR3b3JrRGF0YVRhc2sgZG9lcyBub3QgdHJ5IHRvIHVzZSBpdHMgY2xp ZW50LCBjYW5jZWwgaXQgYXQgdGhlIHNhbWUgdGltZS4KKworICAgICAgICAqIE5ldHdvcmtQcm9j ZXNzL05ldHdvcmtMb2FkLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0xvYWQ6On5OZXR3 b3JrTG9hZCk6CisKIDIwMTktMDItMTUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIE1vdmUgc2VydmljZSB3b3JrZXIgcmVzcG9uc2UgdmFsaWRhdGlvbiBmcm9t IHRoZSBzZXJ2aWNlIHdvcmtlciBjbGllbnQgdG8gdGhlIHNlcnZpY2Ugd29ya2VyIGl0c2VsZgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcAppbmRleCAzYTZm YTEwY2Y5ZjdlZDRiZmNkODNkMGJhMjc0NjhlYjIzMTcwNjBiLi44ZTcwNWQzODRmNWIyYzY4ODc2 NzAwNDRhNzJjMGU5YTIxZjcyZmU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL05ldHdvcmtMb2FkLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L05ldHdvcmtMb2FkLmNwcApAQCAtODAsOCArODAsMTAgQEAgTmV0d29ya0xvYWQ6On5OZXR3b3Jr TG9hZCgpCiAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKICAgICBpZiAobV9yZWRpcmVj dENvbXBsZXRpb25IYW5kbGVyKQogICAgICAgICBtX3JlZGlyZWN0Q29tcGxldGlvbkhhbmRsZXIo eyB9KTsKLSAgICBpZiAobV90YXNrKQorICAgIGlmIChtX3Rhc2spIHsKICAgICAgICAgbV90YXNr LT5jbGVhckNsaWVudCgpOworICAgICAgICBtX3Rhc2stPmNhbmNlbCgpOworICAgIH0KIH0KIAog dm9pZCBOZXR3b3JrTG9hZDo6Y2FuY2VsKCkK