194694 2019-02-15 00:41:56 -0800 [bmalloc] NSBundle-based application name check should be executed after debug-heap environment variable check 2019-02-15 01:12:14 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki mark.lam webkit-bug-importer oldest_to_newest 1506505 0 ysuzuki 2019-02-15 00:41:56 -0800 [bmalloc] NSBundle-based application name check should be executed after debug-heap environment variable check 1506509 1 362103 ysuzuki 2019-02-15 00:48:54 -0800 Created attachment 362103 Patch 1506511 2 362103 mark.lam 2019-02-15 01:03:29 -0800 Comment on attachment 362103 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362103&action=review r=me with suggested improvement. > Source/bmalloc/bmalloc/Gigacage.cpp:271 > bool result = !PerProcess<Environment>::get()->isDebugHeapEnabled(); > if (!result) This is not related to your patch but since you're in this code, let's fix this too: 1. the name "result" is not meaningful. Let's call it debugHeapEnabled instead. 2. the double negative is hard to follow. Let's not negate the result of PerProcess<Environment>::get()->isDebugHeapEnabled(), and let's not negate the boolean value in the if check. 1506512 3 362103 ysuzuki 2019-02-15 01:06:07 -0800 Comment on attachment 362103 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362103&action=review >> Source/bmalloc/bmalloc/Gigacage.cpp:271 >> if (!result) > > This is not related to your patch but since you're in this code, let's fix this too: > 1. the name "result" is not meaningful. Let's call it debugHeapEnabled instead. > 2. the double negative is hard to follow. Let's not negate the result of PerProcess<Environment>::get()->isDebugHeapEnabled(), and let's not negate the boolean value in the if check. Sounds nice! Fixed. 1506513 4 ysuzuki 2019-02-15 01:10:05 -0800 Committed r241581: <https://trac.webkit.org/changeset/241581> 1506516 5 webkit-bug-importer 2019-02-15 01:12:14 -0800 <rdar://problem/48104501> 362103 2019-02-15 00:48:54 -0800 2019-02-15 01:03:29 -0800 Patch bug-194694-20190215004853.patch text/plain 2013 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggODhiOThlZDM2ODUzOTAw NzQ3NjJhMTg5ZmEyZmM0ZTFkNDM4MTlkNC4uN2NjODQwZjI4OTVhOGEyMjY2ZmFhN2MzYjdiNmY4 MzI0ZGNkNDQ3MyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAyLTE1ICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW2JtYWxsb2NdIE5TQnVu ZGxlLWJhc2VkIGFwcGxpY2F0aW9uIG5hbWUgY2hlY2sgc2hvdWxkIGJlIGV4ZWN1dGVkIGFmdGVy IGRlYnVnLWhlYXAgZW52aXJvbm1lbnQgdmFyaWFibGUgY2hlY2sKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDY5NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEludGVyZXN0aW5nbHksIE5TQnVuZGxlIGFs bG9jYXRlcyBmYWlyIGFtb3VudCBvZiBtZW1vcnkgYW5kIGtlZXBzIGl0IGZvciBhIHByb2Nlc3Mt bG9uZyB0aW1lLiBGb3IgZXhhbXBsZSwgaXQKKyAgICAgICAgYWxsb2NhdGVzIGdsb2JhbCBOU0Nv bmNyZXRlSGFzaFRhYmxlLCB3aGljaCB0YWtlcyAyLjVLQi4gVGhpcyBwYXRjaCBjaGFuZ2VzIHRo ZSBvcmRlciBvZiBnaWdhY2FnZS1jaGVjaywgd2UKKyAgICAgICAgZmlyc3QgY2hlY2sgIk1hbGxv Yz0xIiBzdGF0dXMsIGFuZCB0aGVuIGNoZWNrIHRoZSBwcm9jZXNzIG5hbWUgdGhyb3VnaCBOU0J1 bmRsZS4gVGhpcyBhbGxvd3MgdXMgdG8gcmVtb3ZlIE5TQnVuZGxlCisgICAgICAgIHJlbGF0ZWQg YWxsb2NhdGlvbiBpbiBKU0MgaW5pdGlhbGl6YXRpb24gaW4gdGhlIHN5c3RlbSBtYWxsb2MgbW9k ZS4KKworICAgICAgICAqIGJtYWxsb2MvR2lnYWNhZ2UuY3BwOgorICAgICAgICAoR2lnYWNhZ2U6 OnNob3VsZEJlRW5hYmxlZCk6CisKIDIwMTktMDItMTIgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1x dWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDEx ODIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0dpZ2FjYWdlLmNwcCBiL1Nv dXJjZS9ibWFsbG9jL2JtYWxsb2MvR2lnYWNhZ2UuY3BwCmluZGV4IGJkMTgwODJlNjdkMTQyZWJj NWMwZjBhOTU2NmE4N2FjZjYxMGNhYzUuLjUzYTgzMDJiMzBhZDc4MDA4NDdkODE3YjE2M2Q0ODdm YjY2M2VkOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvR2lnYWNhZ2UuY3Bw CisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvR2lnYWNhZ2UuY3BwCkBAIC0yNjcsMTIgKzI2 NywxMiBAQCBib29sIHNob3VsZEJlRW5hYmxlZCgpCiAgICAgc3RkOjpjYWxsX29uY2UoCiAgICAg ICAgIG9uY2VGbGFnLAogICAgICAgICBbXSB7Ci0gICAgICAgICAgICBpZiAoIWdpZ2FjYWdlRW5h YmxlZEZvclByb2Nlc3MoKSkKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0KICAgICAgICAgICAg IGJvb2wgcmVzdWx0ID0gIVBlclByb2Nlc3M8RW52aXJvbm1lbnQ+OjpnZXQoKS0+aXNEZWJ1Z0hl YXBFbmFibGVkKCk7CiAgICAgICAgICAgICBpZiAoIXJlc3VsdCkKICAgICAgICAgICAgICAgICBy ZXR1cm47CisKKyAgICAgICAgICAgIGlmICghZ2lnYWNhZ2VFbmFibGVkRm9yUHJvY2VzcygpKQor ICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIAogICAgICAgICAgICAgaWYgKGNo YXIqIGdpZ2FjYWdlRW5hYmxlZCA9IGdldGVudigiR0lHQUNBR0VfRU5BQkxFRCIpKSB7CiAgICAg ICAgICAgICAgICAgaWYgKCFzdHJjYXNlY21wKGdpZ2FjYWdlRW5hYmxlZCwgIm5vIikgfHwgIXN0 cmNhc2VjbXAoZ2lnYWNhZ2VFbmFibGVkLCAiZmFsc2UiKSB8fCAhc3RyY2FzZWNtcChnaWdhY2Fn ZUVuYWJsZWQsICIwIikpIHsK