194674 2019-02-14 14:09:57 -0800 [bmalloc] Do not start scavenger thread if we use system malloc 2019-02-15 00:45:37 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue mark.lam webkit-bug-importer oldest_to_newest 1506357 0 ysuzuki 2019-02-14 14:09:57 -0800 ... 1506486 1 362099 ysuzuki 2019-02-14 23:10:43 -0800 Created attachment 362099 Patch 1506491 2 362099 ysuzuki 2019-02-14 23:27:20 -0800 Comment on attachment 362099 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362099&action=review > Source/bmalloc/bmalloc/Scavenger.cpp:72 > + if (PerProcess<Environment>::get()->isDebugHeapEnabled()) > + return; > + For bmalloc::Heap, Large & Small allocations go to debug heap if `isDebugHeapEnabled()` is true. IsoHeaps also allocate memory from system malloc (fallbacking to malloc). 1506497 3 362099 mark.lam 2019-02-15 00:24:50 -0800 Comment on attachment 362099 Patch r=me 1506500 4 362099 ysuzuki 2019-02-15 00:27:27 -0800 Comment on attachment 362099 Patch Thank you! 1506506 5 362099 commit-queue 2019-02-15 00:43:13 -0800 Comment on attachment 362099 Patch Clearing flags on attachment: 362099 Committed r241580: <https://trac.webkit.org/changeset/241580> 1506507 6 commit-queue 2019-02-15 00:43:15 -0800 All reviewed patches have been landed. Closing bug. 1506508 7 webkit-bug-importer 2019-02-15 00:45:37 -0800 <rdar://problem/48104040> 362099 2019-02-14 23:10:43 -0800 2019-02-15 00:43:13 -0800 Patch bug-194674-20190214231042.patch text/plain 1672 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggODhiOThlZDM2ODUzOTAw NzQ3NjJhMTg5ZmEyZmM0ZTFkNDM4MTlkNC4uZWZlODNkYmM4YmU2NThiZWI4ZjEyYjdhZTA1Nzk5 MDJjOTFjZmFmMCAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAyLTE0ICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW2JtYWxsb2NdIERvIG5v dCBzdGFydCBzY2F2ZW5nZXIgdGhyZWFkIGlmIHdlIHVzZSBzeXN0ZW0gbWFsbG9jCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ2NzQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBhbHdheXMgc3RhcnQg dGhlIHNjYXZlbmdlciB0aHJlYWQgZXZlbiBpZiBzeXN0ZW0gbWFsbG9jIGlzIHVzZWQgYnkgdGhl IGVudmlyb25tZW50IHZhcmlhYmxlIGxpa2UgIk1hbGxvYz0xIi4KKyAgICAgICAgQmVjYXVzZSBi bWFsbG9jIGFsbG9jYXRpb24gZ29lcyB0byB0aGUgc3lzdGVtIG1hbGxvYyBpZiAiTWFsbG9jPTEi IGlzIHNldCwgd2UgZG8gbm90IG5lZWQgdG8gc2NhdmVuZ2UuIFRoaXMgcGF0Y2gKKyAgICAgICAg Y2hhbmdlcyBpdCBub3QgdG8gc3RhcnQgdGhlIHNjYXZlbmdlciB0aHJlYWQuCisKKyAgICAgICAg KiBibWFsbG9jL1NjYXZlbmdlci5jcHA6CisgICAgICAgIChibWFsbG9jOjpTY2F2ZW5nZXI6OlNj YXZlbmdlcik6CisKIDIwMTktMDItMTIgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDExODIuCmRpZmYg LS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1NjYXZlbmdlci5jcHAgYi9Tb3VyY2UvYm1h bGxvYy9ibWFsbG9jL1NjYXZlbmdlci5jcHAKaW5kZXggZWRiMDE0ZGU5YjJmY2JjYWU1NDVjYzdi OWFmYzQxZDdiZjNhYzNmMi4uY2EzMzYyNjU3YmZhMDFmMTA5MGY5MWFjODFlYWUxNGExM2ZhYmNl MSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TY2F2ZW5nZXIuY3BwCisrKyBi L1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvU2NhdmVuZ2VyLmNwcApAQCAtNjcsNiArNjcsOSBAQCBz dHJ1Y3QgUHJpbnRUaW1lIHsKIAogU2NhdmVuZ2VyOjpTY2F2ZW5nZXIoc3RkOjpsb2NrX2d1YXJk PE11dGV4PiYpCiB7CisgICAgaWYgKFBlclByb2Nlc3M8RW52aXJvbm1lbnQ+OjpnZXQoKS0+aXNE ZWJ1Z0hlYXBFbmFibGVkKCkpCisgICAgICAgIHJldHVybjsKKwogI2lmIEJPUyhEQVJXSU4pCiAg ICAgYXV0byBxdWV1ZSA9IGRpc3BhdGNoX3F1ZXVlX2NyZWF0ZSgiV2ViS2l0IE1hbGxvYyBNZW1v cnkgUHJlc3N1cmUgSGFuZGxlciIsIERJU1BBVENIX1FVRVVFX1NFUklBTCk7CiAgICAgbV9wcmVz c3VyZUhhbmRsZXJEaXNwYXRjaFNvdXJjZSA9IGRpc3BhdGNoX3NvdXJjZV9jcmVhdGUoRElTUEFU Q0hfU09VUkNFX1RZUEVfTUVNT1JZUFJFU1NVUkUsIDAsIERJU1BBVENIX01FTU9SWVBSRVNTVVJF X0NSSVRJQ0FMLCBxdWV1ZSk7Cg==