<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>194657</bug_id>
          
          <creation_ts>2019-02-14 10:30:43 -0800</creation_ts>
          <short_desc>Sample domainsVisited diagnostic logging</short_desc>
          <delta_ts>2019-02-16 13:52:03 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>beidson</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1506222</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-02-14 10:30:43 -0800</bug_when>
    <thetext>Sample domainsVisited diagnostic logging, we are getting a lot of data from this key and this is hurting our other keys.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1506223</commentid>
    <comment_count>1</comment_count>
      <attachid>362033</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-02-14 10:32:27 -0800</bug_when>
    <thetext>Created attachment 362033
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1506249</commentid>
    <comment_count>2</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-02-14 10:58:00 -0800</bug_when>
    <thetext>&lt;rdar://problem/48079857&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1506860</commentid>
    <comment_count>3</comment_count>
      <attachid>362033</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-02-15 16:36:11 -0800</bug_when>
    <thetext>Comment on attachment 362033
Patch

Clearing flags on attachment: 362033

Committed r241632: &lt;https://trac.webkit.org/changeset/241632&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1506861</commentid>
    <comment_count>4</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-02-15 16:36:12 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1507041</commentid>
    <comment_count>5</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2019-02-16 13:52:03 -0800</bug_when>
    <thetext>Is it sufficient to change domainVisitedKey to sampling, without also changing domainCausingJetsamKey and domainCausingEnergyDrainKey?</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>362033</attachid>
            <date>2019-02-14 10:32:27 -0800</date>
            <delta_ts>2019-02-15 16:36:11 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-194657-20190214103226.patch</filename>
            <type>text/plain</type>
            <size>1658</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmY2ZWFlNWU3ZGNlMWUy
MTU1MjU1ZjE5ZjA0OTNmMDdhYjNjY2NmYS4uMzU1Mzk3NTM4ZmM4MGNjNjhjOGEwNjM0YmU0YzNm
NjBiYWE1MWRhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAyLTE0ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2FtcGxlIGRvbWFpbnNWaXNp
dGVkIGRpYWdub3N0aWMgbG9nZ2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTk0NjU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgU2FtcGxlIGRvbWFpbnNWaXNpdGVkIGRpYWdub3N0aWMgbG9nZ2luZywg
d2UgYXJlIGdldHRpbmcgYSBsb3Qgb2YgZGF0YSBmcm9tCisgICAgICAgIHRoaXMga2V5IGFuZCB0
aGlzIGlzIGh1cnRpbmcgb3VyIG90aGVyIGtleXMuCisKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6bG9nTmF2aWdhdGlvbik6CisKIDIwMTktMDItMTQg
IENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2
aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDE0ODYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w
YWdlL1BhZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAppbmRleCA2OTA3MzVk
NGYwY2IyMGM3MDJiMmI3YjQ3ZDQ4YmIyYTMyMmU5Mjc2Li5iMDI2ODhhNGE4NDdkNTZlMDA3NDA5
OTE3N2I0ZGE1MDNkNzU0Mjg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2Uu
Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKQEAgLTIzNjksNyArMjM2OSw3
IEBAIHZvaWQgUGFnZTo6bG9nTmF2aWdhdGlvbihjb25zdCBOYXZpZ2F0aW9uJiBuYXZpZ2F0aW9u
KQogICAgIGRpYWdub3N0aWNMb2dnaW5nQ2xpZW50KCkubG9nRGlhZ25vc3RpY01lc3NhZ2UoRGlh
Z25vc3RpY0xvZ2dpbmdLZXlzOjpuYXZpZ2F0aW9uS2V5KCksIG5hdmlnYXRpb25EZXNjcmlwdGlv
biwgU2hvdWxkU2FtcGxlOjpObyk7CiAKICAgICBpZiAoIW5hdmlnYXRpb24uZG9tYWluLmlzRW1w
dHkoKSkKLSAgICAgICAgZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQoKS5sb2dEaWFnbm9zdGljTWVz
c2FnZVdpdGhFbmhhbmNlZFByaXZhY3koRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpkb21haW5WaXNp
dGVkS2V5KCksIG5hdmlnYXRpb24uZG9tYWluLCBTaG91bGRTYW1wbGU6Ok5vKTsKKyAgICAgICAg
ZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQoKS5sb2dEaWFnbm9zdGljTWVzc2FnZVdpdGhFbmhhbmNl
ZFByaXZhY3koRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpkb21haW5WaXNpdGVkS2V5KCksIG5hdmln
YXRpb24uZG9tYWluLCBTaG91bGRTYW1wbGU6Olllcyk7CiB9CiAKIHZvaWQgUGFnZTo6bWFpbkZy
YW1lTG9hZFN0YXJ0ZWQoY29uc3QgVVJMJiBkZXN0aW5hdGlvblVSTCwgRnJhbWVMb2FkVHlwZSB0
eXBlKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>