194647 2019-02-14 01:32:17 -0800 AX: ARIA Reflection was disabled in error 2019-02-14 09:27:26 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 jcraig cfleizach cfleizach commit-queue rniwa webkit-bug-importer oldest_to_newest 1506098 0 jcraig 2019-02-14 01:32:17 -0800 AX: ARIA Reflection was disabled in error r236522 from bug 151380 disabled the ARIAReflectionEnabled flag, presumably in error. https://bugs.webkit.org/show_bug.cgi?id=151380#c18 The automated tests did not catch the fault because the test runner overrides the flag: ~src/WebKit/Tools/WebKitTestRunner/TestController.cpp: 827: WKPreferencesSetAriaReflectionEnabled(preferences, true); So the fix may be to revert the AriaReflectionEnabled value in WebPreferences.yaml and remove the test override. 1506101 1 jcraig 2019-02-14 01:37:46 -0800 <rdar://problem/48068336> 1506103 2 362005 cfleizach 2019-02-14 01:40:20 -0800 Created attachment 362005 patch 1506106 3 362005 jcraig 2019-02-14 01:49:03 -0800 Comment on attachment 362005 patch View in context: https://bugs.webkit.org/attachment.cgi?id=362005&action=review > Source/WebKit/Shared/WebPreferences.yaml:1438 > + defaultValue: true Should this patch pull the test override out too? ~src/WebKit/Tools/WebKitTestRunner/TestController.cpp: 827: WKPreferencesSetAriaReflectionEnabled(preferences, true); 1506107 4 362005 cfleizach 2019-02-14 01:49:42 -0800 Comment on attachment 362005 patch View in context: https://bugs.webkit.org/attachment.cgi?id=362005&action=review >> Source/WebKit/Shared/WebPreferences.yaml:1438 >> + defaultValue: true > > Should this patch pull the test override out too? > > ~src/WebKit/Tools/WebKitTestRunner/TestController.cpp: > 827: WKPreferencesSetAriaReflectionEnabled(preferences, true); will wait for Ryosuke to weigh in on that 1506113 5 362005 rniwa 2019-02-14 02:30:04 -0800 Comment on attachment 362005 patch We probably should remove the override in the test runner as well 1506149 6 362016 cfleizach 2019-02-14 08:05:45 -0800 Created attachment 362016 Landing patch 1506190 7 362016 commit-queue 2019-02-14 09:27:25 -0800 Comment on attachment 362016 Landing patch Clearing flags on attachment: 362016 Committed r241549: <https://trac.webkit.org/changeset/241549> 1506191 8 commit-queue 2019-02-14 09:27:26 -0800 All reviewed patches have been landed. Closing bug. 362005 2019-02-14 01:40:20 -0800 2019-02-14 08:05:45 -0800 patch patch text/plain 1086 cfleizach SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDE1MTQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAyLTE0ICBDaHJpcyBGbGVp emFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEFSSUEgUmVmbGVjdGlv biB3YXMgZGlzYWJsZWQgaW4gZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NDY0NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDgwNjgzMzY+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFy ZWQvV2ViUHJlZmVyZW5jZXMueWFtbDoKKwogMjAxOS0wMi0xMyAgUnlvc3VrZSBOaXdhICA8cm5p d2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBDcmFzaCBpbiBXS0J1bmRsZUZyYW1lR2V0UGFyZW50 RnJhbWUgd2hlbiBjYWxsZWQgaW5zaWRlIGRpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeQpJbmRl eDogU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCShyZXZpc2lvbiAyNDEz MjEpCisrKyBTb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCSh3b3JraW5n IGNvcHkpCkBAIC0xNDM1LDcgKzE0MzUsNyBAQAogCiBBcmlhUmVmbGVjdGlvbkVuYWJsZWQ6CiAg IHR5cGU6IGJvb2wKLSAgZGVmYXVsdFZhbHVlOiBmYWxzZQorICBkZWZhdWx0VmFsdWU6IHRydWUK ICAgaHVtYW5SZWFkYWJsZU5hbWU6ICJBUklBIFJlZmxlY3Rpb24iCiAgIGh1bWFuUmVhZGFibGVE ZXNjcmlwdGlvbjogIkFSSUEgUmVmbGVjdGlvbiBzdXBwb3J0IgogICBjYXRlZ29yeTogaW50ZXJu YWwK 362016 2019-02-14 08:05:45 -0800 2019-02-14 09:27:25 -0800 Landing patch patch text/plain 2414 cfleizach SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDEzMzEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAyLTE0ICBDaHJpcyBGbGVp emFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEFSSUEgUmVmbGVjdGlv biB3YXMgZGlzYWJsZWQgaW4gZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NDY0NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDgwNjgzMzY+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgorCisgICAgICAgICogU2hhcmVk L1dlYlByZWZlcmVuY2VzLnlhbWw6CisKIDIwMTktMDItMTIgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgZmlyaW5nIGFzc2VydGlv biBhZnRlciByMjQxMzE3CkluZGV4OiBTb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNl cy55YW1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2Vz LnlhbWwJKHJldmlzaW9uIDI0MTMzMSkKKysrIFNvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZl cmVuY2VzLnlhbWwJKHdvcmtpbmcgY29weSkKQEAgLTE0MzUsNyArMTQzNSw3IEBACiAKIEFyaWFS ZWZsZWN0aW9uRW5hYmxlZDoKICAgdHlwZTogYm9vbAotICBkZWZhdWx0VmFsdWU6IGZhbHNlCisg IGRlZmF1bHRWYWx1ZTogdHJ1ZQogICBodW1hblJlYWRhYmxlTmFtZTogIkFSSUEgUmVmbGVjdGlv biIKICAgaHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAiQVJJQSBSZWZsZWN0aW9uIHN1cHBvcnQi CiAgIGNhdGVnb3J5OiBpbnRlcm5hbApJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMjQxNTQ0KQorKysgVG9vbHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDItMTQgIENocmlzIEZsZWl6 YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogQVJJQSBSZWZsZWN0aW9u IHdhcyBkaXNhYmxlZCBpbiBlcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk0NjQ3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODA2ODMzNj4K KworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgUmVtb3ZlIHRl c3Qgb3ZlcnJpZGUgbm93IHRoYXQgdGhpcyBmZWF0dXJlIHNob3VsZCBiZSBlbmFibGVkIGJ5IGRl ZmF1bHQuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcDoK KyAgICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXI6OnJlc2V0UHJlZmVyZW5jZXNUb0NvbnNpc3Rl bnRWYWx1ZXMpOgorCiAyMDE5LTAyLTEzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3Jn PgogCiAgICAgICAgIENyYXNoIGluIFdLQnVuZGxlRnJhbWVHZXRQYXJlbnRGcmFtZSB3aGVuIGNh bGxlZCBpbnNpZGUgZGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFyY2h5CkluZGV4OiBUb29scy9XZWJL aXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJL aXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAkocmV2aXNpb24gMjQxMzMxKQorKysgVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTgyNyw3ICs4MjcsNiBAQAogICAgIFdLUHJlZmVyZW5jZXNTZXRTdG9yYWdlQWNjZXNzQVBJRW5h YmxlZChwcmVmZXJlbmNlcywgdHJ1ZSk7CiAgICAgCiAgICAgV0tQcmVmZXJlbmNlc1NldEFjY2Vz c2liaWxpdHlPYmplY3RNb2RlbEVuYWJsZWQocHJlZmVyZW5jZXMsIHRydWUpOwotICAgIFdLUHJl ZmVyZW5jZXNTZXRBcmlhUmVmbGVjdGlvbkVuYWJsZWQocHJlZmVyZW5jZXMsIHRydWUpOwogICAg IFdLUHJlZmVyZW5jZXNTZXRDU1NPTVZpZXdTY3JvbGxpbmdBUElFbmFibGVkKHByZWZlcmVuY2Vz LCB0cnVlKTsKICAgICBXS1ByZWZlcmVuY2VzU2V0TWVkaWFDYXBhYmlsaXRpZXNFbmFibGVkKHBy ZWZlcmVuY2VzLCB0cnVlKTsKIAo=