194642 2019-02-13 21:57:06 -0800 Web Inspector: remove unused parameter in _parseStylePropertyPayload 2019-02-15 15:37:58 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue hi inspector-bugzilla-changes oldest_to_newest 1506056 0 nvasilyev 2019-02-13 21:57:06 -0800 . 1506057 1 361996 nvasilyev 2019-02-13 22:00:02 -0800 Created attachment 361996 Patch 1506074 2 361996 hi 2019-02-13 23:22:55 -0800 Comment on attachment 361996 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361996&action=review rs=me, it took a minute to understand what you meant by _this_ in "used by this method", but I see what you mean. The `styleText` parameter was never used :P > Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:509 > + _parseStylePropertyPayload(payload, index, styleDeclaration) There should also (technically) be a ChangeLog entry for this. > Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:665 > + var property = this._parseStylePropertyPayload(propertyPayload, i, styleDeclaration); Style: `let`. > Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:669 > + var text = payload.cssText; Style: `let`. 1506791 3 362162 nvasilyev 2019-02-15 15:00:09 -0800 Created attachment 362162 Patch for landing 1506812 4 362162 commit-queue 2019-02-15 15:37:56 -0800 Comment on attachment 362162 Patch for landing Clearing flags on attachment: 362162 Committed r241621: <https://trac.webkit.org/changeset/241621> 1506813 5 commit-queue 2019-02-15 15:37:58 -0800 All reviewed patches have been landed. Closing bug. 361996 2019-02-13 22:00:02 -0800 2019-02-15 15:00:09 -0800 Patch patch.txt text/plain 2384 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDUxMGFmZTRjNjg2Li4wOWY0OTA3NDVkNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDItMTMgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogcmVtb3ZlIHVudXNlZCBwYXJhbWV0ZXIgaW4gX3BhcnNlU3R5bGVQcm9wZXJ0eVBheWxvYWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDY0Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9Nb2RlbHMvRE9NTm9kZVN0eWxlcy5qczoKKyAgICAgICAgKFdJLkRPTU5vZGVTdHls ZXMucHJvdG90eXBlLl9wYXJzZVN0eWxlRGVjbGFyYXRpb25QYXlsb2FkKToKKyAgICAgICAgYHN0 eWxlVGV4dGAgd2Fzbid0IHVzZWQgYnkgdGhpcyBtZXRob2QuCisKIDIwMTktMDItMTMgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogU3R5bGVzOiB2YWxpZCB2YWx1ZXMgaW4gc3R5bGUgYXR0cmlidXRlcyBhcmUgcmVwb3J0ZWQg YXMgdW5zdXBwb3J0ZWQgcHJvcGVydHkgdmFsdWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZVN0eWxlcy5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlU3R5bGVzLmpzCmluZGV4 IGExOTliZTAzMTBiLi4wMjU5YTE2Y2ZjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanMKQEAgLTUw Niw3ICs1MDYsNyBAQCBXSS5ET01Ob2RlU3R5bGVzID0gY2xhc3MgRE9NTm9kZVN0eWxlcyBleHRl bmRzIFdJLk9iamVjdAogICAgICAgICByZXR1cm4gbmV3IFdJLlRleHRSYW5nZShwYXlsb2FkLnN0 YXJ0TGluZSwgcGF5bG9hZC5zdGFydENvbHVtbiwgcGF5bG9hZC5lbmRMaW5lLCBwYXlsb2FkLmVu ZENvbHVtbik7CiAgICAgfQogCi0gICAgX3BhcnNlU3R5bGVQcm9wZXJ0eVBheWxvYWQocGF5bG9h ZCwgaW5kZXgsIHN0eWxlRGVjbGFyYXRpb24sIHN0eWxlVGV4dCkKKyAgICBfcGFyc2VTdHlsZVBy b3BlcnR5UGF5bG9hZChwYXlsb2FkLCBpbmRleCwgc3R5bGVEZWNsYXJhdGlvbikKICAgICB7CiAg ICAgICAgIHZhciB0ZXh0ID0gcGF5bG9hZC50ZXh0IHx8ICIiOwogICAgICAgICB2YXIgbmFtZSA9 IHBheWxvYWQubmFtZTsKQEAgLTY1Myw4ICs2NTMsNiBAQCBXSS5ET01Ob2RlU3R5bGVzID0gY2xh c3MgRE9NTm9kZVN0eWxlcyBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICAgICAgc2hvcnRoYW5k c1tzaG9ydGhhbmQubmFtZV0gPSBzaG9ydGhhbmQudmFsdWU7CiAgICAgICAgIH0KIAotICAgICAg ICB2YXIgdGV4dCA9IHBheWxvYWQuY3NzVGV4dDsKLQogICAgICAgICB2YXIgaW5oZXJpdGVkUHJv cGVydHlDb3VudCA9IDA7CiAKICAgICAgICAgdmFyIHByb3BlcnRpZXMgPSBbXTsKQEAgLTY2NCwx MCArNjYyLDExIEBAIFdJLkRPTU5vZGVTdHlsZXMgPSBjbGFzcyBET01Ob2RlU3R5bGVzIGV4dGVu ZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICBpZiAoaW5oZXJpdGVkICYmIFdJLkNTU1Byb3BlcnR5 LmlzSW5oZXJpdGVkUHJvcGVydHlOYW1lKHByb3BlcnR5UGF5bG9hZC5uYW1lKSkKICAgICAgICAg ICAgICAgICArK2luaGVyaXRlZFByb3BlcnR5Q291bnQ7CiAKLSAgICAgICAgICAgIHZhciBwcm9w ZXJ0eSA9IHRoaXMuX3BhcnNlU3R5bGVQcm9wZXJ0eVBheWxvYWQocHJvcGVydHlQYXlsb2FkLCBp LCBzdHlsZURlY2xhcmF0aW9uLCB0ZXh0KTsKKyAgICAgICAgICAgIHZhciBwcm9wZXJ0eSA9IHRo aXMuX3BhcnNlU3R5bGVQcm9wZXJ0eVBheWxvYWQocHJvcGVydHlQYXlsb2FkLCBpLCBzdHlsZURl Y2xhcmF0aW9uKTsKICAgICAgICAgICAgIHByb3BlcnRpZXMucHVzaChwcm9wZXJ0eSk7CiAgICAg ICAgIH0KIAorICAgICAgICB2YXIgdGV4dCA9IHBheWxvYWQuY3NzVGV4dDsKICAgICAgICAgdmFy IHN0eWxlU2hlZXRUZXh0UmFuZ2UgPSB0aGlzLl9wYXJzZVNvdXJjZVJhbmdlUGF5bG9hZChwYXls b2FkLnJhbmdlKTsKIAogICAgICAgICBpZiAoc3R5bGVEZWNsYXJhdGlvbikgewo= 362162 2019-02-15 15:00:09 -0800 2019-02-15 15:37:56 -0800 Patch for landing patch.txt text/plain 2317 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGI4M2IxZWMyYzJhLi44OTRlODY4ODg4YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDItMTUgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogcmVtb3ZlIHVudXNlZCBwYXJhbWV0ZXIgaW4gX3BhcnNlU3R5bGVQcm9wZXJ0eVBheWxvYWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDY0Mgor CisgICAgICAgIFJldmlld2VkIGJ5IERldmluIFJvdXNzby4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanM6CisgICAgICAgIChXSS5ET01Ob2RlU3R5bGVz LnByb3RvdHlwZS5fcGFyc2VTdHlsZURlY2xhcmF0aW9uUGF5bG9hZCk6CisgICAgICAgIFRoZSBg c3R5bGVUZXh0YCBwYXJhbWV0ZXIgd2FzIG5ldmVyIHVzZWQKKwogMjAxOS0wMi0xNCAgQ29tbWl0 IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjI0MTQ5Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlU3R5bGVzLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanMKaW5kZXggYzc4NDUwNzhm YmMuLjgwYjJiYjhiMmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Nb2RlbHMvRE9NTm9kZVN0eWxlcy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZVN0eWxlcy5qcwpAQCAtNTA2LDcgKzUwNiw3 IEBAIFdJLkRPTU5vZGVTdHlsZXMgPSBjbGFzcyBET01Ob2RlU3R5bGVzIGV4dGVuZHMgV0kuT2Jq ZWN0CiAgICAgICAgIHJldHVybiBuZXcgV0kuVGV4dFJhbmdlKHBheWxvYWQuc3RhcnRMaW5lLCBw YXlsb2FkLnN0YXJ0Q29sdW1uLCBwYXlsb2FkLmVuZExpbmUsIHBheWxvYWQuZW5kQ29sdW1uKTsK ICAgICB9CiAKLSAgICBfcGFyc2VTdHlsZVByb3BlcnR5UGF5bG9hZChwYXlsb2FkLCBpbmRleCwg c3R5bGVEZWNsYXJhdGlvbiwgc3R5bGVUZXh0KQorICAgIF9wYXJzZVN0eWxlUHJvcGVydHlQYXls b2FkKHBheWxvYWQsIGluZGV4LCBzdHlsZURlY2xhcmF0aW9uKQogICAgIHsKICAgICAgICAgdmFy IHRleHQgPSBwYXlsb2FkLnRleHQgfHwgIiI7CiAgICAgICAgIHZhciBuYW1lID0gcGF5bG9hZC5u YW1lOwpAQCAtNjM5LDggKzYzOSw2IEBAIFdJLkRPTU5vZGVTdHlsZXMgPSBjbGFzcyBET01Ob2Rl U3R5bGVzIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICBzaG9ydGhhbmRzW3Nob3J0aGFu ZC5uYW1lXSA9IHNob3J0aGFuZC52YWx1ZTsKICAgICAgICAgfQogCi0gICAgICAgIHZhciB0ZXh0 ID0gcGF5bG9hZC5jc3NUZXh0OwotCiAgICAgICAgIHZhciBpbmhlcml0ZWRQcm9wZXJ0eUNvdW50 ID0gMDsKIAogICAgICAgICB2YXIgcHJvcGVydGllcyA9IFtdOwpAQCAtNjUwLDEwICs2NDgsMTEg QEAgV0kuRE9NTm9kZVN0eWxlcyA9IGNsYXNzIERPTU5vZGVTdHlsZXMgZXh0ZW5kcyBXSS5PYmpl Y3QKICAgICAgICAgICAgIGlmIChpbmhlcml0ZWQgJiYgV0kuQ1NTUHJvcGVydHkuaXNJbmhlcml0 ZWRQcm9wZXJ0eU5hbWUocHJvcGVydHlQYXlsb2FkLm5hbWUpKQogICAgICAgICAgICAgICAgICsr aW5oZXJpdGVkUHJvcGVydHlDb3VudDsKIAotICAgICAgICAgICAgdmFyIHByb3BlcnR5ID0gdGhp cy5fcGFyc2VTdHlsZVByb3BlcnR5UGF5bG9hZChwcm9wZXJ0eVBheWxvYWQsIGksIHN0eWxlRGVj bGFyYXRpb24sIHRleHQpOworICAgICAgICAgICAgbGV0IHByb3BlcnR5ID0gdGhpcy5fcGFyc2VT dHlsZVByb3BlcnR5UGF5bG9hZChwcm9wZXJ0eVBheWxvYWQsIGksIHN0eWxlRGVjbGFyYXRpb24p OwogICAgICAgICAgICAgcHJvcGVydGllcy5wdXNoKHByb3BlcnR5KTsKICAgICAgICAgfQogCisg ICAgICAgIGxldCB0ZXh0ID0gcGF5bG9hZC5jc3NUZXh0OwogICAgICAgICB2YXIgc3R5bGVTaGVl dFRleHRSYW5nZSA9IHRoaXMuX3BhcnNlU291cmNlUmFuZ2VQYXlsb2FkKHBheWxvYWQucmFuZ2Up OwogCiAgICAgICAgIGlmIChzdHlsZURlY2xhcmF0aW9uKSB7Cg==