194641 2019-02-13 21:36:10 -0800 Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy 2019-02-13 22:47:35 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa achristensen beidson cdumez ggaren koivisto oldest_to_newest 1506047 0 rniwa 2019-02-13 21:36:10 -0800 When WKBundleFrameGetParentFrame is called inside PageLoaderClient's didRemoveFrameFromHierarchy, we crash WebFrame::parentFrame() because owner element's document no longer has a frame. 1506050 1 361994 rniwa 2019-02-13 21:43:21 -0800 Created attachment 361994 Fixes the bug 1506051 2 rniwa 2019-02-13 21:43:46 -0800 <rdar://problem/31441007> 1506060 3 361994 ggaren 2019-02-13 22:09:18 -0800 Comment on attachment 361994 Fixes the bug r=me 1506068 4 361994 rniwa 2019-02-13 22:47:33 -0800 Comment on attachment 361994 Fixes the bug Clearing flags on attachment: 361994 Committed r241500: <https://trac.webkit.org/changeset/241500> 1506069 5 rniwa 2019-02-13 22:47:35 -0800 All reviewed patches have been landed. Closing bug. 361994 2019-02-13 21:43:21 -0800 2019-02-13 22:47:33 -0800 Fixes the bug bug-194641-20190213214320.patch text/plain 3450 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDE0OTYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTEzICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIGluIFdLQnVuZGxlRnJhbWVH ZXRQYXJlbnRGcmFtZSB3aGVuIGNhbGxlZCBpbnNpZGUgZGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFy Y2h5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ2 NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhl ZCB0aGUgYnVnIGJ5IGFkZGluZyBhIG51bGwgY2hlY2sgdG8gV2ViRnJhbWU6OnBhcmVudEZyYW1l LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViRnJhbWU6OnBhcmVudEZyYW1lIGNvbnN0KToKKwogMjAxOS0wMi0xMyAgQWxh biBDb29uICA8YWxhbmNvb25AYXBwbGUuY29tPgogCiAgICAgICAgIEFwcGx5IHBhdGNoLiByZGFy Oi8vcHJvYmxlbS80MDk2NjQwMApJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBh Z2UvV2ViRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYkZyYW1lLmNwcAkocmV2aXNpb24gMjQxNDk2KQorKysgU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NjMsOSAr NDYzLDEzIEBAIFN0cmluZyBXZWJGcmFtZTo6aW5uZXJUZXh0KCkgY29uc3QKIFdlYkZyYW1lKiBX ZWJGcmFtZTo6cGFyZW50RnJhbWUoKSBjb25zdAogewogICAgIGlmICghbV9jb3JlRnJhbWUgfHwg IW1fY29yZUZyYW1lLT5vd25lckVsZW1lbnQoKSkKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAg IHJldHVybiBudWxscHRyOworCisgICAgYXV0byogZnJhbWUgPSBtX2NvcmVGcmFtZS0+b3duZXJF bGVtZW50KCktPmRvY3VtZW50KCkuZnJhbWUoKTsKKyAgICBpZiAoIWZyYW1lKQorICAgICAgICBy ZXR1cm4gbnVsbHB0cjsKIAotICAgIHJldHVybiBXZWJGcmFtZTo6ZnJvbUNvcmVGcmFtZSgqbV9j b3JlRnJhbWUtPm93bmVyRWxlbWVudCgpLT5kb2N1bWVudCgpLmZyYW1lKCkpOworICAgIHJldHVy biBXZWJGcmFtZTo6ZnJvbUNvcmVGcmFtZSgqZnJhbWUpOwogfQogCiBSZWY8QVBJOjpBcnJheT4g V2ViRnJhbWU6OmNoaWxkRnJhbWVzKCkKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MTQ5OCkKKysrIFRvb2xzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAyLTEzICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIGluIFdLQnVuZGxlRnJhbWVH ZXRQYXJlbnRGcmFtZSB3aGVuIGNhbGxlZCBpbnNpZGUgZGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFy Y2h5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ2 NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRl ZCBhIGNhbGwgdG8gV0tCdW5kbGVGcmFtZUdldFBhcmVudEZyYW1lIHRvIGFuIGV4aXN0aW5nIHRl c3QgZm9yIGRpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeQorICAgICAgICBzbyB0aGF0IHRoZSB0 ZXN0IHdvdWxkIGZhaWwgd2l0aG91dCB0aGlzIGZpeC4KKworICAgICAgICAqIFRlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0L0RpZFJlbW92ZUZyYW1lRnJvbUhpZWFyY2h5SW5QYWdlQ2FjaGVfQnVu ZGxlLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OmRpZFJlbW92ZUZyYW1lRnJvbUhpZXJh cmNoeUNhbGxiYWNrKToKKwogMjAxOS0wMi0xMyAgQWxhbiBDb29uICA8YWxhbmNvb25AYXBwbGUu Y29tPgogCiAgICAgICAgIENoZXJyeS1waWNrIHIyNDEyODguIHJkYXI6Ly9wcm9ibGVtLzQ3OTky MjEwCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9EaWRSZW1vdmVGcmFt ZUZyb21IaWVhcmNoeUluUGFnZUNhY2hlX0J1bmRsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvRGlkUmVtb3ZlRnJhbWVGcm9tSGllYXJjaHlJblBh Z2VDYWNoZV9CdW5kbGUuY3BwCShyZXZpc2lvbiAyNDE0OTYpCisrKyBUb29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdC9EaWRSZW1vdmVGcmFtZUZyb21IaWVhcmNoeUluUGFnZUNhY2hlX0J1 bmRsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJJbmpl Y3RlZEJ1bmRsZVRlc3QuaCIKIAogI2luY2x1ZGUgIlBsYXRmb3JtVXRpbGl0aWVzLmgiCisjaW5j bHVkZSA8V2ViS2l0L1dLQnVuZGxlRnJhbWUuaD4KICNpbmNsdWRlIDxXZWJLaXQvV0tCdW5kbGVQ YWdlLmg+CiAKIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJIHsKQEAgLTQ1LDEwICs0NiwxMiBAQCBz dGF0aWMgSW5qZWN0ZWRCdW5kbGVUZXN0OjpSZWdpc3RlcjxEaWRSCiAKIHN0YXRpYyB1bnNpZ25l ZCBkaWRSZW1vdmVGcmFtZUZyb21IaWVyYXJjaHlDb3VudDsKIAotdm9pZCBkaWRSZW1vdmVGcmFt ZUZyb21IaWVyYXJjaHlDYWxsYmFjayhXS0J1bmRsZVBhZ2VSZWYgcGFnZSwgV0tCdW5kbGVGcmFt ZVJlZiwgV0tUeXBlUmVmKiwgY29uc3Qgdm9pZCopCit2b2lkIGRpZFJlbW92ZUZyYW1lRnJvbUhp ZXJhcmNoeUNhbGxiYWNrKFdLQnVuZGxlUGFnZVJlZiBwYWdlLCBXS0J1bmRsZUZyYW1lUmVmIGZy YW1lLCBXS1R5cGVSZWYqLCBjb25zdCB2b2lkKikKIHsKICAgICBkaWRSZW1vdmVGcmFtZUZyb21I aWVyYXJjaHlDb3VudCsrOwogCisgICAgUkVMRUFTRV9BU1NFUlQoIVdLQnVuZGxlRnJhbWVHZXRQ YXJlbnRGcmFtZShmcmFtZSkpOworCiAgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IG1lc3Nh Z2UoQWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoIkRpZFJlbW92ZUZyYW1l RnJvbUhpZXJhcmNoeSIpKTsKICAgICBXS0J1bmRsZVBhZ2VQb3N0TWVzc2FnZShwYWdlLCBtZXNz YWdlLmdldCgpLCBtZXNzYWdlLmdldCgpKTsKIH0K