194623 2019-02-13 16:27:26 -0800 Web Inspector: don't include accessibility role in DOM.Node object payloads 2019-02-14 09:06:13 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg ews-watchlist hi inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1505928 0 bburg 2019-02-13 16:27:26 -0800 This is complicated to fetch at all the points where we want to build and push nodes immediately. Turning on AX often indirectly causes style recalc and layout. This is bad because we are often building nodes in the first place due to a DOM node tree update (i.e., NodeInserted). 1505929 1 bburg 2019-02-13 16:27:42 -0800 <rdar://problem/36384037> 1505932 2 361957 bburg 2019-02-13 16:31:48 -0800 Created attachment 361957 Patch 1505936 3 ews-watchlist 2019-02-13 16:33:52 -0800 This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. 1505942 4 361957 hi 2019-02-13 16:39:49 -0800 Comment on attachment 361957 Patch r=me We should also update `WI.DOMNode.prototype.accessibilityProperties` to save the role to `_computedRole` so that `WI.DOMNode.prototype.computedRole` actually returns a value once we've requested accessibility info at least once (this is needed by `WI.roleSelectorForNode`). 1506172 5 bburg 2019-02-14 09:06:13 -0800 Committed r241547: <https://trac.webkit.org/changeset/241547> 361957 2019-02-13 16:31:48 -0800 2019-02-13 16:39:49 -0800 Patch bug-194623-20190213163147.patch text/plain 4391 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNDQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YzNlMWQ4ODQ2NDkyOTI2ZTUyNWRlYTFlNTNkMzQ3NzVhZDQ2NjZmLi41MGE5NWJiMWQ2ZTE0ZTBi NTU5MzI4NzIxYjIwZDUwZDNjNTdmN2I3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wMi0xMyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBkb24ndCBpbmNsdWRlIGFjY2Vzc2liaWxpdHkgcm9sZSBp biBET00uTm9kZSBvYmplY3QgcGF5bG9hZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5NDYyMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYzODQw Mzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVt b3ZlIHByb3BlcnR5IG9mIERPTS5Ob2RlIHRoYXQgaXMgbm8gbG9uZ2VyIGJlaW5nIHNlbnQuCisK KyAgICAgICAgKiBpbnNwZWN0b3IvcHJvdG9jb2wvRE9NLmpzb246CisKIDIwMTktMDItMTMgIFRh ZGV1IFphZ2FsbG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CiAKICAgICAgICAgVmFyaWFibGVMZW5n dGhPYmplY3Q6OmFsbG9jYXRlPFQ+IHNob3VsZCBpbml0aWFsaXplIG9iamVjdHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCBiNWRkZWU4MmNkYWE2M2Y5MWI4OTVjMDc4NzBkMjNlMGFhZTJkNzNjLi4wYjgwNzM5ZGI0 ZTAzZjBhMDM2YjEzZTI2ZWJkMzE5ODIwMGJlZDNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTktMDItMTMgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAg V2ViIEluc3BlY3RvcjogZG9uJ3QgaW5jbHVkZSBhY2Nlc3NpYmlsaXR5IHJvbGUgaW4gRE9NLk5v ZGUgb2JqZWN0IHBheWxvYWRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTQ2MjMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM2Mzg0MDM3PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFjY2Vzc2liaWxp dHkgcHJvcGVydGllcyBhcmUgY29tcGxpY2F0ZWQgdG8gZmV0Y2ggYXQgYWxsIHRoZSBwb2ludHMg d2hlcmUgd2Ugd2FudCB0byBidWlsZCBhbmQgcHVzaCBub2RlcyBpbW1lZGlhdGVseS4KKyAgICAg ICAgVHVybmluZyBvbiBBWCBvZnRlbiBpbmRpcmVjdGx5IGNhdXNlcyBzdHlsZSByZWNhbGMgYW5k IGxheW91dC4gVGhpcyBpcyBiYWQgYmVjYXVzZSB3ZSBhcmUgb2Z0ZW4gYnVpbGRpbmcgbm9kZXMg aW4gdGhlCisgICAgICAgIGZpcnN0IHBsYWNlIGR1ZSB0byBhIERPTSBub2RlIHRyZWUgdXBkYXRl IChpLmUuLCBOb2RlSW5zZXJ0ZWQpLgorCisgICAgICAgIEl0IHR1cm5zIG91dCB0aGF0IERPTS5n ZXRBY2Nlc3NpYmlsaXR5UHJvcGVydGllc0Zvck5vZGUgaXMgY2FsbGVkIGV2ZXJ5IHRpbWUgd2Ug ZGlzcGxheQorICAgICAgICB0aGUgY29tcHV0ZWQgcm9sZSBpbiB0aGUgRWxlbWVudHMgVGFiID4g Tm9kZXMgU2lkZWJhciA+IEFjY2Vzc2liaWxpdHkgU2VjdGlvbi4gU28gaXQgaXMgbm90CisgICAg ICAgIG5lY2Vzc2FyeSB0byBjb2xsZWN0IHRoaXMgaW5mb3JtYXRpb24gaW4gYSBwcm9ibGVtYXRp YyB3YXkgd2hlbiBpbml0aWFsbHkgcHVzaGluZyB0aGUgbm9kZSwgYXMKKyAgICAgICAgaXQgd2ls bCBiZSB1cGRhdGVkIGFueXdheS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5nZSBp biBiZWhhdmlvci4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRE9NQWdl bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OmJ1aWxkT2JqZWN0 Rm9yTm9kZSk6CisKIDIwMTktMDItMTMgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBTdG9wIHVzaW5nIHNldERlZmVyc0xvYWRpbmcgZnJvbSBX ZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3Rv Y29sL0RPTS5qc29uIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9E T00uanNvbgppbmRleCAwMTNjMmJiMmUzMWI0MDY5OTgyNzcwN2VkYWEyMzdmMTZjOGUzZWE2Li4w M2M0MzdmNDVhMDQ2MzZlYWNkYzA3NmFjYzk5ZDg3MmIyMTA2OTBhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0RPTS5qc29uCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJvdG9jb2wvRE9NLmpzb24KQEAgLTY1LDcgKzY1 LDYgQEAKICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInNoYWRvd1Jvb3RzIiwgInR5cGUiOiAi YXJyYXkiLCAib3B0aW9uYWwiOiB0cnVlLCAiaXRlbXMiOiB7ICIkcmVmIjogIk5vZGUiIH0sICJk ZXNjcmlwdGlvbiI6ICJTaGFkb3cgcm9vdCBsaXN0IGZvciBnaXZlbiBlbGVtZW50IGhvc3QuIiB9 LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAidGVtcGxhdGVDb250ZW50IiwgIiRyZWYiOiAi Tm9kZSIsICJvcHRpb25hbCI6IHRydWUsICJkZXNjcmlwdGlvbiI6ICJDb250ZW50IGRvY3VtZW50 IGZyYWdtZW50IGZvciB0ZW1wbGF0ZSBlbGVtZW50cyIgfSwKICAgICAgICAgICAgICAgICB7ICJu YW1lIjogInBzZXVkb0VsZW1lbnRzIiwgInR5cGUiOiAiYXJyYXkiLCAiaXRlbXMiOiB7ICIkcmVm IjogIk5vZGUiIH0sICJvcHRpb25hbCI6IHRydWUsICJkZXNjcmlwdGlvbiI6ICJQc2V1ZG8gZWxl bWVudHMgYXNzb2NpYXRlZCB3aXRoIHRoaXMgbm9kZS4iIH0sCi0gICAgICAgICAgICAgICAgeyAi bmFtZSI6ICJyb2xlIiwgInR5cGUiOiAic3RyaW5nIiwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2Ny aXB0aW9uIjogIkNvbXB1dGVkIHZhbHVlIGZvciBmaXJzdCByZWNvZ25pemVkIHJvbGUgdG9rZW4s IGRlZmF1bHQgcm9sZSBwZXIgZWxlbWVudCwgb3Igb3ZlcnJpZGRlbiByb2xlLiIgfSwKICAgICAg ICAgICAgICAgICB7ICJuYW1lIjogImNvbnRlbnRTZWN1cml0eVBvbGljeUhhc2giLCAidHlwZSI6 ICJzdHJpbmciLCAib3B0aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiQ29tcHV0ZWQgU0hB LTI1NiBDb250ZW50IFNlY3VyaXR5IFBvbGljeSBoYXNoIHNvdXJjZSBmb3IgZ2l2ZW4gZWxlbWVu dC4iIH0KICAgICAgICAgICAgIF0KICAgICAgICAgfSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRE9NQWdlbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JET01BZ2VudC5jcHAKaW5kZXggMzUzNmQ3OGVj MGYyN2Y2OTdjYmMwM2UyYmVkZDk2ZWViZTcxNGZiOC4uMTk5M2I1NTIxNjk1NDZjODNlMDk2YTIz NmY3M2VlOTJlZTQwMWFmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Fn ZW50cy9JbnNwZWN0b3JET01BZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2FnZW50cy9JbnNwZWN0b3JET01BZ2VudC5jcHAKQEAgLTE1OTQsMTUgKzE1OTQsNiBAQCBSZWY8 SW5zcGVjdG9yOjpQcm90b2NvbDo6RE9NOjpOb2RlPiBJbnNwZWN0b3JET01BZ2VudDo6YnVpbGRP YmplY3RGb3JOb2RlKE5vZGUqCiAgICAgICAgIHZhbHVlLT5zZXRTaGFkb3dSb290VHlwZShzaGFk b3dSb290VHlwZShzaGFkb3dSb290Lm1vZGUoKSkpOwogICAgIH0KIAotICAgIC8vIE5lZWQgdG8g ZW5hYmxlIEFYIHRvIGdldCB0aGUgY29tcHV0ZWQgcm9sZS4KLSAgICBpZiAoIVdlYkNvcmU6OkFY T2JqZWN0Q2FjaGU6OmFjY2Vzc2liaWxpdHlFbmFibGVkKCkpCi0gICAgICAgIFdlYkNvcmU6OkFY T2JqZWN0Q2FjaGU6OmVuYWJsZUFjY2Vzc2liaWxpdHkoKTsKLQotICAgIGlmIChBWE9iamVjdENh Y2hlKiBheE9iamVjdENhY2hlID0gbm9kZS0+ZG9jdW1lbnQoKS5heE9iamVjdENhY2hlKCkpIHsK LSAgICAgICAgaWYgKEFjY2Vzc2liaWxpdHlPYmplY3QqIGF4T2JqZWN0ID0gYXhPYmplY3RDYWNo ZS0+Z2V0T3JDcmVhdGUobm9kZSkpCi0gICAgICAgICAgICB2YWx1ZS0+c2V0Um9sZShheE9iamVj dC0+Y29tcHV0ZWRSb2xlU3RyaW5nKCkpOwotICAgIH0KLQogICAgIHJldHVybiB2YWx1ZTsKIH0K IAo=