194622 2019-02-13 16:09:57 -0800 [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins 2019-02-14 08:49:40 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1505914 0 zalan 2019-02-13 16:09:57 -0800 This is something I actually couldn't find in https://www.w3.org/TR/CSS22/box.html#collapsing-margins "A box's own margins collapse if the 'min-height' property is zero, and it has neither top or bottom borders nor top or bottom padding, and it has a 'height' of either 0 or 'auto', and it does not contain a line box, and all of its in-flow children's margins (if any) collapse." 1505947 1 361964 zalan 2019-02-13 16:47:56 -0800 Created attachment 361964 Patch 1506139 2 361964 koivisto 2019-02-14 07:33:25 -0800 Comment on attachment 361964 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361964&action=review > LayoutTests/fast/block/block-only/block-replaced-with-vertical-margins-expected.html:3 > + min-height: 0.1px; Seems little hackish. 1506161 3 zalan 2019-02-14 08:44:47 -0800 Committed r241546: <https://trac.webkit.org/changeset/241546> 1506162 4 webkit-bug-importer 2019-02-14 08:49:40 -0800 <rdar://problem/48075210> 361964 2019-02-13 16:47:56 -0800 2019-02-14 07:33:25 -0800 Patch bug-194622-20190213164749.patch text/plain 5570 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODlmODFhMmFmOTI2NjBm M2Y3OWZmMTI5OTNjNjZhOGVhOGZlNTM1ZS4uMTdjZDFjNzA4ZTkxZjUzYThlMzE5NWUwNDkwOTMy OWQzYWU3NTM3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAyLTEzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXVtNYXJnaW5D b2xsYXBzZV0gUmVwbGFjZWQgYm94ZXMgZG9uJ3QgY29sbGFwc2UgdGhyb3VnaCB0aGVpciBtYXJn aW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ2 MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnN1 cmUgdGhhdCBibG9jayByZXBsYWNlZCBib3hlcyBkb24ndCBjb2xsYXBzZSB0aHJvdWdoIHRoZWly IHZlcnRpY2FsIG1hcmdpbnMuIAorCisgICAgICAgIFRlc3Q6IGZhc3QvYmxvY2svYmxvY2stb25s eS9ibG9jay1yZXBsYWNlZC13aXRoLXZlcnRpY2FsLW1hcmdpbnMuaHRtbAorCisgICAgICAgICog bGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja01hcmdpbkNvbGxhcHNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dDo6QmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6TWFyZ2luQ29sbGFwc2U6 Om1hcmdpbnNDb2xsYXBzZVRocm91Z2gpOgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3TGF5b3V0 Q29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpsYXlvdXRVc2luZ0Zvcm1hdHRpbmdDb250 ZXh0KToKKwogMjAxOS0wMi0xMiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNv bT4KIAogICAgICAgICBBbGxvdyBwYWdlcyB0byB0cmlnZ2VyIHByb2dyYW1tYXRpYyBwYXN0ZSBm cm9tIHNjcmlwdCBvbiBpT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9j a2Zvcm1hdHRpbmcvQmxvY2tNYXJnaW5Db2xsYXBzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuY3BwCmluZGV4IGZjOWVmODE3 NzQ5NzNhYjA2NzZlMTUzOTVlNTVjNDZhZmY0YjdjNWMuLjAwZTBhMGY0NGFkZTgyZGEyMWQzNjU2 MDAwYTBjNmQyMWZjNTZlZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9j a2Zvcm1hdHRpbmcvQmxvY2tNYXJnaW5Db2xsYXBzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja01hcmdpbkNvbGxhcHNlLmNwcApAQCAtMzkyLDYg KzM5MiwxMCBAQCBib29sIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6Ok1hcmdpbkNvbGxhcHNlOjpt YXJnaW5zQ29sbGFwc2VUaHJvdWdoKGNvbnN0IExheW91dAogICAgIGlmICghbGF5b3V0Qm94LnN0 eWxlKCkubWluSGVpZ2h0KCkuaXNBdXRvKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAg IC8vIEZJWE1FOiBCbG9jayByZXBsYWNlZCBib3hlcyBjbGVhcmx5IGRvbid0IGNvbGxhcHNlIHRo cm91Z2ggdGhlaXIgbWFyZ2lucywgYnV0IEkgY291bGRuJ3QgZmluZCBpdCBpbiB0aGUgc3BlYyB5 ZXQgKGFuZCBubywgaXQncyBub3QgYSBxdWlyaykuCisgICAgaWYgKGxheW91dEJveC5pc1JlcGxh Y2VkKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIGlmICghaXM8Q29udGFpbmVyPihs YXlvdXRCb3gpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hh bmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDRjMTg4MTRkMzVhNTMzOTE2OGUwM2YwMTRk MDdiZjg4NWU1ZTA3NTIuLmRlODU4NGQ1YWIyODJjOGJiOGUwYmIxYTc5OTczY2MxYWUzODQ5ZTAg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxOS0wMi0xMyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgor CisgICAgICAgIFtMRkNdW0JGQ11bTWFyZ2luQ29sbGFwc2VdIFJlcGxhY2VkIGJveGVzIGRvbid0 IGNvbGxhcHNlIHRocm91Z2ggdGhlaXIgbWFyZ2lucworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NjIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBMYXlvdXRSZWxvYWRlZC9taXNjL0xGQy1wYXNzaW5n LXRlc3RzLnR4dDoKKwogMjAxOS0wMi0xMiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtMRkNdIEV4cGFuZCB0ZXN0cyBjb3ZlcmFnZSAoNjAgbmV3IHRlc3RzIC0+ IDg2MCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0xheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3Npbmct dGVzdHMudHh0IGIvVG9vbHMvTGF5b3V0UmVsb2FkZWQvbWlzYy9MRkMtcGFzc2luZy10ZXN0cy50 eHQKaW5kZXggOGE5NWY5ZTMzOGQ2ZDU5NjgwYzA5ZWQwMGIzMTBjYzI4MmMxZGZjZC4uMjc3ZjIz NzI3MGI0MDBiMzc3NTQzNDQ5MDY3MDVhNjEyZGQwNWE1MiAxMDA2NDQKLS0tIGEvVG9vbHMvTGF5 b3V0UmVsb2FkZWQvbWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQKKysrIGIvVG9vbHMvTGF5b3V0 UmVsb2FkZWQvbWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQKQEAgLTQzLDYgKzQzLDcgQEAgZmFz dC9ibG9jay9ibG9jay1vbmx5L2Fic29sdXRlLXdpZHRoLXNocmluay10by1maXQuaHRtbAogZmFz dC9ibG9jay9ibG9jay1vbmx5L2Fic29sdXRlLXdpZHRoLXN0cmV0Y2guaHRtbAogZmFzdC9ibG9j ay9ibG9jay1vbmx5L2Fic29sdXRlLXdpdGgtc3RhdGljLWJsb2NrLXBvc2l0aW9uLW5lc3RlZC5o dG1sCiBmYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvYWxtb3N0LWludHJ1ZGluZy1sZWZ0LWZsb2F0LXNp bXBsZS5odG1sCitmYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvYmxvY2stcmVwbGFjZWQtd2l0aC12ZXJ0 aWNhbC1tYXJnaW5zLmh0bWwKIGZhc3QvYmxvY2svYmxvY2stb25seS9ib2R5LWhlaWdodC13aXRo LWF1dG8taHRtbC1oZWlnaHQtcXVpcmsyLmh0bWwKIGZhc3QvYmxvY2svYmxvY2stb25seS9ib2R5 LWhlaWdodC13aXRoLWF1dG8taHRtbC1oZWlnaHQtcXVpcmsuaHRtbAogZmFzdC9ibG9jay9ibG9j ay1vbmx5L2JvZHktaGVpZ2h0LXdpdGgtbm9uLWF1dG8taHRtbC1oZWlnaHQtcXVpcmsyLmh0bWwK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhY2U3MmNiMGRhOTYxZjllYzhiODg4MDg0ODk4NmYzNTk0MGI4N2NmLi5lNzFhMTlm OTBkZjIzMmNkNzliZGZmYjkxZTg1NjkyZGY4NTJkYjMyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTktMDItMTMgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBb TEZDXVtCRkNdW01hcmdpbkNvbGxhcHNlXSBSZXBsYWNlZCBib3hlcyBkb24ndCBjb2xsYXBzZSB0 aHJvdWdoIHRoZWlyIG1hcmdpbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NDYyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogZmFzdC9ibG9jay9ibG9jay1vbmx5L2Jsb2NrLXJlcGxhY2VkLXdpdGgt dmVydGljYWwtbWFyZ2lucy1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Js b2NrL2Jsb2NrLW9ubHkvYmxvY2stcmVwbGFjZWQtd2l0aC12ZXJ0aWNhbC1tYXJnaW5zLmh0bWw6 IEFkZGVkLgorCiAyMDE5LTAyLTEyICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUu Y29tPgogCiAgICAgICAgIEFsbG93IHBhZ2VzIHRvIHRyaWdnZXIgcHJvZ3JhbW1hdGljIHBhc3Rl IGZyb20gc2NyaXB0IG9uIGlPUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ibG9jay9i bG9jay1vbmx5L2Jsb2NrLXJlcGxhY2VkLXdpdGgtdmVydGljYWwtbWFyZ2lucy1leHBlY3RlZC5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ibG9jay9ibG9jay1vbmx5L2Jsb2NrLXJlcGxhY2VkLXdp dGgtdmVydGljYWwtbWFyZ2lucy1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU4YTViZjJhYzlk N2ExY2U4ZDhmODdiMzkyYmJkNjc1ZmY5YzI5Y2UKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvYmxvY2stcmVwbGFjZWQtd2l0aC12ZXJ0aWNhbC1t YXJnaW5zLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwxNyBAQAorPHN0eWxlPgorLmZpcnN0IHsK KyAgICBtaW4taGVpZ2h0OiAwLjFweDsKKyAgICB3aWR0aDogMTAwcHg7CisgICAgbWFyZ2luLXRv cDogMTAwcHg7CisgICAgbWFyZ2luLWJvdHRvbTogMTBweDsKKyAgICBvdXRsaW5lOiA1cHggc29s aWQgYmx1ZTsKK30KKworLnNlY29uZCB7CisgICAgd2lkdGg6IDEwMHB4OworICAgIGhlaWdodDog MTAwcHg7CisgICAgbWFyZ2luLXRvcDogMjBweDsKKyAgICBvdXRsaW5lOiA1cHggc29saWQgYmx1 ZTsKK30KKzwvc3R5bGU+Cis8ZGl2IGNsYXNzPWZpcnN0PjwvZGl2PjxkaXYgY2xhc3M9c2Vjb25k PjwvZGl2PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvYmxvY2svYmxvY2stb25seS9ibG9jay1yZXBsYWNlZC13aXRoLXZlcnRpY2FsLW1h cmdpbnMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svYmxvY2stb25seS9ibG9jay1yZXBs YWNlZC13aXRoLXZlcnRpY2FsLW1hcmdpbnMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kM2UwMjFkOTFjYzU5 OGViZTZiZWYwMTI2YzAwMjhkMjc4MjZkZGUyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9ibG9jay9ibG9jay1vbmx5L2Jsb2NrLXJlcGxhY2VkLXdpdGgtdmVydGljYWwtbWFy Z2lucy5odG1sCkBAIC0wLDAgKzEsMTkgQEAKKzxzdHlsZT4KK2ltZyB7CisgICAgZGlzcGxheTog YmxvY2s7CisgICAgaGVpZ2h0OiAwcHg7CisgICAgbWluLWhlaWdodDogMHB4OworICAgIHdpZHRo OiAxMDBweDsKKyAgICBtYXJnaW4tdG9wOiAxMDBweDsKKyAgICBtYXJnaW4tYm90dG9tOiAxMHB4 OworICAgIG91dGxpbmU6IDVweCBzb2xpZCBibHVlOworfQorCitkaXYgeworICAgIHdpZHRoOiAx MDBweDsKKyAgICBoZWlnaHQ6IDEwMHB4OworICAgIG1hcmdpbi10b3A6IDIwcHg7CisgICAgb3V0 bGluZTogNXB4IHNvbGlkIGJsdWU7Cit9Cis8L3N0eWxlPgorPGltZyBzcmM9ImZvb2Jhci5qcGci PjxkaXY+PC9kaXY+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=