194621 2019-02-13 15:51:59 -0800 [Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized. 2019-02-14 06:26:49 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson graouts jonlee webkit-bug-importer oldest_to_newest 1505901 0 jer.noble 2019-02-13 15:51:59 -0800 [Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized. 1505903 1 jer.noble 2019-02-13 15:53:35 -0800 <rdar://problem/48002560> 1505906 2 361951 jer.noble 2019-02-13 15:55:43 -0800 Created attachment 361951 Patch 1505997 3 361951 commit-queue 2019-02-13 18:28:53 -0800 Comment on attachment 361951 Patch Clearing flags on attachment: 361951 Committed r241492: <https://trac.webkit.org/changeset/241492> 1505998 4 commit-queue 2019-02-13 18:28:55 -0800 All reviewed patches have been landed. Closing bug. 1505999 5 361951 jonlee 2019-02-13 18:36:12 -0800 Comment on attachment 361951 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361951&action=review > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:287 > + this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode); @Antoine, why was rAF used in the first place? @Jer, are there other instances where rAF is being used for similar purposes that should be reconsidered? 1506130 6 graouts 2019-02-14 06:26:49 -0800 (In reply to Jon Lee from comment #5) > Comment on attachment 361951 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=361951&action=review > > > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:287 > > + this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode); > > @Antoine, why was rAF used in the first place? I don't know for sure, but I would wager this was to do with flakiness. 361951 2019-02-13 15:55:43 -0800 2019-02-13 18:28:53 -0800 Patch bug-194621-20190213155542.patch text/plain 1847 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTFjZWM2ZWZkN2Q1NjVj NjJmOTQ2MDNmYmFiN2I4NWYxZDZlZDM1Ny4uNDFmNDU5MjlhOWFlNjA0MTBlZTEyNzRlMmI3MGM2 NTk4NWQ4NTIxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAyLTEzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFBpUCB3aW5kb3cg Y2FuIGdldCAic3R1Y2siIGlmIFBpUCBpcyBjbG9zZWQgd2hpbGUgU2FmYXJpIHdpbmRvdyBpcyBt aW5pbWl6ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTQ2MjEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4MDAyNTYwPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gU2FmYXJpIGlzIG1pbmlt aXplZCwgbm8gckFGKCkgcmVxdWVzdHMgYXJlIGV4ZWN1dGVkLiBEb24ndCBnYXRlIHJlc3BvbmRp bmcgdG8gcHJlc2VudGF0aW9uCisgICAgICAgIGNoYW5nZSBldmVudHMgaW4gdGhlIG1lZGlhLWNv bnRyb2xsZXIuanMgb24gckFGKCkuCisKKyAgICAgICAgKiBNb2R1bGVzL21vZGVybi1tZWRpYS1j b250cm9scy9tZWRpYS9tZWRpYS1jb250cm9sbGVyLmpzOgorICAgICAgICAoTWVkaWFDb250cm9s bGVyLnByb3RvdHlwZS5fcmV0dXJuTWVkaWFMYXllclRvSW5saW5lSWZOZWVkZWQpOgorCiAyMDE5 LTAyLTEzICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIE51bGwt ZGVyZWYgY3Jhc2ggYXQgU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6Om91dHB1dE9ic2N1cmVk RHVlVG9JbnN1ZmZpY2llbnRFeHRlcm5hbFByb3RlY3Rpb25DaGFuZ2VkKCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhL21lZGlh LWNvbnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250 cm9scy9tZWRpYS9tZWRpYS1jb250cm9sbGVyLmpzCmluZGV4IDE4ZmE5MWViOTMwNDliZDAyZWE2 ZGM0Njc1NWU2MDY3MmRhNGRmYzMuLjY3NTNiYTlkOWE2YzRiMTIwNjZlMTUxOTIzOWMxNTc0ZTlm ODkzYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNv bnRyb2xzL21lZGlhL21lZGlhLWNvbnRyb2xsZXIuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEvbWVkaWEtY29udHJvbGxlci5qcwpAQCAt Mjg0LDcgKzI4NCw3IEBAIGNsYXNzIE1lZGlhQ29udHJvbGxlcgogICAgIF9yZXR1cm5NZWRpYUxh eWVyVG9JbmxpbmVJZk5lZWRlZCgpCiAgICAgewogICAgICAgICBpZiAodGhpcy5ob3N0KQotICAg ICAgICAgICAgd2luZG93LnJlcXVlc3RBbmltYXRpb25GcmFtZSgoKSA9PiB0aGlzLmhvc3Quc2V0 UHJlcGFyZWRUb1JldHVyblZpZGVvTGF5ZXJUb0lubGluZSh0aGlzLm1lZGlhLndlYmtpdFByZXNl bnRhdGlvbk1vZGUgIT09IFBpUE1vZGUpKTsKKyAgICAgICAgICAgIHRoaXMuaG9zdC5zZXRQcmVw YXJlZFRvUmV0dXJuVmlkZW9MYXllclRvSW5saW5lKHRoaXMubWVkaWEud2Via2l0UHJlc2VudGF0 aW9uTW9kZSAhPT0gUGlQTW9kZSk7CiAgICAgfQogCiAgICAgX2NvbnRyb2xzQ2xhc3NGb3JMYXlv dXRUcmFpdHMobGF5b3V0VHJhaXRzKQo=