194615 2019-02-13 14:52:44 -0800 [iOS] Add a hack to work around buggy video control library 2019-02-13 16:29:03 -0800 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue jer.noble webkit-bug-importer oldest_to_newest 1505870 0 eric.carlson 2019-02-13 14:52:44 -0800 A widely used media control JavaScript library hides the mute button if it isn't possible to change the volume. 1505871 1 eric.carlson 2019-02-13 14:53:57 -0800 <rdar://problem/46146946> 1505874 2 361941 eric.carlson 2019-02-13 15:00:02 -0800 Created attachment 361941 Patch 1505930 3 361941 commit-queue 2019-02-13 16:29:01 -0800 Comment on attachment 361941 Patch Clearing flags on attachment: 361941 Committed r241487: <https://trac.webkit.org/changeset/241487> 1505931 4 commit-queue 2019-02-13 16:29:03 -0800 All reviewed patches have been landed. Closing bug. 361941 2019-02-13 15:00:02 -0800 2019-02-13 16:29:01 -0800 Patch bug-194615-20190213150002.patch text/plain 5863 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjJhZGFjNjIwN2RmYTM2 OTBlYWU1OWE5NjNmYTFkYjYyODQ3ZTc0Ni4uZDdmMjg5YjY3ZDBmMWI5OWIyOWIzMzI0MGU0ODk2 N2VkZmI3OGE2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAyLTEzICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEFkZCBh IGhhY2sgdG8gd29yayBhcm91bmQgYnVnZ3kgdmlkZW8gY29udHJvbCBsaWJyYXJ5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ2MTUKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzQ2MTQ2OTQ2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRlc3Q6IG1lZGlhL2lvcy92aWRlby12b2x1bWUtaW9zLXF1aXJr Lmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpzZXRWb2x1bWUpOiBDaGFuZ2UgbV92b2x1bWUgZm9y IG9uZSB0dXJuIG9mIHRoZSBydW5sb29wLgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxl bWVudDo6Y2FuY2VsUGVuZGluZ1Rhc2tzKTogQ2xlYXIgdGhlIHRhc2sgcXVldWUgdXNlZCB0byBy ZXN0b3JlIG1fdm9sdW1lLgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6Y2xv c2VUYXNrUXVldWVzKTogQ2xvc2UgaXQuCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50 Lmg6CisKIDIwMTktMDItMTMgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CiAK ICAgICAgICAgU3RvcmUgQWQgQ2xpY2sgQXR0cmlidXRpb24gcmVxdWVzdHMgaW4gdGhlIG5ldHdv cmsgcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXgg M2QxZTM0MzI4NGJlYTY4YjkxNDU1OGUwMTdkMmEzMmYwYTc0ODJkYS4uODhlYWUxODhhMGVhMDMy NTA4YTU3MDA2NjM2MDFkMDM5N2E5NjBjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwCkBAIC0zNzIyLDEwICszNzIyLDEwIEBAIEV4Y2VwdGlvbk9yPHZvaWQ+IEhU TUxNZWRpYUVsZW1lbnQ6OnNldFZvbHVtZShkb3VibGUgdm9sdW1lKQogICAgIGlmICghKHZvbHVt ZSA+PSAwICYmIHZvbHVtZSA8PSAxKSkKICAgICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IEluZGV4 U2l6ZUVycm9yIH07CiAKLSNpZiAhUExBVEZPUk0oSU9TX0ZBTUlMWSkKICAgICBpZiAobV92b2x1 bWUgPT0gdm9sdW1lKQogICAgICAgICByZXR1cm4geyB9OwogCisjaWYgIVBMQVRGT1JNKElPU19G QU1JTFkpCiAgICAgaWYgKHZvbHVtZSAmJiBwcm9jZXNzaW5nVXNlckdlc3R1cmVGb3JNZWRpYSgp KQogICAgICAgICByZW1vdmVCZWhhdmlvcnNSZXN0cmljdGlvbnNBZnRlckZpcnN0VXNlckdlc3R1 cmUoTWVkaWFFbGVtZW50U2Vzc2lvbjo6QWxsUmVzdHJpY3Rpb25zICYgfk1lZGlhRWxlbWVudFNl c3Npb246OlJlcXVpcmVVc2VyR2VzdHVyZVRvQ29udHJvbENvbnRyb2xzTWFuYWdlcik7CiAKQEAg LTM3MzgsNyArMzczOCwxOSBAQCBFeGNlcHRpb25Pcjx2b2lkPiBIVE1MTWVkaWFFbGVtZW50Ojpz ZXRWb2x1bWUoZG91YmxlIHZvbHVtZSkKICAgICAgICAgcGF1c2VJbnRlcm5hbCgpOwogICAgICAg ICBzZXRBdXRvcGxheUV2ZW50UGxheWJhY2tTdGF0ZShBdXRvcGxheUV2ZW50UGxheWJhY2tTdGF0 ZTo6UHJldmVudGVkQXV0b3BsYXkpOwogICAgIH0KKyNlbHNlCisgICAgYXV0byBvbGRWb2x1bWUg PSBtX3ZvbHVtZTsKKyAgICBtX3ZvbHVtZSA9IHZvbHVtZTsKKworICAgIGlmIChtX3ZvbHVtZVJl dmVydFRhc2tRdWV1ZS5oYXNQZW5kaW5nVGFzaygpKQorICAgICAgICByZXR1cm4geyB9OworCisg ICAgbV92b2x1bWVSZXZlcnRUYXNrUXVldWUuc2NoZWR1bGVUYXNrKFt0aGlzLCBvbGRWb2x1bWVd IHsKKyAgICAgICAgbV92b2x1bWUgPSBvbGRWb2x1bWU7CisgICAgfSk7CisKICNlbmRpZgorICAg IAogICAgIHJldHVybiB7IH07CiB9CiAKQEAgLTU1MjcsNiArNTUzOSw5IEBAIHZvaWQgSFRNTE1l ZGlhRWxlbWVudDo6Y2FuY2VsUGVuZGluZ1Rhc2tzKCkKICAgICBtX3VwZGF0ZU1lZGlhU3RhdGVU YXNrLmNhbmNlbFRhc2soKTsKICAgICBtX21lZGlhRW5naW5lVXBkYXRlZFRhc2suY2FuY2VsVGFz aygpOwogICAgIG1fdXBkYXRlUGxheVN0YXRlVGFzay5jYW5jZWxUYXNrKCk7CisjaWYgUExBVEZP Uk0oSU9TX0ZBTUlMWSkKKyAgICBtX3ZvbHVtZVJldmVydFRhc2tRdWV1ZS5jYW5jZWxUYXNrKCk7 CisjZW5kaWYKIH0KIAogdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp1c2VyQ2FuY2VsbGVkTG9hZCgp CkBAIC01NzA1LDYgKzU3MjAsOSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmNsb3NlVGFza1F1 ZXVlcygpCiAgICAgbV9lbmNyeXB0ZWRNZWRpYVF1ZXVlLmNsb3NlKCk7CiAjZW5kaWYKICAgICBt X2FzeW5jRXZlbnRRdWV1ZS5jbG9zZSgpOworI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCisgICAg bV92b2x1bWVSZXZlcnRUYXNrUXVldWUuY2xvc2UoKTsKKyNlbmRpZgogfQogCiB2b2lkIEhUTUxN ZWRpYUVsZW1lbnQ6OmNvbnRleHREZXN0cm95ZWQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRp YUVsZW1lbnQuaAppbmRleCBiOTBkYzI5ZWZhYTNkMjQyZjBiMzFmNTg2YjdlN2EwZWYwMzg1ZDcz Li4zNGUxODRhZTcwY2EyMDAxOTg4ZGQxNzQ5ZmEzY2E3NTc5Yjc3ODUyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaApAQCAtOTY3LDYgKzk2Nyw5IEBAIHByaXZhdGU6CiAg ICAgR2VuZXJpY1Rhc2tRdWV1ZTxUaW1lcj4gbV9wbGF5YmFja1RhcmdldElzV2lyZWxlc3NRdWV1 ZTsKICAgICBSZWZQdHI8VGltZVJhbmdlcz4gbV9wbGF5ZWRUaW1lUmFuZ2VzOwogICAgIEdlbmVy aWNFdmVudFF1ZXVlIG1fYXN5bmNFdmVudFF1ZXVlOworI2lmIFBMQVRGT1JNKElPU19GQU1JTFkp CisgICAgRGVmZXJyYWJsZVRhc2s8VGltZXI+IG1fdm9sdW1lUmV2ZXJ0VGFza1F1ZXVlOworI2Vu ZGlmCiAKICAgICBQbGF5UHJvbWlzZVZlY3RvciBtX3BlbmRpbmdQbGF5UHJvbWlzZXM7CiAKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCA1YjA0MzI3OWNhNzU5ZjlmNWQ0NzczODcxZDljMjA5OWRhOTlhZDQ3Li4zOGRlYjNkNjUy ZjZhMDM1ZDYxMDAzNGZkMDYwYjFkMTRmMDUyYmFlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIw MTktMDItMTMgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAg ICAgW2lPU10gQWRkIGEgaGFjayB0byB3b3JrIGFyb3VuZCBidWdneSB2aWRlbyBjb250cm9sIGxp YnJhcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 NDYxNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDYxNDY5NDY+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtZWRpYS9pb3MvdmlkZW8tdm9sdW1l LWlvcy1xdWlyay1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL2lvcy92aWRl by12b2x1bWUtaW9zLXF1aXJrLmh0bWw6IEFkZGVkLgorCiAyMDE5LTAyLTEzICBKb2huIFdpbGFu ZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3JlIEFkIENsaWNrIEF0dHJp YnV0aW9uIHJlcXVlc3RzIGluIHRoZSBuZXR3b3JrIHByb2Nlc3MKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL21lZGlhL2lvcy92aWRlby12b2x1bWUtaW9zLXF1aXJrLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL21lZGlhL2lvcy92aWRlby12b2x1bWUtaW9zLXF1aXJrLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4wNDM0MGI4N2EzYjBjMTQzMmJhZjI5ZWNiNjJjOWFlNzRmM2QwNGUyCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvaW9zL3ZpZGVvLXZvbHVtZS1pb3MtcXVp cmstZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTMgQEAKKworVGVzdCAndm9sdW1lJyBhdHRyaWJ1 dGUKKworRVhQRUNURUQgKHZpZGVvLnZvbHVtZSA9PSAnMScpIE9LCitSVU4odmlkZW8udm9sdW1l ID0gMC41KQorRVhQRUNURUQgKHZpZGVvLnZvbHVtZSA9PSAnMC41JykgT0sKK1JVTih2aWRlby52 b2x1bWUgPSAwKQorRVhQRUNURUQgKHZpZGVvLnZvbHVtZSA9PSAnMCcpIE9LCitURVNUKHZpZGVv LnZvbHVtZSA9IDEuNSkgVEhST1dTKERPTUV4Y2VwdGlvbi5JTkRFWF9TSVpFX0VSUikgT0sKK1RF U1QodmlkZW8udm9sdW1lID0gLTAuNSkgVEhST1dTKERPTUV4Y2VwdGlvbi5JTkRFWF9TSVpFX0VS UikgT0sKK0VYUEVDVEVEICh2aWRlby52b2x1bWUgPT0gJzEnKSBPSworRU5EIE9GIFRFU1QKKwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvaW9zL3ZpZGVvLXZvbHVtZS1pb3MtcXVpcmsu aHRtbCBiL0xheW91dFRlc3RzL21lZGlhL2lvcy92aWRlby12b2x1bWUtaW9zLXF1aXJrLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uM2JlNDFiMzhiMzMzM2RiODZiNjgxMTExOGIwYTg1NTMxYTYyYTRhMgotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL2lvcy92aWRlby12b2x1bWUtaW9zLXF1 aXJrLmh0bWwKQEAgLTAsMCArMSwxOSBAQAorPHZpZGVvIGNvbnRyb2xzPjwvdmlkZW8+Cis8cD5U ZXN0ICd2b2x1bWUnIGF0dHJpYnV0ZTxwPgorPHNjcmlwdCBzcmM9Li4vbWVkaWEtZmlsZS5qcz48 L3NjcmlwdD4KKzxzY3JpcHQgc3JjPS4uL3ZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+Cis8c2NyaXB0 PgorICAgIHRlc3RFeHBlY3RlZCgidmlkZW8udm9sdW1lIiwgMS4wKTsKKyAgICBydW4oInZpZGVv LnZvbHVtZSA9IDAuNSIpOworICAgIHRlc3RFeHBlY3RlZCgidmlkZW8udm9sdW1lIiwgMC41KTsK KyAgICBydW4oInZpZGVvLnZvbHVtZSA9IDAiKTsKKyAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLnZv bHVtZSIsIDApOworICAgIHRlc3RET01FeGNlcHRpb24oInZpZGVvLnZvbHVtZSA9IDEuNSIsICJE T01FeGNlcHRpb24uSU5ERVhfU0laRV9FUlIiKTsKKyAgICB0ZXN0RE9NRXhjZXB0aW9uKCJ2aWRl by52b2x1bWUgPSAtMC41IiwgIkRPTUV4Y2VwdGlvbi5JTkRFWF9TSVpFX0VSUiIpOworICAgIHZp ZGVvLnNyYyA9IGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgImNvbnRlbnQvdGVzdCIpOworCisJc2V0 VGltZW91dChmdW5jdGlvbigpIHsgCisJICAgIHRlc3RFeHBlY3RlZCgidmlkZW8udm9sdW1lIiwg MS4wKTsKKyAgICAgICAgZW5kVGVzdCgpOworCX0gLCAxMDApOworPC9zY3JpcHQ+Cg==