194595 2019-02-13 10:09:48 -0800 Make WebRTCUnifiedPlanEnabled true by default 2019-02-14 09:23:54 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson jonlee mcatanzaro webkit-bug-importer youennf oldest_to_newest 1505750 0 youennf 2019-02-13 10:09:48 -0800 Make WebRTCUnifiedPlanEnabled true by default 1505751 1 361923 youennf 2019-02-13 10:10:25 -0800 Created attachment 361923 Patch 1505756 2 youennf 2019-02-13 10:29:51 -0800 <rdar://problem/48042888> 1505816 3 361923 commit-queue 2019-02-13 12:49:09 -0800 Comment on attachment 361923 Patch Rejecting attachment 361923 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 361923, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=361923&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=194595&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 361923 from bug 194595. Fetching: https://bugs.webkit.org/attachment.cgi?id=361923 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog M Source/WebKit/Shared/WebPreferences.yaml Committed r241452 fatal: Unable to create '/Volumes/Data/EWS/WebKit/.git/svn/refs/remotes/origin/master/index.lock': File exists. Another git process seems to be running in this repository, e.g. an editor opened by 'git commit'. Please make sure all processes are terminated then try again. If it still fails, a git process may have crashed in this repository earlier: remove the file manually to continue. write-tree: command returned error: 128 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog M Source/WebKit/Shared/WebPreferences.yaml Committed r241452 fatal: Unable to create '/Volumes/Data/EWS/WebKit/.git/svn/refs/remotes/origin/master/index.lock': File exists. Another git process seems to be running in this repository, e.g. an editor opened by 'git commit'. Please make sure all processes are terminated then try again. If it still fails, a git process may have crashed in this repository earlier: remove the file manually to continue. write-tree: command returned error: 128 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 898e28d9b03..4e47e4f74cc master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 241448 = 898e28d9b0368fe03c07f87edcab2e4ede1f241d r241449 = 274a8e1fb29505562053ccdfd4e867a69cd7c138 r241450 = 34567a6878937b6da4f9de9449f5ba2f002e6053 r241451 = 4e47e4f74cc461b732e1e608881a5633810304ca Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/11137306 1505827 4 mcatanzaro 2019-02-13 13:12:33 -0800 Need to drop category: experimental now. 1505964 5 youennf 2019-02-13 17:08:28 -0800 (In reply to Michael Catanzaro from comment #4) > Need to drop category: experimental now. The category 'experimental' allows to keep it in Safari Experimental Features which is nice to have during adoption of the feature. It allows web devs to test with and without, check what breaks... Agreed this option should be removed from the experimental category at some point. 1506142 6 361923 commit-queue 2019-02-14 07:36:24 -0800 Comment on attachment 361923 Patch Rejecting attachment 361923 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 361923, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=361923&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=194595&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 361923 from bug 194595. Fetching: https://bugs.webkit.org/attachment.cgi?id=361923 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/Shared/WebPreferences.yaml Hunk #1 FAILED at 530. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Shared/WebPreferences.yaml.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/11146825 1506188 7 youennf 2019-02-14 09:23:54 -0800 https://trac.webkit.org/changeset/241452/webkit 361923 2019-02-13 10:10:25 -0800 2019-02-14 07:36:24 -0800 Patch bug-194595-20190213101025.patch text/plain 1206 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYzN2RlNzljOWFhZjRlMWZk Y2JjMTE5OTZmYTIzMjQ3ZTNhZjg2MTguLjU4MmUxODRiMGIxMzk1MDI4MjUxNWEzN2MyNjc1NTlk MzZmNzNjOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDItMTMgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgV2ViUlRDVW5pZmllZFBs YW5FbmFibGVkIHRydWUgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbDoKKwogMjAxOS0w Mi0wNyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgRmlsdGVy IG91dCBPdmVyY29uc3RyYWluZWRlcnJvci5jb25zdHJhaW50IHdoZW4gZ2V0VXNlck1lZGlhIGlz IG5vdCBncmFudGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJl bmNlcy55YW1sIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAppbmRl eCBjY2U0YWNlODM1NjMyNWU3YTBhMDBlNTIzZjllNGM5OTJmOTE1MmZmLi44ZWZlNmJhNTc2ZmYx MGFlOGNjNTY2MWVhZTVlMWZlNWFjZTgwZjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1No YXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlBy ZWZlcmVuY2VzLnlhbWwKQEAgLTUzMCw3ICs1MzAsNyBAQCBQZWVyQ29ubmVjdGlvbkVuYWJsZWQ6 CiAKIFdlYlJUQ1VuaWZpZWRQbGFuRW5hYmxlZDoKICAgdHlwZTogYm9vbAotICBkZWZhdWx0VmFs dWU6IERFRkFVTFRfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTX0VOQUJMRUQKKyAgZGVmYXVsdFZhbHVl OiB0cnVlCiAgIHdlYmNvcmVCaW5kaW5nOiBSdW50aW1lRW5hYmxlZEZlYXR1cmVzCiAgIGNvbmRp dGlvbjogRU5BQkxFKFdFQl9SVEMpCiAgIGh1bWFuUmVhZGFibGVOYW1lOiAiV2ViUlRDIFVuaWZp ZWQgUGxhbiIK