194584 2019-02-12 22:42:46 -0800 Crash in Page::setActivityState because m_page is null 2019-02-13 13:10:13 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa achristensen beidson cdumez ggaren koivisto mcatanzaro oldest_to_newest 1505621 0 rniwa 2019-02-12 22:42:46 -0800 e.g. 0 com.apple.WebCore 0x00007fff50236b2e WebCore::Page::setActivityState(WTF::OptionSet<WebCore::ActivityState::Flag>) + 14 1 com.apple.WebKit 0x00007fff50fc071d WebKit::WebPage::setActivityState(WTF::OptionSet<WebCore::ActivityState::Flag>, unsigned long long, WTF::Vector<WebKit::CallbackID, 0ul, WTF::CrashOnOverflow, 16ul> const&) + 83 2 com.apple.WebKit 0x00007fff50fd446e WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::Decoder&) + 4872 3 com.apple.WebKit 0x00007fff50c58d84 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 126 4 com.apple.WebKit 0x00007fff50f1dd06 WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 28 5 com.apple.WebKit 0x00007fff50c48a98 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 108 6 com.apple.WebKit 0x00007fff50c4c24b IPC::Connection::dispatchOneIncomingMessage() + 181 1505622 1 rniwa 2019-02-12 22:42:55 -0800 <rdar://problem/47761293> 1505625 2 361898 rniwa 2019-02-12 22:55:49 -0800 Created attachment 361898 Adds a nullcheck 1505663 3 361898 rniwa 2019-02-13 01:07:26 -0800 Comment on attachment 361898 Adds a nullcheck Clearing flags on attachment: 361898 Committed r241401: <https://trac.webkit.org/changeset/241401> 1505664 4 rniwa 2019-02-13 01:07:27 -0800 All reviewed patches have been landed. Closing bug. 1505819 5 mcatanzaro 2019-02-13 12:56:47 -0800 Note incoming follow-up: [3441/3510] Building CXX object Source...t.dir/WebProcess/WebPage/WebPage.cpp.o In file included from DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:32, from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:25, from ../../Source/WebKit/config.h:47, from ../../Source/WebKit/WebProcess/WebPage/WebPage.cpp:28: ../../Source/WebKit/WebProcess/WebPage/WebPage.cpp: In member function ‘void WebKit::WebPage::setActivityState(WTF::OptionSet<WebCore::ActivityState::Flag>, WebKit::ActivityStateChangeID, const WTF::Vector<WebKit::CallbackID>&)’: ../../Source/WebKit/WebProcess/WebPage/WebPage.cpp:3048:33: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 6 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=] ASSERT_WITH_MESSAGE(m_page, "setActivityState called on %lld but WebCore page was null", pageID()); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~ DerivedSources/ForwardingHeaders/wtf/Assertions.h:391:99: note: in definition of macro ‘ASSERT_WITH_MESSAGE’ WTFReportAssertionFailureWithMessage(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, #assertion, __VA_ARGS__); \ ^~~~~~~~~~~ 1505826 6 mcatanzaro 2019-02-13 13:10:13 -0800 Committed r241453: <https://trac.webkit.org/changeset/241453> 361898 2019-02-12 22:55:49 -0800 2019-02-13 01:07:26 -0800 Adds a nullcheck bug-194584-20190212225549.patch text/plain 1403 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDEzNDcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTEyICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIGluIFBhZ2U6OnNldEFjdGl2 aXR5U3RhdGUgYmVjYXVzZSBtX3BhZ2UgaXMgbnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NTg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbnVsbCBjaGVjayB0byBhdm9pZCB0aGUgY3Jh c2guIEFsc28gYWRkIGEgZGVidWcgYXNzZXJ0aW9uIHRvIGhlbHAgZGlhZ25vc2UgdGhpcyBpbiB0 aGUgZnV0dXJlLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpzZXRBY3Rpdml0eVN0YXRlKToKKwogMjAxOS0wMi0x MiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViU2Vydmlj ZVdvcmtlclByb3ZpZGVyOjpoYW5kbGVGZXRjaCBubyBsb25nZXIgbmVlZHMgYSBDYWNoZWRSZXNv dXJjZSBwYXJhbWV0ZXIKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwCShyZXZpc2lvbiAyNDEzMzkpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzA0NSw3ICszMDQ1LDgg QEAgdm9pZCBXZWJQYWdlOjpzZXRBY3Rpdml0eVN0YXRlKE9wdGlvblNldAogICAgIGlmIChjaGFu Z2VkKQogICAgICAgICB1cGRhdGVUaHJvdHRsZVN0YXRlKCk7CiAKLSAgICB7CisgICAgQVNTRVJU X1dJVEhfTUVTU0FHRShtX3BhZ2UsICJzZXRBY3Rpdml0eVN0YXRlIGNhbGxlZCBvbiAlbGxkIGJ1 dCBXZWJDb3JlIHBhZ2Ugd2FzIG51bGwiLCBwYWdlSUQoKSk7CisgICAgaWYgKG1fcGFnZSkgewog ICAgICAgICBTZXRGb3JTY29wZTxib29sPiBjdXJyZW50bHlDaGFuZ2luZ0FjdGl2aXR5U3RhdGUg eyBtX2NoYW5naW5nQWN0aXZpdHlTdGF0ZSwgdHJ1ZSB9OwogICAgICAgICBtX3BhZ2UtPnNldEFj dGl2aXR5U3RhdGUoYWN0aXZpdHlTdGF0ZSk7CiAgICAgfQo=