194582 2019-02-12 22:06:53 -0800 Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction 2019-02-13 08:39:18 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa achristensen beidson cdumez dbates ews-watchlist ggaren japhet koivisto oldest_to_newest 1505606 0 rniwa 2019-02-12 22:06:53 -0800 We're hitting a release assertion in PolicyCheckIdentifier::isValidFor when WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction fails to send a sync IPC. 1505607 1 rniwa 2019-02-12 22:07:07 -0800 <rdar://problem/47941089> 1505613 2 361895 rniwa 2019-02-12 22:12:58 -0800 Created attachment 361895 Fixes the bug 1505660 3 361895 rniwa 2019-02-13 01:01:51 -0800 Comment on attachment 361895 Fixes the bug Clearing flags on attachment: 361895 Committed r241352: <https://trac.webkit.org/changeset/241352> 1505661 4 rniwa 2019-02-13 01:01:52 -0800 All reviewed patches have been landed. Closing bug. 1505724 5 cdumez 2019-02-13 08:39:18 -0800 Not even a PSON bug :P 361895 2019-02-12 22:12:58 -0800 2019-02-13 01:01:51 -0800 Fixes the bug bug-194582-20190212221257.patch text/plain 4164 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MTMyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAyLTEyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbGVhc2UgYXNzZXJ0IGluIFBv bGljeUNoZWNrSWRlbnRpZmllcjo6aXNWYWxpZEZvciB2aWEgV2ViRnJhbWVMb2FkZXJDbGllbnQ6 OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NTgyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgdGhlIHplcm8tbmVzcyBvZiBt X3BvbGljeUNoZWNrIGZpcnN0IHNvIHRoYXQgd2UgY2FuIGRpZmZlcmVudGlhdGUgcHJvY2VzcyBJ RCBiZWluZyB3cm9uZworICAgICAgICBmcm9tIHRoZSBub24tZ2VuZXJhdGVkIGlkZW50aWZpZXIg YmVpbmcgc2VudCB0byB1cyBhcyBpdCB3YXMgdGhlIGNhc2UgaW4gdGhpcyBmYWlsdXJlLgorCisg ICAgICAgICogbG9hZGVyL1BvbGljeUNoZWNrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9s aWN5Q2hlY2tJZGVudGlmaWVyOjppc1ZhbGlkRm9yKToKKwogMjAxOS0wMi0xMiAgV2Vuc29uIEhz aWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxvdyBwYWdlcyB0byB0 cmlnZ2VyIHByb2dyYW1tYXRpYyBwYXN0ZSBmcm9tIHNjcmlwdCBvbiBpT1MKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2xvYWRlci9Qb2xpY3lDaGVja2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9sb2FkZXIvUG9saWN5Q2hlY2tlci5jcHAJKHJldmlzaW9uIDI0MTMyMikKKysrIFNv dXJjZS9XZWJDb3JlL2xvYWRlci9Qb2xpY3lDaGVja2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt ODAsOCArODAsOCBAQCBQb2xpY3lDaGVja0lkZW50aWZpZXIgUG9saWN5Q2hlY2tJZGVudGlmCiAK IGJvb2wgUG9saWN5Q2hlY2tJZGVudGlmaWVyOjppc1ZhbGlkRm9yKFBvbGljeUNoZWNrSWRlbnRp ZmllciBleHBlY3RlZElkZW50aWZpZXIpCiB7Ci0gICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9NRVNT QUdFKG1fcHJvY2VzcyA9PSBleHBlY3RlZElkZW50aWZpZXIubV9wcm9jZXNzLCAiUmVjZWl2ZWQg YSBwb2xpY3kgY2hlY2sgcmVzcG9uc2UgZm9yIGEgd3JvbmcgcHJvY2VzcyIpOwogICAgIFJFTEVB U0VfQVNTRVJUX1dJVEhfTUVTU0FHRShtX3BvbGljeUNoZWNrLCAiUmVjZWl2ZWQgMCBhcyB0aGUg cG9saWN5IGNoZWNrIGlkZW50aWZpZXIiKTsKKyAgICBSRUxFQVNFX0FTU0VSVF9XSVRIX01FU1NB R0UobV9wcm9jZXNzID09IGV4cGVjdGVkSWRlbnRpZmllci5tX3Byb2Nlc3MsICJSZWNlaXZlZCBh IHBvbGljeSBjaGVjayByZXNwb25zZSBmb3IgYSB3cm9uZyBwcm9jZXNzIik7CiAgICAgUkVMRUFT RV9BU1NFUlRfV0lUSF9NRVNTQUdFKG1fcG9saWN5Q2hlY2sgPD0gZXhwZWN0ZWRJZGVudGlmaWVy Lm1fcG9saWN5Q2hlY2ssICJSZWNlaXZlZCBhIHBvbGljeSBjaGVjayByZXNwb25zZSBmcm9tIHRo ZSBmdXR1cmUiKTsKICAgICByZXR1cm4gbV9wb2xpY3lDaGVjayA9PSBleHBlY3RlZElkZW50aWZp ZXIubV9wb2xpY3lDaGVjazsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDEzMzkpCisrKyBT b3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisy MDE5LTAyLTEyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJl bGVhc2UgYXNzZXJ0IGluIFBvbGljeUNoZWNrSWRlbnRpZmllcjo6aXNWYWxpZEZvciB2aWEgV2Vi RnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlv bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NTgy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJ1 ZyB3YXMgY2F1c2VkIGJ5IFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERlY2lkZVBvbGlj eUZvck5hdmlnYXRpb25BY3Rpb24gaW52b2tpbmcgdGhlIGNhbGxiYWNrCisgICAgICAgIHdpdGgg cmVzcG9uc2VJZGVudGlmaWVyIGV2ZW4gd2hlbiB3ZSBoYWQgZmFpbGVkIHRvIHNlbmQgdGhlIHBv bGljeSBjaGVjayBJUEMuIENsZWFybHksIHJlc3BvbnNlSWRlbnRpZmllcgorICAgICAgICBpcyBp bnZhbGlkIGluIHRoYXQgY2FzZSwgYW5kIHdlIHNob3VsZCBiZSB1c2luZyByZXF1ZXN0SWRlbnRp ZmllciBpbnN0ZWFkLgorCisgICAgICAgIFVuZm9ydHVuYXRlbHkgbm8gbmV3IHRlc3RzIHNpbmNl IEknbSBub3QgYXdhcmUgb2YgYSB3YXkgdG8gbWFrZSBzZW5kU3luYyBmYWlsIGluIHRoaXMgY2Fz ZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJD bGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0 Y2hEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKToKKwogMjAxOS0wMi0xMiAgWW91ZW5u IEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViU2VydmljZVdvcmtlclBy b3ZpZGVyOjpoYW5kbGVGZXRjaCBubyBsb25nZXIgbmVlZHMgYSBDYWNoZWRSZXNvdXJjZSBwYXJh bWV0ZXIKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJG cmFtZUxvYWRlckNsaWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAkocmV2aXNpb24gMjQx MzIyKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1l TG9hZGVyQ2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTExLDcgKzkxMSw3IEBAIHZvaWQg V2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGVjaWQKICAgICAgICAgICAgIHJlcXVlc3RJ ZGVudGlmaWVyLCBkb2N1bWVudExvYWRlci0+bmF2aWdhdGlvbklEKCksIG5hdmlnYXRpb25BY3Rp b25EYXRhLCBvcmlnaW5hdGluZ0ZyYW1lSW5mb0RhdGEsIG9yaWdpbmF0aW5nUGFnZUlELCBuYXZp Z2F0aW9uQWN0aW9uLnJlc291cmNlUmVxdWVzdCgpLCByZXF1ZXN0LAogICAgICAgICAgICAgSVBD OjpGb3JtRGF0YVJlZmVyZW5jZSB7IHJlcXVlc3QuaHR0cEJvZHkoKSB9LCByZWRpcmVjdFJlc3Bv bnNlLCBVc2VyRGF0YShXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS50cmFuc2Zvcm1PYmplY3RzVG9I YW5kbGVzKHVzZXJEYXRhLmdldCgpKS5nZXQoKSkpLAogICAgICAgICAgICAgTWVzc2FnZXM6Oldl YlBhZ2VQcm94eTo6RGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvblN5bmM6OlJlcGx5KHJl c3BvbnNlSWRlbnRpZmllciwgcG9saWN5QWN0aW9uLCBuZXdOYXZpZ2F0aW9uSUQsIGRvd25sb2Fk SUQsIHdlYnNpdGVQb2xpY2llcykpKSB7Ci0gICAgICAgICAgICBtX2ZyYW1lLT5kaWRSZWNlaXZl UG9saWN5RGVjaXNpb24obGlzdGVuZXJJRCwgcmVzcG9uc2VJZGVudGlmaWVyLCBQb2xpY3lBY3Rp b246Oklnbm9yZSwgMCwgeyB9LCB7IH0pOworICAgICAgICAgICAgbV9mcmFtZS0+ZGlkUmVjZWl2 ZVBvbGljeURlY2lzaW9uKGxpc3RlbmVySUQsIHJlcXVlc3RJZGVudGlmaWVyLCBQb2xpY3lBY3Rp b246Oklnbm9yZSwgMCwgeyB9LCB7IH0pOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9 CiAK