194581 2019-02-12 22:02:55 -0800 Remove unnecessary null check in bindings. 2019-02-12 23:14:24 -0800 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 194530 1 mark.lam mark.lam cdumez commit-queue darin webkit-bug-importer ysuzuki oldest_to_newest 1505605 0 mark.lam 2019-02-12 22:02:55 -0800 See https://bugs.webkit.org/show_bug.cgi?id=194530#c10: It is always save to call visitor.containsOpaqueRoot(root) with a null root pointer. It will just return false. Since we don't expect the root pointer to be null in the common case, having a null check here is also not be optimal. We'll remove this unneeded null check. 1505609 1 361893 mark.lam 2019-02-12 22:09:47 -0800 Created attachment 361893 proposed patch. 1505612 2 361894 mark.lam 2019-02-12 22:12:27 -0800 Created attachment 361894 proposed patch. 1505623 3 361894 ysuzuki 2019-02-12 22:47:19 -0800 Comment on attachment 361894 proposed patch. r=me 1505627 4 361894 commit-queue 2019-02-12 23:13:12 -0800 Comment on attachment 361894 proposed patch. Clearing flags on attachment: 361894 Committed r241348: <https://trac.webkit.org/changeset/241348> 1505628 5 commit-queue 2019-02-12 23:13:14 -0800 All reviewed patches have been landed. Closing bug. 1505629 6 webkit-bug-importer 2019-02-12 23:14:24 -0800 <rdar://problem/48029348> 361893 2019-02-12 22:09:47 -0800 2019-02-12 22:12:27 -0800 proposed patch. bug-194581.patch text/plain 2457 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MTMzOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE5LTAyLTEyICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgbnVs bCBjaGVjayBpbiBiaW5kaW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NDU4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEl0IGlzIGFsd2F5cyBzYXZlIHRvIGNhbGwgdmlzaXRvci5jb250YWluc09w YXF1ZVJvb3Qocm9vdCkgd2l0aCBhIG51bGwgcm9vdCBwb2ludGVyLgorICAgICAgICBJdCB3aWxs IGp1c3QgcmV0dXJuIGZhbHNlLiAgU2luY2Ugd2UgZG9uJ3QgZXhwZWN0IHRoZSByb290IHBvaW50 ZXIgdG8gYmUgbnVsbCBpbgorICAgICAgICBoZSBjb21tb24gY2FzZSwgaGF2aW5nIGEgbnVsbCBj aGVjayBoZXJlIGlzIGFsc28gbm90IGJlIG9wdGltYWwuICBXZSdsbCByZW1vdmUgdGhpcworICAg ICAgICB1bm5lZWRlZCBudWxsIGNoZWNrLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChHZW5lcmF0ZUltcGxlbWVudGF0aW9uKToKKyAg ICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0R2VuZXJhdGVJc1JlYWNoYWJs ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU1Rlc3RHZW5lcmF0ZUlzUmVhY2hhYmxlT3duZXI6 OmlzUmVhY2hhYmxlRnJvbU9wYXF1ZVJvb3RzKToKKwogMjAxOS0wMi0xMiAgUm9iIEJ1aXMgIDxy YnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEFsaWduIHdpdGggRmV0Y2ggb24gZGF0YTogVVJM cwpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMu cG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9ySlMucG0JKHJldmlzaW9uIDI0MTMxNikKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCSh3b3JraW5nIGNvcHkpCkBAIC00Njc5LDcgKzQ2 NzksNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogICAgICAgICAgICAgfQogCiAgICAg ICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgJHJvb3RTdHJpbmcpOwotICAgICAgICAgICAgcHVz aChAaW1wbENvbnRlbnQsICIgICAgcmV0dXJuIHJvb3QgJiYgdmlzaXRvci5jb250YWluc09wYXF1 ZVJvb3Qocm9vdCk7XG4iKTsKKyAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIHJl dHVybiB2aXNpdG9yLmNvbnRhaW5zT3BhcXVlUm9vdChyb290KTtcbiIpOwogICAgICAgICB9IGVs c2UgewogICAgICAgICAgICAgaWYgKCEkZW1pdHRlZEpTQ2FzdCkgewogICAgICAgICAgICAgICAg IHB1c2goQGltcGxDb250ZW50LCAiICAgIFVOVVNFRF9QQVJBTShoYW5kbGUpO1xuIik7CkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0R2VuZXJhdGVJ c1JlYWNoYWJsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L0pTL0pTVGVzdEdlbmVyYXRlSXNSZWFjaGFibGUuY3BwCShyZXZpc2lvbiAyNDEz MTYpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0R2Vu ZXJhdGVJc1JlYWNoYWJsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwNCw3ICsyMDQsNyBAQCBi b29sIEpTVGVzdEdlbmVyYXRlSXNSZWFjaGFibGVPd25lcjo6aXNSCiAgICAgVGVzdEdlbmVyYXRl SXNSZWFjaGFibGUqIHJvb3QgPSAmanNUZXN0R2VuZXJhdGVJc1JlYWNoYWJsZS0+d3JhcHBlZCgp OwogICAgIGlmIChVTkxJS0VMWShyZWFzb24pKQogICAgICAgICAqcmVhc29uID0gIlJlYWNoYWJs ZSBmcm9tIFRlc3RHZW5lcmF0ZUlzUmVhY2hhYmxlIjsKLSAgICByZXR1cm4gcm9vdCAmJiB2aXNp dG9yLmNvbnRhaW5zT3BhcXVlUm9vdChyb290KTsKKyAgICByZXR1cm4gdmlzaXRvci5jb250YWlu c09wYXF1ZVJvb3Qocm9vdCk7CiB9CiAKIHZvaWQgSlNUZXN0R2VuZXJhdGVJc1JlYWNoYWJsZU93 bmVyOjpmaW5hbGl6ZShKU0M6OkhhbmRsZTxKU0M6OlVua25vd24+IGhhbmRsZSwgdm9pZCogY29u dGV4dCkK 361894 2019-02-12 22:12:27 -0800 2019-02-12 23:13:12 -0800 proposed patch. bug-194581.patch text/plain 2455 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MTMzOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE5LTAyLTEyICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgbnVs bCBjaGVjayBpbiBiaW5kaW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NDU4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEl0IGlzIGFsd2F5cyBzYWZlIHRvIGNhbGwgdmlzaXRvci5jb250YWluc09w YXF1ZVJvb3Qocm9vdCkgd2l0aCBhIG51bGwgcm9vdCBwb2ludGVyLgorICAgICAgICBJdCB3aWxs IGp1c3QgcmV0dXJuIGZhbHNlLiAgU2luY2Ugd2UgZG9uJ3QgZXhwZWN0IHRoZSByb290IHBvaW50 ZXIgdG8gYmUgbnVsbCBpbgorICAgICAgICB0aGUgY29tbW9uIGNhc2UsIGhhdmluZyBhIG51bGwg Y2hlY2sgaGVyZSBpcyBhbHNvIG5vdCBvcHRpbWFsLiAgV2UnbGwgcmVtb3ZlIHRoaXMKKyAgICAg ICAgdW5uZWVkZWQgbnVsbCBjaGVjay4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisgICAg ICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdEdlbmVyYXRlSXNSZWFjaGFibGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNUZXN0R2VuZXJhdGVJc1JlYWNoYWJsZU93bmVyOjpp c1JlYWNoYWJsZUZyb21PcGFxdWVSb290cyk6CisKIDIwMTktMDItMTIgIFJvYiBCdWlzICA8cmJ1 aXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBBbGlnbiB3aXRoIEZldGNoIG9uIGRhdGE6IFVSTHMK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBt Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckpTLnBtCShyZXZpc2lvbiAyNDEzMTYpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQkod29ya2luZyBjb3B5KQpAQCAtNDY3OSw3ICs0Njc5 LDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgICAgIH0KIAogICAgICAg ICAgICAgcHVzaChAaW1wbENvbnRlbnQsICRyb290U3RyaW5nKTsKLSAgICAgICAgICAgIHB1c2go QGltcGxDb250ZW50LCAiICAgIHJldHVybiByb290ICYmIHZpc2l0b3IuY29udGFpbnNPcGFxdWVS b290KHJvb3QpO1xuIik7CisgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICByZXR1 cm4gdmlzaXRvci5jb250YWluc09wYXF1ZVJvb3Qocm9vdCk7XG4iKTsKICAgICAgICAgfSBlbHNl IHsKICAgICAgICAgICAgIGlmICghJGVtaXR0ZWRKU0Nhc3QpIHsKICAgICAgICAgICAgICAgICBw dXNoKEBpbXBsQ29udGVudCwgIiAgICBVTlVTRURfUEFSQU0oaGFuZGxlKTtcbiIpOwpJbmRleDog U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdEdlbmVyYXRlSXNS ZWFjaGFibGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvdGVzdC9KUy9KU1Rlc3RHZW5lcmF0ZUlzUmVhY2hhYmxlLmNwcAkocmV2aXNpb24gMjQxMzE2 KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdEdlbmVy YXRlSXNSZWFjaGFibGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDQsNyArMjA0LDcgQEAgYm9v bCBKU1Rlc3RHZW5lcmF0ZUlzUmVhY2hhYmxlT3duZXI6OmlzUgogICAgIFRlc3RHZW5lcmF0ZUlz UmVhY2hhYmxlKiByb290ID0gJmpzVGVzdEdlbmVyYXRlSXNSZWFjaGFibGUtPndyYXBwZWQoKTsK ICAgICBpZiAoVU5MSUtFTFkocmVhc29uKSkKICAgICAgICAgKnJlYXNvbiA9ICJSZWFjaGFibGUg ZnJvbSBUZXN0R2VuZXJhdGVJc1JlYWNoYWJsZSI7Ci0gICAgcmV0dXJuIHJvb3QgJiYgdmlzaXRv ci5jb250YWluc09wYXF1ZVJvb3Qocm9vdCk7CisgICAgcmV0dXJuIHZpc2l0b3IuY29udGFpbnNP cGFxdWVSb290KHJvb3QpOwogfQogCiB2b2lkIEpTVGVzdEdlbmVyYXRlSXNSZWFjaGFibGVPd25l cjo6ZmluYWxpemUoSlNDOjpIYW5kbGU8SlNDOjpVbmtub3duPiBoYW5kbGUsIHZvaWQqIGNvbnRl eHQpCg==