<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>194577</bug_id>
          
          <creation_ts>2019-02-12 17:58:22 -0800</creation_ts>
          <short_desc>JSScript needs to retain its cache path NSURL*</short_desc>
          <delta_ts>2019-02-12 22:35:24 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>gskachkov</cc>
    
    <cc>guijemont</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>rmorisset</cc>
    
    <cc>thorton</cc>
    
    <cc>ticaiolima</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1505549</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-02-12 17:58:22 -0800</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505555</commentid>
    <comment_count>1</comment_count>
      <attachid>361882</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-02-12 18:09:57 -0800</bug_when>
    <thetext>Created attachment 361882
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505560</commentid>
    <comment_count>2</comment_count>
      <attachid>361882</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-02-12 18:12:27 -0800</bug_when>
    <thetext>Comment on attachment 361882
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361882&amp;action=review

&gt; Source/JavaScriptCore/API/JSScript.mm:109
&gt; +    result-&gt;m_cachePath = [cachePath retain];

Can we make m_cachePath be a retainPtr?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505561</commentid>
    <comment_count>3</comment_count>
      <attachid>361884</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-02-12 18:13:46 -0800</bug_when>
    <thetext>Created attachment 361884
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505562</commentid>
    <comment_count>4</comment_count>
      <attachid>361884</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2019-02-12 18:14:27 -0800</bug_when>
    <thetext>Comment on attachment 361884
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361884&amp;action=review

&gt; Source/JavaScriptCore/API/JSScript.mm:132
&gt; +    int fd = open(m_cachePath.get().path.UTF8String, O_RDONLY);

In WK2 we usually would just [m_cachePath path].UTF8String but it&apos;s up to you.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505564</commentid>
    <comment_count>5</comment_count>
      <attachid>361885</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-02-12 18:16:49 -0800</bug_when>
    <thetext>Created attachment 361885
patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505565</commentid>
    <comment_count>6</comment_count>
      <attachid>361884</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-02-12 18:17:03 -0800</bug_when>
    <thetext>Comment on attachment 361884
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361884&amp;action=review

&gt;&gt; Source/JavaScriptCore/API/JSScript.mm:132
&gt;&gt; +    int fd = open(m_cachePath.get().path.UTF8String, O_RDONLY);
&gt; 
&gt; In WK2 we usually would just [m_cachePath path].UTF8String but it&apos;s up to you.

Sounds good. Fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505566</commentid>
    <comment_count>7</comment_count>
      <attachid>361886</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-02-12 18:17:44 -0800</bug_when>
    <thetext>Created attachment 361886
patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505617</commentid>
    <comment_count>8</comment_count>
      <attachid>361886</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-12 22:34:49 -0800</bug_when>
    <thetext>Comment on attachment 361886
patch for landing

Clearing flags on attachment: 361886

Committed r241340: &lt;https://trac.webkit.org/changeset/241340&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505618</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-12 22:34:51 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505619</commentid>
    <comment_count>10</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-02-12 22:35:24 -0800</bug_when>
    <thetext>&lt;rdar://problem/48028610&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>361882</attachid>
            <date>2019-02-12 18:09:57 -0800</date>
            <delta_ts>2019-02-12 18:13:46 -0800</delta_ts>
            <desc>patch</desc>
            <filename>a-backup.diff</filename>
            <type>text/plain</type>
            <size>1575</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQxMzM0KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA
CisyMDE5LTAyLTEyICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IEpTU2NyaXB0IG5lZWRzIHRvIHJldGFpbiBpdHMgY2FjaGUgcGF0aCBOU1VSTCoKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDU3NworCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQVBJL0pTU2NyaXB0Lm1t
OgorICAgICAgICAoK1tKU1NjcmlwdCBzY3JpcHRGcm9tQVNDSUlGaWxlOmluVmlydHVhbE1hY2hp
bmU6d2l0aENvZGVTaWduaW5nOmFuZEJ5dGVjb2RlQ2FjaGU6XSk6CisgICAgICAgICgtW0pTU2Ny
aXB0IGRlYWxsb2NdKToKKwogMjAxOS0wMi0xMiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56
YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IC1XaW1wbGljaXQtZmFs
bHRocm91Z2ggd2FybmluZyBhZnRlciByMjQxMTQwCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvQVBJL0pTU2NyaXB0Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9B
UEkvSlNTY3JpcHQubW0JKHJldmlzaW9uIDI0MTMzNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9BUEkvSlNTY3JpcHQubW0JKHdvcmtpbmcgY29weSkKQEAgLTEwNiw3ICsxMDYsNyBAQCArIChp
bnN0YW5jZXR5cGUpc2NyaXB0RnJvbUFTQ0lJRmlsZTooTlNVCiAgICAgSlNTY3JpcHQgKnJlc3Vs
dCA9IFtbW0pTU2NyaXB0IGFsbG9jXSBpbml0XSBhdXRvcmVsZWFzZV07CiAgICAgcmVzdWx0LT5t
X3ZpcnR1YWxNYWNoaW5lID0gdm07CiAgICAgcmVzdWx0LT5tX3NvdXJjZSA9IFN0cmluZzo6ZnJv
bVVURjhXaXRoTGF0aW4xRmFsbGJhY2soYnVmZmVyLmRhdGEoKSwgYnVmZmVyLnNpemUoKSk7Ci0g
ICAgcmVzdWx0LT5tX2NhY2hlUGF0aCA9IGNhY2hlUGF0aDsKKyAgICByZXN1bHQtPm1fY2FjaGVQ
YXRoID0gW2NhY2hlUGF0aCByZXRhaW5dOwogICAgIFtyZXN1bHQgcmVhZENhY2hlXTsKICAgICBy
ZXR1cm4gcmVzdWx0OwogfQpAQCAtMTIwLDYgKzEyMCw5IEBAIC0gKHZvaWQpZGVhbGxvYwogewog
ICAgIGlmIChtX2NhY2hlZEJ5dGVjb2RlLnNpemUoKSAmJiAhbV9jYWNoZWRCeXRlY29kZS5vd25l
ZCgpKQogICAgICAgICBtdW5tYXAoY29uc3RfY2FzdDx2b2lkKj4obV9jYWNoZWRCeXRlY29kZS5k
YXRhKCkpLCBtX2NhY2hlZEJ5dGVjb2RlLnNpemUoKSk7CisKKyAgICBbbV9jYWNoZVBhdGggcmVs
ZWFzZV07CisKICAgICBbc3VwZXIgZGVhbGxvY107CiB9CiAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>361884</attachid>
            <date>2019-02-12 18:13:46 -0800</date>
            <delta_ts>2019-02-12 18:16:49 -0800</delta_ts>
            <desc>patch</desc>
            <filename>a-backup.diff</filename>
            <type>text/plain</type>
            <size>2141</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQxMzM0KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA
CisyMDE5LTAyLTEyICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IEpTU2NyaXB0IG5lZWRzIHRvIHJldGFpbiBpdHMgY2FjaGUgcGF0aCBOU1VSTCoKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDU3NworCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQVBJL0pTU2NyaXB0Lm1t
OgorICAgICAgICAoK1tKU1NjcmlwdCBzY3JpcHRGcm9tQVNDSUlGaWxlOmluVmlydHVhbE1hY2hp
bmU6d2l0aENvZGVTaWduaW5nOmFuZEJ5dGVjb2RlQ2FjaGU6XSk6CisgICAgICAgICgtW0pTU2Ny
aXB0IGRlYWxsb2NdKToKKwogMjAxOS0wMi0xMiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56
YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IC1XaW1wbGljaXQtZmFs
bHRocm91Z2ggd2FybmluZyBhZnRlciByMjQxMTQwCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvQVBJL0pTU2NyaXB0Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9B
UEkvSlNTY3JpcHQubW0JKHJldmlzaW9uIDI0MTMzNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9BUEkvSlNTY3JpcHQubW0JKHdvcmtpbmcgY29weSkKQEAgLTQyLDcgKzQyLDcgQEAKIEBpbXBs
ZW1lbnRhdGlvbiBKU1NjcmlwdCB7CiAgICAgX193ZWFrIEpTVmlydHVhbE1hY2hpbmUqIG1fdmly
dHVhbE1hY2hpbmU7CiAgICAgU3RyaW5nIG1fc291cmNlOwotICAgIE5TVVJMKiBtX2NhY2hlUGF0
aDsKKyAgICBSZXRhaW5QdHI8TlNVUkw+IG1fY2FjaGVQYXRoOwogICAgIEpTQzo6Q2FjaGVkQnl0
ZWNvZGUgbV9jYWNoZWRCeXRlY29kZTsKICAgICBKU0M6OlN0cm9uZzxKU0M6OkpTU291cmNlQ29k
ZT4gbV9qc1NvdXJjZUNvZGU7CiAgICAgVW5pcXVlZFN0cmluZ0ltcGwqIG1fbW9kdWxlS2V5OwpA
QCAtMTIwLDYgKzEyMCw3IEBAIC0gKHZvaWQpZGVhbGxvYwogewogICAgIGlmIChtX2NhY2hlZEJ5
dGVjb2RlLnNpemUoKSAmJiAhbV9jYWNoZWRCeXRlY29kZS5vd25lZCgpKQogICAgICAgICBtdW5t
YXAoY29uc3RfY2FzdDx2b2lkKj4obV9jYWNoZWRCeXRlY29kZS5kYXRhKCkpLCBtX2NhY2hlZEJ5
dGVjb2RlLnNpemUoKSk7CisKICAgICBbc3VwZXIgZGVhbGxvY107CiB9CiAKQEAgLTEyOCw3ICsx
MjksNyBAQCAtICh2b2lkKXJlYWRDYWNoZQogICAgIGlmICghbV9jYWNoZVBhdGgpCiAgICAgICAg
IHJldHVybjsKIAotICAgIGludCBmZCA9IG9wZW4obV9jYWNoZVBhdGgucGF0aC5VVEY4U3RyaW5n
LCBPX1JET05MWSk7CisgICAgaW50IGZkID0gb3BlbihtX2NhY2hlUGF0aC5nZXQoKS5wYXRoLlVU
RjhTdHJpbmcsIE9fUkRPTkxZKTsKICAgICBpZiAoZmQgPT0gLTEpCiAgICAgICAgIHJldHVybjsK
IApAQCAtMTYxLDcgKzE2Miw3IEBAIC0gKHZvaWQpd3JpdGVDYWNoZQogICAgIG1fY2FjaGVkQnl0
ZWNvZGUgPSBKU0M6OmdlbmVyYXRlTW9kdWxlQnl0ZWNvZGUobV92aXJ0dWFsTWFjaGluZS52bSwg
bV9qc1NvdXJjZUNvZGUtPnNvdXJjZUNvZGUoKSwgZXJyb3IpOwogICAgIGlmIChlcnJvci5pc1Zh
bGlkKCkpCiAgICAgICAgIHJldHVybjsKLSAgICBpbnQgZmQgPSBvcGVuKG1fY2FjaGVQYXRoLnBh
dGguVVRGOFN0cmluZywgT19DUkVBVCB8IE9fV1JPTkxZLCAwNjY2KTsKKyAgICBpbnQgZmQgPSBv
cGVuKG1fY2FjaGVQYXRoLmdldCgpLnBhdGguVVRGOFN0cmluZywgT19DUkVBVCB8IE9fV1JPTkxZ
LCAwNjY2KTsKICAgICBpZiAoZmQgPT0gLTEpCiAgICAgICAgIHJldHVybjsKICAgICBpbnQgcmMg
PSBmbG9jayhmZCwgTE9DS19FWCB8IExPQ0tfTkIpOwo=
</data>
<flag name="review"
          id="378527"
          type_id="1"
          status="+"
          setter="thorton"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>361885</attachid>
            <date>2019-02-12 18:16:49 -0800</date>
            <delta_ts>2019-02-12 18:17:44 -0800</delta_ts>
            <desc>patch for landing</desc>
            <filename>a-backup.diff</filename>
            <type>text/plain</type>
            <size>2129</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQxMzM0KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA
CisyMDE5LTAyLTEyICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IEpTU2NyaXB0IG5lZWRzIHRvIHJldGFpbiBpdHMgY2FjaGUgcGF0aCBOU1VSTCoKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDU3NworCisgICAgICAg
IFJldmlld2VkIGJ5IFRpbSBIb3J0b24uCisKKyAgICAgICAgKiBBUEkvSlNTY3JpcHQubW06Cisg
ICAgICAgICgrW0pTU2NyaXB0IHNjcmlwdEZyb21BU0NJSUZpbGU6aW5WaXJ0dWFsTWFjaGluZTp3
aXRoQ29kZVNpZ25pbmc6YW5kQnl0ZWNvZGVDYWNoZTpdKToKKyAgICAgICAgKC1bSlNTY3JpcHQg
ZGVhbGxvY10pOgorCiAyMDE5LTAyLTEyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9A
aWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggLVdpbXBsaWNpdC1mYWxsdGhy
b3VnaCB3YXJuaW5nIGFmdGVyIHIyNDExNDAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9B
UEkvSlNTY3JpcHQubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9K
U1NjcmlwdC5tbQkocmV2aXNpb24gMjQxMzM0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQ
SS9KU1NjcmlwdC5tbQkod29ya2luZyBjb3B5KQpAQCAtNDIsNyArNDIsNyBAQAogQGltcGxlbWVu
dGF0aW9uIEpTU2NyaXB0IHsKICAgICBfX3dlYWsgSlNWaXJ0dWFsTWFjaGluZSogbV92aXJ0dWFs
TWFjaGluZTsKICAgICBTdHJpbmcgbV9zb3VyY2U7Ci0gICAgTlNVUkwqIG1fY2FjaGVQYXRoOwor
ICAgIFJldGFpblB0cjxOU1VSTD4gbV9jYWNoZVBhdGg7CiAgICAgSlNDOjpDYWNoZWRCeXRlY29k
ZSBtX2NhY2hlZEJ5dGVjb2RlOwogICAgIEpTQzo6U3Ryb25nPEpTQzo6SlNTb3VyY2VDb2RlPiBt
X2pzU291cmNlQ29kZTsKICAgICBVbmlxdWVkU3RyaW5nSW1wbCogbV9tb2R1bGVLZXk7CkBAIC0x
MjAsNiArMTIwLDcgQEAgLSAodm9pZClkZWFsbG9jCiB7CiAgICAgaWYgKG1fY2FjaGVkQnl0ZWNv
ZGUuc2l6ZSgpICYmICFtX2NhY2hlZEJ5dGVjb2RlLm93bmVkKCkpCiAgICAgICAgIG11bm1hcChj
b25zdF9jYXN0PHZvaWQqPihtX2NhY2hlZEJ5dGVjb2RlLmRhdGEoKSksIG1fY2FjaGVkQnl0ZWNv
ZGUuc2l6ZSgpKTsKKwogICAgIFtzdXBlciBkZWFsbG9jXTsKIH0KIApAQCAtMTI4LDcgKzEyOSw3
IEBAIC0gKHZvaWQpcmVhZENhY2hlCiAgICAgaWYgKCFtX2NhY2hlUGF0aCkKICAgICAgICAgcmV0
dXJuOwogCi0gICAgaW50IGZkID0gb3BlbihtX2NhY2hlUGF0aC5wYXRoLlVURjhTdHJpbmcsIE9f
UkRPTkxZKTsKKyAgICBpbnQgZmQgPSBvcGVuKFttX2NhY2hlUGF0aCBwYXRoXS5VVEY4U3RyaW5n
LCBPX1JET05MWSk7CiAgICAgaWYgKGZkID09IC0xKQogICAgICAgICByZXR1cm47CiAKQEAgLTE2
MSw3ICsxNjIsNyBAQCAtICh2b2lkKXdyaXRlQ2FjaGUKICAgICBtX2NhY2hlZEJ5dGVjb2RlID0g
SlNDOjpnZW5lcmF0ZU1vZHVsZUJ5dGVjb2RlKG1fdmlydHVhbE1hY2hpbmUudm0sIG1fanNTb3Vy
Y2VDb2RlLT5zb3VyY2VDb2RlKCksIGVycm9yKTsKICAgICBpZiAoZXJyb3IuaXNWYWxpZCgpKQog
ICAgICAgICByZXR1cm47Ci0gICAgaW50IGZkID0gb3BlbihtX2NhY2hlUGF0aC5wYXRoLlVURjhT
dHJpbmcsIE9fQ1JFQVQgfCBPX1dST05MWSwgMDY2Nik7CisgICAgaW50IGZkID0gb3BlbihbbV9j
YWNoZVBhdGggcGF0aF0uVVRGOFN0cmluZywgT19DUkVBVCB8IE9fV1JPTkxZLCAwNjY2KTsKICAg
ICBpZiAoZmQgPT0gLTEpCiAgICAgICAgIHJldHVybjsKICAgICBpbnQgcmMgPSBmbG9jayhmZCwg
TE9DS19FWCB8IExPQ0tfTkIpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>361886</attachid>
            <date>2019-02-12 18:17:44 -0800</date>
            <delta_ts>2019-02-12 22:34:49 -0800</delta_ts>
            <desc>patch for landing</desc>
            <filename>a-backup.diff</filename>
            <type>text/plain</type>
            <size>1912</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQxMzM0KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA
CisyMDE5LTAyLTEyICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IEpTU2NyaXB0IG5lZWRzIHRvIHJldGFpbiBpdHMgY2FjaGUgcGF0aCBOU1VSTCoKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDU3NworCisgICAgICAg
IFJldmlld2VkIGJ5IFRpbSBIb3J0b24uCisKKyAgICAgICAgKiBBUEkvSlNTY3JpcHQubW06Cisg
ICAgICAgICgrW0pTU2NyaXB0IHNjcmlwdEZyb21BU0NJSUZpbGU6aW5WaXJ0dWFsTWFjaGluZTp3
aXRoQ29kZVNpZ25pbmc6YW5kQnl0ZWNvZGVDYWNoZTpdKToKKyAgICAgICAgKC1bSlNTY3JpcHQg
ZGVhbGxvY10pOgorCiAyMDE5LTAyLTEyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9A
aWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggLVdpbXBsaWNpdC1mYWxsdGhy
b3VnaCB3YXJuaW5nIGFmdGVyIHIyNDExNDAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9B
UEkvSlNTY3JpcHQubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9K
U1NjcmlwdC5tbQkocmV2aXNpb24gMjQxMzM0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQ
SS9KU1NjcmlwdC5tbQkod29ya2luZyBjb3B5KQpAQCAtNDIsNyArNDIsNyBAQAogQGltcGxlbWVu
dGF0aW9uIEpTU2NyaXB0IHsKICAgICBfX3dlYWsgSlNWaXJ0dWFsTWFjaGluZSogbV92aXJ0dWFs
TWFjaGluZTsKICAgICBTdHJpbmcgbV9zb3VyY2U7Ci0gICAgTlNVUkwqIG1fY2FjaGVQYXRoOwor
ICAgIFJldGFpblB0cjxOU1VSTD4gbV9jYWNoZVBhdGg7CiAgICAgSlNDOjpDYWNoZWRCeXRlY29k
ZSBtX2NhY2hlZEJ5dGVjb2RlOwogICAgIEpTQzo6U3Ryb25nPEpTQzo6SlNTb3VyY2VDb2RlPiBt
X2pzU291cmNlQ29kZTsKICAgICBVbmlxdWVkU3RyaW5nSW1wbCogbV9tb2R1bGVLZXk7CkBAIC0x
MjgsNyArMTI4LDcgQEAgLSAodm9pZClyZWFkQ2FjaGUKICAgICBpZiAoIW1fY2FjaGVQYXRoKQog
ICAgICAgICByZXR1cm47CiAKLSAgICBpbnQgZmQgPSBvcGVuKG1fY2FjaGVQYXRoLnBhdGguVVRG
OFN0cmluZywgT19SRE9OTFkpOworICAgIGludCBmZCA9IG9wZW4oW21fY2FjaGVQYXRoIHBhdGhd
LlVURjhTdHJpbmcsIE9fUkRPTkxZKTsKICAgICBpZiAoZmQgPT0gLTEpCiAgICAgICAgIHJldHVy
bjsKIApAQCAtMTYxLDcgKzE2MSw3IEBAIC0gKHZvaWQpd3JpdGVDYWNoZQogICAgIG1fY2FjaGVk
Qnl0ZWNvZGUgPSBKU0M6OmdlbmVyYXRlTW9kdWxlQnl0ZWNvZGUobV92aXJ0dWFsTWFjaGluZS52
bSwgbV9qc1NvdXJjZUNvZGUtPnNvdXJjZUNvZGUoKSwgZXJyb3IpOwogICAgIGlmIChlcnJvci5p
c1ZhbGlkKCkpCiAgICAgICAgIHJldHVybjsKLSAgICBpbnQgZmQgPSBvcGVuKG1fY2FjaGVQYXRo
LnBhdGguVVRGOFN0cmluZywgT19DUkVBVCB8IE9fV1JPTkxZLCAwNjY2KTsKKyAgICBpbnQgZmQg
PSBvcGVuKFttX2NhY2hlUGF0aCBwYXRoXS5VVEY4U3RyaW5nLCBPX0NSRUFUIHwgT19XUk9OTFks
IDA2NjYpOwogICAgIGlmIChmZCA9PSAtMSkKICAgICAgICAgcmV0dXJuOwogICAgIGludCByYyA9
IGZsb2NrKGZkLCBMT0NLX0VYIHwgTE9DS19OQik7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>