194563 2019-02-12 16:22:09 -0800 Fix the Windows build after r241320 2019-02-12 17:08:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED DoNotImportToRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh jlewis3 ryanhaddad tsavell webkit-bug-importer oldest_to_newest 1505477 0 wenson_hsieh 2019-02-12 16:22:09 -0800 Filing a bug so I can test my change against the Windows EWS bot. 1505481 1 wenson_hsieh 2019-02-12 16:25:39 -0800 c:\cygwin\home\buildbot\worker\win10-debug\build\source\webcore\page\frame.cpp(689): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj] c:\cygwin\home\buildbot\worker\win10-debug\build\source\webcore\page\frame.cpp(689): warning C4715: 'WebCore::Frame::requestDOMPasteAccess': not all control paths return a value [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj] 1505482 2 361861 wenson_hsieh 2019-02-12 16:25:47 -0800 Created attachment 361861 Patch 1505483 3 361862 wenson_hsieh 2019-02-12 16:26:37 -0800 Created attachment 361862 Patch 1505516 4 wenson_hsieh 2019-02-12 17:08:10 -0800 It looks like Alex just landed a fix for this in r241331. 361861 2019-02-12 16:25:47 -0800 2019-02-12 16:26:33 -0800 Patch bug-194563-20190212162546.patch text/plain 1824 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA1MWE3YjM2NzYyMzVi NTYzNzI1ODA0YzllNjRhZjJkYjhiYTk3OS4uN2ExNjAzNzFjMGFjM2YyZjBlNmU4Njc3MzEyOTZj MTMwZjkyODI4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAyLTEyICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQs IHRyeSB0byBmaXggdGhlIFdpbmRvd3MgYnVpbGQgYWZ0ZXIgcjI0MTMyMAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NTYzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZyYW1lOjpyZXF1ZXN0RE9NUGFzdGVBY2Nlc3MpOgorCiAyMDE5LTAy LTEyICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHRyeSB0byBmaXggdGhlIGludGVybmFsIGlPUyBidWlsZCBhZnRlciByMjQxMzIx CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWUuY3BwCmluZGV4IGI1MWU0NDQ0MjU2Mzk2MmJlZGYzZDdiN2RhOWM2ZWJh ZWFlNzE0MzguLjM5ZThkYTVlNDkzMWQ1ZTEwMmQ5MTQ5MGI1NWEyZmRhNDYyYjAwMTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRnJhbWUuY3BwCkBAIC02NzYsMTYgKzY3NiwxNyBAQCBib29sIEZyYW1lOjpyZXF1ZXN0 RE9NUGFzdGVBY2Nlc3MoKQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBjYXNlIERPTVBhc3Rl QWNjZXNzUG9saWN5OjpEZW5pZWQ6CiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBjYXNlIERP TVBhc3RlQWNjZXNzUG9saWN5OjpOb3RSZXF1ZXN0ZWRZZXQ6IHsKLSAgICAgICAgYXV0byogY2xp ZW50ID0gbV9lZGl0b3ItPmNsaWVudCgpOwotICAgICAgICBpZiAoIWNsaWVudCkKLSAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKLQotICAgICAgICBib29sIGdyYW50ZWQgPSBjbGllbnQtPnJlcXVl c3RET01QYXN0ZUFjY2VzcygpOwotICAgICAgICBnZXN0dXJlVG9rZW4tPmRpZFJlcXVlc3RET01Q YXN0ZUFjY2VzcyhncmFudGVkKTsKLSAgICAgICAgcmV0dXJuIGdyYW50ZWQ7Ci0gICAgfQorICAg IGNhc2UgRE9NUGFzdGVBY2Nlc3NQb2xpY3k6Ok5vdFJlcXVlc3RlZFlldDoKKyAgICAgICAgYnJl YWs7CiAgICAgfQorCisgICAgYXV0byogY2xpZW50ID0gbV9lZGl0b3ItPmNsaWVudCgpOworICAg IGlmICghY2xpZW50KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBib29sIGdyYW50ZWQg PSBjbGllbnQtPnJlcXVlc3RET01QYXN0ZUFjY2VzcygpOworICAgIGdlc3R1cmVUb2tlbi0+ZGlk UmVxdWVzdERPTVBhc3RlQWNjZXNzKGdyYW50ZWQpOworICAgIHJldHVybiBncmFudGVkOwogfQog CiB2b2lkIEZyYW1lOjpzZXRQcmludGluZyhib29sIHByaW50aW5nLCBjb25zdCBGbG9hdFNpemUm IHBhZ2VTaXplLCBjb25zdCBGbG9hdFNpemUmIG9yaWdpbmFsUGFnZVNpemUsIGZsb2F0IG1heGlt dW1TaHJpbmtSYXRpbywgQWRqdXN0Vmlld1NpemVPck5vdCBzaG91bGRBZGp1c3RWaWV3U2l6ZSkK 361862 2019-02-12 16:26:37 -0800 2019-02-12 16:26:52 -0800 Patch bug-194563-20190212162635.patch text/plain 1785 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA1MWE3YjM2NzYyMzVi NTYzNzI1ODA0YzllNjRhZjJkYjhiYTk3OS4uYzMzYjcyNmVlNTI1ODE4Yjc1MTI5N2I2YmE1YTIw YzRmZGQwNWEyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDExIEBACisyMDE5LTAyLTEyICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQs IHRyeSB0byBmaXggdGhlIFdpbmRvd3MgYnVpbGQgYWZ0ZXIgcjI0MTMyMAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NTYzCisKKyAgICAgICAgKiBw YWdlL0ZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpyZXF1ZXN0RE9NUGFzdGVB Y2Nlc3MpOgorCiAyMDE5LTAyLTEyICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHRyeSB0byBmaXggdGhlIGludGVybmFsIGlPUyBi dWlsZCBhZnRlciByMjQxMzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCmluZGV4IGI1MWU0NDQ0MjU2Mzk2 MmJlZGYzZDdiN2RhOWM2ZWJhZWFlNzE0MzguLjM5ZThkYTVlNDkzMWQ1ZTEwMmQ5MTQ5MGI1NWEy ZmRhNDYyYjAwMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCkBAIC02NzYsMTYgKzY3NiwxNyBAQCBi b29sIEZyYW1lOjpyZXF1ZXN0RE9NUGFzdGVBY2Nlc3MoKQogICAgICAgICByZXR1cm4gdHJ1ZTsK ICAgICBjYXNlIERPTVBhc3RlQWNjZXNzUG9saWN5OjpEZW5pZWQ6CiAgICAgICAgIHJldHVybiBm YWxzZTsKLSAgICBjYXNlIERPTVBhc3RlQWNjZXNzUG9saWN5OjpOb3RSZXF1ZXN0ZWRZZXQ6IHsK LSAgICAgICAgYXV0byogY2xpZW50ID0gbV9lZGl0b3ItPmNsaWVudCgpOwotICAgICAgICBpZiAo IWNsaWVudCkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgICAgICBib29sIGdyYW50 ZWQgPSBjbGllbnQtPnJlcXVlc3RET01QYXN0ZUFjY2VzcygpOwotICAgICAgICBnZXN0dXJlVG9r ZW4tPmRpZFJlcXVlc3RET01QYXN0ZUFjY2VzcyhncmFudGVkKTsKLSAgICAgICAgcmV0dXJuIGdy YW50ZWQ7Ci0gICAgfQorICAgIGNhc2UgRE9NUGFzdGVBY2Nlc3NQb2xpY3k6Ok5vdFJlcXVlc3Rl ZFlldDoKKyAgICAgICAgYnJlYWs7CiAgICAgfQorCisgICAgYXV0byogY2xpZW50ID0gbV9lZGl0 b3ItPmNsaWVudCgpOworICAgIGlmICghY2xpZW50KQorICAgICAgICByZXR1cm4gZmFsc2U7CisK KyAgICBib29sIGdyYW50ZWQgPSBjbGllbnQtPnJlcXVlc3RET01QYXN0ZUFjY2VzcygpOworICAg IGdlc3R1cmVUb2tlbi0+ZGlkUmVxdWVzdERPTVBhc3RlQWNjZXNzKGdyYW50ZWQpOworICAgIHJl dHVybiBncmFudGVkOwogfQogCiB2b2lkIEZyYW1lOjpzZXRQcmludGluZyhib29sIHByaW50aW5n LCBjb25zdCBGbG9hdFNpemUmIHBhZ2VTaXplLCBjb25zdCBGbG9hdFNpemUmIG9yaWdpbmFsUGFn ZVNpemUsIGZsb2F0IG1heGltdW1TaHJpbmtSYXRpbywgQWRqdXN0Vmlld1NpemVPck5vdCBzaG91 bGRBZGp1c3RWaWV3U2l6ZSkK