194557 2019-02-12 14:24:43 -0800 Find on Page shouldn't zoom in on matches 2019-02-12 15:33:30 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue simon.fraser wenson_hsieh oldest_to_newest 1505402 0 thorton 2019-02-12 14:24:43 -0800 Find on Page shouldn't zoom in on matches 1505404 1 361841 thorton 2019-02-12 14:25:13 -0800 Created attachment 361841 Patch 1505405 2 thorton 2019-02-12 14:25:25 -0800 <rdar://problem/42087017> 1505406 3 thorton 2019-02-12 14:26:32 -0800 I waffled a bit about adding this to SmartMagnificationController since it is explicitly not magnification. But I'd rather there than a new message in one of the god classes, and I think we could rename and push SmartMagnificationController in the direction of being the standard "reveal stuff" mechanism instead of just being about smart magnification. 1505409 4 361841 wenson_hsieh 2019-02-12 14:27:30 -0800 Comment on attachment 361841 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361841&action=review r=mews > Source/WebKit/UIProcess/ios/SmartMagnificationController.mm:131 > +void SmartMagnificationController::scrollToRect(FloatPoint origin, FloatRect targetRect) Nit - could be const FloatPoint& and const FloatRect&. Do we also need WebCore:: here? 1505411 5 thorton 2019-02-12 14:31:41 -0800 (In reply to Wenson Hsieh from comment #4) > Comment on attachment 361841 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=361841&action=review > > r=mews Thankyou. > > Source/WebKit/UIProcess/ios/SmartMagnificationController.mm:131 > > +void SmartMagnificationController::scrollToRect(FloatPoint origin, FloatRect targetRect) > > Nit - could be const FloatPoint& and const FloatRect&. Could be but why do that when they fit in a register :P (/me channels andersca) > Do we also need WebCore:: here? No, there's a 'using namespace WebCore' inside the 'namespace WebKit' (which is fine). 1505446 6 361841 commit-queue 2019-02-12 15:33:29 -0800 Comment on attachment 361841 Patch Clearing flags on attachment: 361841 Committed r241323: <https://trac.webkit.org/changeset/241323> 1505447 7 commit-queue 2019-02-12 15:33:30 -0800 All reviewed patches have been landed. Closing bug. 361841 2019-02-12 14:25:13 -0800 2019-02-12 15:33:29 -0800 Patch bug-194557-20190212142512.patch text/plain 5280 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQyNTMzZTM1ZmM2MWVkOWYy NmY3ZTg2NDgxMTJiMDNiMWNiZTg4YTcuLjg4MmE1YWMwMDAyZjU3YzIwZjdlNTY1MTdmMGQ0NDNk OTRmZjViNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDItMTIgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRmluZCBvbiBQYWdlIHNo b3VsZG4ndCB6b29tIGluIG9uIG1hdGNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5NDU1NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDIwODcw MTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvaW9zL1NtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBV SVByb2Nlc3MvaW9zL1NtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXIubWVzc2FnZXMuaW46Cisg ICAgICAgICogVUlQcm9jZXNzL2lvcy9TbWFydE1hZ25pZmljYXRpb25Db250cm9sbGVyLm1tOgor ICAgICAgICAoV2ViS2l0OjpTbWFydE1hZ25pZmljYXRpb25Db250cm9sbGVyOjpzY3JvbGxUb1Jl Y3QpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvRmluZENvbnRyb2xsZXJJT1Mu bW06CisgICAgICAgIChXZWJLaXQ6OkZpbmRDb250cm9sbGVyOjp1cGRhdGVGaW5kSW5kaWNhdG9y KToKKyAgICAgICAgT25seSBzY3JvbGwgdG8gcmV2ZWFsIHRoZSBmaW5kIHJlc3VsdCwgZG8gbm90 IHpvb20gaW4uCisKIDIwMTktMDItMTEgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgW0NvY29hXSBXZWIgQXV0b21hdGlvbjogY2xpZW50IGNhbGxiYWNrcyBhcmUgbm90 IGNhbGxlZCBpZiBkZWxlZ2F0ZSBkb2VzIG5vdCBvdmVycmlkZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1NtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXIuaCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9TbWFydE1hZ25pZmljYXRpb25Db250cm9sbGVyLmgK aW5kZXggYzlhNTEzZjdkZDBmMGU3MTUxMjVmOTNmZGJmN2FlMWFjNzVlNWY5My4uZDE4YzYyMmQ4 MDBkYWE0ZDAyOWY5NGI2Y2E4YTY0Y2ZiM2Y0ZDFlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1NtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXIuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvU21hcnRNYWduaWZpY2F0aW9uQ29udHJvbGxlci5oCkBA IC01NCw2ICs1NCw3IEBAIHByaXZhdGU6CiAKICAgICB2b2lkIGRpZENvbGxlY3RHZW9tZXRyeUZv clNtYXJ0TWFnbmlmaWNhdGlvbkdlc3R1cmUoV2ViQ29yZTo6RmxvYXRQb2ludCBvcmlnaW4sIFdl YkNvcmU6OkZsb2F0UmVjdCByZW5kZXJSZWN0LCBXZWJDb3JlOjpGbG9hdFJlY3QgdmlzaWJsZUNv bnRlbnRCb3VuZHMsIGJvb2wgZml0RW50aXJlUmVjdCwgZG91YmxlIHZpZXdwb3J0TWluaW11bVNj YWxlLCBkb3VibGUgdmlld3BvcnRNYXhpbXVtU2NhbGUpOwogICAgIHZvaWQgbWFnbmlmeShXZWJD b3JlOjpGbG9hdFBvaW50IG9yaWdpbiwgV2ViQ29yZTo6RmxvYXRSZWN0IHRhcmdldFJlY3QsIFdl YkNvcmU6OkZsb2F0UmVjdCB2aXNpYmxlQ29udGVudFJlY3QsIGRvdWJsZSB2aWV3cG9ydE1pbmlt dW1TY2FsZSwgZG91YmxlIHZpZXdwb3J0TWF4aW11bVNjYWxlKTsKKyAgICB2b2lkIHNjcm9sbFRv UmVjdChXZWJDb3JlOjpGbG9hdFBvaW50IG9yaWdpbiwgV2ViQ29yZTo6RmxvYXRSZWN0IHRhcmdl dFJlY3QpOwogICAgIHZvaWQgYWRqdXN0U21hcnRNYWduaWZpY2F0aW9uVGFyZ2V0UmVjdEFuZFpv b21TY2FsZXMoYm9vbCBhZGRNYWduaWZpY2F0aW9uUGFkZGluZywgV2ViQ29yZTo6RmxvYXRSZWN0 JiB0YXJnZXRSZWN0LCBkb3VibGUmIG1pbmltdW1TY2FsZSwgZG91YmxlJiBtYXhpbXVtU2NhbGUp OwogCiAgICAgV2ViUGFnZVByb3h5JiBtX3dlYlBhZ2VQcm94eTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9TbWFydE1hZ25pZmljYXRpb25Db250cm9sbGVyLm1lc3Nh Z2VzLmluIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1NtYXJ0TWFnbmlmaWNhdGlvbkNv bnRyb2xsZXIubWVzc2FnZXMuaW4KaW5kZXggN2E3MWM5MzlkMDg5OGIzZDZlZDM3MzI4ZjEzMTA2 YzgyNjNmMjE2NS4uOWJiY2YxNWQ4NzU5YjQ3NzAxOGEyMDY4OTEzMzcwYTQ0Y2MyYTYwZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1NtYXJ0TWFnbmlmaWNhdGlvbkNv bnRyb2xsZXIubWVzc2FnZXMuaW4KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1Nt YXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXIubWVzc2FnZXMuaW4KQEAgLTI1LDYgKzI1LDcgQEAK IG1lc3NhZ2VzIC0+IFNtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXIgewogICAgIERpZENvbGxl Y3RHZW9tZXRyeUZvclNtYXJ0TWFnbmlmaWNhdGlvbkdlc3R1cmUoV2ViQ29yZTo6RmxvYXRQb2lu dCBvcmlnaW4sIFdlYkNvcmU6OkZsb2F0UmVjdCByZW5kZXJSZWN0LCBXZWJDb3JlOjpGbG9hdFJl Y3QgdmlzaWJsZUNvbnRlbnRCb3VuZHMsIGJvb2wgZml0RW50aXJlUmVjdCwgZG91YmxlIHZpZXdw b3J0TWluaW11bVNjYWxlLCBkb3VibGUgdmlld3BvcnRNYXhpbXVtU2NhbGUpCiAgICAgTWFnbmlm eShXZWJDb3JlOjpGbG9hdFBvaW50IG9yaWdpbiwgV2ViQ29yZTo6RmxvYXRSZWN0IHRhcmdldFJl Y3QsIFdlYkNvcmU6OkZsb2F0UmVjdCB2aXNpYmxlQ29udGVudFJlY3QsIGRvdWJsZSB2aWV3cG9y dE1pbmltdW1TY2FsZSwgZG91YmxlIHZpZXdwb3J0TWF4aW11bVNjYWxlKQorICAgIFNjcm9sbFRv UmVjdChXZWJDb3JlOjpGbG9hdFBvaW50IG9yaWdpbiwgV2ViQ29yZTo6RmxvYXRSZWN0IHRhcmdl dFJlY3QpCiB9CiAKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL1NtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvU21hcnRNYWduaWZpY2F0aW9uQ29udHJvbGxlci5tbQppbmRleCA5Y2ExNGRjMGQx OTUzMzAyMjExNmJmNWUwMWE5ZWEwODAxZDMyMDM4Li5mODg0MzBiMGI4NWJmZmEyZjk2ZjMwNTU1 ZDA4YWZiY2RhMDljZjQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv U21hcnRNYWduaWZpY2F0aW9uQ29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvU21hcnRNYWduaWZpY2F0aW9uQ29udHJvbGxlci5tbQpAQCAtMTI4LDYgKzEyOCwx MSBAQCB2b2lkIFNtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXI6Om1hZ25pZnkoRmxvYXRQb2lu dCBvcmlnaW4sIEZsb2F0UmVjdCB0YXJnZXRSZQogICAgIFttX2NvbnRlbnRWaWV3IF96b29tVG9S ZWN0OnRhcmdldFJlY3Qgd2l0aE9yaWdpbjpvcmlnaW4gZml0RW50aXJlUmVjdDpOTyBtaW5pbXVt U2NhbGU6bWluaW11bVNjYWxlIG1heGltdW1TY2FsZTptYXhpbXVtU2NhbGUgbWluaW11bVNjcm9s bERpc3RhbmNlOjBdOwogfQogCit2b2lkIFNtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXI6OnNj cm9sbFRvUmVjdChGbG9hdFBvaW50IG9yaWdpbiwgRmxvYXRSZWN0IHRhcmdldFJlY3QpCit7Cisg ICAgW21fY29udGVudFZpZXcgX3Njcm9sbFRvUmVjdDp0YXJnZXRSZWN0IHdpdGhPcmlnaW46b3Jp Z2luIG1pbmltdW1TY3JvbGxEaXN0YW5jZTowXTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0 CiAKICNlbmRpZiAvLyBQTEFURk9STShJT1NfRkFNSUxZKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL0ZpbmRDb250cm9sbGVySU9TLm1tIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL0ZpbmRDb250cm9sbGVySU9TLm1tCmluZGV4 IDNjMWIwZWFjNWVmMThjMjI4NzFiNzhjZDlkNDM1MmJmZTU1NjIyNmQuLmRjYjY0ZTkzM2M0MjA5 MWU1NmY0MDIyMDJhMjE4Yzg4MTA3MWM2ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9XZWJQYWdlL2lvcy9GaW5kQ29udHJvbGxlcklPUy5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvRmluZENvbnRyb2xsZXJJT1MubW0KQEAgLTEwNiwx NSArMTA2LDEyIEBAIGJvb2wgRmluZENvbnRyb2xsZXI6OnVwZGF0ZUZpbmRJbmRpY2F0b3IoRnJh bWUmIHNlbGVjdGVkRnJhbWUsIGJvb2wgaXNTaG93aW5nT3ZlCiAgICAgbV9maW5kSW5kaWNhdG9y T3ZlcmxheS0+c2V0TmVlZHNEaXNwbGF5KCk7CiAKICAgICBpZiAoc2hvdWxkQW5pbWF0ZSkgewot ICAgICAgICBGbG9hdFJlY3QgdmlzaWJsZUNvbnRlbnRSZWN0ID0gbV93ZWJQYWdlLT5tYWluRnJh bWVWaWV3KCktPnVub2JzY3VyZWRDb250ZW50UmVjdEluY2x1ZGluZ1Njcm9sbGJhcnMoKTsKLQog ICAgICAgICBib29sIGlzUmVwbGFjZWQ7CiAgICAgICAgIGNvbnN0IFZpc2libGVTZWxlY3Rpb24m IHZpc2libGVTZWxlY3Rpb24gPSBzZWxlY3RlZEZyYW1lLnNlbGVjdGlvbigpLnNlbGVjdGlvbigp OwogICAgICAgICBGbG9hdFJlY3QgcmVuZGVyUmVjdCA9IHZpc2libGVTZWxlY3Rpb24uc3RhcnQo KS5jb250YWluZXJOb2RlKCktPnJlbmRlclJlY3QoJmlzUmVwbGFjZWQpOwotCiAgICAgICAgIElu dFJlY3Qgc3RhcnRSZWN0ID0gdmlzaWJsZVNlbGVjdGlvbi52aXNpYmxlU3RhcnQoKS5hYnNvbHV0 ZUNhcmV0Qm91bmRzKCk7CiAKLSAgICAgICAgbV93ZWJQYWdlLT5zZW5kKE1lc3NhZ2VzOjpTbWFy dE1hZ25pZmljYXRpb25Db250cm9sbGVyOjpNYWduaWZ5KHN0YXJ0UmVjdC5jZW50ZXIoKSwgcmVu ZGVyUmVjdCwgdmlzaWJsZUNvbnRlbnRSZWN0LCBtX3dlYlBhZ2UtPm1pbmltdW1QYWdlU2NhbGVG YWN0b3IoKSwgbV93ZWJQYWdlLT5tYXhpbXVtUGFnZVNjYWxlRmFjdG9yKCkpKTsKKyAgICAgICAg bV93ZWJQYWdlLT5zZW5kKE1lc3NhZ2VzOjpTbWFydE1hZ25pZmljYXRpb25Db250cm9sbGVyOjpT Y3JvbGxUb1JlY3Qoc3RhcnRSZWN0LmNlbnRlcigpLCByZW5kZXJSZWN0KSk7CiAgICAgfQogCiAg ICAgbV9pc1Nob3dpbmdGaW5kSW5kaWNhdG9yID0gdHJ1ZTsK