194554 2019-02-12 13:05:41 -0800 webkitpy: No option to only show unexpected failures in results.html for iPad 2019-02-12 13:53:08 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn lforschler oldest_to_newest 1505352 0 jbedard 2019-02-12 13:05:41 -0800 results.html for iPad should have an option to hid unexpected results. The root cause of this problem is the fact that Port.uses_test_expectations_file() returns 'false' for iPhone and iPad because the iphone-simulator and ipad-simulator directories do not exist. 1505353 1 jbedard 2019-02-12 13:05:55 -0800 <rdar://problem/47922442> 1505369 2 361828 jbedard 2019-02-12 13:27:45 -0800 Created attachment 361828 Patch 1505372 3 361828 aakash_jain 2019-02-12 13:31:47 -0800 Comment on attachment 361828 Patch rs=me 1505374 4 361830 jbedard 2019-02-12 13:34:46 -0800 Created attachment 361830 Patch for landing 1505388 5 361830 commit-queue 2019-02-12 13:53:06 -0800 Comment on attachment 361830 Patch for landing Clearing flags on attachment: 361830 Committed r241318: <https://trac.webkit.org/changeset/241318> 1505389 6 commit-queue 2019-02-12 13:53:08 -0800 All reviewed patches have been landed. Closing bug. 361828 2019-02-12 13:27:45 -0800 2019-02-12 13:34:44 -0800 Patch bug-194554-20190212132745.patch text/plain 2801 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MTMxNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE5LTAyLTEyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogTm8gb3B0aW9uIHRvIG9ubHkgc2hvdyB1bmV4cGVjdGVk IGZhaWx1cmVzIGluIHJlc3VsdHMuaHRtbCBmb3IgaVBhZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NTU0CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS80NzkyMjQ0Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBKdXN0IGJlY2F1c2UgYSBUZXN0RXhwZWNhdGlvbnMgZmlsZSBkb2VzIG5vdCBleGlzdCBm b3IgYSBzcGVjaWZpYyBwbGF0Zm9ybSBkb2VzIG5vdCBtZWFuIHRoYXQKKyAgICAgICAgVGVzdEV4 cGVjYXRpb25zIGFyZSBub3QgYmVpbmcgdXNlZCwgZ2l2ZW4gdGhhdCBwbGF0Zm9ybXMgaW5oZXJp dCB0ZXN0IGV4cGVjdGF0aW9ucy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9i YXNlLnB5OgorICAgICAgICAoUG9ydC51c2VzX3Rlc3RfZXhwZWN0YXRpb25zX2ZpbGUpOiBDaGVj ayBhbGwgcG9zc2libGUgbG9jYXRpb25zIG9mIGEgVGVzdEV4cGVjdGF0aW9ucyBmaWxlLgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5OgorICAgICAgICAo UG9ydFRlc3QudGVzdF91c2VzX3Rlc3RfZXhwZWN0YXRpb25zX2ZpbGUpOgorCiAyMDE5LTAyLTEy ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAg V2ViUGFnZTo6Y2xvc2UgbmVlZHMgdG8gcmVtb3ZlIGFsbCBtZXNzYWdlIHJlY2VpdmVycyBhc3Nv Y2lhdGVkIHdpdGggdGhhdCBXZWJQYWdlLCBub3QgV2ViUGFnZTo6fldlYlBhZ2UKSW5kZXg6IFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5CShyZXZpc2lvbiAyNDEzMDYpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQkod29ya2luZyBjb3B5KQpAQCAtMTE1Nyw3ICsx MTU3LDEwIEBAIGNsYXNzIFBvcnQob2JqZWN0KToKICAgICBkZWYgdXNlc190ZXN0X2V4cGVjdGF0 aW9uc19maWxlKHNlbGYpOgogICAgICAgICAjIFRoaXMgaXMgZGlmZmVyZW50IGZyb20gY2hlY2tp bmcgdGVzdF9leHBlY3RhdGlvbnMoKSBpcyBOb25lLCBiZWNhdXNlCiAgICAgICAgICMgc29tZSBw b3J0cyBoYXZlIFNraXBwZWQgZmlsZXMgd2hpY2ggYXJlIHJldHVybmVkIGFzIHBhcnQgb2YgdGVz dF9leHBlY3RhdGlvbnMoKS4KLSAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3Rz KHNlbGYucGF0aF90b190ZXN0X2V4cGVjdGF0aW9uc19maWxlKCkpCisgICAgICAgIGZvciBwYXRo IGluIHNlbGYuZGVmYXVsdF9iYXNlbGluZV9zZWFyY2hfcGF0aCgpOgorICAgICAgICAgICAgaWYg c2VsZi5fZmlsZXN5c3RlbS5leGlzdHMoc2VsZi5fZmlsZXN5c3RlbS5qb2luKHBhdGgsICdUZXN0 RXhwZWN0YXRpb25zJykpOgorICAgICAgICAgICAgICAgIHJldHVybiBUcnVlCisgICAgICAgIHJl dHVybiBGYWxzZQogCiAgICAgZGVmIHdhcm5faWZfYnVnX21pc3NpbmdfaW5fdGVzdF9leHBlY3Rh dGlvbnMoc2VsZik6CiAgICAgICAgIHJldHVybiBGYWxzZQpJbmRleDogVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L2Jhc2VfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L2Jhc2VfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI0MTMwNikKKysrIFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkp CkBAIC0yMjUsOSArMjI1LDggQEAgY2xhc3MgUG9ydFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgog ICAgIGRlZiB0ZXN0X3VzZXNfdGVzdF9leHBlY3RhdGlvbnNfZmlsZShzZWxmKToKICAgICAgICAg cG9ydCA9IHNlbGYubWFrZV9wb3J0KHBvcnRfbmFtZT0nZm9vJykKICAgICAgICAgcG9ydC5wb3J0 X25hbWUgPSAnZm9vJwotICAgICAgICBwb3J0LnBhdGhfdG9fdGVzdF9leHBlY3RhdGlvbnNfZmls ZSA9IGxhbWJkYTogJy9tb2NrLXJlc3VsdHMvVGVzdEV4cGVjdGF0aW9ucycKICAgICAgICAgc2Vs Zi5hc3NlcnRGYWxzZShwb3J0LnVzZXNfdGVzdF9leHBlY3RhdGlvbnNfZmlsZSgpKQotICAgICAg ICBwb3J0Ll9maWxlc3lzdGVtID0gTW9ja0ZpbGVTeXN0ZW0oeycvbW9jay1yZXN1bHRzL1Rlc3RF eHBlY3RhdGlvbnMnOiAnJ30pCisgICAgICAgIHBvcnQuX2ZpbGVzeXN0ZW0gPSBNb2NrRmlsZVN5 c3RlbSh7Jy9tb2NrLWNoZWNrb3V0L0xheW91dFRlc3RzL3BsYXRmb3JtL2Zvby9UZXN0RXhwZWN0 YXRpb25zJzogJyd9KQogICAgICAgICBzZWxmLmFzc2VydFRydWUocG9ydC51c2VzX3Rlc3RfZXhw ZWN0YXRpb25zX2ZpbGUoKSkKIAogICAgIGRlZiB0ZXN0X2ZpbmRfbm9fcGF0aHNfc3BlY2lmaWVk KHNlbGYpOgo= 361830 2019-02-12 13:34:46 -0800 2019-02-12 13:53:06 -0800 Patch for landing bug-194554-20190212133445.patch text/plain 2804 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MTMxNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE5LTAyLTEyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogTm8gb3B0aW9uIHRvIG9ubHkgc2hvdyB1bmV4cGVjdGVk IGZhaWx1cmVzIGluIHJlc3VsdHMuaHRtbCBmb3IgaVBhZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NTU0CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS80NzkyMjQ0Mj4KKworICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBBYWthc2ggSmFpbi4KKwor ICAgICAgICBKdXN0IGJlY2F1c2UgYSBUZXN0RXhwZWNhdGlvbnMgZmlsZSBkb2VzIG5vdCBleGlz dCBmb3IgYSBzcGVjaWZpYyBwbGF0Zm9ybSBkb2VzIG5vdCBtZWFuIHRoYXQKKyAgICAgICAgVGVz dEV4cGVjYXRpb25zIGFyZSBub3QgYmVpbmcgdXNlZCwgZ2l2ZW4gdGhhdCBwbGF0Zm9ybXMgaW5o ZXJpdCB0ZXN0IGV4cGVjdGF0aW9ucy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9y dC9iYXNlLnB5OgorICAgICAgICAoUG9ydC51c2VzX3Rlc3RfZXhwZWN0YXRpb25zX2ZpbGUpOiBD aGVjayBhbGwgcG9zc2libGUgbG9jYXRpb25zIG9mIGEgVGVzdEV4cGVjdGF0aW9ucyBmaWxlLgor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5OgorICAgICAg ICAoUG9ydFRlc3QudGVzdF91c2VzX3Rlc3RfZXhwZWN0YXRpb25zX2ZpbGUpOgorCiAyMDE5LTAy LTEyICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgV2ViUGFnZTo6Y2xvc2UgbmVlZHMgdG8gcmVtb3ZlIGFsbCBtZXNzYWdlIHJlY2VpdmVycyBh c3NvY2lhdGVkIHdpdGggdGhhdCBXZWJQYWdlLCBub3QgV2ViUGFnZTo6fldlYlBhZ2UKSW5kZXg6 IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5CShyZXZpc2lvbiAyNDEzMDYpCisrKyBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQkod29ya2luZyBjb3B5KQpAQCAtMTE1Nyw3 ICsxMTU3LDEwIEBAIGNsYXNzIFBvcnQob2JqZWN0KToKICAgICBkZWYgdXNlc190ZXN0X2V4cGVj dGF0aW9uc19maWxlKHNlbGYpOgogICAgICAgICAjIFRoaXMgaXMgZGlmZmVyZW50IGZyb20gY2hl Y2tpbmcgdGVzdF9leHBlY3RhdGlvbnMoKSBpcyBOb25lLCBiZWNhdXNlCiAgICAgICAgICMgc29t ZSBwb3J0cyBoYXZlIFNraXBwZWQgZmlsZXMgd2hpY2ggYXJlIHJldHVybmVkIGFzIHBhcnQgb2Yg dGVzdF9leHBlY3RhdGlvbnMoKS4KLSAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uZXhp c3RzKHNlbGYucGF0aF90b190ZXN0X2V4cGVjdGF0aW9uc19maWxlKCkpCisgICAgICAgIGZvciBw YXRoIGluIHNlbGYuZGVmYXVsdF9iYXNlbGluZV9zZWFyY2hfcGF0aCgpOgorICAgICAgICAgICAg aWYgc2VsZi5fZmlsZXN5c3RlbS5leGlzdHMoc2VsZi5fZmlsZXN5c3RlbS5qb2luKHBhdGgsICdU ZXN0RXhwZWN0YXRpb25zJykpOgorICAgICAgICAgICAgICAgIHJldHVybiBUcnVlCisgICAgICAg IHJldHVybiBGYWxzZQogCiAgICAgZGVmIHdhcm5faWZfYnVnX21pc3NpbmdfaW5fdGVzdF9leHBl Y3RhdGlvbnMoc2VsZik6CiAgICAgICAgIHJldHVybiBGYWxzZQpJbmRleDogVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L2Jhc2VfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9wb3J0L2Jhc2VfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI0MTMwNikKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNv cHkpCkBAIC0yMjUsOSArMjI1LDggQEAgY2xhc3MgUG9ydFRlc3QodW5pdHRlc3QuVGVzdENhc2Up OgogICAgIGRlZiB0ZXN0X3VzZXNfdGVzdF9leHBlY3RhdGlvbnNfZmlsZShzZWxmKToKICAgICAg ICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KHBvcnRfbmFtZT0nZm9vJykKICAgICAgICAgcG9ydC5w b3J0X25hbWUgPSAnZm9vJwotICAgICAgICBwb3J0LnBhdGhfdG9fdGVzdF9leHBlY3RhdGlvbnNf ZmlsZSA9IGxhbWJkYTogJy9tb2NrLXJlc3VsdHMvVGVzdEV4cGVjdGF0aW9ucycKICAgICAgICAg c2VsZi5hc3NlcnRGYWxzZShwb3J0LnVzZXNfdGVzdF9leHBlY3RhdGlvbnNfZmlsZSgpKQotICAg ICAgICBwb3J0Ll9maWxlc3lzdGVtID0gTW9ja0ZpbGVTeXN0ZW0oeycvbW9jay1yZXN1bHRzL1Rl c3RFeHBlY3RhdGlvbnMnOiAnJ30pCisgICAgICAgIHBvcnQuX2ZpbGVzeXN0ZW0gPSBNb2NrRmls ZVN5c3RlbSh7Jy9tb2NrLWNoZWNrb3V0L0xheW91dFRlc3RzL3BsYXRmb3JtL2Zvby9UZXN0RXhw ZWN0YXRpb25zJzogJyd9KQogICAgICAgICBzZWxmLmFzc2VydFRydWUocG9ydC51c2VzX3Rlc3Rf ZXhwZWN0YXRpb25zX2ZpbGUoKSkKIAogICAgIGRlZiB0ZXN0X2ZpbmRfbm9fcGF0aHNfc3BlY2lm aWVkKHNlbGYpOgo=