194549 2019-02-12 11:56:53 -0800 Web Inspector: Timeline.prototype.recordsInTimeRange uses a property most records do not have 2019-02-12 13:23:32 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1505318 0 joepeck 2019-02-12 11:56:53 -0800 Timeline.prototype.recordsInTimeRange uses a property most records do not have Change `record.timestamp` to `record.startTime`. • Not all records have a timestamp. They do have a startTime/endTime • Those that do, set the startTime/endTime to the timestamp value 1505320 1 361818 joepeck 2019-02-12 11:57:18 -0800 Created attachment 361818 [PATCH] Proposed Fix 1505325 2 361818 hi 2019-02-12 12:04:04 -0800 Comment on attachment 361818 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=361818&action=review rs=me > Source/WebInspectorUI/UserInterface/Models/Timeline.js:99 > + let upperIndex = this._records.upperBound(endTime, (time, record) => time - record.startTime); Should this be `endTime`? If it's `startTime`, that means we'd include records that began in the range, but finished outside of the range. If it's `endTime`, then we'd exclude those records. 1505348 3 361818 joepeck 2019-02-12 12:55:41 -0800 Comment on attachment 361818 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=361818&action=review >> Source/WebInspectorUI/UserInterface/Models/Timeline.js:99 >> + let upperIndex = this._records.upperBound(endTime, (time, record) => time - record.startTime); > > Should this be `endTime`? If it's `startTime`, that means we'd include records that began in the range, but finished outside of the range. If it's `endTime`, then we'd exclude those records. I'd expect records that are even partially in the range. The lowerIndex could use `record.endTime`, but there is `includeRecordBeforeStart`. 1505364 4 361818 commit-queue 2019-02-12 13:22:02 -0800 Comment on attachment 361818 [PATCH] Proposed Fix Clearing flags on attachment: 361818 Committed r241315: <https://trac.webkit.org/changeset/241315> 1505365 5 commit-queue 2019-02-12 13:22:03 -0800 All reviewed patches have been landed. Closing bug. 1505367 6 webkit-bug-importer 2019-02-12 13:23:32 -0800 <rdar://problem/48012450> 361818 2019-02-12 11:57:18 -0800 2019-02-12 13:22:02 -0800 [PATCH] Proposed Fix time-range-1.patch text/plain 1650 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE4YWJiODY5MDMzLi45OTY4NjM0MzAxZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDItMTIgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBUaW1lbGluZS5wcm90b3R5cGUucmVjb3Jkc0luVGltZVJhbmdlIHVzZXMgYSBwcm9wZXJ0eSBt b3N0IHJlY29yZHMgZG8gbm90IGhhdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NDU0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvVGltZWxpbmUuanM6CisgICAg ICAgIChXSS5UaW1lbGluZS5wcm90b3R5cGUucmVjb3Jkc0luVGltZVJhbmdlKToKKwogMjAxOS0w Mi0xMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFJlbW92ZSB1bnVzZWQgbWF4VXNhZ2UgaW4gQ1BVVGltZWxpbmVWaWV3CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvVGlt ZWxpbmUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvVGlt ZWxpbmUuanMKaW5kZXggM2RlOTgzZGNhYWUuLjc1NmNlNTc0YzQwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvVGltZWxpbmUuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1RpbWVsaW5lLmpzCkBA IC05NSw4ICs5NSw4IEBAIFdJLlRpbWVsaW5lID0gY2xhc3MgVGltZWxpbmUgZXh0ZW5kcyBXSS5P YmplY3QKIAogICAgIHJlY29yZHNJblRpbWVSYW5nZShzdGFydFRpbWUsIGVuZFRpbWUsIGluY2x1 ZGVSZWNvcmRCZWZvcmVTdGFydCkKICAgICB7Ci0gICAgICAgIGxldCBsb3dlckluZGV4ID0gdGhp cy5fcmVjb3Jkcy5sb3dlckJvdW5kKHN0YXJ0VGltZSwgKHRpbWUsIHJlY29yZCkgPT4gdGltZSAt IHJlY29yZC50aW1lc3RhbXApOwotICAgICAgICBsZXQgdXBwZXJJbmRleCA9IHRoaXMuX3JlY29y ZHMudXBwZXJCb3VuZChlbmRUaW1lLCAodGltZSwgcmVjb3JkKSA9PiB0aW1lIC0gcmVjb3JkLnRp bWVzdGFtcCk7CisgICAgICAgIGxldCBsb3dlckluZGV4ID0gdGhpcy5fcmVjb3Jkcy5sb3dlckJv dW5kKHN0YXJ0VGltZSwgKHRpbWUsIHJlY29yZCkgPT4gdGltZSAtIHJlY29yZC5zdGFydFRpbWUp OworICAgICAgICBsZXQgdXBwZXJJbmRleCA9IHRoaXMuX3JlY29yZHMudXBwZXJCb3VuZChlbmRU aW1lLCAodGltZSwgcmVjb3JkKSA9PiB0aW1lIC0gcmVjb3JkLnN0YXJ0VGltZSk7CiAKICAgICAg ICAgLy8gSW5jbHVkZSB0aGUgcmVjb3JkIHJpZ2h0IGJlZm9yZSB0aGUgc3RhcnQgdGltZS4KICAg ICAgICAgaWYgKGluY2x1ZGVSZWNvcmRCZWZvcmVTdGFydCAmJiBsb3dlckluZGV4ID4gMCkK