194546 2019-02-12 11:10:16 -0800 AX: Fix flaky accessibility/loading-iframe-sends-notification.html 2019-02-12 11:51:09 -0800 1 1 1 Unclassified WebKit Accessibility Other All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni ews-watchlist jcraig jdiggs ryanhaddad samuel_white webkit-bug-importer zalan oldest_to_newest 1505286 0 cfleizach 2019-02-12 11:10:16 -0800 Fix flaky test accessibility/loading-iframe-sends-notification.html This is relying on timing between load events and AX notifications. We don't need to do that. 1505287 1 webkit-bug-importer 2019-02-12 11:10:42 -0800 <rdar://problem/48007383> 1505288 2 361808 cfleizach 2019-02-12 11:11:30 -0800 Created attachment 361808 patch 1505312 3 361808 commit-queue 2019-02-12 11:51:08 -0800 Comment on attachment 361808 patch Clearing flags on attachment: 361808 Committed r241307: <https://trac.webkit.org/changeset/241307> 1505313 4 commit-queue 2019-02-12 11:51:09 -0800 All reviewed patches have been landed. Closing bug. 361808 2019-02-12 11:11:30 -0800 2019-02-12 11:51:08 -0800 patch patch text/plain 3127 cfleizach SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI0MTMwNCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAyLTEyICBDaHJpcyBGbGVpemFjaCAg PGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEZpeCBmbGFreSBhY2Nlc3NpYmls aXR5L2xvYWRpbmctaWZyYW1lLXNlbmRzLW5vdGlmaWNhdGlvbi5odG1sCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ1NDYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRlc3Qgd2FzIHJlbHlpbmcg b24gdGltaW5nIGJldHdlZW4gbG9hZCBldmVudHMgYmVpbmcgc2VudCBhbmQgYWNjZXNzaWJpbGl0 eSBldmVudHMgYmVpbmcgc2VudC4KKyAgICAgICAgV2UgZG9uJ3QgbmVlZCB0byBkbyB0aGF0LCB3 ZSBjYW4gbW9yZSBkaXJlY3RseSB0ZXN0IHRoaXMgaW50ZXJwbGF5LgorCisgICAgICAgICogYWNj ZXNzaWJpbGl0eS9sb2FkaW5nLWlmcmFtZS1zZW5kcy1ub3RpZmljYXRpb24tZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbG9hZGluZy1pZnJhbWUtc2VuZHMtbm90aWZpY2F0 aW9uLmh0bWw6CisKIDIwMTktMDItMTIgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpA aWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIFdQRSBnYXJkZW5pbmcuIFVuc2tpcCBj b250ZW50IGV4dGVuc2lvbnMgdGVzdHMgYWZ0ZXIgcjI0MTI4MwpJbmRleDogTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9sb2FkaW5nLWlmcmFtZS1zZW5kcy1ub3RpZmljYXRpb24tZXhwZWN0ZWQu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbG9hZGluZy1pZnJh bWUtc2VuZHMtbm90aWZpY2F0aW9uLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMjQxMjk2KQorKysg TGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9sb2FkaW5nLWlmcmFtZS1zZW5kcy1ub3RpZmljYXRp b24tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xMyw3ICsxMyw2IEBACiBQQVNTIGZp bmRCeUFjY2Vzc2libGVUaXRsZVN1YnN0cmluZyhyb290LCAnSW5uZXJCdXR0b24nKSAhPSBudWxs IGlzIGZhbHNlCiBHb3Qgbm90aWZpY2F0aW9uIG9uIGlmcmFtZS4KIFBBU1MgZmluZEJ5QWNjZXNz aWJsZVRpdGxlU3Vic3RyaW5nKHJvb3QsICdJbm5lckJ1dHRvbicpICE9IG51bGwgaXMgdHJ1ZQot UEFTUyBnb3RJZnJhbWVOb3RpZmljYXRpb24gaXMgdHJ1ZQogUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L2xvYWRpbmctaWZyYW1lLXNlbmRzLW5vdGlmaWNhdGlvbi5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbG9hZGluZy1pZnJhbWUtc2VuZHMtbm90aWZpY2F0 aW9uLmh0bWwJKHJldmlzaW9uIDI0MTI5NikKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkv bG9hZGluZy1pZnJhbWUtc2VuZHMtbm90aWZpY2F0aW9uLmh0bWwJKHdvcmtpbmcgY29weSkKQEAg LTQyLDggKzQyLDYgQEAKIAogICAgIGZ1bmN0aW9uIHJ1blRlc3QoKQogICAgIHsKLSAgICAgICAg d2luZG93LmdvdElmcmFtZU5vdGlmaWNhdGlvbiA9IGZhbHNlOwotCiAgICAgICAgIGlmICh3aW5k b3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKICAgICAgICAgICAgIHdpbmRvdy5yb290ID0g YWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIucm9vdEVsZW1lbnQ7CiAKQEAgLTU5LDI0ICs1NywxNiBA QAogICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgICAgICAgICBkZWJ1Zygi R290IG5vdGlmaWNhdGlvbiBvbiBpZnJhbWUuIik7Ci0gICAgICAgICAgICAgICAgZ290SWZyYW1l Tm90aWZpY2F0aW9uID0gdHJ1ZTsKIAogICAgICAgICAgICAgICAgIC8vIENoZWNrIHRoYXQgdGhl IGJ1dHRvbiB3aXRoaW4gdGhlIGlmcmFtZSBpcyBub3cgcmVhY2hhYmxlIGZyb20gdGhlIHJvb3Qu CiAgICAgICAgICAgICAgICAgc2hvdWxkQmVUcnVlKCJmaW5kQnlBY2Nlc3NpYmxlVGl0bGVTdWJz dHJpbmcocm9vdCwgJ0lubmVyQnV0dG9uJykgIT0gbnVsbCIpOworICAgICAgICAgICAgICAgIGFj Y2Vzc2liaWxpdHlDb250cm9sbGVyLnJlbW92ZU5vdGlmaWNhdGlvbkxpc3RlbmVyKCk7CisgICAg ICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7CiAgICAgICAgICAgICB9KTsKICAgICAgICAgfQog CiAgICAgICAgIHdpbmRvdy5pZnJhbWVFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImlmcmFtZSIpOwotICAgICAgICBpZnJhbWVFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQi LCBmdW5jdGlvbigpIHsKLSAgICAgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkg ewotICAgICAgICAgICAgICAgIHNob3VsZEJlVHJ1ZSgiZ290SWZyYW1lTm90aWZpY2F0aW9uIik7 Ci0gICAgICAgICAgICAgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikKLSAg ICAgICAgICAgICAgICAgICAgYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIucmVtb3ZlTm90aWZpY2F0 aW9uTGlzdGVuZXIoKTsKIAotICAgICAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOwotICAgICAg ICAgICAgfSwgMTApOwotICAgICAgICB9LCBmYWxzZSk7Ci0KICAgICAgICAgLy8gTG9hZCBjb250 ZW50IGludG8gdGhlIGlmcmFtZS4gVGhpcyB3aWxsIHRyaWdnZXIgdGhlIGV2ZW50CiAgICAgICAg IC8vIGhhbmRsZXIgYWJvdmUsIHdoaWNoIHdpbGwgY2hlY2sgdGhhdCB0aGUgYWNjZXNzaWJpbGl0 eSB0cmVlCiAgICAgICAgIC8vIHdhcyB1cGRhdGVkIHdpdGggbmV3IGNvbnRlbnQuCg==