194537 2019-02-12 06:42:24 -0800 [GStreamer] Simplify GObject class name check 2019-02-15 15:30:45 -0800 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Trivial --- 1 bugzilla pnormand bugs-noreply commit-queue mcatanzaro pnormand oldest_to_newest 1505210 0 bugzilla 2019-02-12 06:42:24 -0800 This line: https://sources.debian.org/src/webkit2gtk/2.23.3-1/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp/#L1754 reads: if (g_strcmp0(G_OBJECT_CLASS_NAME(G_OBJECT_GET_CLASS(G_OBJECT(element))), "GstDownloadBuffer")) It could be simplified to: if (g_strcmp0(G_OBJECT_TYPE_NAME(element)), "GstDownloadBuffer")) 1506579 1 362117 pnormand 2019-02-15 08:48:19 -0800 Created attachment 362117 Patch 1506593 2 362117 commit-queue 2019-02-15 09:26:22 -0800 Comment on attachment 362117 Patch Clearing flags on attachment: 362117 Committed r241590: <https://trac.webkit.org/changeset/241590> 1506594 3 commit-queue 2019-02-15 09:26:24 -0800 All reviewed patches have been landed. Closing bug. 1506805 4 webkit-bug-importer 2019-02-15 15:30:45 -0800 <rdar://problem/48126892> 362117 2019-02-15 08:48:19 -0800 2019-02-15 09:26:22 -0800 Patch bug-194537-20190215164817.patch text/plain 1753 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTViMzMxZjU5ZGIzZTY1 ODIzNzZkZDUwMWUxMDQzNjYxMDg4MzY4NS4uNGM2ODIxYTQzOTQxYTk0YTdhZWYyZWQ2Zjg5OWUw YWJhOTM5MzQyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTE1ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBTaW1wbGlmeSBHT2JqZWN0IGNsYXNzIG5hbWUgY2hlY2sKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDUzNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnVyaURlY29kZUJpbkVsZW1lbnRBZGRlZENhbGxiYWNr KToKKyAgICAgICAgVXNlIEdfT0JKRUNUX1RZUEVfTkFNRSgpIHRvIGZpbHRlciBvdXQgdXJpZGVj b2RlYmluIGNoaWxkCisgICAgICAgIGVsZW1lbnRzLgorCiAyMDE5LTAyLTE1ICBQaGlsaXBwZSBO b3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBEZWNv ZGluZyBtZWRpYS1jYXBhYmlsaXRpZXMgY29uZmlndXJhdGlvbiBpbml0aWFsIHN1cHBvcnQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggZjc4 MTlkNDFiNjQ4ZTJiZmNlMzlhYjAyMzk3ZmE3YzVhMzg2ZGFmNS4uOGM2N2Q2ODE2ZjkxYjhjODA1 Y2M1MGExM2VlYzM2M2NjZjg2Y2QzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTE3NTMsNyArMTc1Myw3IEBAIHZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyOjpzb3VyY2VTZXR1cENhbGxiYWNrKE1lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lCiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjp1cmlEZWNvZGVC aW5FbGVtZW50QWRkZWRDYWxsYmFjayhHc3RCaW4qIGJpbiwgR3N0RWxlbWVudCogZWxlbWVudCwg TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyKiBwbGF5ZXIpCiB7Ci0gICAgaWYgKGdfc3RyY21w MChHX09CSkVDVF9DTEFTU19OQU1FKEdfT0JKRUNUX0dFVF9DTEFTUyhHX09CSkVDVChlbGVtZW50 KSkpLCAiR3N0RG93bmxvYWRCdWZmZXIiKSkKKyAgICBpZiAoZ19zdHJjbXAwKEdfT0JKRUNUX1RZ UEVfTkFNRShlbGVtZW50KSwgIkdzdERvd25sb2FkQnVmZmVyIikpCiAgICAgICAgIHJldHVybjsK IAogICAgIHBsYXllci0+bV9kb3dubG9hZEJ1ZmZlciA9IGVsZW1lbnQ7Cg==