<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>194535</bug_id>
          
          <creation_ts>2019-02-12 05:25:54 -0800</creation_ts>
          <short_desc>CodeBlocks read from disk should not be re-written</short_desc>
          <delta_ts>2019-02-14 09:17:25 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tadeu Zagallo">tzagallo</reporter>
          <assigned_to name="Tadeu Zagallo">tzagallo</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1505203</commentid>
    <comment_count>0</comment_count>
    <who name="Tadeu Zagallo">tzagallo</who>
    <bug_when>2019-02-12 05:25:54 -0800</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505204</commentid>
    <comment_count>1</comment_count>
      <attachid>361792</attachid>
    <who name="Tadeu Zagallo">tzagallo</who>
    <bug_when>2019-02-12 05:27:42 -0800</bug_when>
    <thetext>Created attachment 361792
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505754</commentid>
    <comment_count>2</comment_count>
      <attachid>361792</attachid>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2019-02-13 10:24:15 -0800</bug_when>
    <thetext>Comment on attachment 361792
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505769</commentid>
    <comment_count>3</comment_count>
      <attachid>361792</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-13 10:50:22 -0800</bug_when>
    <thetext>Comment on attachment 361792
Patch

Rejecting attachment 361792 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-02&apos;, &apos;land-attachment&apos;, &apos;--force-clean&apos;, &apos;--non-interactive&apos;, &apos;--parent-command=commit-queue&apos;, 361792, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=361792&amp;action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=194535&amp;ctype=xml&amp;excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 361792 from bug 194535.
Fetching: https://bugs.webkit.org/attachment.cgi?id=361792
Failed to run &quot;[&apos;git&apos;, &apos;svn&apos;, &apos;dcommit&apos;, &apos;--rmdir&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/JavaScriptCore/ChangeLog
	M	Source/JavaScriptCore/runtime/CodeCache.cpp
	M	Source/JavaScriptCore/runtime/CodeCache.h
Committed r241442
fatal: Unable to create &apos;/Volumes/Data/EWS/WebKit/.git/svn/refs/remotes/origin/master/index.lock&apos;: File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by &apos;git commit&apos;. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.
write-tree: command returned error: 128


Failed to run &quot;[&apos;git&apos;, &apos;svn&apos;, &apos;dcommit&apos;, &apos;--rmdir&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/JavaScriptCore/ChangeLog
	M	Source/JavaScriptCore/runtime/CodeCache.cpp
	M	Source/JavaScriptCore/runtime/CodeCache.h
Committed r241442
fatal: Unable to create &apos;/Volumes/Data/EWS/WebKit/.git/svn/refs/remotes/origin/master/index.lock&apos;: File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by &apos;git commit&apos;. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.
write-tree: command returned error: 128


Failed to run &quot;[&apos;git&apos;, &apos;svn&apos;, &apos;dcommit&apos;, &apos;--rmdir&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   a68a1b1e94c..5ff49f45c34  master     -&gt; origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 241437 = a68a1b1e94ceb6c7436139f5348f18141ae0b15a
r241440 = 64539b902bf2cc5c451511d0fde4fbe959b92f6e
r241441 = 5ff49f45c34c2eb581c95662e359560130c66457
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/11136301</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1506179</commentid>
    <comment_count>4</comment_count>
    <who name="Tadeu Zagallo">tzagallo</who>
    <bug_when>2019-02-14 09:16:14 -0800</bug_when>
    <thetext>Landed in r241442: &lt;https://trac.webkit.org/r241442&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1506180</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-02-14 09:17:25 -0800</bug_when>
    <thetext>&lt;rdar://problem/48075964&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>361792</attachid>
            <date>2019-02-12 05:27:42 -0800</date>
            <delta_ts>2019-02-13 10:50:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-194535-20190212142711.patch</filename>
            <type>text/plain</type>
            <size>2799</size>
            <attacher name="Tadeu Zagallo">tzagallo</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2
MDgyNDlmN2YyNzY5OTQ3MzdiZDc4MTdhMTA1ZjA4NTNhMGRkZTM5Li4xMGM1YmUyNTJiNTUxMDdl
YmZmMzBmNDE5ZTg4ZmMzNjRjYTE2YmQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxOSBAQAorMjAxOS0wMi0xMiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv
bT4KKworICAgICAgICBDb2RlQmxvY2tzIHJlYWQgZnJvbSBkaXNrIHNob3VsZCBub3QgYmUgcmUt
d3JpdHRlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTk0NTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
S2VlcCB0cmFjayBvZiB3aGljaCBDb2RlQmxvY2tzIGhhdmUgYmVlbiByZWFkIGZyb20gZGlzayBv
ciBoYXZlIGFscmVhZHkKKyAgICAgICAgYmVlbiBzZXJpYWxpemVkIGluIENvZGVDYWNoZS4KKwor
ICAgICAgICAqIHJ1bnRpbWUvQ29kZUNhY2hlLmNwcDoKKyAgICAgICAgKEpTQzo6Q29kZUNhY2hl
Ojp3cml0ZSk6CisgICAgICAgICogcnVudGltZS9Db2RlQ2FjaGUuaDoKKyAgICAgICAgKEpTQzo6
U291cmNlQ29kZVZhbHVlOjpTb3VyY2VDb2RlVmFsdWUpOgorICAgICAgICAoSlNDOjpDb2RlQ2Fj
aGVNYXA6OmZldGNoRnJvbURpc2tJbXBsKToKKwogMjAxOS0wMi0xMSAgTWFyayBMYW0gIDxtYXJr
LmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmFuZG9taXplIGluc2VydGlvbiBvZiBkZWFsbG9j
YXRlZCBTdHJ1Y3R1cmVJRHMgaW50byB0aGUgU3RydWN0dXJlSURUYWJsZSdzIGZyZWUgbGlzdC4K
ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvZGVDYWNoZS5jcHAg
Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuY3BwCmluZGV4IGI0MWU1
MjY1MWYzZTdjOWY2ZWNkZTIzZmZiOTY5OWM4OWRiNzg2NTcuLmQ1M2FhZGFiZTExMWQzOTAyMWVm
M2QwMWNmZDQ1N2U0OThhYjA2MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y
dW50aW1lL0NvZGVDYWNoZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv
Q29kZUNhY2hlLmNwcApAQCAtMTU5LDggKzE1OSwxMiBAQCBVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0
YWJsZSogQ29kZUNhY2hlOjpnZXRVbmxpbmtlZEdsb2JhbEZ1bmN0aW9uRXhlY3V0YWJsZShWTSYg
dgogCiB2b2lkIENvZGVDYWNoZTo6d3JpdGUoVk0mIHZtKQogewotICAgIGZvciAoY29uc3QgYXV0
byYgaXQgOiBtX3NvdXJjZUNvZGUpCisgICAgZm9yIChhdXRvJiBpdCA6IG1fc291cmNlQ29kZSkg
eworICAgICAgICBpZiAoaXQudmFsdWUud3JpdHRlbikKKyAgICAgICAgICAgIGNvbnRpbnVlOwor
ICAgICAgICBpdC52YWx1ZS53cml0dGVuID0gdHJ1ZTsKICAgICAgICAgd3JpdGVDb2RlQmxvY2so
dm0sIGl0LmtleSwgaXQudmFsdWUpOworICAgIH0KIH0KIAogdm9pZCBnZW5lcmF0ZVVubGlua2Vk
Q29kZUJsb2NrRm9yRnVuY3Rpb25zKFZNJiB2bSwgVW5saW5rZWRDb2RlQmxvY2sqIHVubGlua2Vk
Q29kZUJsb2NrLCBjb25zdCBTb3VyY2VDb2RlJiBwYXJlbnRTb3VyY2UsIERlYnVnZ2VyTW9kZSBk
ZWJ1Z2dlck1vZGUsIFBhcnNlckVycm9yJiBlcnJvcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9ydW50aW1lL0NvZGVDYWNoZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1
bnRpbWUvQ29kZUNhY2hlLmgKaW5kZXggODBjMGQ5NWY5ZWY3OTQ5NTJlNWZiYzY4M2VlNTY2NTBl
MGEwMjFhZi4uYmU0NGJkZGVlOTlmZTQ5NGUxODg1Y2EzZTc3OTFkYTY2OTRmODg5ZCAxMDA2NDQK
LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmgKKysrIGIvU291
cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmgKQEAgLTc1LDE0ICs3NSwxNiBA
QCBzdHJ1Y3QgU291cmNlQ29kZVZhbHVlIHsKICAgICB7CiAgICAgfQogCi0gICAgU291cmNlQ29k
ZVZhbHVlKFZNJiB2bSwgSlNDZWxsKiBjZWxsLCBpbnQ2NF90IGFnZSkKKyAgICBTb3VyY2VDb2Rl
VmFsdWUoVk0mIHZtLCBKU0NlbGwqIGNlbGwsIGludDY0X3QgYWdlLCBib29sIHdyaXR0ZW4gPSBm
YWxzZSkKICAgICAgICAgOiBjZWxsKHZtLCBjZWxsKQogICAgICAgICAsIGFnZShhZ2UpCisgICAg
ICAgICwgd3JpdHRlbih3cml0dGVuKQogICAgIHsKICAgICB9CiAKICAgICBTdHJvbmc8SlNDZWxs
PiBjZWxsOwogICAgIGludDY0X3QgYWdlOworICAgIGJvb2wgd3JpdHRlbjsKIH07CiAKIGNsYXNz
IENvZGVDYWNoZU1hcCB7CkBAIC0xNTQsNyArMTU2LDcgQEAgcHVibGljOgogICAgICAgICAgICAg
cmV0dXJuIG51bGxwdHI7CiAKICAgICAgICAgVkVSQk9TRV9MT0coIkZvdW5kIGNhY2hlZCBDb2Rl
QmxvY2sgb24gZGlzayIpOwotICAgICAgICBhZGRDYWNoZShrZXksIFNvdXJjZUNvZGVWYWx1ZSh2
bSwgdW5saW5rZWRDb2RlQmxvY2ssIG1fYWdlKSk7CisgICAgICAgIGFkZENhY2hlKGtleSwgU291
cmNlQ29kZVZhbHVlKHZtLCB1bmxpbmtlZENvZGVCbG9jaywgbV9hZ2UsIHRydWUpKTsKICAgICAg
ICAgcmV0dXJuIHVubGlua2VkQ29kZUJsb2NrOwogI2Vsc2UKICAgICAgICAgVU5VU0VEX1BBUkFN
KHZtKTsK
</data>
<flag name="review"
          id="378433"
          type_id="1"
          status="+"
          setter="msaboff"
    />
    <flag name="commit-queue"
          id="378560"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>