194534 2019-02-12 05:05:45 -0800 VariableLengthObject::allocate<T> should initialize objects 2019-02-13 11:23:00 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1505200 0 tzagallo 2019-02-12 05:05:45 -0800 ... 1505201 1 361791 tzagallo 2019-02-12 05:13:44 -0800 Created attachment 361791 Patch 1505755 2 361791 msaboff 2019-02-13 10:26:19 -0800 Comment on attachment 361791 Patch r=me 1505785 3 361791 commit-queue 2019-02-13 11:16:42 -0800 Comment on attachment 361791 Patch Clearing flags on attachment: 361791 Committed r241447: <https://trac.webkit.org/changeset/241447> 1505786 4 commit-queue 2019-02-13 11:16:44 -0800 All reviewed patches have been landed. Closing bug. 1505788 5 webkit-bug-importer 2019-02-13 11:23:00 -0800 <rdar://problem/48045346> 361791 2019-02-12 05:13:44 -0800 2019-02-13 11:16:42 -0800 Patch bug-194534-20190212141313.patch text/plain 6765 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MDgyNDlmN2YyNzY5OTQ3MzdiZDc4MTdhMTA1ZjA4NTNhMGRkZTM5Li45YTNlZTUyMTRiMGU0NDli ZGM0NDU3MTAyOTg5YzBkMjM3NmJlNWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxOS0wMi0xMiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBWYXJpYWJsZUxlbmd0aE9iamVjdDo6YWxsb2NhdGU8VD4gc2hvdWxkIGlu aXRpYWxpemUgb2JqZWN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk0NTM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgYGJ1ZmZlcigpYCBzaG91bGQgbm90IGJlIGNhbGxlZCBmb3IgZW1wdHkgVmFyaWFi bGVMZW5ndGhPYmplY3RzLCBidXQKKyAgICAgICAgdGhlc2UgY2FzZXMgd2VyZSBub3QgYmVpbmcg Y2F1Z2h0IGR1ZSB0byB0aGUgb2JqZWN0cyBub3QgYmVpbmcgcHJvcGVybHkKKyAgICAgICAgaW5p dGlhbGl6ZWQuIEZpeCBpdCBzbyB0aGF0IGFsbG9jYXRlIGNhbGxzIHRoZSBjb25zdHJ1Y3RvciBh bmQgZml4IHRoZQorICAgICAgICBhc3NlcnRpb24gZmFpbHVlcy4KKworICAgICAgICAqIHJ1bnRp bWUvQ2FjaGVkVHlwZXMuY3BwOgorICAgICAgICAoSlNDOjpDYWNoZWRPYmplY3Q6Om9wZXJhdG9y IG5ldyk6CisgICAgICAgIChKU0M6OlZhcmlhYmxlTGVuZ3RoT2JqZWN0OjphbGxvY2F0ZSk6Cisg ICAgICAgIChKU0M6OkNhY2hlZFZlY3Rvcjo6ZW5jb2RlKToKKyAgICAgICAgKEpTQzo6Q2FjaGVk VmVjdG9yOjpkZWNvZGUgY29uc3QpOgorICAgICAgICAoSlNDOjpDYWNoZWRVbmlxdWVkU3RyaW5n SW1wbDo6ZGVjb2RlIGNvbnN0KToKKyAgICAgICAgKEpTQzo6Q2FjaGVkQml0VmVjdG9yOjplbmNv ZGUpOgorICAgICAgICAoSlNDOjpDYWNoZWRCaXRWZWN0b3I6OmRlY29kZSBjb25zdCk6CisgICAg ICAgIChKU0M6OkNhY2hlZEFycmF5OjplbmNvZGUpOgorICAgICAgICAoSlNDOjpDYWNoZWRBcnJh eTo6ZGVjb2RlIGNvbnN0KToKKyAgICAgICAgKEpTQzo6Q2FjaGVkSW1tdXRhYmxlQnV0dGVyZmx5 OjpDYWNoZWRJbW11dGFibGVCdXR0ZXJmbHkpOgorICAgICAgICAoSlNDOjpDYWNoZWRCaWdJbnQ6 OmRlY29kZSBjb25zdCk6CisKIDIwMTktMDItMTEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIFJhbmRvbWl6ZSBpbnNlcnRpb24gb2YgZGVhbGxvY2F0ZWQgU3RydWN0 dXJlSURzIGludG8gdGhlIFN0cnVjdHVyZUlEVGFibGUncyBmcmVlIGxpc3QuCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9DYWNoZWRUeXBlcy5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9DYWNoZWRUeXBlcy5jcHAKaW5kZXggZjZmZmVlNDk5MGMx OWMwZmZhNTJiZmI0MjNlZjM3OTQ2NzYxZGY0My4uN2VjMjNkMTM2NTRhZDY0M2Y0MDA5OWUwMGNl ODE3NDZjZDM1NmVkOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv Q2FjaGVkVHlwZXMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hl ZFR5cGVzLmNwcApAQCAtMzA2LDEwICszMDYsMjEgQEAgc3RhdGljIHN0ZDo6ZW5hYmxlX2lmX3Q8 IXN0ZDo6aXNfc2FtZTxULCBTb3VyY2VUeXBlPFQ+Pjo6dmFsdWUsIFNvdXJjZVR5cGU8VD4+JiYK IHRlbXBsYXRlPHR5cGVuYW1lIFNvdXJjZT4KIGNsYXNzIENhY2hlZE9iamVjdCB7CiAgICAgV1RG X01BS0VfTk9OQ09QWUFCTEUoQ2FjaGVkT2JqZWN0PFNvdXJjZT4pOwotICAgIFdURl9GT1JCSURf SEVBUF9BTExPQ0FUSU9OOwogCiBwdWJsaWM6CiAgICAgdXNpbmcgU291cmNlVHlwZV8gPSBTb3Vy Y2U7CisKKyAgICBDYWNoZWRPYmplY3QoKSA9IGRlZmF1bHQ7CisKKyAgICBpbmxpbmUgdm9pZCog b3BlcmF0b3IgbmV3KHNpemVfdCwgdm9pZCogd2hlcmUpIHsgcmV0dXJuIHdoZXJlOyB9CisKKyAg ICAvLyBDb3BpZWQgZnJvbSBXVEZfRk9SQklEX0hFQVBfQUxMT0NBVElPTiwgc2luY2Ugd2Ugb25s eSB3YW50IHRvIGFsbG93IHBsYWNlbWVudCBuZXcKKyAgICB2b2lkKiBvcGVyYXRvciBuZXdbXShz aXplX3QsIHZvaWQqKSA9IGRlbGV0ZTsKKyAgICB2b2lkKiBvcGVyYXRvciBuZXcoc2l6ZV90KSA9 IGRlbGV0ZTsKKyAgICB2b2lkIG9wZXJhdG9yIGRlbGV0ZSh2b2lkKikgPSBkZWxldGU7CisgICAg dm9pZCogb3BlcmF0b3IgbmV3W10oc2l6ZV90IHNpemUpID0gZGVsZXRlOworICAgIHZvaWQgb3Bl cmF0b3IgZGVsZXRlW10odm9pZCopID0gZGVsZXRlOworICAgIHZvaWQqIG9wZXJhdG9yIG5ldyhz aXplX3QsIE5vdE51bGxUYWcsIHZvaWQqIGxvY2F0aW9uKSA9IGRlbGV0ZTsKIH07CiAKIHRlbXBs YXRlPHR5cGVuYW1lIFNvdXJjZT4KQEAgLTMzMiw5ICszNDMsNiBAQCBwcm90ZWN0ZWQ6CiAKICAg ICB1aW50OF90KiBhbGxvY2F0ZShFbmNvZGVyJiBlbmNvZGVyLCBzaXplX3Qgc2l6ZSkKICAgICB7 Ci0gICAgICAgIGlmICghc2l6ZSkKLSAgICAgICAgICAgIHJldHVybiBudWxscHRyOwotCiAgICAg ICAgIHB0cmRpZmZfdCBvZmZzZXRPZmZzZXQgPSBlbmNvZGVyLm9mZnNldE9mKCZtX29mZnNldCk7 CiAgICAgICAgIGF1dG8gcmVzdWx0ID0gZW5jb2Rlci5tYWxsb2Moc2l6ZSk7CiAgICAgICAgIG1f b2Zmc2V0ID0gcmVzdWx0Lm9mZnNldCgpIC0gb2Zmc2V0T2Zmc2V0OwpAQCAtMzQ1LDcgKzM1Myw3 IEBAIHByb3RlY3RlZDoKICAgICBUKiBhbGxvY2F0ZShFbmNvZGVyJiBlbmNvZGVyLCB1bnNpZ25l ZCBzaXplID0gMSkKICAgICB7CiAgICAgICAgIHVpbnQ4X3QqIHJlc3VsdCA9IGFsbG9jYXRlKGVu Y29kZXIsIHNpemVvZihUKSAqIHNpemUpOwotICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2Fz dDxUKj4ocmVzdWx0KTsKKyAgICAgICAgcmV0dXJuIG5ldyAocmVzdWx0KSBUKCk7CiAgICAgfQog CiBwcml2YXRlOgpAQCAtNDYzLDYgKzQ3MSw4IEBAIHB1YmxpYzoKICAgICB2b2lkIGVuY29kZShF bmNvZGVyJiBlbmNvZGVyLCBjb25zdCBWZWN0b3I8U291cmNlVHlwZTxUPiwgSW5saW5lQ2FwYWNp dHksIE92ZXJmbG93SGFuZGxlcj4mIHZlY3RvcikKICAgICB7CiAgICAgICAgIG1fc2l6ZSA9IHZl Y3Rvci5zaXplKCk7CisgICAgICAgIGlmICghbV9zaXplKQorICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICBUKiBidWZmZXIgPSB0aGlzLT50ZW1wbGF0ZSBhbGxvY2F0ZTxUPihlbmNvZGVyLCBt X3NpemUpOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbV9zaXplOyArK2kpCiAg ICAgICAgICAgICA6OkpTQzo6ZW5jb2RlKGVuY29kZXIsIGJ1ZmZlcltpXSwgdmVjdG9yW2ldKTsK QEAgLTQ3MSw2ICs0ODEsOCBAQCBwdWJsaWM6CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUuLi4gQXJn cz4KICAgICB2b2lkIGRlY29kZShEZWNvZGVyJiBkZWNvZGVyLCBWZWN0b3I8U291cmNlVHlwZTxU PiwgSW5saW5lQ2FwYWNpdHksIE92ZXJmbG93SGFuZGxlcj4mIHZlY3RvciwgQXJncy4uLiBhcmdz KSBjb25zdAogICAgIHsKKyAgICAgICAgaWYgKCFtX3NpemUpCisgICAgICAgICAgICByZXR1cm47 CiAgICAgICAgIHZlY3Rvci5yZXNpemVUb0ZpdChtX3NpemUpOwogICAgICAgICBjb25zdCBUKiBi dWZmZXIgPSB0aGlzLT50ZW1wbGF0ZSBidWZmZXI8VD4oKTsKICAgICAgICAgZm9yICh1bnNpZ25l ZCBpID0gMDsgaSA8IG1fc2l6ZTsgKytpKQpAQCAtNTcwLDkgKzU4Miw2IEBAIHB1YmxpYzoKICAg ICAgICAgICAgIGlmICghbV9pc1N5bWJvbCkKICAgICAgICAgICAgICAgICByZXR1cm4gQXRvbWlj U3RyaW5nSW1wbDo6YWRkKGJ1ZmZlciwgbV9sZW5ndGgpLmxlYWtSZWYoKTsKIAotICAgICAgICAg ICAgaWYgKCFtX2xlbmd0aCkKLSAgICAgICAgICAgICAgICByZXR1cm4gJlN5bWJvbEltcGw6OmNy ZWF0ZU51bGxTeW1ib2woKS5sZWFrUmVmKCk7Ci0KICAgICAgICAgICAgIElkZW50aWZpZXIgaWRl bnQgPSBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKCZkZWNvZGVyLnZtKCksIGJ1ZmZlciwgbV9sZW5n dGgpOwogICAgICAgICAgICAgU3RyaW5nIHN0ciA9IGRlY29kZXIudm0oKS5wcm9wZXJ0eU5hbWVz LT5sb29rVXBQcml2YXRlTmFtZShpZGVudCk7CiAgICAgICAgICAgICBTdHJpbmdJbXBsKiBpbXBs ID0gc3RyLnJlbGVhc2VJbXBsKCkuZ2V0KCk7CkBAIC01ODAsNiArNTg5LDEyIEBAIHB1YmxpYzoK ICAgICAgICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxVbmlxdWVkU3RyaW5nSW1wbCo+KGltcGwp OwogICAgICAgICB9OwogCisgICAgICAgIGlmICghbV9sZW5ndGgpIHsKKyAgICAgICAgICAgIGlm IChtX2lzU3ltYm9sKQorICAgICAgICAgICAgICAgIHJldHVybiAmU3ltYm9sSW1wbDo6Y3JlYXRl TnVsbFN5bWJvbCgpLmxlYWtSZWYoKTsKKyAgICAgICAgICAgIHJldHVybiBBdG9taWNTdHJpbmdJ bXBsOjphZGQoIiIpLmxlYWtSZWYoKTsKKyAgICAgICAgfQorCiAgICAgICAgIGlmIChtX2lzOEJp dCkKICAgICAgICAgICAgIHJldHVybiBjcmVhdGUodGhpcy0+YnVmZmVyPExDaGFyPigpKTsKICAg ICAgICAgcmV0dXJuIGNyZWF0ZSh0aGlzLT5idWZmZXI8VUNoYXI+KCkpOwpAQCAtNzQwLDEyICs3 NTUsMTYgQEAgcHVibGljOgogICAgIHZvaWQgZW5jb2RlKEVuY29kZXImIGVuY29kZXIsIGNvbnN0 IEJpdFZlY3RvciYgYml0VmVjdG9yKQogICAgIHsKICAgICAgICAgbV9zaXplID0gYml0VmVjdG9y LnNpemUoKTsKKyAgICAgICAgaWYgKCFtX3NpemUpCisgICAgICAgICAgICByZXR1cm47CiAgICAg ICAgIHVpbnQ4X3QqIGJ1ZmZlciA9IHRoaXMtPmFsbG9jYXRlKGVuY29kZXIsIG1fc2l6ZSk7CiAg ICAgICAgIG1lbWNweShidWZmZXIsIGJpdFZlY3Rvci5iaXRzKCksIG1fc2l6ZSk7CiAgICAgfQog CiAgICAgdm9pZCBkZWNvZGUoRGVjb2RlciYsIEJpdFZlY3RvciYgYml0VmVjdG9yKSBjb25zdAog ICAgIHsKKyAgICAgICAgaWYgKCFtX3NpemUpCisgICAgICAgICAgICByZXR1cm47CiAgICAgICAg IGJpdFZlY3Rvci5lbnN1cmVTaXplKG1fc2l6ZSk7CiAgICAgICAgIG1lbWNweShiaXRWZWN0b3Iu Yml0cygpLCB0aGlzLT5idWZmZXIoKSwgbV9zaXplKTsKICAgICB9CkBAIC04NjAsNiArODc5LDgg QEAgY2xhc3MgQ2FjaGVkQXJyYXkgOiBwdWJsaWMgVmFyaWFibGVMZW5ndGhPYmplY3Q8U291cmNl Kj4gewogcHVibGljOgogICAgIHZvaWQgZW5jb2RlKEVuY29kZXImIGVuY29kZXIsIGNvbnN0IFNv dXJjZSogYXJyYXksIHVuc2lnbmVkIHNpemUpCiAgICAgeworICAgICAgICBpZiAoIXNpemUpCisg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIFQqIGRzdCA9IHRoaXMtPnRlbXBsYXRlIGFsbG9j YXRlPFQ+KGVuY29kZXIsIHNpemUpOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwg c2l6ZTsgKytpKQogICAgICAgICAgICAgOjpKU0M6OmVuY29kZShlbmNvZGVyLCBkc3RbaV0sIGFy cmF5W2ldKTsKQEAgLTg2OCw2ICs4ODksOCBAQCBwdWJsaWM6CiAgICAgdGVtcGxhdGU8dHlwZW5h bWUuLi4gQXJncz4KICAgICB2b2lkIGRlY29kZShEZWNvZGVyJiBkZWNvZGVyLCBTb3VyY2UqIGFy cmF5LCB1bnNpZ25lZCBzaXplLCBBcmdzLi4uIGFyZ3MpIGNvbnN0CiAgICAgeworICAgICAgICBp ZiAoIXNpemUpCisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIGNvbnN0IFQqIGJ1ZmZlciA9 IHRoaXMtPnRlbXBsYXRlIGJ1ZmZlcjxUPigpOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAw OyBpIDwgc2l6ZTsgKytpKQogICAgICAgICAgICAgOjpKU0M6OmRlY29kZShkZWNvZGVyLCBidWZm ZXJbaV0sIGFycmF5W2ldLCBhcmdzLi4uKTsKQEAgLTk0OCw2ICs5NzEsMTEgQEAgcHJpdmF0ZToK IGNsYXNzIENhY2hlZEpTVmFsdWU7CiBjbGFzcyBDYWNoZWRJbW11dGFibGVCdXR0ZXJmbHkgOiBw dWJsaWMgQ2FjaGVkT2JqZWN0PEpTSW1tdXRhYmxlQnV0dGVyZmx5PiB7CiBwdWJsaWM6CisgICAg Q2FjaGVkSW1tdXRhYmxlQnV0dGVyZmx5KCkKKyAgICAgICAgOiBtX2NhY2hlZERvdWJsZXMoKQor ICAgIHsKKyAgICB9CisKICAgICB2b2lkIGVuY29kZShFbmNvZGVyJiBlbmNvZGVyLCBKU0ltbXV0 YWJsZUJ1dHRlcmZseSYgaW1tdXRhYmxlQnV0dGVyZmx5KQogICAgIHsKICAgICAgICAgbV9sZW5n dGggPSBpbW11dGFibGVCdXR0ZXJmbHkubGVuZ3RoKCk7CkBAIC0xMDM3LDcgKzEwNjUsOCBAQCBw dWJsaWM6CiAgICAgewogICAgICAgICBKU0JpZ0ludCogYmlnSW50ID0gSlNCaWdJbnQ6OmNyZWF0 ZVdpdGhMZW5ndGhVbmNoZWNrZWQoZGVjb2Rlci52bSgpLCBtX2xlbmd0aCk7CiAgICAgICAgIGJp Z0ludC0+c2V0U2lnbihtX3NpZ24pOwotICAgICAgICBtZW1jcHkoYmlnSW50LT5kYXRhU3RvcmFn ZSgpLCB0aGlzLT5idWZmZXIoKSwgc2l6ZW9mKEpTQmlnSW50OjpEaWdpdCkgKiBtX2xlbmd0aCk7 CisgICAgICAgIGlmIChtX2xlbmd0aCkKKyAgICAgICAgICAgIG1lbWNweShiaWdJbnQtPmRhdGFT dG9yYWdlKCksIHRoaXMtPmJ1ZmZlcigpLCBzaXplb2YoSlNCaWdJbnQ6OkRpZ2l0KSAqIG1fbGVu Z3RoKTsKICAgICAgICAgcmV0dXJuIGJpZ0ludDsKICAgICB9CiAK