<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>194518</bug_id>
          
          <creation_ts>2019-02-11 15:36:25 -0800</creation_ts>
          <short_desc>[ews-app] Add method to fetch patch</short_desc>
          <delta_ts>2019-02-12 16:03:29 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>lforschler</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1505019</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-02-11 15:36:25 -0800</bug_when>
    <thetext>Add method to fetch patch object given patch id.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505021</commentid>
    <comment_count>1</comment_count>
      <attachid>361721</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2019-02-11 15:38:47 -0800</bug_when>
    <thetext>Created attachment 361721
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505023</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-02-11 15:42:09 -0800</bug_when>
    <thetext>Attachment 361721 did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:80:  [Patch.get_patch] Class &apos;Patch&apos; has no &apos;objects&apos; member  [pylint/E1101] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505466</commentid>
    <comment_count>3</comment_count>
      <attachid>361721</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-12 16:02:30 -0800</bug_when>
    <thetext>Comment on attachment 361721
Proposed patch

Clearing flags on attachment: 361721

Committed r241326: &lt;https://trac.webkit.org/changeset/241326&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505467</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-12 16:02:31 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1505468</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-02-12 16:03:29 -0800</bug_when>
    <thetext>&lt;rdar://problem/48019402&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>361721</attachid>
            <date>2019-02-11 15:38:47 -0800</date>
            <delta_ts>2019-02-12 16:02:30 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>ews-app-get-patch.patch</filename>
            <type>text/plain</type>
            <size>1334</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI0MTI4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDEzIEBACisyMDE5LTAyLTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv
bT4KKworICAgICAgICBbZXdzLWFwcF0gQWRkIG1ldGhvZCB0byBmZXRjaCBwYXRjaAorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NTE4CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw
cG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvcGF0Y2gucHk6CisgICAgICAgIChQYXRjaC5nZXRfcGF0
Y2gpOgorCiAyMDE5LTAyLTExICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAog
ICAgICAgICBbaU9TXSBNb3VzZS9Ub3VjaC9Qb2ludGVyIGV2ZW50cyBhcmUgbWlzc2luZyBtb2Rp
ZmllciBrZXlzCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2Rl
bHMvcGF0Y2gucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFw
cC9ld3MvbW9kZWxzL3BhdGNoLnB5CShyZXZpc2lvbiAyNDEyODIpCisrKyBUb29scy9CdWlsZFNs
YXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvcGF0Y2gucHkJKHdvcmtpbmcgY29weSkKQEAg
LTc1LDYgKzc1LDEzIEBAIGNsYXNzIFBhdGNoKG1vZGVscy5Nb2RlbCk6CiAgICAgICAgIHJldHVy
biBQYXRjaC5pc19leGlzdGluZ19wYXRjaF9pZChwYXRjaF9pZCkgYW5kIFBhdGNoLm9iamVjdHMu
Z2V0KHBrPXBhdGNoX2lkKS5zZW50X3RvX2J1aWxkYm90CiAKICAgICBAY2xhc3NtZXRob2QKKyAg
ICBkZWYgZ2V0X3BhdGNoKGNscywgcGF0Y2hfaWQpOgorICAgICAgICB0cnk6CisgICAgICAgICAg
ICByZXR1cm4gUGF0Y2gub2JqZWN0cy5nZXQocGF0Y2hfaWQ9cGF0Y2hfaWQpCisgICAgICAgIGV4
Y2VwdDoKKyAgICAgICAgICAgIHJldHVybiBOb25lCisKKyAgICBAY2xhc3NtZXRob2QKICAgICBk
ZWYgc2V0X3NlbnRfdG9fYnVpbGRib3QoY2xzLCBwYXRjaF9pZCk6CiAgICAgICAgIGlmIG5vdCBQ
YXRjaC5pc19leGlzdGluZ19wYXRjaF9pZChwYXRjaF9pZCk6CiAgICAgICAgICAgICByZXR1cm4g
RVJSX05PTl9FWElTVElOR19QQVRDSAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>