194500 2019-02-11 08:07:42 -0800 [WPE][GTK] Sleep disabler code should inhibit idle when a "System" sleep disabler is requested 2019-02-12 01:30:04 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia commit-queue mcatanzaro webkit-bug-importer oldest_to_newest 1504865 0 mcatanzaro 2019-02-11 08:07:42 -0800 Splitting this out of bug #18697, I see I wrote this comment when writing SleepDisablerGlib: // We don't support suspend ("System") inhibitors, only idle inhibitors. // To get suspend inhibitors, we'd need to use the fancy GNOME // SessionManager API, which requires registering as a client application, // which is not practical from the web process. Secondly, because the only // current use of a suspend inhibitor in WebKit, // HTMLMediaElement::shouldDisableSleep, is suspicious. There's really no // valid reason for WebKit to ever block suspend, only idle. There are three things wrong with this comment: * Nowadays, GNOME suspends the computer automatically on inactivity, and we actually do want to prevent that. * Inhibiting idle does affect the autosuspend countdown. So the current code should prevent automatic suspend, just not manual suspend. (I think I stand by my comment that we do not want to inhibit normal suspend, since that would just be annoying.) * I don't know why I thought HTMLMediaElement::shouldDisableSleep was suspicious. Anyway, I guess the behavior we want is to ignore the Type argument and just always inhibit idle. That is, treat type=System the same way we current treat type=Display. I couldn't decide which to do when I wrote this code, but in retrospect that would have been a better option. 1504867 1 mcatanzaro 2019-02-11 08:19:22 -0800 (In reply to Michael Catanzaro from comment #0) > Splitting this out of bug #18697 I meant bug #186971 1504870 2 361680 mcatanzaro 2019-02-11 08:22:17 -0800 Created attachment 361680 Patch 1505176 3 361680 commit-queue 2019-02-12 01:29:52 -0800 Comment on attachment 361680 Patch Clearing flags on attachment: 361680 Committed r241290: <https://trac.webkit.org/changeset/241290> 1505177 4 commit-queue 2019-02-12 01:29:54 -0800 All reviewed patches have been landed. Closing bug. 361680 2019-02-11 08:22:17 -0800 2019-02-12 01:29:52 -0800 Patch bug-194500-20190211102215.patch text/plain 3387 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCAzYzBlZjg0 NDliMjA4ZTBmNmE4YTliNmI3MDhmOWI3MWJhN2NiNGQxLi4wNDg2YTk3YzQ2YzY5NGEwODU0ODY1 ZDMyY2E1ODM4YWViYTk3ZmNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAor MjAxOS0wMi0xMSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisK KyAgICAgICAgW1dQRV1bR1RLXSBTbGVlcCBkaXNhYmxlciBjb2RlIHNob3VsZCBpbmhpYml0IGlk bGUgd2hlbiBhICJTeXN0ZW0iIHNsZWVwIGRpc2FibGVyIGlzIHJlcXVlc3RlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NTAwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlIHRocmVlIHRo aW5ncyB3cm9uZyB3aXRoIHRoZSBjb21tZW50IGF0IHRoZSB0b3Agb2YgU2xlZXBEaXNhYmxlckdM aWIncyBjb25zdHJ1Y3RvcjoKKworICAgICAgICAoMSkgTm93YWRheXMsIEdOT01FIHN1c3BlbmRz IHRoZSBjb21wdXRlciBhdXRvbWF0aWNhbGx5IG9uIGluYWN0aXZpdHksIGFuZCB3ZSBhY3R1YWxs eSBkbworICAgICAgICAgICAgd2FudCB0byBwcmV2ZW50IHRoYXQuCisKKyAgICAgICAgKDIpIElu aGliaXRpbmcgaWRsZSBkb2VzIGFmZmVjdCB0aGUgYXV0b3N1c3BlbmQgY291bnRkb3duLiBTbyB0 aGUgY3VycmVudCBjb2RlIHNob3VsZAorICAgICAgICAgICAgcHJldmVudCBhdXRvbWF0aWMgc3Vz cGVuZCwganVzdCBub3QgbWFudWFsIHN1c3BlbmQuIChJIHRoaW5rIEkgc3RhbmQgYnkgbXkgY29t bWVudCB0aGF0CisgICAgICAgICAgICB3ZSBkbyBub3Qgd2FudCB0byBpbmhpYml0IG5vcm1hbCBz dXNwZW5kLCBzaW5jZSB0aGF0IHdvdWxkIGp1c3QgYmUgYW5ub3lpbmcuKQorCisgICAgICAgICgz KSBJIGRvbid0IGtub3cgd2h5IEkgdGhvdWdodCBIVE1MTWVkaWFFbGVtZW50OjpzaG91bGREaXNh YmxlU2xlZXAgd2FzIHN1c3BpY2lvdXMuCisKKyAgICAgICAgQW55d2F5LCB0aGUgYmVoYXZpb3Ig d2Ugd2FudCBpcyB0byBpZ25vcmUgdGhlIFR5cGUgYXJndW1lbnQgYW5kIGp1c3QgYWx3YXlzIGlu aGliaXQgaWRsZS4KKyAgICAgICAgVGhhdCBpcywgdHJlYXQgdHlwZT1TeXN0ZW0gdGhlIHNhbWUg d2F5IHdlIGN1cnJlbnQgdHJlYXQgdHlwZT1EaXNwbGF5LgorCisgICAgICAgICogcGFsL3N5c3Rl bS9nbGliL1NsZWVwRGlzYWJsZXJHTGliLmNwcDoKKyAgICAgICAgKFBBTDo6U2xlZXBEaXNhYmxl ckdMaWI6OlNsZWVwRGlzYWJsZXJHTGliKToKKwogMjAxOS0wMi0wOCAgTXlsZXMgQy4gTWF4Zmll bGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gQXNrIHBsYXRmb3Jt IGZvciBnZW5lcmljIGZvbnQgZmFtaWx5IG1hcHBpbmdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9QQUwvcGFsL3N5c3RlbS9nbGliL1NsZWVwRGlzYWJsZXJHTGliLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL1BBTC9wYWwvc3lzdGVtL2dsaWIvU2xlZXBEaXNhYmxlckdMaWIuY3BwCmluZGV4IDFl ODcyZmY1NjgyOWQ1MTdhZTg3OGQ1NzI0MTZkMmY1MjRiZmZiNzEuLjZmOTIyZTExOGFmZGZjODM1 NWE4NWMxODRjYzdlZjJiYWQzNTUyNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9w YWwvc3lzdGVtL2dsaWIvU2xlZXBEaXNhYmxlckdMaWIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L1BBTC9wYWwvc3lzdGVtL2dsaWIvU2xlZXBEaXNhYmxlckdMaWIuY3BwCkBAIC00MSwxNSArNDEs MTMgQEAgU2xlZXBEaXNhYmxlckdMaWI6OlNsZWVwRGlzYWJsZXJHTGliKGNvbnN0IGNoYXIqIHJl YXNvbiwgVHlwZSB0eXBlKQogICAgICwgbV9jYW5jZWxsYWJsZShhZG9wdEdSZWYoZ19jYW5jZWxs YWJsZV9uZXcoKSkpCiAgICAgLCBtX3JlYXNvbihyZWFzb24pCiB7Ci0gICAgLy8gV2UgZG9uJ3Qg c3VwcG9ydCBzdXNwZW5kICgiU3lzdGVtIikgaW5oaWJpdG9ycywgb25seSBpZGxlIGluaGliaXRv cnMuCi0gICAgLy8gVG8gZ2V0IHN1c3BlbmQgaW5oaWJpdG9ycywgd2UnZCBuZWVkIHRvIHVzZSB0 aGUgZmFuY3kgR05PTUUKLSAgICAvLyBTZXNzaW9uTWFuYWdlciBBUEksIHdoaWNoIHJlcXVpcmVz IHJlZ2lzdGVyaW5nIGFzIGEgY2xpZW50IGFwcGxpY2F0aW9uLAotICAgIC8vIHdoaWNoIGlzIG5v dCBwcmFjdGljYWwgZnJvbSB0aGUgd2ViIHByb2Nlc3MuIFNlY29uZGx5LCBiZWNhdXNlIHRoZSBv bmx5Ci0gICAgLy8gY3VycmVudCB1c2Ugb2YgYSBzdXNwZW5kIGluaGliaXRvciBpbiBXZWJLaXQs Ci0gICAgLy8gSFRNTE1lZGlhRWxlbWVudDo6c2hvdWxkRGlzYWJsZVNsZWVwLCBpcyBzdXNwaWNp b3VzLiBUaGVyZSdzIHJlYWxseSBubwotICAgIC8vIHZhbGlkIHJlYXNvbiBmb3IgV2ViS2l0IHRv IGV2ZXIgYmxvY2sgc3VzcGVuZCwgb25seSBpZGxlLgotICAgIGlmICh0eXBlICE9IFNsZWVwRGlz YWJsZXI6OlR5cGU6OkRpc3BsYXkpCi0gICAgICAgIHJldHVybjsKKyAgICAvLyBXZSBpZ25vcmUg VHlwZSBiZWNhdXNlIHdlIGFsd2F5cyB3YW50IHRvIGluaGliaXQgYm90aCBzY3JlZW4gbG9jayBh bmQKKyAgICAvLyBzdXNwZW5kLCBidXQgb25seSB3aGVuIGlkbGUuIFRoZXJlIGlzIG5vIHJlYXNv biBmb3IgV2ViS2l0IHRvIGV2ZXIgYmxvY2sKKyAgICAvLyBhIHVzZXIgZnJvbSBtYW51YWxseSBz dXNwZW5kaW5nIHRoZSBjb21wdXRlciwgc28gaW5oaWJpdGluZyBpZGxlCisgICAgLy8gc3VmZmlj ZXMuIFRoZXJlJ3MgYWxzbyBwcm9iYWJseSBubyBnb29kIHJlYXNvbiBmb3IgY29kZSB0YWtpbmcg YSBzbGVlcAorICAgIC8vIGRpc2FibGVyIHRvIGRpZmZlcmVudGlhdGUgYmV0d2VlbiBsb2NrIGFu ZCBzdXNwZW5kIG9uIG91ciBwbGF0Zm9ybS4gSWYgd2UKKyAgICAvLyBldmVyIG5lZWQgdGhpcyBk aXN0aW5jdGlvbiwgd2hpY2ggc2VlbXMgdW5saWtlbHksIHRoZW4gd2UnbGwgbmVlZCB0bworICAg IC8vIGF1ZGl0IGFsbCB1c2Ugb2YgU2xlZXBEaXNhYmxlci4KIAogICAgIC8vIEZpcnN0LCB0cnkg dG8gdXNlIHRoZSBTY3JlZW5TYXZlciBBUEkuCiAgICAgZ19kYnVzX3Byb3h5X25ld19mb3JfYnVz KEdfQlVTX1RZUEVfU0VTU0lPTiwgc3RhdGljX2Nhc3Q8R0RCdXNQcm94eUZsYWdzPihHX0RCVVNf UFJPWFlfRkxBR1NfRE9fTk9UX0xPQURfUFJPUEVSVElFUyB8IEdfREJVU19QUk9YWV9GTEFHU19E T19OT1RfQ09OTkVDVF9TSUdOQUxTKSwK