194497 2019-02-11 04:06:49 -0800 [WPE] Do not try to create empty egl windows 2019-02-11 06:09:03 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply webkit-bug-importer zan oldest_to_newest 1504840 0 cgarcia 2019-02-11 04:06:49 -0800 In AcceleratedSurfaceWPE we ensure the size we pass to wpe is at least 0x0, but wl_egl_window_create() returns nullptr if 0 is passed as width or height. We should use at least 1x1 instead. 1504841 1 361671 cgarcia 2019-02-11 04:08:44 -0800 Created attachment 361671 Patch 1504854 2 cgarcia 2019-02-11 06:08:11 -0800 Committed r241262: <https://trac.webkit.org/changeset/241262> 361671 2019-02-11 04:08:44 -0800 2019-02-11 05:38:55 -0800 Patch wpe-empty-egl-window.diff text/plain 2135 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNDFiMWU5ZDZlOWUuLmFlY2MxNTA0YzBmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDE5LTAyLTExICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbV1BFXSBEbyBub3QgdHJ5IHRvIGNyZWF0ZSBlbXB0eSBlZ2wgd2lu ZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0 NDk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4g QWNjZWxlcmF0ZWRTdXJmYWNlV1BFIHdlIGVuc3VyZSB0aGUgc2l6ZSB3ZSBwYXNzIHRvIHdwZSBp cyBhdCBsZWFzdCAweDAsIGJ1dCB3bF9lZ2xfd2luZG93X2NyZWF0ZSgpIHJldHVybnMKKyAgICAg ICAgbnVsbHB0ciBpZiAwIGlzIHBhc3NlZCBhcyB3aWR0aCBvciBoZWlnaHQuIFdlIHNob3VsZCB1 c2UgYXQgbGVhc3QgMXgxIGluc3RlYWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv d3BlL0FjY2VsZXJhdGVkU3VyZmFjZVdQRS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkFjY2VsZXJh dGVkU3VyZmFjZVdQRTo6aW5pdGlhbGl6ZSk6CisgICAgICAgIChXZWJLaXQ6OkFjY2VsZXJhdGVk U3VyZmFjZVdQRTo6Y2xpZW50UmVzaXplKToKKwogMjAxOS0wMi0xMSAgQ2FybG9zIEdhcmNpYSBD YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0gU2VuZCBjbGllbnQg aG9zdCBmZCBhbmQgbGlicmFyeSBuYW1lIGFzIHdlYiBwcm9jZXNzIGNyZWF0aW9uIHBhcmFtZXRl cnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3dwZS9BY2Nl bGVyYXRlZFN1cmZhY2VXUEUuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uv d3BlL0FjY2VsZXJhdGVkU3VyZmFjZVdQRS5jcHAKaW5kZXggOWI4Y2NiY2I1Y2QuLjUzMGQ3NDZm OTg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS93cGUvQWNj ZWxlcmF0ZWRTdXJmYWNlV1BFLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS93cGUvQWNjZWxlcmF0ZWRTdXJmYWNlV1BFLmNwcApAQCAtNjYsNyArNjYsNyBAQCB2b2lk IEFjY2VsZXJhdGVkU3VyZmFjZVdQRTo6aW5pdGlhbGl6ZSgpCiAgICAgfTsKICAgICB3cGVfcmVu ZGVyZXJfYmFja2VuZF9lZ2xfdGFyZ2V0X3NldF9jbGllbnQobV9iYWNrZW5kLCAmc19jbGllbnQs IHRoaXMpOwogICAgIHdwZV9yZW5kZXJlcl9iYWNrZW5kX2VnbF90YXJnZXRfaW5pdGlhbGl6ZSht X2JhY2tlbmQsIGRvd25jYXN0PFBsYXRmb3JtRGlzcGxheUxpYldQRT4oUGxhdGZvcm1EaXNwbGF5 OjpzaGFyZWREaXNwbGF5KCkpLmJhY2tlbmQoKSwKLSAgICAgICAgc3RkOjptYXgoMCwgbV9zaXpl LndpZHRoKCkpLCBzdGQ6Om1heCgwLCBtX3NpemUuaGVpZ2h0KCkpKTsKKyAgICAgICAgc3RkOjpt YXgoMSwgbV9zaXplLndpZHRoKCkpLCBzdGQ6Om1heCgxLCBtX3NpemUuaGVpZ2h0KCkpKTsKIH0K IAogdm9pZCBBY2NlbGVyYXRlZFN1cmZhY2VXUEU6OmZpbmFsaXplKCkKQEAgLTk0LDcgKzk0LDcg QEAgdWludDY0X3QgQWNjZWxlcmF0ZWRTdXJmYWNlV1BFOjpzdXJmYWNlSUQoKSBjb25zdAogdm9p ZCBBY2NlbGVyYXRlZFN1cmZhY2VXUEU6OmNsaWVudFJlc2l6ZShjb25zdCBJbnRTaXplJiBzaXpl KQogewogICAgIEFTU0VSVChtX2JhY2tlbmQpOwotICAgIHdwZV9yZW5kZXJlcl9iYWNrZW5kX2Vn bF90YXJnZXRfcmVzaXplKG1fYmFja2VuZCwgc3RkOjptYXgoMCwgbV9zaXplLndpZHRoKCkpLCBz dGQ6Om1heCgwLCBtX3NpemUuaGVpZ2h0KCkpKTsKKyAgICB3cGVfcmVuZGVyZXJfYmFja2VuZF9l Z2xfdGFyZ2V0X3Jlc2l6ZShtX2JhY2tlbmQsIHN0ZDo6bWF4KDEsIG1fc2l6ZS53aWR0aCgpKSwg c3RkOjptYXgoMSwgbV9zaXplLmhlaWdodCgpKSk7CiB9CiAKIHZvaWQgQWNjZWxlcmF0ZWRTdXJm YWNlV1BFOjp3aWxsUmVuZGVyRnJhbWUoKQo=