194493 2019-02-10 23:34:17 -0800 Remove the RELEASE_ASSERT check for duplicate cases in the BinarySwitch constructor. 2019-02-11 10:11:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 194492 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1504816 0 mark.lam 2019-02-10 23:34:17 -0800 Having duplicate cases in the BinarySwitch if not a correctness issue. It is however not good for performance and memory usage. As such, a debug ASSERT will do. We'll also do an audit of the clients of BinarySwitch to see if it's possible to be instantiated with duplicate cases in https://bugs.webkit.org/show_bug.cgi?id=194492 later. 1504817 1 mark.lam 2019-02-10 23:34:38 -0800 <rdar://problem/36380852> 1504819 2 361662 mark.lam 2019-02-10 23:49:22 -0800 Created attachment 361662 proposed patch. 1504820 3 361663 mark.lam 2019-02-10 23:51:04 -0800 Created attachment 361663 proposed patch. 1504821 4 361664 mark.lam 2019-02-11 00:04:18 -0800 Created attachment 361664 proposed patch. 1504829 5 361664 ysuzuki 2019-02-11 01:44:10 -0800 Comment on attachment 361664 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=361664&action=review r=me > Source/JavaScriptCore/jit/BinarySwitch.cpp:65 > + RELEASE_ASSERT(m_cases[i - 1] < m_cases[i], i, m_cases.size(), m_cases[i].value, m_cases[i].index); Why not using `ASSERT` here? 1504904 6 mark.lam 2019-02-11 10:11:16 -0800 Thanks for the review. I've changed the RELEASE_ASSERT to a debug ASSERT. Landed in r241267: <http://trac.webkit.org/r241267>. 361662 2019-02-10 23:49:22 -0800 2019-02-10 23:51:04 -0800 proposed patch. bug-194493.patch text/plain 2216 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQxMjU4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE5LTAyLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgdGhlIFJFTEVBU0VfQVNTRVJUIGNoZWNrIGZvciBkdXBsaWNhdGUgY2FzZXMgaW4gdGhl IEJpbmFyeVN3aXRjaCBjb25zdHJ1Y3Rvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5NDQ5MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYzODA4 NTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGF2 aW5nIGR1cGxpY2F0ZSBjYXNlcyBpbiB0aGUgQmluYXJ5U3dpdGNoIGlzIG5vdCBhIGNvcnJlY3Ru ZXNzIGlzc3VlLiAgSXQgaXMKKyAgICAgICAgaG93ZXZlciBub3QgZ29vZCBmb3IgcGVyZm9ybWFu Y2UgYW5kIG1lbW9yeSB1c2FnZS4gIEFzIHN1Y2gsIGEgZGVidWcgQVNTRVJUIHdpbGwKKyAgICAg ICAgZG8uICBXZSdsbCBhbHNvIGRvIGFuIGF1ZGl0IG9mIHRoZSBjbGllbnRzIG9mIEJpbmFyeVN3 aXRjaCB0byBzZWUgaWYgaXQncworICAgICAgICBwb3NzaWJsZSB0byBiZSBpbnN0YW50aWF0ZWQg d2l0aCBkdXBsaWNhdGUgY2FzZXMgaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NDQ5MiBsYXRlci4KKworICAgICAgICBBbHNvIGFkZGVkIHNvbWUg dmFsdWUgZHVtcHMgdG8gdGhlIFJFTEVBU0VfQVNTRVJUIHRvIGhlbHAgZGVidWcgdGhlIGlzc3Vl IHdoZW4gd2UKKyAgICAgICAgZXZlciBzZWUgZHVwbGljYXRlIGNhc2VzLgorCisgICAgICAgICog aml0L0JpbmFyeVN3aXRjaC5jcHA6CisgICAgICAgIChKU0M6OkJpbmFyeVN3aXRjaDo6QmluYXJ5 U3dpdGNoKToKKwogMjAxOS0wMi0xMCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgU3dpdGNoIHVzZXMgb2YgU3RyaW5nQnVpbGRlciB3aXRoIFN0cmluZzo6Zm9ybWF0 IGZvciBoZXggbnVtYmVycyB0byB1c2UgSGV4TnVtYmVyLmggaW5zdGVhZApJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9CaW5hcnlTd2l0Y2guY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvQmluYXJ5U3dpdGNoLmNwcAkocmV2aXNpb24gMjQxMjU4KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9CaW5hcnlTd2l0Y2guY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMywgMjAxNSBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTMtMjAxOSBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5k IHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2Rp ZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRp dGlvbnMKQEAgLTU5LDEwICs1OSwxMiBAQCBCaW5hcnlTd2l0Y2g6OkJpbmFyeVN3aXRjaChHUFJS ZWcgdmFsdWUsCiAKICAgICBpZiAoQmluYXJ5U3dpdGNoSW50ZXJuYWw6OnZlcmJvc2UpCiAgICAg ICAgIGRhdGFMb2coIlNvcnRlZCBjYXNlczogIiwgbGlzdER1bXAobV9jYXNlcyksICJcbiIpOwot ICAgIAorCisjaWYgIUFTU0VSVF9ESVNBQkxFRAogICAgIGZvciAodW5zaWduZWQgaSA9IDE7IGkg PCBtX2Nhc2VzLnNpemUoKTsgKytpKQotICAgICAgICBSRUxFQVNFX0FTU0VSVChtX2Nhc2VzW2kg LSAxXSA8IG1fY2FzZXNbaV0pOwotICAgIAorICAgICAgICBSRUxFQVNFX0FTU0VSVChtX2Nhc2Vz W2kgLSAxXSA8IG1fY2FzZXNbaV0sIGksIG1fY2FzZXMuc2l6ZSgpLCBtX2Nhc2VzW2ldKTsKKyNl bmRpZgorCiAgICAgYnVpbGQoMCwgZmFsc2UsIG1fY2FzZXMuc2l6ZSgpKTsKIH0KIAo= 361663 2019-02-10 23:51:04 -0800 2019-02-11 00:03:30 -0800 proposed patch. bug-194493.patch text/plain 2211 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQxMjU4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE5LTAyLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgdGhlIFJFTEVBU0VfQVNTRVJUIGNoZWNrIGZvciBkdXBsaWNhdGUgY2FzZXMgaW4gdGhl IEJpbmFyeVN3aXRjaCBjb25zdHJ1Y3Rvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5NDQ5MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYzODA4 NTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGF2 aW5nIGR1cGxpY2F0ZSBjYXNlcyBpbiB0aGUgQmluYXJ5U3dpdGNoIGlzIG5vdCBhIGNvcnJlY3Ru ZXNzIGlzc3VlLiAgSXQgaXMKKyAgICAgICAgaG93ZXZlciBub3QgZ29vZCBmb3IgcGVyZm9ybWFu Y2UgYW5kIG1lbW9yeSB1c2FnZS4gIEFzIHN1Y2gsIGEgZGVidWcgQVNTRVJUIHdpbGwKKyAgICAg ICAgZG8uICBXZSdsbCBhbHNvIGRvIGFuIGF1ZGl0IG9mIHRoZSBjbGllbnRzIG9mIEJpbmFyeVN3 aXRjaCB0byBzZWUgaWYgaXQncworICAgICAgICBwb3NzaWJsZSB0byBiZSBpbnN0YW50aWF0ZWQg d2l0aCBkdXBsaWNhdGUgY2FzZXMgaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NDQ5MiBsYXRlci4KKworICAgICAgICBBbHNvIGFkZGVkIHNvbWUg dmFsdWUgZHVtcHMgdG8gdGhlIFJFTEVBU0VfQVNTRVJUIHRvIGhlbHAgZGVidWcgdGhlIGlzc3Vl IHdoZW4gd2UKKyAgICAgICAgc2VlIGR1cGxpY2F0ZSBjYXNlcy4KKworICAgICAgICAqIGppdC9C aW5hcnlTd2l0Y2guY3BwOgorICAgICAgICAoSlNDOjpCaW5hcnlTd2l0Y2g6OkJpbmFyeVN3aXRj aCk6CisKIDIwMTktMDItMTAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFN3aXRjaCB1c2VzIG9mIFN0cmluZ0J1aWxkZXIgd2l0aCBTdHJpbmc6OmZvcm1hdCBmb3Ig aGV4IG51bWJlcnMgdG8gdXNlIEhleE51bWJlci5oIGluc3RlYWQKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvQmluYXJ5U3dpdGNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0JpbmFyeVN3aXRjaC5jcHAJKHJldmlzaW9uIDI0MTI1OCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQmluYXJ5U3dpdGNoLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTMsIDIwMTUgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEzLTIwMTkgQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0 aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z CkBAIC01OSwxMCArNTksMTIgQEAgQmluYXJ5U3dpdGNoOjpCaW5hcnlTd2l0Y2goR1BSUmVnIHZh bHVlLAogCiAgICAgaWYgKEJpbmFyeVN3aXRjaEludGVybmFsOjp2ZXJib3NlKQogICAgICAgICBk YXRhTG9nKCJTb3J0ZWQgY2FzZXM6ICIsIGxpc3REdW1wKG1fY2FzZXMpLCAiXG4iKTsKLSAgICAK KworI2lmICFBU1NFUlRfRElTQUJMRUQKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAxOyBpIDwgbV9j YXNlcy5zaXplKCk7ICsraSkKLSAgICAgICAgUkVMRUFTRV9BU1NFUlQobV9jYXNlc1tpIC0gMV0g PCBtX2Nhc2VzW2ldKTsKLSAgICAKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQobV9jYXNlc1tpIC0g MV0gPCBtX2Nhc2VzW2ldLCBpLCBtX2Nhc2VzLnNpemUoKSwgbV9jYXNlc1tpXSk7CisjZW5kaWYK KwogICAgIGJ1aWxkKDAsIGZhbHNlLCBtX2Nhc2VzLnNpemUoKSk7CiB9CiAK 361664 2019-02-11 00:04:18 -0800 2019-02-11 01:44:10 -0800 proposed patch. bug-194493.patch text/plain 2235 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQxMjU4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE5LTAyLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgdGhlIFJFTEVBU0VfQVNTRVJUIGNoZWNrIGZvciBkdXBsaWNhdGUgY2FzZXMgaW4gdGhl IEJpbmFyeVN3aXRjaCBjb25zdHJ1Y3Rvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5NDQ5MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzYzODA4 NTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGF2 aW5nIGR1cGxpY2F0ZSBjYXNlcyBpbiB0aGUgQmluYXJ5U3dpdGNoIGlzIG5vdCBhIGNvcnJlY3Ru ZXNzIGlzc3VlLiAgSXQgaXMKKyAgICAgICAgaG93ZXZlciBub3QgZ29vZCBmb3IgcGVyZm9ybWFu Y2UgYW5kIG1lbW9yeSB1c2FnZS4gIEFzIHN1Y2gsIGEgZGVidWcgQVNTRVJUIHdpbGwKKyAgICAg ICAgZG8uICBXZSdsbCBhbHNvIGRvIGFuIGF1ZGl0IG9mIHRoZSBjbGllbnRzIG9mIEJpbmFyeVN3 aXRjaCB0byBzZWUgaWYgaXQncworICAgICAgICBwb3NzaWJsZSB0byBiZSBpbnN0YW50aWF0ZWQg d2l0aCBkdXBsaWNhdGUgY2FzZXMgaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NDQ5MiBsYXRlci4KKworICAgICAgICBBbHNvIGFkZGVkIHNvbWUg dmFsdWUgZHVtcHMgdG8gdGhlIFJFTEVBU0VfQVNTRVJUIHRvIGhlbHAgZGVidWcgdGhlIGlzc3Vl IHdoZW4gd2UKKyAgICAgICAgc2VlIGR1cGxpY2F0ZSBjYXNlcy4KKworICAgICAgICAqIGppdC9C aW5hcnlTd2l0Y2guY3BwOgorICAgICAgICAoSlNDOjpCaW5hcnlTd2l0Y2g6OkJpbmFyeVN3aXRj aCk6CisKIDIwMTktMDItMTAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFN3aXRjaCB1c2VzIG9mIFN0cmluZ0J1aWxkZXIgd2l0aCBTdHJpbmc6OmZvcm1hdCBmb3Ig aGV4IG51bWJlcnMgdG8gdXNlIEhleE51bWJlci5oIGluc3RlYWQKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvQmluYXJ5U3dpdGNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0JpbmFyeVN3aXRjaC5jcHAJKHJldmlzaW9uIDI0MTI1OCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQmluYXJ5U3dpdGNoLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTMsIDIwMTUgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEzLTIwMTkgQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0 aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z CkBAIC01OSwxMCArNTksMTIgQEAgQmluYXJ5U3dpdGNoOjpCaW5hcnlTd2l0Y2goR1BSUmVnIHZh bHVlLAogCiAgICAgaWYgKEJpbmFyeVN3aXRjaEludGVybmFsOjp2ZXJib3NlKQogICAgICAgICBk YXRhTG9nKCJTb3J0ZWQgY2FzZXM6ICIsIGxpc3REdW1wKG1fY2FzZXMpLCAiXG4iKTsKLSAgICAK KworI2lmICFBU1NFUlRfRElTQUJMRUQKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAxOyBpIDwgbV9j YXNlcy5zaXplKCk7ICsraSkKLSAgICAgICAgUkVMRUFTRV9BU1NFUlQobV9jYXNlc1tpIC0gMV0g PCBtX2Nhc2VzW2ldKTsKLSAgICAKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQobV9jYXNlc1tpIC0g MV0gPCBtX2Nhc2VzW2ldLCBpLCBtX2Nhc2VzLnNpemUoKSwgbV9jYXNlc1tpXS52YWx1ZSwgbV9j YXNlc1tpXS5pbmRleCk7CisjZW5kaWYKKwogICAgIGJ1aWxkKDAsIGZhbHNlLCBtX2Nhc2VzLnNp emUoKSk7CiB9CiAK