194478 2019-02-09 17:14:43 -0800 [LFC][IFC] Add intrinsic width support for replaced boxes 2019-02-10 08:54:27 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1504652 0 zalan 2019-02-09 17:14:43 -0800 ssia 1504653 1 361617 zalan 2019-02-09 17:18:32 -0800 Created attachment 361617 Patch 1504681 2 361617 commit-queue 2019-02-10 08:53:47 -0800 Comment on attachment 361617 Patch Clearing flags on attachment: 361617 Committed r241249: <https://trac.webkit.org/changeset/241249> 1504682 3 commit-queue 2019-02-10 08:53:49 -0800 All reviewed patches have been landed. Closing bug. 1504683 4 webkit-bug-importer 2019-02-10 08:54:27 -0800 <rdar://problem/47949150> 361617 2019-02-09 17:18:32 -0800 2019-02-10 08:53:47 -0800 Patch bug-194478-20190209171831.patch text/plain 7333 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTAzMjBjMjA5OGQ1YWU2 YzJiODI1Y2UxNDJkNjQwYTVkNzNmYTk4Yy4uNDQyOTgyNTk0ZTk3NThmNmYyYzFjMTgxNjkxYzk3 NTU4NzQyZDg1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTAyLTA5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBBZGQgaW50 cmluc2ljIHdpZHRoIHN1cHBvcnQgZm9yIHJlcGxhY2VkIGJveGVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ0NzgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5n L0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6 SW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OmxheW91dCBjb25zdCk6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXQ6OklubGluZUZvcm1hdHRpbmdDb250ZXh0OjppbnN0cmluc2ljV2lkdGhDb25zdHJh aW50cyBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZvcm1hdHRpbmdD b250ZXh0Ojpjb21wdXRlTWFyZ2luIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6 SW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVCb3JkZXJBbmRQYWRkaW5nIGNvbnN0KToK KyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6SW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OmxheW91 dEZvcm1hdHRpbmdDb250ZXh0Um9vdCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6 OklubGluZUZvcm1hdHRpbmdDb250ZXh0Ojpjb21wdXRlV2lkdGhBbmRIZWlnaHRGb3JSZXBsYWNl ZElubGluZUJveCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZvcm1h dHRpbmdDb250ZXh0Ojpjb21wdXRlTWFyZ2luQm9yZGVyQW5kUGFkZGluZyBjb25zdCk6IERlbGV0 ZWQuCisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0Nv bnRleHQuaDoKKwogMjAxOS0wMi0wOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgRWxpbWluYXRlIHVubmVjZXNzYXJ5IFN0cmluZyB0ZW1wb3JhcmllcyBieSB1c2lu ZyBTdHJpbmdDb25jYXRlbmF0ZU51bWJlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0 LmNwcAppbmRleCBkMjYyMDFlYThkNDk1MDVjMTMzZTE5MzNjMDUxNTY3YWFmNTc2ZGJkLi5mMmQ1 ZmE2M2FiNjA4M2JkMGYwY2E1OWJkMWI1NGM2N2MyZjg0MzU0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9y bWF0dGluZ0NvbnRleHQuY3BwCkBAIC03Nyw5ICs3NywxMSBAQCB2b2lkIElubGluZUZvcm1hdHRp bmdDb250ZXh0OjpsYXlvdXQoKSBjb25zdAogICAgIHdoaWxlIChsYXlvdXRCb3gpIHsKICAgICAg ICAgaWYgKGxheW91dEJveC0+ZXN0YWJsaXNoZXNGb3JtYXR0aW5nQ29udGV4dCgpKQogICAgICAg ICAgICAgbGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRSb290KCpsYXlvdXRCb3gsIHVzZWRWYWx1ZXMp OwotICAgICAgICBlbHNlIGlmIChpczxDb250YWluZXI+KCpsYXlvdXRCb3gpKQotICAgICAgICAg ICAgY29tcHV0ZU1hcmdpbkJvcmRlckFuZFBhZGRpbmcoZG93bmNhc3Q8SW5saW5lQ29udGFpbmVy PigqbGF5b3V0Qm94KSwgdXNlZFZhbHVlcyk7Ci0gICAgICAgIGVsc2UgaWYgKGxheW91dEJveC0+ aXNSZXBsYWNlZCgpKQorICAgICAgICBlbHNlIGlmIChpczxDb250YWluZXI+KCpsYXlvdXRCb3gp KSB7CisgICAgICAgICAgICBhdXRvJiBpbmxpbmVDb250YWluZXIgPSBkb3duY2FzdDxJbmxpbmVD b250YWluZXI+KCpsYXlvdXRCb3gpOworICAgICAgICAgICAgY29tcHV0ZU1hcmdpbihpbmxpbmVD b250YWluZXIsIHVzZWRWYWx1ZXMpOworICAgICAgICAgICAgY29tcHV0ZUJvcmRlckFuZFBhZGRp bmcoaW5saW5lQ29udGFpbmVyLCB1c2VkVmFsdWVzKTsKKyAgICAgICAgfSBlbHNlIGlmIChsYXlv dXRCb3gtPmlzUmVwbGFjZWQoKSkKICAgICAgICAgICAgIGNvbXB1dGVXaWR0aEFuZEhlaWdodEZv clJlcGxhY2VkSW5saW5lQm94KCpsYXlvdXRCb3gsIHVzZWRWYWx1ZXMpOwogICAgICAgICBsYXlv dXRCb3ggPSBuZXh0SW5QcmVPcmRlcigqbGF5b3V0Qm94LCByb290KTsKICAgICB9CkBAIC0xMDEs MTAgKzEwMywxNyBAQCBGb3JtYXR0aW5nQ29udGV4dDo6SW5zdHJpbnNpY1dpZHRoQ29uc3RyYWlu dHMgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6Omluc3RyaW5zaQogICAgIGF1dG8gdXNlZFZhbHVl cyA9IFVzZWRIb3Jpem9udGFsVmFsdWVzIHsgeyB9LCB7IH0sIHsgfSB9OwogICAgIGF1dG8qIGxh eW91dEJveCA9IHJvb3QuZmlyc3RJbkZsb3dPckZsb2F0aW5nQ2hpbGQoKTsKICAgICB3aGlsZSAo bGF5b3V0Qm94KSB7Ci0gICAgICAgIGlmIChsYXlvdXRCb3gtPmVzdGFibGlzaGVzRm9ybWF0dGlu Z0NvbnRleHQoKSB8fCBsYXlvdXRCb3gtPmlzUmVwbGFjZWQoKSkKKyAgICAgICAgaWYgKGxheW91 dEJveC0+ZXN0YWJsaXNoZXNGb3JtYXR0aW5nQ29udGV4dCgpKQogICAgICAgICAgICAgQVNTRVJU X05PVF9JTVBMRU1FTlRFRF9ZRVQoKTsKLSAgICAgICAgZWxzZSBpZiAoaXM8Q29udGFpbmVyPigq bGF5b3V0Qm94KSkKLSAgICAgICAgICAgIGNvbXB1dGVNYXJnaW5Cb3JkZXJBbmRQYWRkaW5nKGRv d25jYXN0PElubGluZUNvbnRhaW5lcj4oKmxheW91dEJveCksIHVzZWRWYWx1ZXMpOworICAgICAg ICBlbHNlIGlmIChsYXlvdXRCb3gtPmlzUmVwbGFjZWQoKSB8fCBpczxDb250YWluZXI+KCpsYXlv dXRCb3gpKSB7CisgICAgICAgICAgICBjb21wdXRlQm9yZGVyQW5kUGFkZGluZygqbGF5b3V0Qm94 LCB1c2VkVmFsdWVzKTsKKyAgICAgICAgICAgIGlmIChsYXlvdXRCb3gtPmlzUmVwbGFjZWQoKSkK KyAgICAgICAgICAgICAgICBjb21wdXRlV2lkdGhBbmRNYXJnaW4oKmxheW91dEJveCwgdXNlZFZh bHVlcyk7CisgICAgICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgICAgICAvLyBTaW1wbGUgaW5s aW5lIGNvbnRhaW5lciB3aXRoIG5vIGludHJpbnNpYyB3aWR0aCA8c3Bhbj4uCisgICAgICAgICAg ICAgICAgY29tcHV0ZU1hcmdpbihkb3duY2FzdDxJbmxpbmVDb250YWluZXI+KCpsYXlvdXRCb3gp LCB1c2VkVmFsdWVzKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQogICAgICAgICBsYXlvdXRC b3ggPSBuZXh0SW5QcmVPcmRlcigqbGF5b3V0Qm94LCByb290KTsKICAgICB9CiAKQEAgLTEzMCwy NiArMTM5LDI1IEBAIEZvcm1hdHRpbmdDb250ZXh0OjpJbnN0cmluc2ljV2lkdGhDb25zdHJhaW50 cyBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6aW5zdHJpbnNpCiAgICAgcmV0dXJuIGluc3RyaW5z aWNXaWR0aENvbnN0cmFpbnRzOwogfQogCi12b2lkIElubGluZUZvcm1hdHRpbmdDb250ZXh0Ojpj b21wdXRlQm9yZGVyQW5kUGFkZGluZyhjb25zdCBCb3gmIGxheW91dEJveCwgVXNlZEhvcml6b250 YWxWYWx1ZXMgdXNlZFZhbHVlcykgY29uc3QKLXsKLSAgICBhdXRvJiBkaXNwbGF5Qm94ID0gbGF5 b3V0U3RhdGUoKS5kaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KGxheW91dEJveCk7Ci0gICAgZGlzcGxh eUJveC5zZXRCb3JkZXIoR2VvbWV0cnk6OmNvbXB1dGVkQm9yZGVyKGxheW91dEJveCkpOwotICAg IGRpc3BsYXlCb3guc2V0UGFkZGluZyhHZW9tZXRyeTo6Y29tcHV0ZWRQYWRkaW5nKGxheW91dEJv eCwgdXNlZFZhbHVlcykpOwotfQotCi12b2lkIElubGluZUZvcm1hdHRpbmdDb250ZXh0Ojpjb21w dXRlTWFyZ2luQm9yZGVyQW5kUGFkZGluZyhjb25zdCBJbmxpbmVDb250YWluZXImIGlubGluZUNv bnRhaW5lciwgVXNlZEhvcml6b250YWxWYWx1ZXMgdXNlZFZhbHVlcykgY29uc3QKK3ZvaWQgSW5s aW5lRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVNYXJnaW4oY29uc3QgSW5saW5lQ29udGFpbmVy JiBpbmxpbmVDb250YWluZXIsIFVzZWRIb3Jpem9udGFsVmFsdWVzIHVzZWRWYWx1ZXMpIGNvbnN0 CiB7CiAgICAgLy8gTm9uLXJlcGxhY2VkLCBub24tZm9ybWF0dGluZyByb290IGNvbnRhaW5lcnMg KDxzcGFuPjwvc3Bhbj4pIGRvbid0IGhhdmUgd2lkdGggcHJvcGVydHkgLT4gbm9uIHdpZHRoIGNv bXB1dGF0aW9uLiAKICAgICBBU1NFUlQoIWlubGluZUNvbnRhaW5lci5yZXBsYWNlZCgpKTsKICAg ICBBU1NFUlQoIWlubGluZUNvbnRhaW5lci5lc3RhYmxpc2hlc0Zvcm1hdHRpbmdDb250ZXh0KCkp OwogCi0gICAgY29tcHV0ZUJvcmRlckFuZFBhZGRpbmcoaW5saW5lQ29udGFpbmVyLCB1c2VkVmFs dWVzKTsKICAgICBhdXRvJiBkaXNwbGF5Qm94ID0gbGF5b3V0U3RhdGUoKS5kaXNwbGF5Qm94Rm9y TGF5b3V0Qm94KGlubGluZUNvbnRhaW5lcik7CiAgICAgYXV0byBjb21wdXRlZEhvcml6b250YWxN YXJnaW4gPSBHZW9tZXRyeTo6Y29tcHV0ZWRIb3Jpem9udGFsTWFyZ2luKGlubGluZUNvbnRhaW5l ciwgdXNlZFZhbHVlcyk7CiAgICAgZGlzcGxheUJveC5zZXRIb3Jpem9udGFsQ29tcHV0ZWRNYXJn aW4oY29tcHV0ZWRIb3Jpem9udGFsTWFyZ2luKTsKICAgICBkaXNwbGF5Qm94LnNldEhvcml6b250 YWxNYXJnaW4oeyBjb21wdXRlZEhvcml6b250YWxNYXJnaW4uc3RhcnQudmFsdWVPcigwKSwgY29t cHV0ZWRIb3Jpem9udGFsTWFyZ2luLmVuZC52YWx1ZU9yKDApIH0pOwogfQogCit2b2lkIElubGlu ZUZvcm1hdHRpbmdDb250ZXh0Ojpjb21wdXRlQm9yZGVyQW5kUGFkZGluZyhjb25zdCBCb3gmIGxh eW91dEJveCwgVXNlZEhvcml6b250YWxWYWx1ZXMgdXNlZFZhbHVlcykgY29uc3QKK3sKKyAgICBh dXRvJiBkaXNwbGF5Qm94ID0gbGF5b3V0U3RhdGUoKS5kaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KGxh eW91dEJveCk7CisgICAgZGlzcGxheUJveC5zZXRCb3JkZXIoR2VvbWV0cnk6OmNvbXB1dGVkQm9y ZGVyKGxheW91dEJveCkpOworICAgIGRpc3BsYXlCb3guc2V0UGFkZGluZyhHZW9tZXRyeTo6Y29t cHV0ZWRQYWRkaW5nKGxheW91dEJveCwgdXNlZFZhbHVlcykpOworfQorCiB2b2lkIElubGluZUZv cm1hdHRpbmdDb250ZXh0Ojpjb21wdXRlV2lkdGhBbmRNYXJnaW4oY29uc3QgQm94JiBsYXlvdXRC b3gsIFVzZWRIb3Jpem9udGFsVmFsdWVzIHVzZWRWYWx1ZXMpIGNvbnN0CiB7CiAgICAgYXV0byYg bGF5b3V0U3RhdGUgPSB0aGlzLT5sYXlvdXRTdGF0ZSgpOwpAQCAtMTkxLDYgKzE5OSw3IEBAIHZv aWQgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVIZWlnaHRBbmRNYXJnaW4oY29uc3Qg Qm94JiBsYXlvdXRCb3gpIGNvbnN0CiB2b2lkIElubGluZUZvcm1hdHRpbmdDb250ZXh0OjpsYXlv dXRGb3JtYXR0aW5nQ29udGV4dFJvb3QoY29uc3QgQm94JiByb290LCBVc2VkSG9yaXpvbnRhbFZh bHVlcyB1c2VkVmFsdWVzKSBjb25zdAogewogICAgIEFTU0VSVChyb290LmlzRmxvYXRpbmdQb3Np dGlvbmVkKCkgfHwgcm9vdC5pc0lubGluZUJsb2NrQm94KCkpOworICAgIEFTU0VSVCh1c2VkVmFs dWVzLmNvbnRhaW5pbmdCbG9ja1dpZHRoKTsKIAogICAgIGNvbXB1dGVCb3JkZXJBbmRQYWRkaW5n KHJvb3QsIHVzZWRWYWx1ZXMpOwogICAgIGNvbXB1dGVXaWR0aEFuZE1hcmdpbihyb290LCB1c2Vk VmFsdWVzKTsKQEAgLTIwOCw2ICsyMTcsNyBAQCB2b2lkIElubGluZUZvcm1hdHRpbmdDb250ZXh0 Ojpjb21wdXRlV2lkdGhBbmRIZWlnaHRGb3JSZXBsYWNlZElubGluZUJveChjb25zdCBCbwogICAg IEFTU0VSVCghbGF5b3V0Qm94LmlzQ29udGFpbmVyKCkpOwogICAgIEFTU0VSVCghbGF5b3V0Qm94 LmVzdGFibGlzaGVzRm9ybWF0dGluZ0NvbnRleHQoKSk7CiAgICAgQVNTRVJUKGxheW91dEJveC5y ZXBsYWNlZCgpKTsKKyAgICBBU1NFUlQodXNlZFZhbHVlcy5jb250YWluaW5nQmxvY2tXaWR0aCk7 CiAKICAgICBjb21wdXRlQm9yZGVyQW5kUGFkZGluZyhsYXlvdXRCb3gsIHVzZWRWYWx1ZXMpOwog ICAgIGNvbXB1dGVXaWR0aEFuZE1hcmdpbihsYXlvdXRCb3gsIHVzZWRWYWx1ZXMpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0 dGluZ0NvbnRleHQuaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lu bGluZUZvcm1hdHRpbmdDb250ZXh0LmgKaW5kZXggMGNiYjk2ZDJmNGY0ZmJiZTcyMmZmZmNmYzQ3 NTAxMWEyN2M5YWU3MC4uZmZhNzBlOWM5MDdiYzMzYWFkZTk1YTBmOTk5NTBkN2I4MjUyZTA0YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5l Rm9ybWF0dGluZ0NvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9y bWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5oCkBAIC04Nyw4ICs4Nyw4IEBAIHByaXZh dGU6CiAKICAgICB2b2lkIGxheW91dEZvcm1hdHRpbmdDb250ZXh0Um9vdChjb25zdCBCb3gmLCBV c2VkSG9yaXpvbnRhbFZhbHVlcykgY29uc3Q7CiAgICAgdm9pZCBjb21wdXRlV2lkdGhBbmRIZWln aHRGb3JSZXBsYWNlZElubGluZUJveChjb25zdCBCb3gmLCBVc2VkSG9yaXpvbnRhbFZhbHVlcykg Y29uc3Q7CisgICAgdm9pZCBjb21wdXRlTWFyZ2luKGNvbnN0IElubGluZUNvbnRhaW5lciYsIFVz ZWRIb3Jpem9udGFsVmFsdWVzKSBjb25zdDsKICAgICB2b2lkIGNvbXB1dGVCb3JkZXJBbmRQYWRk aW5nKGNvbnN0IEJveCYsIFVzZWRIb3Jpem9udGFsVmFsdWVzKSBjb25zdDsKLSAgICB2b2lkIGNv bXB1dGVNYXJnaW5Cb3JkZXJBbmRQYWRkaW5nKGNvbnN0IElubGluZUNvbnRhaW5lciYsIFVzZWRI b3Jpem9udGFsVmFsdWVzKSBjb25zdDsKICAgICB2b2lkIGNvbXB1dGVIZWlnaHRBbmRNYXJnaW4o Y29uc3QgQm94JikgY29uc3Q7CiAgICAgdm9pZCBjb21wdXRlV2lkdGhBbmRNYXJnaW4oY29uc3Qg Qm94JiwgVXNlZEhvcml6b250YWxWYWx1ZXMpIGNvbnN0OwogCg==