194472 2019-02-09 02:27:23 -0800 [GTK] Fix typo in the newly added API 2019-02-09 08:05:03 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alicem webkit-unassigned berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo mcatanzaro webkit-bug-importer oldest_to_newest 1504569 0 alicem 2019-02-09 02:27:23 -0800 I shouldn't have used find and replace to change allow -> enabled in https://bugs.webkit.org/show_bug.cgi?id=193919 1504570 1 361605 alicem 2019-02-09 02:30:25 -0800 Created attachment 361605 Patch 1504571 2 ews-watchlist 2019-02-09 02:32:17 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1504575 3 361605 mcatanzaro 2019-02-09 08:03:13 -0800 Comment on attachment 361605 Patch We also need #if PLATFORM(GTK) guards in the WebKitSettings.cpp, since it's not available for WPE. 1504576 4 mcatanzaro 2019-02-09 08:04:13 -0800 Committed r241240: <https://trac.webkit.org/changeset/241240> 1504577 5 mcatanzaro 2019-02-09 08:05:03 -0800 (In reply to Michael Catanzaro from comment #3) > Comment on attachment 361605 [details] > Patch > > We also need #if PLATFORM(GTK) guards in the WebKitSettings.cpp, since it's > not available for WPE. I see it's already in a larger group of guards. (I wonder why the font size setting is GTK-specific....) 361605 2019-02-09 02:30:25 -0800 2019-02-09 08:03:51 -0800 Patch bug-194472-20190209153023.patch text/plain 3008 alicem U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMwMmM4ZTI4MDA0MmFmMTFh YWY5MTY1ZTY3ZGQxMzRlZGU0OWY0MDguLmFjMjY5ZTM2OTMwYTk5YmExODAyOGFiYjYwYjEzNDhm MzI1NGJiNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDItMDkgIEFsZXhhbmRl ciBNaWtoYXlsZW5rbyAgPGV4YWxtNzY1OUBnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS10gRml4 IHR5cG8gaW4gdGhlIG5ld2x5IGFkZGVkIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NDcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4IGEgdHlwbzogZW5hYmxlZWQgLT4gZW5hYmxlZC4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAg ICh3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV9iYWNrX2ZvcndhcmRfbmF2aWdhdGlvbl9nZXN0 dXJlcyk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuaDoKKwog MjAxOS0wMi0wOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgog CiAgICAgICAgIFNwZWN1bGF0aXZlIGZpeCBmb3IgTW9qYXZlIEFQSSB0ZXN0IGFmdGVyIHIyNDEy MjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFNl dHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFNldHRp bmdzLmNwcAppbmRleCBhODQwNjUxYzZkYWE4MWMxYjVmYTZiZWQ1ZTAzMzE5MDIwMjk1ZWM0Li5h NzU3MDk0N2JjNTAwZWNhZWVkYmUzNjc2NDU1MGVkYzE1NTRkNTQyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRTZXR0aW5ncy5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwCkBAIC0zNTU3 LDIxICszNTU3LDIxIEBAIGdib29sZWFuIHdlYmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX2JhY2tf Zm9yd2FyZF9uYXZpZ2F0aW9uX2dlc3R1cmVzKFdlYktpdFNldHRpCiAvKioKICAqIHdlYmtpdF9z ZXR0aW5nc19zZXRfZW5hYmxlX2JhY2tfZm9yd2FyZF9uYXZpZ2F0aW9uX2dlc3R1cmVzOgogICog QHNldHRpbmdzOiBhICNXZWJLaXRTZXR0aW5ncwotICogQGVuYWJsZWVkOiB2YWx1ZSB0byBiZSBz ZXQKKyAqIEBlbmFibGVkOiB2YWx1ZSB0byBiZSBzZXQKICAqCiAgKiBTZXQgdGhlICNXZWJLaXRT ZXR0aW5nczplbmFibGUtYmFjay1mb3J3YXJkLW5hdmlnYXRpb24tZ2VzdHVyZXMgcHJvcGVydHku CiAgKgogICogU2luY2U6IDIuMjQKICAqLwotdm9pZCB3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJs ZV9iYWNrX2ZvcndhcmRfbmF2aWdhdGlvbl9nZXN0dXJlcyhXZWJLaXRTZXR0aW5ncyogc2V0dGlu Z3MsIGdib29sZWFuIGVuYWJsZWVkKQordm9pZCB3ZWJraXRfc2V0dGluZ3Nfc2V0X2VuYWJsZV9i YWNrX2ZvcndhcmRfbmF2aWdhdGlvbl9nZXN0dXJlcyhXZWJLaXRTZXR0aW5ncyogc2V0dGluZ3Ms IGdib29sZWFuIGVuYWJsZWQpCiB7CiAgICAgZ19yZXR1cm5faWZfZmFpbChXRUJLSVRfSVNfU0VU VElOR1Moc2V0dGluZ3MpKTsKIAogICAgIFdlYktpdFNldHRpbmdzUHJpdmF0ZSogcHJpdiA9IHNl dHRpbmdzLT5wcml2OwotICAgIGlmIChwcml2LT5lbmFibGVCYWNrRm9yd2FyZE5hdmlnYXRpb25H ZXN0dXJlcyA9PSBlbmFibGVlZCkKKyAgICBpZiAocHJpdi0+ZW5hYmxlQmFja0ZvcndhcmROYXZp Z2F0aW9uR2VzdHVyZXMgPT0gZW5hYmxlZCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgcHJpdi0+ ZW5hYmxlQmFja0ZvcndhcmROYXZpZ2F0aW9uR2VzdHVyZXMgPSBlbmFibGVlZDsKKyAgICBwcml2 LT5lbmFibGVCYWNrRm9yd2FyZE5hdmlnYXRpb25HZXN0dXJlcyA9IGVuYWJsZWQ7CiAgICAgZ19v YmplY3Rfbm90aWZ5KEdfT0JKRUNUKHNldHRpbmdzKSwgImVuYWJsZS1iYWNrLWZvcndhcmQtbmF2 aWdhdGlvbi1nZXN0dXJlcyIpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFNldHRpbmdzLmgKaW5kZXggZmYyMDMzNzNkOGRjMWUwODY1ODdlNDA2N2Q3 Y2U0ZjIwMTNkYWY1YS4uNDIwOTJhZGE1NzlmY2ViZjk5ZDEzNGUwNjdhNDdlMzQ0MDQ0OGVhOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5n cy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3Mu aApAQCAtNDc3LDcgKzQ3Nyw3IEBAIHdlYmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX2JhY2tfZm9y d2FyZF9uYXZpZ2F0aW9uX2dlc3R1cmVzICAgIChXZWJLaXRTZXR0aW5ncyAqCiAKIFdFQktJVF9B UEkgdm9pZAogd2Via2l0X3NldHRpbmdzX3NldF9lbmFibGVfYmFja19mb3J3YXJkX25hdmlnYXRp b25fZ2VzdHVyZXMgICAgKFdlYktpdFNldHRpbmdzICpzZXR0aW5ncywKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnYm9vbGVh biAgICAgICAgZW5hYmxlZWQpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdib29sZWFuICAgICAgICBlbmFibGVkKTsKIAog V0VCS0lUX0FQSSBndWludDMyCiB3ZWJraXRfc2V0dGluZ3NfZm9udF9zaXplX3RvX3BvaW50cyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoZ3VpbnQzMiBwaXhlbHMpOwo=