194467 2019-02-08 19:20:40 -0800 [Cocoa] CTLineGetGlyphRuns() might return nullptr 2019-02-08 20:06:42 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield bfulgham commit-queue dino jonlee simon.fraser thorton webkit-bug-importer oldest_to_newest 1504465 0 mmaxfield 2019-02-08 19:20:40 -0800 [Cocoa] CTLineGetGlyphRuns() might return nullptr 1504466 1 361587 mmaxfield 2019-02-08 19:21:48 -0800 Created attachment 361587 Patch 1504468 2 mmaxfield 2019-02-08 19:22:32 -0800 <rdar://problem/42423999> 1504477 3 361587 commit-queue 2019-02-08 20:06:40 -0800 Comment on attachment 361587 Patch Clearing flags on attachment: 361587 Committed r241231: <https://trac.webkit.org/changeset/241231> 1504478 4 commit-queue 2019-02-08 20:06:42 -0800 All reviewed patches have been landed. Closing bug. 361587 2019-02-08 19:21:48 -0800 2019-02-08 20:06:40 -0800 Patch bug-194467-20190208192147.patch text/plain 2374 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjNiZGQ0N2YzMmJiMmMy YzY4NDg3MzIwNTVhOGUxMzBjOGM0NWQ0MS4uYjA2NmJhYjNmNmFhNDRiNDNjOWE0NjZkMTg2YWI3 YThiM2EwZDczOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAyLTA4ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBD VExpbmVHZXRHbHlwaFJ1bnMoKSBtaWdodCByZXR1cm4gbnVsbHB0cgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NDY3CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS80MjQyMzk5OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBCZSBzb21ld2hhdCBkZWZlbnNpdmUgdG8gdHJ5IHRvIG1ha2Ugc3VyZSB0aGlz IHNvcnQgb2YgdGhpbmcgZG9lc24ndCBoYXBwZW4gaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICBD b3ZlcmVkIGJ5IGZpbmQvdGV4dC9maW5kLWJhY2t3YXJkcy5odG1sCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9tYWMvQ29tcGxleFRleHRDb250cm9sbGVyQ29yZVRleHQubW06CisgICAg ICAgIChXZWJDb3JlOjpDb21wbGV4VGV4dENvbnRyb2xsZXI6OmNvbGxlY3RDb21wbGV4VGV4dFJ1 bnNGb3JDaGFyYWN0ZXJzKToKKwogMjAxOS0wMi0wOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lA YXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIFNocmluayBzaXplb2YoQ29kZUJsb2NrKSBtb3Jl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvQ29tcGxl eFRleHRDb250cm9sbGVyQ29yZVRleHQubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9tYWMvQ29tcGxleFRleHRDb250cm9sbGVyQ29yZVRleHQubW0KaW5kZXggMDM0YjdhYzAw NmM1YzZjOGM2YjQxY2VjMmU3MmY1NzAxYjZiODkzMC4uNzQ3NGU2MmI0ZGRhOWYzY2RjYmVkZDdh MmI3ODNkM2YxMjg0OTAyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlckNvcmVUZXh0Lm1tCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXJDb3JlVGV4 dC5tbQpAQCAtMTYyLDYgKzE2Miw5IEBAIHZvaWQgQ29tcGxleFRleHRDb250cm9sbGVyOjpjb2xs ZWN0Q29tcGxleFRleHRSdW5zRm9yQ2hhcmFjdGVycyhjb25zdCBVQ2hhciogY3AsCiAgICAgICAg IFJldGFpblB0cjxDVFR5cGVzZXR0ZXJSZWY+IHR5cGVzZXR0ZXIgPSBhZG9wdENGKENUVHlwZXNl dHRlckNyZWF0ZVdpdGhVbmlDaGFyUHJvdmlkZXJBbmRPcHRpb25zKCZwcm92aWRlU3RyaW5nQW5k QXR0cmlidXRlcywgMCwgJmluZm8sIG1fcnVuLmx0cigpID8gbHRyVHlwZXNldHRlck9wdGlvbnMg OiBydGxUeXBlc2V0dGVyT3B0aW9ucykpOwogICAgICAgICBJR05PUkVfTlVMTF9DSEVDS19XQVJO SU5HU19FTkQKIAorICAgICAgICBpZiAoIXR5cGVzZXR0ZXIpCisgICAgICAgICAgICByZXR1cm47 CisKICAgICAgICAgbGluZSA9IGFkb3B0Q0YoQ1RUeXBlc2V0dGVyQ3JlYXRlTGluZSh0eXBlc2V0 dGVyLmdldCgpLCBDRlJhbmdlTWFrZSgwLCAwKSkpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIFBy b3ZpZGVySW5mbyBpbmZvID0geyBjcCwgbGVuZ3RoLCBzdHJpbmdBdHRyaWJ1dGVzLmdldCgpIH07 CkBAIC0xNjksMTAgKzE3MiwxNiBAQCB2b2lkIENvbXBsZXhUZXh0Q29udHJvbGxlcjo6Y29sbGVj dENvbXBsZXhUZXh0UnVuc0ZvckNoYXJhY3RlcnMoY29uc3QgVUNoYXIqIGNwLAogICAgICAgICBs aW5lID0gYWRvcHRDRihDVExpbmVDcmVhdGVXaXRoVW5pQ2hhclByb3ZpZGVyKCZwcm92aWRlU3Ry aW5nQW5kQXR0cmlidXRlcywgbnVsbHB0ciwgJmluZm8pKTsKICAgICB9CiAKKyAgICBpZiAoIWxp bmUpCisgICAgICAgIHJldHVybjsKKwogICAgIG1fY29yZVRleHRMaW5lcy5hcHBlbmQobGluZS5n ZXQoKSk7CiAKICAgICBDRkFycmF5UmVmIHJ1bkFycmF5ID0gQ1RMaW5lR2V0R2x5cGhSdW5zKGxp bmUuZ2V0KCkpOwogCisgICAgaWYgKCFydW5BcnJheSkKKyAgICAgICAgcmV0dXJuOworCiAgICAg Q0ZJbmRleCBydW5Db3VudCA9IENGQXJyYXlHZXRDb3VudChydW5BcnJheSk7CiAKICAgICBmb3Ig KENGSW5kZXggciA9IDA7IHIgPCBydW5Db3VudDsgcisrKSB7Cg==