194462 2019-02-08 16:14:46 -0800 Add more more test for clampTo<>() 2019-02-09 16:47:08 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 benjamin benjamin commit-queue darin ggaren webkit-bug-importer oldest_to_newest 1504370 0 benjamin 2019-02-08 16:14:46 -0800 Add more more test for clampTo<>() 1504375 1 361555 benjamin 2019-02-08 16:23:11 -0800 Created attachment 361555 Patch 1504480 2 361589 benjamin 2019-02-08 20:13:45 -0800 Created attachment 361589 Patch 1504506 3 361589 ggaren 2019-02-08 22:07:48 -0800 Comment on attachment 361589 Patch r=me 1504582 4 361589 darin 2019-02-09 09:48:34 -0800 Comment on attachment 361589 Patch Great, that’s exactly what I had in mind. Could do the same for float. 1504643 5 361589 benjamin 2019-02-09 16:16:29 -0800 Comment on attachment 361589 Patch Thanks for the reviews. Before adding float I'd like to go back to the timer optimizations. 1504644 6 darin 2019-02-09 16:31:40 -0800 (In reply to Benjamin Poulain from comment #5) > Before adding float I'd like to go back to the timer optimizations. Yes, I agree, that’s way more valuable. I think you’ve already spent enough time on this. A nice idea to come back later and do a tiny bit more minor tweaking on the tests, but not really important at all. I didn’t mean to keep you stuck on this. 1504645 7 361589 commit-queue 2019-02-09 16:42:01 -0800 Comment on attachment 361589 Patch Clearing flags on attachment: 361589 Committed r241247: <https://trac.webkit.org/changeset/241247> 1504646 8 commit-queue 2019-02-09 16:42:03 -0800 All reviewed patches have been landed. Closing bug. 1504647 9 webkit-bug-importer 2019-02-09 16:47:08 -0800 <rdar://problem/47945009> 361555 2019-02-08 16:23:11 -0800 2019-02-08 20:13:44 -0800 Patch bug-194462-20190208162310.patch text/plain 3080 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjA5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDNjNDc1OGRkN2E4ZDk0YTc1OTI5MDI4OGYyNjg5OTYw YjI1YTFhNC4uOTNlMjc1NTc1YzEwZmU4NmVjNjYzMDZjMjgyMmNmNDBjOTBjYTRlMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTAyLTA4ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4K KworICAgICAgICBBZGQgbW9yZSBtb3JlIHRlc3QgZm9yIGNsYW1wVG88PigpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ0NjIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEYXJpbiBzdWdnZXN0ZWQgdG8g dGVzdCB0aGUgdmVyeSBsYXN0IGZsb2F0aW5nIHBvaW50IG51bWJlcgorICAgICAgICBhdCB0aGUg Ym91bmRhcmllcyB3aGVuIHRydW5jYXRlZCB0byBpbnRlZ2VyLgorICAgICAgICBJIGFkZGVkIHRl c3QgZm9yIG1heC9taW4gYW5kIG1heC0xL21pbi0xLgorCisgICAgICAgICogVGVzdFdlYktpdEFQ SS9UZXN0cy9XVEYvTWF0aEV4dHJhcy5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNU KToKKwogMjAxOS0wMi0wOCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAK ICAgICAgICAgd2Via2l0cHk6IENyYXNoTG9ncy5maW5kX2FsbF9sb2dzIG1heSByZXR1cm4gYSBz dHJpbmcgb3IgYSBkaWN0aW9uYXJ5CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dURi9NYXRoRXh0cmFzLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01h dGhFeHRyYXMuY3BwCmluZGV4IGM3NGUzYzllNTQ3NGY2OTg5N2U5NDYxMjU5NTQ3NWMyZDZlM2Jk MmUuLjEyODBkOGVjZWI1Y2Y3MmVmNmNjNDA2YTNhM2EyZTc0YjFjNTE3MWMgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01hdGhFeHRyYXMuY3BwCisrKyBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01hdGhFeHRyYXMuY3BwCkBAIC0zMTgsNiArMzE4LDI1 IEBAIFRFU1QoV1RGLCBjbGFtcEZsb2F0VG9JbnQpCiAgICAgRVhQRUNUX0VRKGNsYW1wVG88aW50 MzJfdD4oc3RhdGljX2Nhc3Q8ZG91YmxlPig5MDA3MTk5MjU0NzQwOTkxKSksIHN0ZDo6bnVtZXJp Y19saW1pdHM8aW50MzJfdD46Om1heCgpKTsKICAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90 PihzdGF0aWNfY2FzdDxkb3VibGU+KDkwMDcxOTkyNTQ3NDA5OTIpKSwgc3RkOjpudW1lcmljX2xp bWl0czxpbnQzMl90Pjo6bWF4KCkpOwogICAgIEVYUEVDVF9FUShjbGFtcFRvPGludDMyX3Q+KHN0 YXRpY19jYXN0PGRvdWJsZT4oOTAwNzE5OTI1NDc0MDk5MykpLCBzdGQ6Om51bWVyaWNfbGltaXRz PGludDMyX3Q+OjptYXgoKSk7CisKKyAgICAvLyBUZXN0IHRoZSBkb3VibGUgYXQgdGhlIGVkZ2Ug b2YgbWF4L21pbiBhbmQgbWF4LTEvbWluKzEuCisgICAgZG91YmxlIGludE1heCA9IHN0YXRpY19j YXN0PGRvdWJsZT4oc3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWF4KCkpOworICAgIEVY UEVDVF9FUShjbGFtcFRvPGludDMyX3Q+KGludE1heCksIHN0ZDo6bnVtZXJpY19saW1pdHM8aW50 MzJfdD46Om1heCgpKTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90PihzdGQ6Om5leHRh ZnRlcihpbnRNYXgsIDApKSwgc3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWF4KCkgLSAx KTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90PihzdGQ6Om5leHRhZnRlcihpbnRNYXgs IHN0ZDo6bnVtZXJpY19saW1pdHM8ZG91YmxlPjo6bWF4KCkpKSwgc3RkOjpudW1lcmljX2xpbWl0 czxpbnQzMl90Pjo6bWF4KCkpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG88aW50MzJfdD4oc3Rk OjpuZXh0YWZ0ZXIoaW50TWF4IC0gMS4sIDApKSwgc3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90 Pjo6bWF4KCkgLSAyKTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90PihpbnRNYXggLSAx KSwgc3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWF4KCkgLSAxKTsKKyAgICBFWFBFQ1Rf RVEoY2xhbXBUbzxpbnQzMl90PihzdGQ6Om5leHRhZnRlcihpbnRNYXggLSAxLiwgc3RkOjpudW1l cmljX2xpbWl0czxkb3VibGU+OjptYXgoKSkpLCBzdGQ6Om51bWVyaWNfbGltaXRzPGludDMyX3Q+ OjptYXgoKSAtIDEpOworCisgICAgZG91YmxlIGludE1pbiA9IHN0YXRpY19jYXN0PGRvdWJsZT4o c3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWluKCkpOworICAgIEVYUEVDVF9FUShjbGFt cFRvPGludDMyX3Q+KGludE1pbiksIHN0ZDo6bnVtZXJpY19saW1pdHM8aW50MzJfdD46Om1pbigp KTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90PihzdGQ6Om5leHRhZnRlcihpbnRNaW4s IDApKSwgc3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWluKCkgKyAxKTsKKyAgICBFWFBF Q1RfRVEoY2xhbXBUbzxpbnQzMl90PihzdGQ6Om5leHRhZnRlcihpbnRNaW4sIC1zdGQ6Om51bWVy aWNfbGltaXRzPGRvdWJsZT46Om1heCgpKSksIHN0ZDo6bnVtZXJpY19saW1pdHM8aW50MzJfdD46 Om1pbigpKTsKKworICAgIEVYUEVDVF9FUShjbGFtcFRvPGludDMyX3Q+KHN0ZDo6bmV4dGFmdGVy KGludE1pbiArIDEsIDApKSwgc3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWluKCkgKyAy KTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90PihpbnRNaW4gKyAxKSwgc3RkOjpudW1l cmljX2xpbWl0czxpbnQzMl90Pjo6bWluKCkgKyAxKTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxp bnQzMl90PihzdGQ6Om5leHRhZnRlcihpbnRNaW4gKyAxLCAtc3RkOjpudW1lcmljX2xpbWl0czxk b3VibGU+OjptYXgoKSkpLCBzdGQ6Om51bWVyaWNfbGltaXRzPGludDMyX3Q+OjptaW4oKSArIDEp OwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUYXJnZXRUeXBlLCB0eXBlbmFtZSBTb3VyY2VUeXBl Pgo= 361589 2019-02-08 20:13:45 -0800 2019-02-09 16:42:01 -0800 Patch bug-194462-20190208201345.patch text/plain 3077 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjA5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDNjNDc1OGRkN2E4ZDk0YTc1OTI5MDI4OGYyNjg5OTYw YjI1YTFhNC4uMWViZjkwOTk4ODQwZWZiZDc1YmNjNjMzMmJkZmU1NDA0Mzk5M2U5ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTAyLTA4ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4K KworICAgICAgICBBZGQgbW9yZSB0ZXN0cyBmb3IgY2xhbXBUbzw+KCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDQ2MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERhcmluIHN1Z2dlc3RlZCB0byB0ZXN0 IHRoZSB2ZXJ5IGxhc3QgZmxvYXRpbmcgcG9pbnQgbnVtYmVyCisgICAgICAgIGF0IHRoZSBib3Vu ZGFyaWVzIHdoZW4gdHJ1bmNhdGluZyB0byBpbnRlZ2VyLgorICAgICAgICBJIGFkZGVkIHRlc3Qg Zm9yIG1heC9taW4gYW5kIG1heC0xL21pbi0xLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9U ZXN0cy9XVEYvTWF0aEV4dHJhcy5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToK KwogMjAxOS0wMi0wOCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAg ICAgICAgd2Via2l0cHk6IENyYXNoTG9ncy5maW5kX2FsbF9sb2dzIG1heSByZXR1cm4gYSBzdHJp bmcgb3IgYSBkaWN0aW9uYXJ5CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dURi9NYXRoRXh0cmFzLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01hdGhF eHRyYXMuY3BwCmluZGV4IGM3NGUzYzllNTQ3NGY2OTg5N2U5NDYxMjU5NTQ3NWMyZDZlM2JkMmUu LjEyODBkOGVjZWI1Y2Y3MmVmNmNjNDA2YTNhM2EyZTc0YjFjNTE3MWMgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01hdGhFeHRyYXMuY3BwCisrKyBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV1RGL01hdGhFeHRyYXMuY3BwCkBAIC0zMTgsNiArMzE4LDI1IEBA IFRFU1QoV1RGLCBjbGFtcEZsb2F0VG9JbnQpCiAgICAgRVhQRUNUX0VRKGNsYW1wVG88aW50MzJf dD4oc3RhdGljX2Nhc3Q8ZG91YmxlPig5MDA3MTk5MjU0NzQwOTkxKSksIHN0ZDo6bnVtZXJpY19s aW1pdHM8aW50MzJfdD46Om1heCgpKTsKICAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90Pihz dGF0aWNfY2FzdDxkb3VibGU+KDkwMDcxOTkyNTQ3NDA5OTIpKSwgc3RkOjpudW1lcmljX2xpbWl0 czxpbnQzMl90Pjo6bWF4KCkpOwogICAgIEVYUEVDVF9FUShjbGFtcFRvPGludDMyX3Q+KHN0YXRp Y19jYXN0PGRvdWJsZT4oOTAwNzE5OTI1NDc0MDk5MykpLCBzdGQ6Om51bWVyaWNfbGltaXRzPGlu dDMyX3Q+OjptYXgoKSk7CisKKyAgICAvLyBUZXN0IHRoZSBkb3VibGUgYXQgdGhlIGVkZ2Ugb2Yg bWF4L21pbiBhbmQgbWF4LTEvbWluKzEuCisgICAgZG91YmxlIGludE1heCA9IHN0YXRpY19jYXN0 PGRvdWJsZT4oc3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWF4KCkpOworICAgIEVYUEVD VF9FUShjbGFtcFRvPGludDMyX3Q+KGludE1heCksIHN0ZDo6bnVtZXJpY19saW1pdHM8aW50MzJf dD46Om1heCgpKTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90PihzdGQ6Om5leHRhZnRl cihpbnRNYXgsIDApKSwgc3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWF4KCkgLSAxKTsK KyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90PihzdGQ6Om5leHRhZnRlcihpbnRNYXgsIHN0 ZDo6bnVtZXJpY19saW1pdHM8ZG91YmxlPjo6bWF4KCkpKSwgc3RkOjpudW1lcmljX2xpbWl0czxp bnQzMl90Pjo6bWF4KCkpOworCisgICAgRVhQRUNUX0VRKGNsYW1wVG88aW50MzJfdD4oc3RkOjpu ZXh0YWZ0ZXIoaW50TWF4IC0gMS4sIDApKSwgc3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6 bWF4KCkgLSAyKTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90PihpbnRNYXggLSAxKSwg c3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWF4KCkgLSAxKTsKKyAgICBFWFBFQ1RfRVEo Y2xhbXBUbzxpbnQzMl90PihzdGQ6Om5leHRhZnRlcihpbnRNYXggLSAxLiwgc3RkOjpudW1lcmlj X2xpbWl0czxkb3VibGU+OjptYXgoKSkpLCBzdGQ6Om51bWVyaWNfbGltaXRzPGludDMyX3Q+Ojpt YXgoKSAtIDEpOworCisgICAgZG91YmxlIGludE1pbiA9IHN0YXRpY19jYXN0PGRvdWJsZT4oc3Rk OjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWluKCkpOworICAgIEVYUEVDVF9FUShjbGFtcFRv PGludDMyX3Q+KGludE1pbiksIHN0ZDo6bnVtZXJpY19saW1pdHM8aW50MzJfdD46Om1pbigpKTsK KyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90PihzdGQ6Om5leHRhZnRlcihpbnRNaW4sIDAp KSwgc3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWluKCkgKyAxKTsKKyAgICBFWFBFQ1Rf RVEoY2xhbXBUbzxpbnQzMl90PihzdGQ6Om5leHRhZnRlcihpbnRNaW4sIC1zdGQ6Om51bWVyaWNf bGltaXRzPGRvdWJsZT46Om1heCgpKSksIHN0ZDo6bnVtZXJpY19saW1pdHM8aW50MzJfdD46Om1p bigpKTsKKworICAgIEVYUEVDVF9FUShjbGFtcFRvPGludDMyX3Q+KHN0ZDo6bmV4dGFmdGVyKGlu dE1pbiArIDEsIDApKSwgc3RkOjpudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWluKCkgKyAyKTsK KyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQzMl90PihpbnRNaW4gKyAxKSwgc3RkOjpudW1lcmlj X2xpbWl0czxpbnQzMl90Pjo6bWluKCkgKyAxKTsKKyAgICBFWFBFQ1RfRVEoY2xhbXBUbzxpbnQz Ml90PihzdGQ6Om5leHRhZnRlcihpbnRNaW4gKyAxLCAtc3RkOjpudW1lcmljX2xpbWl0czxkb3Vi bGU+OjptYXgoKSkpLCBzdGQ6Om51bWVyaWNfbGltaXRzPGludDMyX3Q+OjptaW4oKSArIDEpOwog fQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUYXJnZXRUeXBlLCB0eXBlbmFtZSBTb3VyY2VUeXBlPgo=