<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>194460</bug_id>
          
          <creation_ts>2019-02-08 15:42:41 -0800</creation_ts>
          <short_desc>B3LowerMacros wrongly sets m_changed to true in the case of AtomicWeakCAS on x86</short_desc>
          <delta_ts>2019-02-08 16:23:34 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Robin Morisset">rmorisset</reporter>
          <assigned_to name="Robin Morisset">rmorisset</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1504345</commentid>
    <comment_count>0</comment_count>
    <who name="Robin Morisset">rmorisset</who>
    <bug_when>2019-02-08 15:42:41 -0800</bug_when>
    <thetext>This is not a serious problem, but may lead to unnecessary calls to m_proc.resetReachability(); m_proc.invalidateCFG();</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504347</commentid>
    <comment_count>1</comment_count>
      <attachid>361546</attachid>
    <who name="Robin Morisset">rmorisset</who>
    <bug_when>2019-02-08 15:46:22 -0800</bug_when>
    <thetext>Created attachment 361546
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504354</commentid>
    <comment_count>2</comment_count>
      <attachid>361546</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2019-02-08 15:52:47 -0800</bug_when>
    <thetext>Comment on attachment 361546
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504373</commentid>
    <comment_count>3</comment_count>
      <attachid>361546</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-08 16:22:03 -0800</bug_when>
    <thetext>Comment on attachment 361546
Patch

Clearing flags on attachment: 361546

Committed r241217: &lt;https://trac.webkit.org/changeset/241217&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504374</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-08 16:22:04 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1504378</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-02-08 16:23:34 -0800</bug_when>
    <thetext>&lt;rdar://problem/47934098&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>361546</attachid>
            <date>2019-02-08 15:46:22 -0800</date>
            <delta_ts>2019-02-08 16:22:03 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-194460-20190208154622.patch</filename>
            <type>text/plain</type>
            <size>1752</size>
            <attacher name="Robin Morisset">rmorisset</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw
MzdkYmY1ODkxNWZhMmUxMDdmZWY4NjYxOTVmMmNmYmIyMTU3OWU0Li5iMmUzMjFjNDU5YTdkYTVk
ZjIxY2JhYjg5ZjZhOWY4MmY0M2U3MjM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxOS0wMi0wOCAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu
Y29tPgorCisgICAgICAgIEIzTG93ZXJNYWNyb3Mgd3JvbmdseSBzZXRzIG1fY2hhbmdlZCB0byB0
cnVlIGluIHRoZSBjYXNlIG9mIEF0b21pY1dlYWtDQVMgb24geDg2CisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ0NjAKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUcml2aWFsIGZpeCwgc2hvdWxkIGFscmVh
ZHkgYmUgY292ZXJlZCBieSB0ZXN0QXRvbWljV2Vha0NBUyBpbiB0ZXN0YjMuY3BwLgorCisgICAg
ICAgICogYjMvQjNMb3dlck1hY3Jvcy5jcHA6CisKIDIwMTktMDItMDggIFJvYmluIE1vcmlzc2V0
ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIEIzVmFsdWU6OnJldHVybnNC
b29sKCkgbW9yZSBwcmVjaXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMv
QjNMb3dlck1hY3Jvcy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNMb3dlck1hY3Jv
cy5jcHAKaW5kZXggZDRjNzU1YTJiOWVhY2Q1MTEwZmVlNDU4NmYzNDE5ZDUxNDY5YzdiYS4uYWJj
NTY1M2VhMTU2ZmU0ZjM4NDFiOWZlODVjODIzYTNmYzgxYWY5MyAxMDA2NDQKLS0tIGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL2IzL0IzTG93ZXJNYWNyb3MuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9iMy9CM0xvd2VyTWFjcm9zLmNwcApAQCAtMjMwLDYgKzIzMCw3IEBAIHByaXZhdGU6
CiAgICAgICAgICAgICAgICAgICAgICAgICBtX2luc2VydGlvblNldC5pbnNlcnRJbnRDb25zdGFu
dChtX2luZGV4LCBleHBlY3RlZFZhbHVlLCBtYXNrKHdpZHRoKSkpOwogICAgICAgICAgICAgICAg
ICAgICAKICAgICAgICAgICAgICAgICAgICAgYXRvbWljLT5jaGlsZCgwKSA9IG1hc2tlZEV4cGVj
dGVkVmFsdWU7CisgICAgICAgICAgICAgICAgICAgIG1fY2hhbmdlZCA9IHRydWU7CiAgICAgICAg
ICAgICAgICAgfQogICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgIGlmIChhdG9taWMt
Pm9wY29kZSgpID09IEF0b21pY1N0cm9uZ0NBUykgewpAQCAtMjM4LDkgKzIzOSw5IEBAIHByaXZh
dGU6CiAgICAgICAgICAgICAgICAgICAgICAgICBtX2luc2VydGlvblNldC5pbnNlcnRDbG9uZSht
X2luZGV4LCBhdG9taWMpKTsKICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAg
ICAgIGF0b21pYy0+cmVwbGFjZVdpdGhJZGVudGl0eShuZXdWYWx1ZSk7CisgICAgICAgICAgICAg
ICAgICAgIG1fY2hhbmdlZCA9IHRydWU7CiAgICAgICAgICAgICAgICAgfQotICAgICAgICAgICAg
ICAgIAotICAgICAgICAgICAgICAgIG1fY2hhbmdlZCA9IHRydWU7CisKICAgICAgICAgICAgICAg
ICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAK
</data>

          </attachment>
      

    </bug>

</bugzilla>