194459 2019-02-08 15:38:31 -0800 Web Inspector: Debugger Popover should work with value in template string `${identifier}` 2019-02-08 17:30:24 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1504342 0 joepeck 2019-02-08 15:38:31 -0800 Debugger Popover should work with value in template string `${identifier}` Steps to Reproduce: 1. Pause on a line like: let foo = `${window}`; 2. Hover over "window" => Expected debugger popover, but did not get one. 1504343 1 webkit-bug-importer 2019-02-08 15:39:46 -0800 <rdar://problem/47932564> 1504357 2 361550 joepeck 2019-02-08 15:56:31 -0800 Created attachment 361550 [PATCH] Proposed Fix Tested with: <script> setTimeout(() => { document.body.onclick = () => { let before = "test"; let array = [1, 2, 3]; console.log(`before ${array} after ${array.length}`); debugger; }; }); </script> • Was able to hover and get popovers inside of these: ${array} and ${array.length} • Did not get a popover when hovering the "before" in `before ...`. 1504407 3 361550 hi 2019-02-08 17:01:53 -0800 Comment on attachment 361550 [PATCH] Proposed Fix rs=me, I like it! 1504424 4 361550 commit-queue 2019-02-08 17:30:22 -0800 Comment on attachment 361550 [PATCH] Proposed Fix Clearing flags on attachment: 361550 Committed r241225: <https://trac.webkit.org/changeset/241225> 1504425 5 commit-queue 2019-02-08 17:30:24 -0800 All reviewed patches have been landed. Closing bug. 361550 2019-02-08 15:56:31 -0800 2019-02-08 17:30:22 -0800 [PATCH] Proposed Fix interpolation-1.patch text/plain 2435 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMzOTM5M2EwYTg2Li40YzljZGZmMjI2OSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDItMDggIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBEZWJ1Z2dlciBQb3BvdmVyIHNob3VsZCB3b3JrIHdpdGggdmFsdWUgaW4gdGVtcGxhdGUgc3Ry aW5nIGAke2lkZW50aWZpZXJ9YAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk0NDU5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzkzMjU2ND4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyLmpzOgor ICAgICAgICAoV0kuQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyLnByb3RvdHlwZS5f cHJvY2Vzc0phdmFTY3JpcHRFeHByZXNzaW9uKToKKyAgICAgICAgV2hlbiB3YWxraW5nIGJhY2t3 YXJkcyB0byBnZXQgdGhlIGZ1bGwgZXhwcmVzc2lvbiB3ZSB3ZXJlIHdhbGtpbmcgb3V0c2lkZQor ICAgICAgICBvZiB0aGUgaW50ZXJwb2xhdGlvbiBncm91cCBgb3V0c2lkZSAke2luc2lkZX1gLiBT dG9wIHdhbGtpbmcgYmFja3dhcmRzIG9uY2UKKyAgICAgICAgd2UgY3Jvc3MgdGhlIGJvdW5kYXJ5 LgorCiAyMDE5LTAyLTA4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogSW1wb3J0IC8gRXhwb3J0IEhlYXAgU25hcHNob3RzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVy cy9Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yVG9rZW5UcmFja2luZ0Nv bnRyb2xsZXIuanMKaW5kZXggZTg1OTZjNzA4ODYuLmMzYmVlZjBhM2ZiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9y VG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVy LmpzCkBAIC01NzgsMTAgKzU3OCwxNiBAQCBXSS5Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRy b2xsZXIgPSBjbGFzcyBDb2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIgZQogICAgICAg ICAgICAgaWYgKCFpc0RvdCAmJiAhaXNFeHByZXNzaW9uKQogICAgICAgICAgICAgICAgIGJyZWFr OwogCi0gICAgICAgICAgICAvLyBEaXNhbGxvdyBvcGVyYXRvcnMuIFdlIHdhbnQgdGhlIGhvdmVy ZWQgZXhwcmVzc2lvbiB0byBiZSBqdXN0IGEgc2luZ2xlIG9wZXJhbmQuCi0gICAgICAgICAgICAv LyBBbHNvLCBzb21lIG9wZXJhdG9ycyBjYW4gbW9kaWZ5IHZhbHVlcywgc3VjaCBhcyBwcmUtaW5j cmVtZW50IGFuZCBhc3NpZ25tZW50IG9wZXJhdG9ycy4KLSAgICAgICAgICAgIGlmIChpc0V4cHJl c3Npb24gJiYgdG9rZW4udHlwZS5pbmNsdWRlcygib3BlcmF0b3IiKSkKLSAgICAgICAgICAgICAg ICBicmVhazsKKyAgICAgICAgICAgIGlmIChpc0V4cHJlc3Npb24pIHsKKyAgICAgICAgICAgICAg ICAvLyBEaXNhbGxvdyBvcGVyYXRvcnMuIFdlIHdhbnQgdGhlIGhvdmVyZWQgZXhwcmVzc2lvbiB0 byBiZSBqdXN0IGEgc2luZ2xlIG9wZXJhbmQuCisgICAgICAgICAgICAgICAgLy8gQWxzbywgc29t ZSBvcGVyYXRvcnMgY2FuIG1vZGlmeSB2YWx1ZXMsIHN1Y2ggYXMgcHJlLWluY3JlbWVudCBhbmQg YXNzaWdubWVudCBvcGVyYXRvcnMuCisgICAgICAgICAgICAgICAgaWYgKHRva2VuLnR5cGUuaW5j bHVkZXMoIm9wZXJhdG9yIikpCisgICAgICAgICAgICAgICAgICAgIGJyZWFrOworCisgICAgICAg ICAgICAgICAgLy8gRG9uJ3QgYnJlYWsgb3V0IG9mIGEgdGVtcGxhdGUgc3RyaW5nIHF1YXNpIGdy b3VwLgorICAgICAgICAgICAgICAgIGlmICh0b2tlbi50eXBlLmluY2x1ZGVzKCJzdHJpbmctMiIp KQorICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIH0KIAogICAgICAgICAg ICAgZXhwcmVzc2lvbiA9IHRva2VuLnN0cmluZyArIGV4cHJlc3Npb247CiAgICAgICAgICAgICBl eHByZXNzaW9uU3RhcnRQb3NpdGlvbi5jaCA9IHRva2VuLnN0YXJ0Owo=