194442 2019-02-08 11:02:56 -0800 Abstract and discussion comments needed for afterScreenUpdates 2019-02-08 12:58:27 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin ggaren thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1504224 0 bdakin 2019-02-08 11:02:56 -0800 Forgot to add abstract and discussion comments with https://trac.webkit.org/changeset/241199/webkit Oops! 1504225 1 361517 bdakin 2019-02-08 11:05:32 -0800 Created attachment 361517 Patch 1504248 2 bdakin 2019-02-08 12:36:30 -0800 Thanks Wenson! https://trac.webkit.org/changeset/241204/webkit 1504249 3 webkit-bug-importer 2019-02-08 12:37:29 -0800 <rdar://problem/47926053> 1504256 4 361517 thorton 2019-02-08 12:56:48 -0800 Comment on attachment 361517 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361517&action=review > Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.h:53 > + which might not include recent changes. This has to be a MAY not a WILL :D 1504258 5 361517 thorton 2019-02-08 12:58:27 -0800 Comment on attachment 361517 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361517&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.h:53 >> + which might not include recent changes. > > This has to be a MAY not a WILL :D Wait, it is. The earlier will in the sentence is weird 361517 2019-02-08 11:05:32 -0800 2019-02-08 12:33:42 -0800 Patch for-review.txt text/plain 1488 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDEyMDApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAyLTA4ICBCZXRoIERha2lu ICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBBYnN0cmFjdCBhbmQgZGlzY3Vzc2lvbiBj b21tZW50cyBuZWVkZWQgZm9yIGFmdGVyU2NyZWVuVXBkYXRlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NDQyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yZ290IHRvIGFkZCB0aGVzZSBjb21tZW50 cyB3aXRoIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQzNjIKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLU25hcHNob3RDb25maWd1cmF0aW9uLmg6CisK IDIwMTktMDItMDggIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFk ZCBhZnRlclNjcmVlblVwZGF0ZXMgdG8gV0tTbmFwc2hvdENvbmZpZ3VyYXRpb24KSW5kZXg6IFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1NuYXBzaG90Q29uZmlndXJhdGlvbi5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1NuYXBz aG90Q29uZmlndXJhdGlvbi5oCShyZXZpc2lvbiAyNDExOTkpCisrKyBTb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tTbmFwc2hvdENvbmZpZ3VyYXRpb24uaAkod29ya2luZyBjb3B5 KQpAQCAtNDgsNiArNDgsMTEgQEAgV0tfQ0xBU1NfQVZBSUxBQkxFKG1hY29zeCgxMC4xMyksIGlv cygxMQogICovCiBAcHJvcGVydHkgKG51bGxhYmxlLCBub25hdG9taWMsIGNvcHkpIE5TTnVtYmVy ICpzbmFwc2hvdFdpZHRoOwogCisvKiEgQGFic3RyYWN0IEEgQm9vbGVhbiB2YWx1ZSB0aGF0IHNw ZWNpZmllcyB3aGV0aGVyIHRoZSBzbmFwc2hvdCBzaG91bGQgYmUgdGFrZW4gYWZ0ZXIgcmVjZW50 CisgY2hhbmdlcyBoYXZlIGJlZW4gaW5jb3Jwb3JhdGVkLiBUaGUgdmFsdWUgTk8gd2lsbCBjYXB0 dXJlIHRoZSBzY3JlZW4gaW4gaXRzIGN1cnJlbnQgc3RhdGUsCisgd2hpY2ggbWlnaHQgbm90IGlu Y2x1ZGUgcmVjZW50IGNoYW5nZXMuCisgQGRpc2N1c3Npb24gVGhlIGRlZmF1bHQgdmFsdWUgaXMg WUVTLgorICovCiBAcHJvcGVydHkgKG5vbmF0b21pYykgQk9PTCBhZnRlclNjcmVlblVwZGF0ZXMg V0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CiAK IEBlbmQK