194437 2019-02-08 09:10:51 -0800 REGRESSION (r240644): Layout Test inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky timeout 2019-05-15 15:37:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell hi commit-queue hi jlewis3 joepeck lforschler ryanhaddad sroberts webkit-bug-importer oldest_to_newest 1504182 0 tsavell 2019-02-08 09:10:51 -0800 The following layout test is flaky on Mojave inspector/page/overrideSetting-ICECandidateFilteringEnabled.html Probable cause: Test was introduced in https://trac.webkit.org/changeset/240644/webkit and is a flakey timeout. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fpage%2FoverrideSetting-ICECandidateFilteringEnabled.html 1505301 1 webkit-bug-importer 2019-02-12 11:24:52 -0800 <rdar://problem/48008005> 1510749 2 363171 hi 2019-02-27 17:58:34 -0800 Created attachment 363171 Patch Not really sure why it's flaky, but I ran it a few hundred times on my machine (WK1 and WK2) and it seemed to work better 1511115 3 363171 joepeck 2019-02-28 14:20:41 -0800 Comment on attachment 363171 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363171&action=review rs=me > LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:24 > + delete pc.onicecandidate; Just set it to null instead of delete? 1511136 4 363171 commit-queue 2019-02-28 14:54:43 -0800 Comment on attachment 363171 Patch Clearing flags on attachment: 363171 Committed r242231: <https://trac.webkit.org/changeset/242231> 1511137 5 commit-queue 2019-02-28 14:54:45 -0800 All reviewed patches have been landed. Closing bug. 1520049 6 sroberts 2019-03-21 17:06:30 -0700 This test is still timing out on Mojave WK1 about 1 in every 4 runs on the dashboard. Also is timing out on Mojave Wk2, but not nearly as consistently. Was able to reproduce locally with : run-webkit-tests inspector/page/overrideSetting-ICECandidateFilteringEnabled.html --iterations 500 -f -1 Produced 22 failures. run-webkit-tests inspector/page/overrideSetting-ICECandidateFilteringEnabled.html --iterations 500 -f Produced 9 failures. Flakiness Dashboard : https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fpage%2FoverrideSetting-ICECandidateFilteringEnabled.html 1523429 7 ryanhaddad 2019-04-02 13:33:11 -0700 Reopening based on Shawn's comment above. 1525707 8 367060 hi 2019-04-09 12:11:22 -0700 Created attachment 367060 Patch It seems like the main issue was with the first part of the test. Removing it made it pass without issue on 1000+ iterations on my machine. I've also enabled debug logging just in case it still fails so we can hopefully get more information as to why. 1527320 9 367060 joepeck 2019-04-15 12:20:05 -0700 Comment on attachment 367060 Patch r=me 1527329 10 367060 commit-queue 2019-04-15 12:46:40 -0700 Comment on attachment 367060 Patch Clearing flags on attachment: 367060 Committed r244280: <https://trac.webkit.org/changeset/244280> 1527330 11 commit-queue 2019-04-15 12:46:41 -0700 All reviewed patches have been landed. Closing bug. 1535695 12 hi 2019-05-13 11:30:10 -0700 This is still showing intermittent failures. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fpage%2FoverrideSetting-ICECandidateFilteringEnabled.html 1535698 13 369754 hi 2019-05-13 11:32:01 -0700 Created attachment 369754 Patch It seems like the failure occurs after the first "part" of the test. Given that the second "part" doesn't really add anything new (e.g. the first "part" goes from filtering enabled to disabled, while the second "part" does the opposite), I think it's fine to remove. 1536614 14 369754 joepeck 2019-05-15 15:09:23 -0700 Comment on attachment 369754 Patch rs=me 1536628 15 369754 commit-queue 2019-05-15 15:37:18 -0700 Comment on attachment 369754 Patch Clearing flags on attachment: 369754 Committed r245363: <https://trac.webkit.org/changeset/245363> 1536629 16 commit-queue 2019-05-15 15:37:20 -0700 All reviewed patches have been landed. Closing bug. 363171 2019-02-27 17:58:34 -0800 2019-05-13 11:32:11 -0700 Patch bug-194437-20190227175833.patch text/plain 3836 hi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMzllZjJjOTY1NWViMjNiMjc4YWNkZGVhOTNkZDU2Y2Y0OTc3ODZjLi4xMDQ1MjFj OGRlZDQwMGI1Y2RkMmY4ZmU3OWE0NTgxZGQzMjQ2ZjI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTktMDItMjcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIyNDA2NDQpOiBMYXlvdXQgVGVzdCBpbnNwZWN0b3IvcGFnZS9vdmVycmlk ZVNldHRpbmctSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZC5odG1sIGlzIGEgZmxha3kgdGlt ZW91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0 NDM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODAwODAwNT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9wYWdlL292ZXJyaWRl U2V0dGluZy1JQ0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkLmh0bWw6CisgICAgICAgICogaW5z cGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLUlDRUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQt ZXhwZWN0ZWQudHh0OgorICAgICAgICBNYWtlIHN1cmUgdG8gY2xvc2UgdGhlIHBlZXIgY29ubmVj dGlvbiBhbmQgZGF0YSBjaGFubmVsIGFmdGVyIGVhY2ggcGhhc2Ugb2YgdGhlIHRlc3QuCisgICAg ICAgIEFsc28gYWRkIGZhaWx1cmUgbG9nZ2luZy4KKwogMjAxOS0wMi0yNyAgV2Vuc29uIEhzaWVo ICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBXZWIgcGFnZXMgc2hv dWxkbid0IGJlIGFibGUgdG8gcHJlc2VudCBhIGtleWJvYXJkIGFmdGVyIHRoZSB3ZWIgdmlldyBy ZXNpZ25zIGZpcnN0IHJlc3BvbmRlcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9y L3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLUlDRUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLUlDRUNh bmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQtZXhwZWN0ZWQudHh0CmluZGV4IDNiOGIwNmU0Y2Q0Njli OGRmNDcxZmEyOWM0MTc4N2MzMTE4ODQ1MTAuLjMyOTExNGViYTEwNGZjMzJkNmRmZDlhNWUyZjAy ZDRjNDcxODc4MWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9wYWdlL292ZXJy aWRlU2V0dGluZy1JQ0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkLWV4cGVjdGVkLnR4dAorKysg Yi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcGFnZS9vdmVycmlkZVNldHRpbmctSUNFQ2FuZGlkYXRl RmlsdGVyaW5nRW5hYmxlZC1leHBlY3RlZC50eHQKQEAgLTMsOSArMywxMyBAQCBUZXN0cyBmb3Ig dGhlIFBhZ2Uub3ZlcnJpZGVTZXR0aW5nIGNvbW1hbmQuCiAKID09IFJ1bm5pbmcgdGVzdCBzdWl0 ZTogUGFnZS5vdmVycmlkZVNldHRpbmcKIC0tIFJ1bm5pbmcgdGVzdCBjYXNlOiBQYWdlLm92ZXJy aWRlU2V0dGluZy5JQ0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkCitQQVNTOiBjcmVhdGVkIG9m ZmVyCiBQQVNTOiBTaG91bGQgbm90IGJlIGFibGUgdG8gZXN0YWJsaXNoIGEgY29ubmVjdGlvbiB3 aGVuIGZpbHRlcmluZyBpY2UgY2FuZGlkYXRlcy4KIE92ZXJyaWRpbmcgSUNFQ2FuZGlkYXRlRmls dGVyaW5nRW5hYmxlZCB0byBmYWxzZS4uLgorUEFTUzogY3JlYXRlZCBvZmZlcgorUEFTUzogcmVj ZWl2ZWQgSUNFIGNhbmRpZGF0ZS4KIFBBU1M6IFNob3VsZCBiZSBhYmxlIHRvIGVzdGFibGlzaCBh IGNvbm5lY3Rpb24gd2hlbiBmaWx0ZXJpbmcgaWNlIGNhbmRpZGF0ZXMuCiBSZW1vdmluZyBJQ0VD YW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkIG92ZXJyaWRlLi4uCitQQVNTOiBjcmVhdGVkIG9mZmVy CiBQQVNTOiBTaG91bGQgbm90IGJlIGFibGUgdG8gZXN0YWJsaXNoIGEgY29ubmVjdGlvbiB3aGVu IGZpbHRlcmluZyBpY2UgY2FuZGlkYXRlcy4KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLUlDRUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQu aHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9wYWdlL292ZXJyaWRlU2V0dGluZy1JQ0VDYW5k aWRhdGVGaWx0ZXJpbmdFbmFibGVkLmh0bWwKaW5kZXggMzNkNzgxMmM1ZmI1MjA2YjI4NzU5YWZk YTRjM2MzMmUyMDk3OTMzNi4uYjE4OTkzZmY0YWNhZmY4OWUwOTg2MWEyMDM0YWFlZTQwZDFjYWUz NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5n LUlDRUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNw ZWN0b3IvcGFnZS9vdmVycmlkZVNldHRpbmctSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZC5o dG1sCkBAIC0xMCwyNSArMTAsMzYgQEAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpCiBmdW5jdGlvbiBj cmVhdGVEYXRhQ2hhbm5lbCgpIHsKICAgICBsZXQgcmVjZWl2ZWRDYW5kaWRhdGUgPSBmYWxzZTsK IAorICAgIGxldCBkYyA9IG51bGw7CisKICAgICBsZXQgcGMgPSBuZXcgUlRDUGVlckNvbm5lY3Rp b24oKTsKLSAgICBwYy5jcmVhdGVEYXRhQ2hhbm5lbCgic2VuZERhdGFDaGFubmVsIik7CiAgICAg cGMub25pY2VjYW5kaWRhdGUgPSAoZXZlbnQpID0+IHsKICAgICAgICAgaWYgKGV2ZW50LmNhbmRp ZGF0ZSkgeworICAgICAgICAgICAgaWYgKCFyZWNlaXZlZENhbmRpZGF0ZSkKKyAgICAgICAgICAg ICAgICBUZXN0UGFnZS5hZGRSZXN1bHQoIlBBU1M6IHJlY2VpdmVkIElDRSBjYW5kaWRhdGUuIik7 CiAgICAgICAgICAgICByZWNlaXZlZENhbmRpZGF0ZSA9IHRydWU7CiAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgIH0KIAorICAgICAgICBkZWxldGUgcGMub25pY2VjYW5kaWRhdGU7CisgICAg ICAgIHBjLmNsb3NlKCk7CisgICAgICAgIGRjLmNsb3NlKCk7CisKICAgICAgICAgaWYgKHJlY2Vp dmVkQ2FuZGlkYXRlKSB7Ci0gICAgICAgICAgICBwYy5jcmVhdGVPZmZlcigpLnRoZW4oKG9mZmVy KSA9PiB7Ci0gICAgICAgICAgICAgICAgVGVzdFBhZ2UuZGlzcGF0Y2hFdmVudFRvRnJvbnRlbmQo IkRhdGFDaGFubmVsIiwge3N1Y2Nlc3M6IHRydWV9KTsKLSAgICAgICAgICAgIH0pOworICAgICAg ICAgICAgVGVzdFBhZ2UuZGlzcGF0Y2hFdmVudFRvRnJvbnRlbmQoIkRhdGFDaGFubmVsIiwge3N1 Y2Nlc3M6IHRydWV9KTsKICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBUZXN0UGFnZS5kaXNw YXRjaEV2ZW50VG9Gcm9udGVuZCgiRGF0YUNoYW5uZWwiLCB7c3VjY2VzczogZmFsc2V9KTsKLQot ICAgICAgICBkZWxldGUgcGMub25pY2VjYW5kaWRhdGU7CiAgICAgfTsKLSAgICBwYy5jcmVhdGVP ZmZlcigpLnRoZW4oKG9mZmVyKSA9PiB7Ci0gICAgICAgIHBjLnNldExvY2FsRGVzY3JpcHRpb24o b2ZmZXIpOworCisgICAgZGMgPSBwYy5jcmVhdGVEYXRhQ2hhbm5lbCgic2VuZERhdGFDaGFubmVs Iik7CisKKyAgICBwYy5jcmVhdGVPZmZlcigpCisgICAgLnRoZW4oKG9mZmVyKSA9PiB7CisgICAg ICAgIFRlc3RQYWdlLmFkZFJlc3VsdCgiUEFTUzogY3JlYXRlZCBvZmZlciIpOworICAgICAgICBy ZXR1cm4gcGMuc2V0TG9jYWxEZXNjcmlwdGlvbihvZmZlcik7CisgICAgfSkKKyAgICAuY2F0Y2go KGVycm9yKSA9PiB7CisgICAgICAgIFRlc3RQYWdlLmFkZFJlc3VsdCgiRkFJTDogIiArIGVycm9y KTsKICAgICB9KTsKIH0KIAo= 367060 2019-04-09 12:11:22 -0700 2019-05-13 11:32:13 -0700 Patch bug-194437-20190409121122.patch text/plain 5314 hi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MmYwYjdmNjg0YjkyOGUzOTEyZGFlMGJlMWNhYzkzNTQwYThjNWNkLi5jNjg4Nzc0 NjkzNWM3Mjk2YmJiMDAyMDI4NjZkZjhhYTYwMWQwZmU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTktMDQtMDkgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIyNDA2NDQpOiBMYXlvdXQgVGVzdCBpbnNwZWN0b3IvcGFnZS9vdmVycmlk ZVNldHRpbmctSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZC5odG1sIGlzIGEgZmxha3kgdGlt ZW91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0 NDM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODAwODAwNT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9wYWdlL292ZXJyaWRl U2V0dGluZy1JQ0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkLmh0bWw6CisgICAgICAgICogaW5z cGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLUlDRUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQt ZXhwZWN0ZWQudHh0OgorCiAyMDE5LTA0LTA5ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggdGVzdCBmYWlsdXJlcyBhZnRlciByMjM5 Njk4LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0 aW5nLUlDRUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLUlDRUNhbmRpZGF0ZUZpbHRlcmluZ0Vu YWJsZWQtZXhwZWN0ZWQudHh0CmluZGV4IDMyOTExNGViYTEwNGZjMzJkNmRmZDlhNWUyZjAyZDRj NDcxODc4MWUuLmRkZWZhNzAwN2ViNDA4NDJjODZiMDNkMmYwOWI3ZGU3YTIxNTM0YWMgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9wYWdlL292ZXJyaWRlU2V0dGluZy1JQ0VDYW5k aWRhdGVGaWx0ZXJpbmdFbmFibGVkLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNw ZWN0b3IvcGFnZS9vdmVycmlkZVNldHRpbmctSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZC1l eHBlY3RlZC50eHQKQEAgLTMsMTMgKzMsMTMgQEAgVGVzdHMgZm9yIHRoZSBQYWdlLm92ZXJyaWRl U2V0dGluZyBjb21tYW5kLgogCiA9PSBSdW5uaW5nIHRlc3Qgc3VpdGU6IFBhZ2Uub3ZlcnJpZGVT ZXR0aW5nCiAtLSBSdW5uaW5nIHRlc3QgY2FzZTogUGFnZS5vdmVycmlkZVNldHRpbmcuSUNFQ2Fu ZGlkYXRlRmlsdGVyaW5nRW5hYmxlZAotUEFTUzogY3JlYXRlZCBvZmZlcgotUEFTUzogU2hvdWxk IG5vdCBiZSBhYmxlIHRvIGVzdGFibGlzaCBhIGNvbm5lY3Rpb24gd2hlbiBmaWx0ZXJpbmcgaWNl IGNhbmRpZGF0ZXMuCiBPdmVycmlkaW5nIElDRUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQgdG8g ZmFsc2UuLi4KK0NyZWF0aW5nIGRhdGEgY2hhbm5lbC4uLgogUEFTUzogY3JlYXRlZCBvZmZlcgog UEFTUzogcmVjZWl2ZWQgSUNFIGNhbmRpZGF0ZS4KIFBBU1M6IFNob3VsZCBiZSBhYmxlIHRvIGVz dGFibGlzaCBhIGNvbm5lY3Rpb24gd2hlbiBmaWx0ZXJpbmcgaWNlIGNhbmRpZGF0ZXMuCiBSZW1v dmluZyBJQ0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkIG92ZXJyaWRlLi4uCitDcmVhdGluZyBk YXRhIGNoYW5uZWwuLi4KIFBBU1M6IGNyZWF0ZWQgb2ZmZXIKIFBBU1M6IFNob3VsZCBub3QgYmUg YWJsZSB0byBlc3RhYmxpc2ggYSBjb25uZWN0aW9uIHdoZW4gZmlsdGVyaW5nIGljZSBjYW5kaWRh dGVzLgogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcGFnZS9vdmVycmlkZVNl dHRpbmctSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZC5odG1sIGIvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLUlDRUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQu aHRtbAppbmRleCBiMTg5OTNmZjRhY2FmZjg5ZTA5ODYxYTIwMzRhYWVlNDBkMWNhZTM2Li40ZTFi YzIwMTZjMDA2YTI0YzI3NTU0ZjllZjIyM2MzNWYxMTg5ZDBmIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvcGFnZS9vdmVycmlkZVNldHRpbmctSUNFQ2FuZGlkYXRlRmlsdGVyaW5n RW5hYmxlZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9wYWdlL292ZXJyaWRlU2V0 dGluZy1JQ0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkLmh0bWwKQEAgLTEyLDcgKzEyLDcgQEAg ZnVuY3Rpb24gY3JlYXRlRGF0YUNoYW5uZWwoKSB7CiAKICAgICBsZXQgZGMgPSBudWxsOwogCi0g ICAgbGV0IHBjID0gbmV3IFJUQ1BlZXJDb25uZWN0aW9uKCk7CisgICAgbGV0IHBjID0gbmV3IFJU Q1BlZXJDb25uZWN0aW9uOwogICAgIHBjLm9uaWNlY2FuZGlkYXRlID0gKGV2ZW50KSA9PiB7CiAg ICAgICAgIGlmIChldmVudC5jYW5kaWRhdGUpIHsKICAgICAgICAgICAgIGlmICghcmVjZWl2ZWRD YW5kaWRhdGUpCkBAIC0yMSwxNiArMjEsMTQgQEAgZnVuY3Rpb24gY3JlYXRlRGF0YUNoYW5uZWwo KSB7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAorICAgICAgICBUZXN0UGFnZS5k aXNwYXRjaEV2ZW50VG9Gcm9udGVuZCgiRGF0YUNoYW5uZWwiLCB7c3VjY2VzczogISFyZWNlaXZl ZENhbmRpZGF0ZX0pOworCiAgICAgICAgIGRlbGV0ZSBwYy5vbmljZWNhbmRpZGF0ZTsKICAgICAg ICAgcGMuY2xvc2UoKTsKICAgICAgICAgZGMuY2xvc2UoKTsKLQotICAgICAgICBpZiAocmVjZWl2 ZWRDYW5kaWRhdGUpIHsKLSAgICAgICAgICAgIFRlc3RQYWdlLmRpc3BhdGNoRXZlbnRUb0Zyb250 ZW5kKCJEYXRhQ2hhbm5lbCIsIHtzdWNjZXNzOiB0cnVlfSk7Ci0gICAgICAgIH0gZWxzZQotICAg ICAgICAgICAgVGVzdFBhZ2UuZGlzcGF0Y2hFdmVudFRvRnJvbnRlbmQoIkRhdGFDaGFubmVsIiwg e3N1Y2Nlc3M6IGZhbHNlfSk7CiAgICAgfTsKIAorICAgIFRlc3RQYWdlLmFkZFJlc3VsdCgiQ3Jl YXRpbmcgZGF0YSBjaGFubmVsLi4uIik7CiAgICAgZGMgPSBwYy5jcmVhdGVEYXRhQ2hhbm5lbCgi c2VuZERhdGFDaGFubmVsIik7CiAKICAgICBwYy5jcmVhdGVPZmZlcigpCkBAIC00NSwxOCArNDMs MTQgQEAgZnVuY3Rpb24gY3JlYXRlRGF0YUNoYW5uZWwoKSB7CiAKIGZ1bmN0aW9uIHRlc3QoKQog eworICAgIEluc3BlY3RvclRlc3QuZGVidWcoKTsKKwogICAgIGxldCBzdWl0ZSA9IEluc3BlY3Rv clRlc3QuY3JlYXRlQXN5bmNTdWl0ZSgiUGFnZS5vdmVycmlkZVNldHRpbmciKTsKIAogICAgIHN1 aXRlLmFkZFRlc3RDYXNlKHsKICAgICAgICAgbmFtZTogIlBhZ2Uub3ZlcnJpZGVTZXR0aW5nLklD RUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQiLAogICAgICAgICBkZXNjcmlwdGlvbjogIlRlc3Qg dGhhdCBjaGFuZ2luZyB3aGV0aGVyIGljZSBjYW5kaWRhdGUgZmlsdGVyaW5nIGlzIGVuYWJsZWQg aGFzIGFuIGVmZmVjdC4iLAogICAgICAgICBhc3luYyB0ZXN0KCkgewotICAgICAgICAgICAgbGV0 IFtkZWZhdWx0UmVzdWx0XSA9IGF3YWl0IFByb21pc2UuYWxsKFsKLSAgICAgICAgICAgICAgICBJ bnNwZWN0b3JUZXN0LmF3YWl0RXZlbnQoIkRhdGFDaGFubmVsIiksCi0gICAgICAgICAgICAgICAg SW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFnZShgY3JlYXRlRGF0YUNoYW5uZWwoKWApLAotICAg ICAgICAgICAgXSk7Ci0gICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdEZhbHNlKGRlZmF1 bHRSZXN1bHQuZGF0YS5zdWNjZXNzLCAiU2hvdWxkIG5vdCBiZSBhYmxlIHRvIGVzdGFibGlzaCBh IGNvbm5lY3Rpb24gd2hlbiBmaWx0ZXJpbmcgaWNlIGNhbmRpZGF0ZXMuIik7Ci0KICAgICAgICAg ICAgIEluc3BlY3RvclRlc3QubG9nKCJPdmVycmlkaW5nIElDRUNhbmRpZGF0ZUZpbHRlcmluZ0Vu YWJsZWQgdG8gZmFsc2UuLi4iKTsKICAgICAgICAgICAgIGF3YWl0IFBhZ2VBZ2VudC5vdmVycmlk ZVNldHRpbmcoUGFnZUFnZW50LlNldHRpbmcuSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZCwg ZmFsc2UpOwogCkBAIC02NCw3ICs1OCw3IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAg ICAgIEluc3BlY3RvclRlc3QuYXdhaXRFdmVudCgiRGF0YUNoYW5uZWwiKSwKICAgICAgICAgICAg ICAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKGBjcmVhdGVEYXRhQ2hhbm5lbCgpYCks CiAgICAgICAgICAgICBdKQotICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5leHBlY3RGYWxzZShk ZWZhdWx0UmVzdWx0LmRhdGEuc3VjY2VzcywgIlNob3VsZCBiZSBhYmxlIHRvIGVzdGFibGlzaCBh IGNvbm5lY3Rpb24gd2hlbiBmaWx0ZXJpbmcgaWNlIGNhbmRpZGF0ZXMuIik7CisgICAgICAgICAg ICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQob3ZlcnJpZGRlblJlc3VsdC5kYXRhLnN1Y2Nlc3Ms ICJTaG91bGQgYmUgYWJsZSB0byBlc3RhYmxpc2ggYSBjb25uZWN0aW9uIHdoZW4gZmlsdGVyaW5n IGljZSBjYW5kaWRhdGVzLiIpOwogCiAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmxvZygiUmVt b3ZpbmcgSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZCBvdmVycmlkZS4uLiIpOwogICAgICAg ICAgICAgYXdhaXQgUGFnZUFnZW50Lm92ZXJyaWRlU2V0dGluZyhQYWdlQWdlbnQuU2V0dGluZy5J Q0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkKTsKQEAgLTczLDcgKzY3LDcgQEAgZnVuY3Rpb24g dGVzdCgpCiAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5hd2FpdEV2ZW50KCJEYXRhQ2hh bm5lbCIpLAogICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJblBhZ2UoYGNy ZWF0ZURhdGFDaGFubmVsKClgKSwKICAgICAgICAgICAgIF0pCi0gICAgICAgICAgICBJbnNwZWN0 b3JUZXN0LmV4cGVjdEZhbHNlKGRlZmF1bHRSZXN1bHQuZGF0YS5zdWNjZXNzLCAiU2hvdWxkIG5v dCBiZSBhYmxlIHRvIGVzdGFibGlzaCBhIGNvbm5lY3Rpb24gd2hlbiBmaWx0ZXJpbmcgaWNlIGNh bmRpZGF0ZXMuIik7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdEZhbHNlKG9yaWdp bmFsUmVzdWx0LmRhdGEuc3VjY2VzcywgIlNob3VsZCBub3QgYmUgYWJsZSB0byBlc3RhYmxpc2gg YSBjb25uZWN0aW9uIHdoZW4gZmlsdGVyaW5nIGljZSBjYW5kaWRhdGVzLiIpOwogICAgICAgICB9 LAogICAgIH0pOwogCg== 369754 2019-05-13 11:32:01 -0700 2019-05-15 15:37:18 -0700 Patch bug-194437-20190513113201.patch text/plain 3136 hi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlYTAwYjg4MGFkZWVkMGI5ZmFhNDczZDVhNTc1NTRmMDRkMjc5MGNlLi4xZmY5YzY3 MGJhMmEwZWNiMmY1YWYyMTkwN2YwYmQ0YzI5MjBhNjVjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTktMDUtMTMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIyNDA2NDQpOiBMYXlvdXQgVGVzdCBpbnNwZWN0b3IvcGFnZS9vdmVycmlk ZVNldHRpbmctSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZC5odG1sIGlzIGEgZmxha3kgdGlt ZW91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0 NDM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODAwODAwNT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9wYWdlL292ZXJyaWRl U2V0dGluZy1JQ0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkLmh0bWw6CisgICAgICAgICogaW5z cGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLUlDRUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQt ZXhwZWN0ZWQudHh0OgorCiAyMDE5LTA1LTEyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJA YXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNDUyMDgpOiBjb21wb3NpdGluZy9z aGFyZWQtYmFja2luZy9zaGFyaW5nLWJvdW5kcy1ub24tY2xpcHBpbmctc2hhcmVkLWxheWVyLmh0 bWwgYXNzZXJ0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3BhZ2Uvb3ZlcnJp ZGVTZXR0aW5nLUlDRUNhbmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLUlDRUNhbmRpZGF0ZUZpbHRl cmluZ0VuYWJsZWQtZXhwZWN0ZWQudHh0CmluZGV4IGRkZWZhNzAwN2ViNDA4NDJjODZiMDNkMmYw OWI3ZGU3YTIxNTM0YWMuLmZiYWZiMWFjMTA2ZWZmOWFmNzg2YjRkMmU2MmMyZjllMzJlNTNjNjkg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9wYWdlL292ZXJyaWRlU2V0dGluZy1J Q0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvcGFnZS9vdmVycmlkZVNldHRpbmctSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5h YmxlZC1leHBlY3RlZC50eHQKQEAgLTgsOCArOCw0IEBAIENyZWF0aW5nIGRhdGEgY2hhbm5lbC4u LgogUEFTUzogY3JlYXRlZCBvZmZlcgogUEFTUzogcmVjZWl2ZWQgSUNFIGNhbmRpZGF0ZS4KIFBB U1M6IFNob3VsZCBiZSBhYmxlIHRvIGVzdGFibGlzaCBhIGNvbm5lY3Rpb24gd2hlbiBmaWx0ZXJp bmcgaWNlIGNhbmRpZGF0ZXMuCi1SZW1vdmluZyBJQ0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVk IG92ZXJyaWRlLi4uCi1DcmVhdGluZyBkYXRhIGNoYW5uZWwuLi4KLVBBU1M6IGNyZWF0ZWQgb2Zm ZXIKLVBBU1M6IFNob3VsZCBub3QgYmUgYWJsZSB0byBlc3RhYmxpc2ggYSBjb25uZWN0aW9uIHdo ZW4gZmlsdGVyaW5nIGljZSBjYW5kaWRhdGVzLgogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvcGFnZS9vdmVycmlkZVNldHRpbmctSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxl ZC5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLUlDRUNh bmRpZGF0ZUZpbHRlcmluZ0VuYWJsZWQuaHRtbAppbmRleCA0ZTFiYzIwMTZjMDA2YTI0YzI3NTU0 ZjllZjIyM2MzNWYxMTg5ZDBmLi5iZGIxZmY4OTgzM2E4YmZhZWYwODc0M2JjMGRhODZlNjBlZTUw MWRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcGFnZS9vdmVycmlkZVNldHRp bmctSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2lu c3BlY3Rvci9wYWdlL292ZXJyaWRlU2V0dGluZy1JQ0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVk Lmh0bWwKQEAgLTQzLDggKzQzLDYgQEAgZnVuY3Rpb24gY3JlYXRlRGF0YUNoYW5uZWwoKSB7CiAK IGZ1bmN0aW9uIHRlc3QoKQogewotICAgIEluc3BlY3RvclRlc3QuZGVidWcoKTsKLQogICAgIGxl dCBzdWl0ZSA9IEluc3BlY3RvclRlc3QuY3JlYXRlQXN5bmNTdWl0ZSgiUGFnZS5vdmVycmlkZVNl dHRpbmciKTsKIAogICAgIHN1aXRlLmFkZFRlc3RDYXNlKHsKQEAgLTU5LDE1ICs1Nyw2IEBAIGZ1 bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJblBh Z2UoYGNyZWF0ZURhdGFDaGFubmVsKClgKSwKICAgICAgICAgICAgIF0pCiAgICAgICAgICAgICBJ bnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQob3ZlcnJpZGRlblJlc3VsdC5kYXRhLnN1Y2Nlc3MsICJT aG91bGQgYmUgYWJsZSB0byBlc3RhYmxpc2ggYSBjb25uZWN0aW9uIHdoZW4gZmlsdGVyaW5nIGlj ZSBjYW5kaWRhdGVzLiIpOwotCi0gICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmxvZygiUmVtb3Zp bmcgSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZCBvdmVycmlkZS4uLiIpOwotICAgICAgICAg ICAgYXdhaXQgUGFnZUFnZW50Lm92ZXJyaWRlU2V0dGluZyhQYWdlQWdlbnQuU2V0dGluZy5JQ0VD YW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVkKTsKLQotICAgICAgICAgICAgbGV0IFtvcmlnaW5hbFJl c3VsdF0gPSBhd2FpdCBQcm9taXNlLmFsbChbCi0gICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVz dC5hd2FpdEV2ZW50KCJEYXRhQ2hhbm5lbCIpLAotICAgICAgICAgICAgICAgIEluc3BlY3RvclRl c3QuZXZhbHVhdGVJblBhZ2UoYGNyZWF0ZURhdGFDaGFubmVsKClgKSwKLSAgICAgICAgICAgIF0p Ci0gICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdEZhbHNlKG9yaWdpbmFsUmVzdWx0LmRh dGEuc3VjY2VzcywgIlNob3VsZCBub3QgYmUgYWJsZSB0byBlc3RhYmxpc2ggYSBjb25uZWN0aW9u IHdoZW4gZmlsdGVyaW5nIGljZSBjYW5kaWRhdGVzLiIpOwogICAgICAgICB9LAogICAgIH0pOwog Cg==