194420 2019-02-07 16:32:35 -0800 Fix Abs(Neg(x)) -> Abs(x) optimization in B3ReduceStrength 2019-02-07 17:02:31 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 194250 1 rmorisset rmorisset commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1504003 0 rmorisset 2019-02-07 16:32:35 -0800 In https://bugs.webkit.org/show_bug.cgi?id=194250, I added an optimization: Abs(Neg(x)) -> Abs(x). But I introduced two bugs, one is that I actually implemented Abs(Neg(x)) -> x, and the other is that the test is looking at Abs(Abs(x)) instead (both were stupid copy-paste mistakes). This trivial patch fixes both. 1504005 1 361468 rmorisset 2019-02-07 16:35:22 -0800 Created attachment 361468 Patch 1504036 2 361468 commit-queue 2019-02-07 17:01:43 -0800 Comment on attachment 361468 Patch Clearing flags on attachment: 361468 Committed r241176: <https://trac.webkit.org/changeset/241176> 1504037 3 commit-queue 2019-02-07 17:01:44 -0800 All reviewed patches have been landed. Closing bug. 1504038 4 webkit-bug-importer 2019-02-07 17:02:31 -0800 <rdar://problem/47903347> 361468 2019-02-07 16:35:22 -0800 2019-02-07 17:01:43 -0800 Patch Patch_194420 text/plain 2282 rmorisset SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQxMTY5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE5LTAyLTA3ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAg ICAgICAgRml4IEFicyhOZWcoeCkpIC0+IEFicyh4KSBvcHRpbWl6YXRpb24gaW4gQjNSZWR1Y2VT dHJlbmd0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk0NDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDI1MCwgSSBhZGRl ZCBhbiBvcHRpbWl6YXRpb246IEFicyhOZWcoeCkpIC0+IEFicyh4KS4KKyAgICAgICAgQnV0IEkg aW50cm9kdWNlZCB0d28gYnVncywgb25lIGlzIHRoYXQgSSBhY3R1YWxseSBpbXBsZW1lbnRlZCBB YnMoTmVnKHgpKSAtPiB4LCBhbmQgdGhlIG90aGVyIGlzIHRoYXQgdGhlIHRlc3QgaXMgbG9va2lu ZyBhdCBBYnMoQWJzKHgpKSBpbnN0ZWFkIChib3RoIHdlcmUgc3R1cGlkIGNvcHktcGFzdGUgbWlz dGFrZXMpLgorICAgICAgICBUaGlzIHRyaXZpYWwgcGF0Y2ggZml4ZXMgYm90aC4KKworICAgICAg ICAqIGIzL0IzUmVkdWNlU3RyZW5ndGguY3BwOgorICAgICAgICAqIGIzL3Rlc3RiMy5jcHA6Cisg ICAgICAgIChKU0M6OkIzOjp0ZXN0QWJzTmVnQXJnKToKKwogMjAxOS0wMi0wNyAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IG1vcmUgZG9lc0dDKCkgZm9yIENo ZWNrVHJhcHMsIEdldE1hcEJ1Y2tldCwgYW5kIFN3aXRjaCBub2Rlcy4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9iMy9CM1JlZHVjZVN0cmVuZ3RoLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYjMvQjNSZWR1Y2VTdHJlbmd0aC5jcHAJKHJldmlzaW9uIDI0MTEy OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1JlZHVjZVN0cmVuZ3RoLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTI0MSw3ICsxMjQxLDggQEAKICAgICAgICAgICAgIC8vIFR1cm4gdGhp czogQWJzKE5lZyh2YWx1ZSkpCiAgICAgICAgICAgICAvLyBJbnRvIHRoaXM6IEFicyh2YWx1ZSkK ICAgICAgICAgICAgIGlmIChtX3ZhbHVlLT5jaGlsZCgwKS0+b3Bjb2RlKCkgPT0gTmVnKSB7Ci0g ICAgICAgICAgICAgICAgcmVwbGFjZVdpdGhJZGVudGl0eShtX3ZhbHVlLT5jaGlsZCgwKS0+Y2hp bGQoMCkpOworICAgICAgICAgICAgICAgIG1fdmFsdWUtPmNoaWxkKDApID0gbV92YWx1ZS0+Y2hp bGQoMCktPmNoaWxkKDApOworICAgICAgICAgICAgICAgIG1fY2hhbmdlZCA9IHRydWU7CiAgICAg ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9iMy90ZXN0YjMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy90ZXN0YjMuY3BwCShyZXZpc2lvbiAyNDExMjgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYjMvdGVzdGIzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzk4NCw3ICszOTg0LDcgQEAKIHsK ICAgICBQcm9jZWR1cmUgcHJvYzsKICAgICBCYXNpY0Jsb2NrKiByb290ID0gcHJvYy5hZGRCbG9j aygpOwotICAgIFZhbHVlKiBuZWcgPSByb290LT5hcHBlbmROZXc8VmFsdWU+KHByb2MsIEFicywg T3JpZ2luKCksCisgICAgVmFsdWUqIG5lZyA9IHJvb3QtPmFwcGVuZE5ldzxWYWx1ZT4ocHJvYywg TmVnLCBPcmlnaW4oKSwKICAgICAgICAgcm9vdC0+YXBwZW5kTmV3PEFyZ3VtZW50UmVnVmFsdWU+ KHByb2MsIE9yaWdpbigpLCBGUFJJbmZvOjphcmd1bWVudEZQUjApKTsKICAgICBWYWx1ZSogYWJz ID0gcm9vdC0+YXBwZW5kTmV3PFZhbHVlPihwcm9jLCBBYnMsIE9yaWdpbigpLCBuZWcpOwogICAg IHJvb3QtPmFwcGVuZE5ld0NvbnRyb2xWYWx1ZShwcm9jLCBSZXR1cm4sIE9yaWdpbigpLCBhYnMp Owo=