194414 2019-02-07 13:33:16 -0800 REGRESSION(r240784): [MSE][GStreamer] MSE tests became flaky on debug 2019-02-10 06:39:03 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply commit-queue darin webkit-bug-importer oldest_to_newest 1503902 0 aboya 2019-02-07 13:33:16 -0800 I'm getting flaky failures where "updateend" is received when "update" was expected. These seem to occur only in Debug, and after bisecting for a while I found the first bad commit to be this: commit 90b22c6ed58ea31072568656d08f047cd86bd82f (refs/bisect/bad) Author: aboya@igalia.com <aboya@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Thu Jan 31 14:54:52 2019 +0000 [MSE][GStreamer] Remove unused GstFlowReturn in AppendPipeline methods https://bugs.webkit.org/show_bug.cgi?id=194067 Reviewed by Xabier Rodriguez-Calvar. A couple methods in AppendPipeline were returning GstFlowReturn despite there being no codepath (sans assertions) where values other than GST_FLOW_OK are returned. Therefore, it makes sense to just make these methods return void. Which is a commit that was not intended to introduce behavior changes, but something may have slipped anyway. 1504173 1 361505 aboya 2019-02-08 08:27:33 -0800 Created attachment 361505 Patch 1504678 2 361505 commit-queue 2019-02-10 06:38:32 -0800 Comment on attachment 361505 Patch Clearing flags on attachment: 361505 Committed r241248: <https://trac.webkit.org/changeset/241248> 1504679 3 commit-queue 2019-02-10 06:38:33 -0800 All reviewed patches have been landed. Closing bug. 361505 2019-02-08 08:27:33 -0800 2019-02-10 06:38:32 -0800 Patch bug-194414-20190208172731.patch text/plain 2535 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWFlNjYzOTY2Yzg2NTQz MzhmMzEzY2MwOTlhZWY0ZTRjYTZhZTE4NC4uNzVkZTgyNDNhZTY3ZjA4YTA4MTk3Y2JhYjM4Mzlh ZjEzOWNhMDk3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTAyLTA4ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIEFkZCBtaXNzaW5nIHJldHVybiB0eXBlIHRvIGxhbWJkYQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NDE0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgZ19zaWduYWxfY29ubmVjdCgp IGlzIHVudHlwZWQsIGEgY29tcGlsZXIgZXJyb3Igd2FzIG5vdAorICAgICAgICBnZW5lcmF0ZWQg d2hlbiBhIGxhbWJkYSB3aXRoIGEgbWlzc2luZyBHc3RGbG93UmV0dXJuIHJldHVybiB0eXBlIHdh cworICAgICAgICBwcm92aWRlZCBmb3IgYSBzaWduYWwgdGhhdCBleHBlY3RzIGl0LgorCisgICAg ICAgIFRoaXMgdXNlZCB0byB3b3JrIGJlZm9yZSByMjQwNzg0IGJlY2F1c2UgYSByZWNlbnQgZnVu Y3Rpb24gY2FsbCBoYWQKKyAgICAgICAgc2V0IEdTVF9GTE9XX09LIGluIHRoZSByZXR1cm4gdmFs dWUgcmVnaXN0ZXIgYW5kIGl0IGhhcHBlbmVkIHRvCisgICAgICAgIHN1cnZpdmUgdW50aWwgdGhl IGxhbWJkYSBmdW5jdGlvbiBjYWxsIGVuZGVkLiBTdGFydGluZyBvbiB0aGF0IGNvbW1pdAorICAg ICAgICBzdWNoIHJldHVybiB2YWx1ZSB3YXMgcmVtb3ZlZCBhbmQgaXQgc3RvcHBlZCB3b3JraW5n IG9uIGRlYnVnLgorCisgICAgICAgIE9mIGNvdXJzZSwgdGhlIGFjdHVhbCBwcm9ibGVtIGlzIGlu IHRoZSBzaWduYXR1cmUgb2YgdGhlIGxhbWJkYQorICAgICAgICBmdW5jdGlvbiwgYW5kIHRoaXMg cGF0Y2ggZml4ZXMgdGhhdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBwZW5kUGlwZWxp bmU6OkFwcGVuZFBpcGVsaW5lKToKKwogMjAxOS0wMS0zMSAgQWxpY2lhIEJveWEgR2FyY8OtYSAg PGFib3lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW01TRV1bR1N0cmVhbWVyXSBVbnJldmlld2Vk IGRlYnVnIGJ1aWxkIGZpeCwgb2Jzb2xldGUgYXNzZXJ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlw ZWxpbmUuY3BwCmluZGV4IDUwNjdjZjMyNzJmYTNhZmRhMzBjMmZkNDAzZmQ5ODAwNjJkN2I4OGUu LjJkOTMyMzgxMWZmM2VlOTZjNDBiZWZiOGU4N2JhYjA0ZTAxNGE0MmIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxp bmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9t c2UvQXBwZW5kUGlwZWxpbmUuY3BwCkBAIC0yMDQsOCArMjA0LDkgQEAgQXBwZW5kUGlwZWxpbmU6 OkFwcGVuZFBpcGVsaW5lKFJlZjxNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRT4gbWVkaWFT b3VyY2VDbGkKICAgICAgICAgICAgIGFwcGVuZFBpcGVsaW5lLT5kaWRSZWNlaXZlSW5pdGlhbGl6 YXRpb25TZWdtZW50KCk7CiAgICAgICAgIH0pOwogICAgIH0pLCB0aGlzKTsKLSAgICBnX3NpZ25h bF9jb25uZWN0KG1fYXBwc2luay5nZXQoKSwgIm5ldy1zYW1wbGUiLCBHX0NBTExCQUNLKCtbXShH c3RFbGVtZW50KiBhcHBzaW5rLCBBcHBlbmRQaXBlbGluZSogYXBwZW5kUGlwZWxpbmUpIHsKKyAg ICBnX3NpZ25hbF9jb25uZWN0KG1fYXBwc2luay5nZXQoKSwgIm5ldy1zYW1wbGUiLCBHX0NBTExC QUNLKCtbXShHc3RFbGVtZW50KiBhcHBzaW5rLCBBcHBlbmRQaXBlbGluZSogYXBwZW5kUGlwZWxp bmUpIC0+IEdzdEZsb3dSZXR1cm4gewogICAgICAgICBhcHBlbmRQaXBlbGluZS0+aGFuZGxlQXBw c2lua05ld1NhbXBsZUZyb21TdHJlYW1pbmdUaHJlYWQoYXBwc2luayk7CisgICAgICAgIHJldHVy biBHU1RfRkxPV19PSzsKICAgICB9KSwgdGhpcyk7CiAgICAgZ19zaWduYWxfY29ubmVjdChtX2Fw cHNpbmsuZ2V0KCksICJlb3MiLCBHX0NBTExCQUNLKCtbXShHc3RFbGVtZW50KiwgQXBwZW5kUGlw ZWxpbmUqIGFwcGVuZFBpcGVsaW5lKSB7CiAgICAgICAgIC8vIGJhc2VzcmMgd2lsbCBlbWl0IGFu IEVPUyBhZnRlciBpdCBoYXMgcmVjZWl2ZWQgYSBHU1RfRkxPV19FUlJPUi4gVGhhdCdzIHRoZSBv bmx5IGNhc2Ugd2UgYXJlIGV4cGVjdGluZy4K