194408 2019-02-07 12:40:24 -0800 Web Inspector: Fix modify-css-property-race.html flakiness 2019-02-07 14:16:30 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1503880 0 nvasilyev 2019-02-07 12:40:24 -0800 https://bugs.webkit.org/show_bug.cgi?id=194318#c11: > After the fixes in https://trac.webkit.org/changeset/241011/webkit > > inspector/css/modify-css-property-race.html > > has become a flakey failure on Debug. Looks like it it somehow writing > another pass message? > > History: > http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=inspector%2Fcss%2Fmodify-css-property-race.html > > Diff: > --- > /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/ > inspector/css/modify-css-property-race-expected.txt > +++ > /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/ > inspector/css/modify-css-property-race-actual.txt > @@ -7,4 +7,5 @@ > PASS: Height should have increased from 11px. > PASS: Height should be 100px or more. > PASS: Height should be 101px or more. > +PASS: Height should be 101px or more. 1503881 1 361429 nvasilyev 2019-02-07 12:43:37 -0800 Created attachment 361429 Patch Verify that the test is no longer flaky on the debug build: Tools/Scripts/run-webkit-tests -1 -iterations 500 -f --debug LayoutTests/inspector/css/modify-css-property-race.html 1503919 2 361429 hi 2019-02-07 13:48:48 -0800 Comment on attachment 361429 Patch rs=me 1503931 3 361429 commit-queue 2019-02-07 14:15:15 -0800 Comment on attachment 361429 Patch Clearing flags on attachment: 361429 Committed r241144: <https://trac.webkit.org/changeset/241144> 1503932 4 commit-queue 2019-02-07 14:15:16 -0800 All reviewed patches have been landed. Closing bug. 1503933 5 webkit-bug-importer 2019-02-07 14:16:30 -0800 <rdar://problem/47897050> 361429 2019-02-07 12:43:37 -0800 2019-02-07 14:15:15 -0800 Patch patch.txt text/plain 1972 nvasilyev ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMGZkYTY5YTkyZi4uMTQ4NTNiNjQ1YzcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxOS0wMi0wNyAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiBGaXggbW9kaWZ5LWNzcy1wcm9wZXJ0eS1yYWNlLmh0bWwgZmxh a2luZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTQ0MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF dmVudCBsaXN0ZW5lciB3YXNuJ3QgcmVtb3ZlZCBwcm9wZXJ0eSwgc29tZXRpbWVzIGNhdXNpbmcg aXQgdG8gZmlyZSBvbmUgbW9yZSB0aW1lLgorCisgICAgICAgICogaW5zcGVjdG9yL2Nzcy9tb2Rp ZnktY3NzLXByb3BlcnR5LXJhY2UuaHRtbDoKKwogMjAxOS0wMi0wNiAgQW5keSBFc3RlcyAgPGFl c3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW1BheW1lbnQgUmVxdWVzdF0gSXQgc2hvdWxkIGJl IHBvc3NpYmxlIHRvIHJlcXVpcmUgYSBwaG9uZXRpYyBuYW1lIGZvciBzaGlwcGluZyBjb250YWN0 cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nzcy9tb2RpZnktY3NzLXByb3Bl cnR5LXJhY2UuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jc3MvbW9kaWZ5LWNzcy1wcm9w ZXJ0eS1yYWNlLmh0bWwKaW5kZXggZDg5OWI2MzQ5YjEuLjY4ZGM2MWZmNzA5IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY3NzL21vZGlmeS1jc3MtcHJvcGVydHktcmFjZS5odG1s CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jc3MvbW9kaWZ5LWNzcy1wcm9wZXJ0eS1yYWNl Lmh0bWwKQEAgLTYxLDYgKzYxLDcgQEAgZnVuY3Rpb24gdGVzdCgpIHsKIAogICAgICAgICAgICAg SW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFnZSgiZXhwYW5kKCkiKTsKICAgICAgICAgICAgIGxl dCB1cGRhdGVDb3VudCA9IDA7CisgICAgICAgICAgICBsZXQgc3R5bGUgPSBnZXRJbmxpbmVTdHls ZURlY2xhcmF0aW9uKCk7CiAKICAgICAgICAgICAgIGZ1bmN0aW9uIHN0eWxlRGVjb3JhdGlvblVw ZGF0ZWQoKSB7CiAgICAgICAgICAgICAgICAgKyt1cGRhdGVDb3VudDsKQEAgLTc3LDEyICs3OCwx MSBAQCBmdW5jdGlvbiB0ZXN0KCkgewogICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0 LmV4cGVjdEdyZWF0ZXJUaGFuT3JFcXVhbChoZWlnaHROdW1iZXIsIDEwMSwgIkhlaWdodCBzaG91 bGQgYmUgMTAxcHggb3IgbW9yZS4iKTsKIAogICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JU ZXN0LmV2YWx1YXRlSW5QYWdlKCJzdG9wRXhwYW5kaW5nKCkiKTsKLSAgICAgICAgICAgICAgICAg ICAgV0kuQ1NTU3R5bGVEZWNsYXJhdGlvbi5yZW1vdmVFdmVudExpc3RlbmVyKFdJLkNTU1N0eWxl RGVjbGFyYXRpb24uRXZlbnQuUHJvcGVydGllc0NoYW5nZWQsIHN0eWxlRGVjb3JhdGlvblVwZGF0 ZWQpOworICAgICAgICAgICAgICAgICAgICBzdHlsZS5yZW1vdmVFdmVudExpc3RlbmVyKFdJLkNT U1N0eWxlRGVjbGFyYXRpb24uRXZlbnQuUHJvcGVydGllc0NoYW5nZWQsIHN0eWxlRGVjb3JhdGlv blVwZGF0ZWQpOwogICAgICAgICAgICAgICAgICAgICByZXNvbHZlKCk7CiAgICAgICAgICAgICAg ICAgfQogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBsZXQgc3R5bGUgPSBnZXRJbmxpbmVT dHlsZURlY2xhcmF0aW9uKCk7CiAgICAgICAgICAgICBzdHlsZS5hZGRFdmVudExpc3RlbmVyKFdJ LkNTU1N0eWxlRGVjbGFyYXRpb24uRXZlbnQuUHJvcGVydGllc0NoYW5nZWQsIHN0eWxlRGVjb3Jh dGlvblVwZGF0ZWQpOwogICAgICAgICB9CiAgICAgfSk7Cg==