194404 2019-02-07 11:51:21 -0800 Make Request constructor throw if FetchRequestInit.signal is not undefined, null or an AbortSignal object 2019-02-11 09:20:15 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194366 InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez commit-queue ggaren webkit-bug-importer oldest_to_newest 1503856 0 youennf 2019-02-07 11:51:21 -0800 Make Request constructor throw if FetchRequestInit.signal is not undefined, null or an AbortSignal object 1503857 1 webkit-bug-importer 2019-02-07 11:51:48 -0800 <rdar://problem/47891915> 1504299 2 361535 youennf 2019-02-08 14:23:38 -0800 Created attachment 361535 Patch 1504505 3 361535 ggaren 2019-02-08 22:07:30 -0800 Comment on attachment 361535 Patch r=me 1504883 4 361535 commit-queue 2019-02-11 09:20:13 -0800 Comment on attachment 361535 Patch Clearing flags on attachment: 361535 Committed r241265: <https://trac.webkit.org/changeset/241265> 1504884 5 commit-queue 2019-02-11 09:20:15 -0800 All reviewed patches have been landed. Closing bug. 361535 2019-02-08 14:23:38 -0800 2019-02-11 09:20:13 -0800 Patch bug-194404-20190208142337.patch text/plain 5656 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ3YjEwNWNiMmRkNjU4 Njg1YmFkNDA5MzZmMzZiNDk3MzdiMWIxNS4uYmQ0YTQ5Y2QwZTRlNjIyMDJhYTgxYjg2OTc2YzMw MzNlYmRkZDU4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAyLTA4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFJlcXVlc3QgY29u c3RydWN0b3IgdGhyb3cgaWYgRmV0Y2hSZXF1ZXN0SW5pdC5zaWduYWwgaXMgbm90IHVuZGVmaW5l ZCwgbnVsbCBvciBhbiBBYm9ydFNpZ25hbCBvYmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDQwNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NDc4OTE5MTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWxpZ24gd2l0aCB0aGUgc3BlYywgZXhjZXB0IGZvciBrbm93biBwcm9ibGVtYXRpYyB3ZWIg c2l0ZXMuCisgICAgICAgIENvdmVyZWQgYnkgdXBkYXRlZCB0ZXN0LgorCisgICAgICAgICogTW9k dWxlcy9mZXRjaC9GZXRjaFJlcXVlc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bmVlZHNTaWdu YWxRdWlyayk6CisgICAgICAgIChXZWJDb3JlOjpwcm9jZXNzSW52YWxpZFNpZ25hbCk6CisgICAg ICAgIChXZWJDb3JlOjpGZXRjaFJlcXVlc3Q6OmluaXRpYWxpemVXaXRoKToKKwogMjAxOS0wMi0w OCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5hYmxlIHRv IHNpZ24gaW4gbGVldGNvZGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2Zl dGNoL0ZldGNoUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZldGNoL0ZldGNo UmVxdWVzdC5jcHAKaW5kZXggY2ZiOWM0YmU1OGY5NzJmNzcyZGRjZWQ4ZDE3MmYzYjNmMzA1ZDMw My4uMGI5NzgzOTJiMDYxNmVjMzZlOTY5YmNkOGM0YzA1YTliODk3YjkyZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9mZXRjaC9GZXRjaFJlcXVlc3QuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvZmV0Y2gvRmV0Y2hSZXF1ZXN0LmNwcApAQCAtMjksMTAgKzI5LDEz IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiRmV0Y2hSZXF1ZXN0LmgiCiAKKyNp bmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1ZGUgIkhUVFBQYXJzZXJzLmgiCiAjaW5jbHVkZSAi SlNBYm9ydFNpZ25hbC5oIgorI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRlICJTY3JpcHRF eGVjdXRpb25Db250ZXh0LmgiCiAjaW5jbHVkZSAiU2VjdXJpdHlPcmlnaW4uaCIKKyNpbmNsdWRl ICJTZXR0aW5ncy5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTE0MSw2ICsxNDQsMzEg QEAgRXhjZXB0aW9uT3I8dm9pZD4gRmV0Y2hSZXF1ZXN0Ojppbml0aWFsaXplT3B0aW9ucyhjb25z dCBJbml0JiBpbml0KQogICAgIHJldHVybiB7IH07CiB9CiAKK3N0YXRpYyBpbmxpbmUgYm9vbCBu ZWVkc1NpZ25hbFF1aXJrKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQmIGNvbnRleHQpCit7CisgICAg aWYgKCFpczxEb2N1bWVudD4oY29udGV4dCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAg IGF1dG8mIGRvY3VtZW50ID0gZG93bmNhc3Q8RG9jdW1lbnQ+KGNvbnRleHQpOworICAgIGlmICgh ZG9jdW1lbnQuc2V0dGluZ3MoKS5uZWVkc1NpdGVTcGVjaWZpY1F1aXJrcygpKQorICAgICAgICBy ZXR1cm4gZmFsc2U7CisKKyAgICBhdXRvIGhvc3QgPSBkb2N1bWVudC50b3BEb2N1bWVudCgpLnVy bCgpLmhvc3QoKTsKKyAgICByZXR1cm4gZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9z dCwgImxlZXRjb2RlLmNvbSIpIHx8IGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3Qs ICJ3d3cudGhyaXZlcGF0aWVudHBvcnRhbC5jb20iKTsKK30KKworc3RhdGljIGlubGluZSBPcHRp b25hbDxFeGNlcHRpb24+IHByb2Nlc3NJbnZhbGlkU2lnbmFsKFNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQmIGNvbnRleHQpCit7CisgICAgQVNDSUlMaXRlcmFsIG1lc3NhZ2UgeyAiRmV0Y2hSZXF1ZXN0 SW5pdC5zaWduYWwgc2hvdWxkIGJlIHVuZGVmaW5lZCwgbnVsbCBvciBhbiBBYm9ydFNpZ25hbCBv YmplY3QuIl9zIH07CisgICAgY29udGV4dC5hZGRDb25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNl OjpKUywgTWVzc2FnZUxldmVsOjpXYXJuaW5nLCBtZXNzYWdlKTsKKworICAgIGlmIChuZWVkc1Np Z25hbFF1aXJrKGNvbnRleHQpKQorICAgICAgICByZXR1cm4geyB9OworCisgICAgUkVMRUFTRV9M T0dfRVJST1IoUmVzb3VyY2VMb2FkaW5nLCAiRmV0Y2hSZXF1ZXN0SW5pdC5zaWduYWwgc2hvdWxk IGJlIHVuZGVmaW5lZCwgbnVsbCBvciBhbiBBYm9ydFNpZ25hbCBvYmplY3QuIik7CisgICAgcmV0 dXJuIEV4Y2VwdGlvbiB7IFR5cGVFcnJvciwgbWVzc2FnZSB9OworfQorCiBFeGNlcHRpb25Pcjx2 b2lkPiBGZXRjaFJlcXVlc3Q6OmluaXRpYWxpemVXaXRoKGNvbnN0IFN0cmluZyYgdXJsLCBJbml0 JiYgaW5pdCkKIHsKICAgICBBU1NFUlQoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKQEAgLTE2 NCw4ICsxOTIsOCBAQCBFeGNlcHRpb25Pcjx2b2lkPiBGZXRjaFJlcXVlc3Q6OmluaXRpYWxpemVX aXRoKGNvbnN0IFN0cmluZyYgdXJsLCBJbml0JiYgaW5pdCkKICAgICAgICAgaWYgKGF1dG8qIHNp Z25hbCA9IEpTQWJvcnRTaWduYWw6OnRvV3JhcHBlZChzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkt PnZtKCksIGluaXQuc2lnbmFsKSkKICAgICAgICAgICAgIG1fc2lnbmFsLT5mb2xsb3coKnNpZ25h bCk7CiAgICAgICAgIGVsc2UgaWYgKCFpbml0LnNpZ25hbC5pc1VuZGVmaW5lZE9yTnVsbCgpKSAg ewotICAgICAgICAgICAgQVNDSUlMaXRlcmFsIGNvbnNvbGVNZXNzYWdlIHsgIkZldGNoUmVxdWVz dEluaXQuc2lnbmFsIHNob3VsZCBiZSB1bmRlZmluZWQsIG51bGwgb3IgYW4gQWJvcnRTaWduYWwg b2JqZWN0LiJfcyB9OwotICAgICAgICAgICAgc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLT5hZGRD b25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlOjpKUywgTWVzc2FnZUxldmVsOjpXYXJuaW5nLCBj b25zb2xlTWVzc2FnZSk7CisgICAgICAgICAgICBpZiAoYXV0byBleGNlcHRpb24gPSBwcm9jZXNz SW52YWxpZFNpZ25hbCgqc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKSkKKyAgICAgICAgICAgICAg ICByZXR1cm4gV1RGTW92ZSgqZXhjZXB0aW9uKTsKICAgICAgICAgfQogICAgIH0KIApAQCAtMjAy LDggKzIzMCw4IEBAIEV4Y2VwdGlvbk9yPHZvaWQ+IEZldGNoUmVxdWVzdDo6aW5pdGlhbGl6ZVdp dGgoRmV0Y2hSZXF1ZXN0JiBpbnB1dCwgSW5pdCYmIGluaXQpCiAgICAgICAgIGlmIChhdXRvKiBz aWduYWwgPSBKU0Fib3J0U2lnbmFsOjp0b1dyYXBwZWQoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgp LT52bSgpLCBpbml0LnNpZ25hbCkpCiAgICAgICAgICAgICBtX3NpZ25hbC0+Zm9sbG93KCpzaWdu YWwpOwogICAgICAgICBlbHNlIGlmICghaW5pdC5zaWduYWwuaXNOdWxsKCkpIHsKLSAgICAgICAg ICAgIEFTQ0lJTGl0ZXJhbCBjb25zb2xlTWVzc2FnZSB7ICJGZXRjaFJlcXVlc3RJbml0LnNpZ25h bCBzaG91bGQgYmUgdW5kZWZpbmVkLCBudWxsIG9yIGFuIEFib3J0U2lnbmFsIG9iamVjdC4iX3Mg fTsKLSAgICAgICAgICAgIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+YWRkQ29uc29sZU1lc3Nh Z2UoTWVzc2FnZVNvdXJjZTo6SlMsIE1lc3NhZ2VMZXZlbDo6V2FybmluZywgY29uc29sZU1lc3Nh Z2UpOworICAgICAgICAgICAgaWYgKGF1dG8gZXhjZXB0aW9uID0gcHJvY2Vzc0ludmFsaWRTaWdu YWwoKnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkpCisgICAgICAgICAgICAgICAgcmV0dXJuIFdU Rk1vdmUoKmV4Y2VwdGlvbik7CiAgICAgICAgIH0KIAogICAgIH0gZWxzZQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDhiMTBh NWZjYWU4ZjQ1Y2NiOTAzY2UyMTI4ZTMyYTFmZGIzYTA0Y2EuLjZkNjM0OTMyZTVhMjBiMzkzZDUx MzJiNjhkODg2MDM1NjQzODcwMmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0wMi0wOCAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBSZXF1ZXN0 IGNvbnN0cnVjdG9yIHRocm93IGlmIEZldGNoUmVxdWVzdEluaXQuc2lnbmFsIGlzIG5vdCB1bmRl ZmluZWQsIG51bGwgb3IgYW4gQWJvcnRTaWduYWwgb2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ0MDQKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzQ3ODkxOTE1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogaHR0cC93cHQvZmV0Y2gvcmVxdWVzdC1hYm9ydC1leHBlY3RlZC50eHQ6CisKIDIw MTktMDItMDggIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFVu YWJsZSB0byBzaWduIGluIGxlZXRjb2RlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC93 cHQvZmV0Y2gvcmVxdWVzdC1hYm9ydC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3dw dC9mZXRjaC9yZXF1ZXN0LWFib3J0LWV4cGVjdGVkLnR4dAppbmRleCA1N2NkNWYzZTgwMGRhNmVi ZjY4ZDlmMmY5NzQ5ZWRkYjZhMzkwMmVkLi40Y2UwMjVlNTkwZjQ5MGM5N2VhNzgxODU4ZjY3NDk2 MTUwYTI5Yzk3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3dwdC9mZXRjaC9yZXF1ZXN0 LWFib3J0LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9mZXRjaC9yZXF1 ZXN0LWFib3J0LWV4cGVjdGVkLnR4dApAQCAtMSw2ICsxLDYgQEAKIENPTlNPTEUgTUVTU0FHRTog bGluZSAxNDogRmV0Y2hSZXF1ZXN0SW5pdC5zaWduYWwgc2hvdWxkIGJlIHVuZGVmaW5lZCwgbnVs bCBvciBhbiBBYm9ydFNpZ25hbCBvYmplY3QuCiBDT05TT0xFIE1FU1NBR0U6IGxpbmUgMjg6IEZl dGNoUmVxdWVzdEluaXQuc2lnbmFsIHNob3VsZCBiZSB1bmRlZmluZWQsIG51bGwgb3IgYW4gQWJv cnRTaWduYWwgb2JqZWN0LgogCi1GQUlMIFJlcXVlc3QgZnJvbSBVUkwgd2l0aCBzaWduYWwgYXNz ZXJ0X3Rocm93czogZnVuY3Rpb24gIigpID0+IHsgbmV3IFJlcXVlc3QoIi8iLCB7c2lnbmFsOiAi bXkgc2lnbmFsIn0pIH0iIGRpZCBub3QgdGhyb3cKLUZBSUwgUmVxdWVzdCBmcm9tIHJlcXVlc3Qg d2l0aCBzaWduYWwgYXNzZXJ0X3Rocm93czogZnVuY3Rpb24gIigpID0+IHsgbmV3IFJlcXVlc3Qo cmVxdWVzdCwge3NpZ25hbDogIm15IHNpZ25hbCJ9KSB9IiBkaWQgbm90IHRocm93CitQQVNTIFJl cXVlc3QgZnJvbSBVUkwgd2l0aCBzaWduYWwgCitQQVNTIFJlcXVlc3QgZnJvbSByZXF1ZXN0IHdp dGggc2lnbmFsIAogCg==