194395 2019-02-07 08:58:28 -0800 Fix animation rendering on the webkit.org homepage 2019-02-07 17:22:27 -0800 1 1 1 Unclassified WebKit WebKit Website WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jond jond commit-queue hi jond nvasilyev webkit-bug-importer oldest_to_newest 1503751 0 jond 2019-02-07 08:58:28 -0800 When the slow animation on the webkit.org homepage completes, the position of the compass element often jumps and becomes incorrectly positioned. 1503752 1 361402 jond 2019-02-07 08:59:49 -0800 Created attachment 361402 Patch 1503858 2 361402 nvasilyev 2019-02-07 11:52:26 -0800 Comment on attachment 361402 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361402&action=review Could you attach a screenshot of the bug? > Websites/webkit.org/wp-content/themes/webkit/front-header.php:-103 > - @-webkit-keyframes bgspin { > - from { > - transform: translateY(-400px) rotate(0); > - -webkit-transform: translateY(-400px) rotate(0deg); > - } > - > - to { > - transform: translateY(-400px) rotate(360); > - -webkit-transform: translateY(-400px) rotate(360deg); > - } > - } > - Nice that we don't need to use -webkit- prefix here anymore. 1503877 3 nvasilyev 2019-02-07 12:33:36 -0800 Do you know why it was jumping? Was it related to font-size changes (I see you previously used rem units)? 1503906 4 361402 nvasilyev 2019-02-07 13:35:34 -0800 Comment on attachment 361402 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361402&action=review > Websites/webkit.org/wp-content/themes/webkit/front-header.php:51 > + transform: translateY(-450px); What's the reasoning behind this change? Is it just gardening? E.g. using pixels for consistency. > Websites/webkit.org/wp-content/themes/webkit/front-header.php:81 > + transform: translateY(-400px); Discussed offline. This line fixes the issue, the rest is a cleanup. I'd r+. 1503907 5 nvasilyev 2019-02-07 13:37:02 -0800 (In reply to Nikita Vasilyev from comment #4) > Comment on attachment 361402 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=361402&action=review > > > Websites/webkit.org/wp-content/themes/webkit/front-header.php:51 > > + transform: translateY(-450px); > > What's the reasoning behind this change? Is it just gardening? E.g. using > pixels for consistency. Ignore my question. We've discussed this — pixels are used for consistency. 1504011 6 361402 hi 2019-02-07 16:39:58 -0800 Comment on attachment 361402 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361402&action=review rs=me > Websites/webkit.org/wp-content/themes/webkit/front-header.php:76 > + animation-name: bgspin; If you can reproduce the bug we discussed offline about this (e.g. a reduction), please file a bug for it :) 1504045 7 361402 commit-queue 2019-02-07 17:21:39 -0800 Comment on attachment 361402 Patch Clearing flags on attachment: 361402 Committed r241178: <https://trac.webkit.org/changeset/241178> 1504046 8 commit-queue 2019-02-07 17:21:41 -0800 All reviewed patches have been landed. Closing bug. 1504047 9 webkit-bug-importer 2019-02-07 17:22:27 -0800 <rdar://problem/47903889> 361402 2019-02-07 08:59:49 -0800 2019-02-07 17:21:39 -0800 Patch bug-194395-20190207085948.patch text/plain 2924 jond U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMTIxCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDkzNDY3 YWU0Y2MzYTEyOTUzMWVlMDI3MTViZTFkMTY0ODE2NzkzMGMuLjM2MmYzMjE2Y2EwM2QwNmIwNzBi YWMzMzBmYWE2ODlkODUwZjk0YzMgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTktMDItMDcgIEpvbiBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgorCisgICAgICAgIEZp eGVkIGFuaW1hdGlvbiBwb3NpdGlvbmluZyB3aGVuIGhvbWVwYWdlIGFuaW1hdGlvbiBjb21wbGV0 ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDM5 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3At Y29udGVudC90aGVtZXMvd2Via2l0L2Zyb250LWhlYWRlci5waHA6CisKIDIwMTktMDItMDQgIEpv biBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBkZW1vcyBmb3IgSW50ZXJz ZWN0aW9uIE9ic2VydmVyIEFQSQpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy93cC1j b250ZW50L3RoZW1lcy93ZWJraXQvZnJvbnQtaGVhZGVyLnBocCBiL1dlYnNpdGVzL3dlYmtpdC5v cmcvd3AtY29udGVudC90aGVtZXMvd2Via2l0L2Zyb250LWhlYWRlci5waHAKaW5kZXggOWJmMTZh MjFlM2FjOGIyYjc3ZWI5MWZiZGFmZWJjNDkxMjAxZjIzNi4uMzAyNGFiYjMyNWE5YzI2ZWIwNDY1 OWQzMGE0ZjAwMzA2YjRlN2MzNiAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy93cC1j b250ZW50L3RoZW1lcy93ZWJraXQvZnJvbnQtaGVhZGVyLnBocAorKysgYi9XZWJzaXRlcy93ZWJr aXQub3JnL3dwLWNvbnRlbnQvdGhlbWVzL3dlYmtpdC9mcm9udC1oZWFkZXIucGhwCkBAIC00Niw5 ICs0Niw5IEBACiAgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgICAgICAgd2lkdGg6IDEw MCU7CiAgICAgICAgIGhlaWdodDogMTI2MXB4OwotICAgICAgICBiYWNrZ3JvdW5kLWltYWdlOiBy YWRpYWwtZ3JhZGllbnQoZWxsaXBzZSBjbG9zZXN0LWNvcm5lciBhdCBjZW50ZXIgY2VudGVyLGhz bCgxOTgsIDEwMCUsIDIwJSkgMCUsaHNsYSgyMDQsIDEwMCUsIDIwJSwwKSAxMDAlKTsKKyAgICAg ICAgYmFja2dyb3VuZC1pbWFnZTogcmFkaWFsLWdyYWRpZW50KGVsbGlwc2UgY2xvc2VzdC1jb3Ju ZXIgYXQgY2VudGVyIGNlbnRlciwgaHNsKDE5OCwgMTAwJSwgMjAlKSAwJSwgaHNsYSgyMDQsIDEw MCUsIDIwJSwgMCkgMTAwJSk7CiAgICAgICAgIHotaW5kZXg6IDQ7Ci0gICAgICAgIHRyYW5zZm9y bTogdHJhbnNsYXRlWSgtNDVyZW0pOworICAgICAgICB0cmFuc2Zvcm06IHRyYW5zbGF0ZVkoLTQ1 MHB4KTsKICAgICB9CiAKICAgICAjdGVtcGxhdGUgewpAQCAtNjEsNyArNjEsOCBAQAogICAgICAg ICBiYWNrZ3JvdW5kLXBvc2l0aW9uOiA1MCUgNDkuNSU7CiAgICAgICAgIGJhY2tncm91bmQtc2l6 ZTogMTAxLjUlOwogICAgICAgICB6LWluZGV4OiAzOwotICAgICAgICB0cmFuc2Zvcm06IHRyYW5z bGF0ZVkoLTQwcmVtKTsgICAgfQorICAgICAgICB0cmFuc2Zvcm06IHRyYW5zbGF0ZVkoLTQwMHB4 KTsKKyAgICB9CiAKICAgICAjY29tcGFzcyB7CiAgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsK QEAgLTcyLDEwICs3MywxMiBAQAogICAgICAgICBiYWNrZ3JvdW5kLXBvc2l0aW9uOiA1MCUgNTAl OwogICAgICAgICBiYWNrZ3JvdW5kLXNpemU6IDk4JTsKICAgICAgICAgb3BhY2l0eTogMC4zOwot ICAgICAgICAtd2Via2l0LWFuaW1hdGlvbjogYmdzcGluIDM2MHMgZWFzZS1vdXQ7Ci0gICAgICAg IGFuaW1hdGlvbjogYmdzcGluIDM2MHMgZWFzZS1vdXQ7CisgICAgICAgIGFuaW1hdGlvbi1uYW1l OiBiZ3NwaW47CisgICAgICAgIGFuaW1hdGlvbi1kdXJhdGlvbjogMzYwczsKKyAgICAgICAgYW5p bWF0aW9uLXRpbWluZy1mdW5jdGlvbjogZWFzZS1vdXQ7CiAgICAgICAgIHotaW5kZXg6IDI7CiAg ICAgICAgIHdpbGwtY2hhbmdlOiB0cmFuc2Zvcm07CisgICAgICAgIHRyYW5zZm9ybTogdHJhbnNs YXRlWSgtNDAwcHgpOwogICAgIH0KIAogICAgIEBrZXlmcmFtZXMgYmdzcGluIHsKQEAgLTg5LDE4 ICs5Miw2IEBACiAgICAgICAgIH0KICAgICB9CiAKLSAgICBALXdlYmtpdC1rZXlmcmFtZXMgYmdz cGluIHsKLSAgICAgICAgZnJvbSB7Ci0gICAgICAgICAgICB0cmFuc2Zvcm06IHRyYW5zbGF0ZVko LTQwMHB4KSByb3RhdGUoMCk7Ci0gICAgICAgICAgICAtd2Via2l0LXRyYW5zZm9ybTogdHJhbnNs YXRlWSgtNDAwcHgpIHJvdGF0ZSgwZGVnKTsKLSAgICAgICAgfQotCi0gICAgICAgIHRvIHsKLSAg ICAgICAgICAgIHRyYW5zZm9ybTogdHJhbnNsYXRlWSgtNDAwcHgpIHJvdGF0ZSgzNjApOwotICAg ICAgICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZVkoLTQwMHB4KSByb3RhdGUoMzYw ZGVnKTsKLSAgICAgICAgfQotICAgIH0KLQogICAgIC5oZXJvIC5jb250ZW50IHsKICAgICAgICAg cG9zaXRpb246IHJlbGF0aXZlOwogICAgICAgICBtYXgtd2lkdGg6IDgwMHB4OwpAQCAtMTQ4LDEw ICsxMzksOCBAQAogICAgIEBtZWRpYSAocHJlZmVycy1yZWR1Y2VkLW1vdGlvbikgewogICAgICAg ICAjY29tcGFzcyB7CiAgICAgICAgICAgICBhbmltYXRpb246IG5vbmU7Ci0gICAgICAgICAgICB0 cmFuc2Zvcm06IHRyYW5zbGF0ZVkoLTQwMHB4KTsKICAgICAgICAgfQogICAgIH0KLQogICAgIDwv c3R5bGU+CiAKICAgICA8P3BocCBpZiAoIGlzX2Zyb250X3BhZ2UoKSAmJiBoYXZlX3Bvc3RzKCkp OiB0aGVfcG9zdCgpOyA/Pgo=